From 17a415bd21dfa41e5ba2b9711a5170d3765d7eac Mon Sep 17 00:00:00 2001 From: Jon Trowbridge Date: Sun, 21 Oct 2001 00:19:25 +0000 Subject: We shouldn't leak the info returned by oaf_query. 2001-10-20 Jon Trowbridge * backend/ebook/e-book.c (activate_factories_for_uri): We shouldn't leak the info returned by oaf_query. * gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove superfluous call to quick_add_unref. (editor_closed_cb): Remove superfluous call to quick_add_unref. * gui/component/select-names/e-select-names.c (esn_get_key_fn): We need to unref the card returned by e_addressbook_model_get_card. svn path=/trunk/; revision=13834 --- addressbook/gui/contact-editor/e-contact-quick-add.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'addressbook/gui/contact-editor/e-contact-quick-add.c') diff --git a/addressbook/gui/contact-editor/e-contact-quick-add.c b/addressbook/gui/contact-editor/e-contact-quick-add.c index 9559add2ee..7b84f50281 100644 --- a/addressbook/gui/contact-editor/e-contact-quick-add.c +++ b/addressbook/gui/contact-editor/e-contact-quick-add.c @@ -165,7 +165,7 @@ card_added_cb (EContactEditor *ce, EBookStatus status, ECard *card, gpointer clo if (qa->cb) qa->cb (qa->card, qa->closure); - quick_add_unref (qa); + /* We don't need to unref qa because we set_data_full below */ gtk_object_set_data (GTK_OBJECT (ce), "quick_add", NULL); } } @@ -176,7 +176,7 @@ editor_closed_cb (GtkWidget *w, gpointer closure) QuickAdd *qa = (QuickAdd *) gtk_object_get_data (GTK_OBJECT (w), "quick_add"); if (qa) { - quick_add_unref (qa); + /* We don't need to unref qa because we set_data_full below */ gtk_object_set_data (GTK_OBJECT (w), "quick_add", NULL); gtk_object_unref (GTK_OBJECT (w)); } -- cgit v1.2.3