From cd622d600ec180de75830913f7284d8d66370493 Mon Sep 17 00:00:00 2001 From: Suman Manjunath Date: Mon, 8 Dec 2008 08:09:01 +0000 Subject: Jeff Cai ** Fix for bug #563077 (Don't pass NULL to gtk_icon_info_get_filename(), fixes a crash if the gnome-settings-daemon is not running). svn path=/trunk/; revision=36844 --- shell/ChangeLog | 10 ++++++++++ shell/e-shell-window.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/shell/ChangeLog b/shell/ChangeLog index 307de5bf79..ef89b297a9 100644 --- a/shell/ChangeLog +++ b/shell/ChangeLog @@ -1,3 +1,13 @@ +2008-12-08 Jeff Cai + + ** Fix for bug #563077 + + * e-shell-window.c (setup_widgets): Don't pass NULL to + gtk_icon_info_get_filename(). + + Fixes a crash if the gnome-settings-daemon is not running. + Observed on SUN Solaris. + 2008-11-07 Matthew Barnes ** Fixes part of bug #557581 diff --git a/shell/e-shell-window.c b/shell/e-shell-window.c index f2eb6bf86d..c533967c77 100644 --- a/shell/e-shell-window.c +++ b/shell/e-shell-window.c @@ -796,7 +796,7 @@ setup_widgets (EShellWindow *window) info->icon_name, width, 0); g_string_append_printf(xml, "\" pixtype=\"filename\" pixname=\"%s\"/>" "\n", - gtk_icon_info_get_filename (icon_info)); + icon_info ? gtk_icon_info_get_filename (icon_info) : ""); gtk_icon_info_free (icon_info); bonobo_ui_component_set_translate (e_shell_window_peek_bonobo_ui_component (window), "/menu", -- cgit v1.2.3