From 72b0983f7ab6f61ec1268da9ba2059c5f07d09ad Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Tue, 17 Apr 2001 20:29:40 +0000 Subject: more memory leaks svn path=/trunk/; revision=9431 --- camel/ChangeLog | 5 +++++ camel/camel-filter-driver.c | 2 ++ mail/ChangeLog | 4 ++++ mail/mail-mt.c | 5 +++-- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/camel/ChangeLog b/camel/ChangeLog index f319cd813f..f5aab711b8 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,8 @@ +2001-04-17 Dan Winship + + * camel-filter-driver.c (camel_filter_driver_filter_message): Fix + a memory leak in the error case. + 2001-04-16 Jeffrey Stedfast * providers/local/camel-mbox-summary.c (summary_rebuild): Don't we diff --git a/camel/camel-filter-driver.c b/camel/camel-filter-driver.c index 08d01da694..464ccc1539 100644 --- a/camel/camel-filter-driver.c +++ b/camel/camel-filter-driver.c @@ -898,6 +898,8 @@ camel_filter_driver_filter_message (CamelFilterDriver *driver, CamelMimeMessage camel_folder_append_message (p->defaultfolder, p->message, p->info, p->ex); } + if (freeinfo) + camel_message_info_free (info); return 0; error: diff --git a/mail/ChangeLog b/mail/ChangeLog index 148338c527..87291536a6 100644 --- a/mail/ChangeLog +++ b/mail/ChangeLog @@ -1,3 +1,7 @@ +2001-04-17 Dan Winship + + * mail-mt.c (mail_msg_check_error): Fix a memory leak. + 2001-04-16 Ettore Perazzoli * importers/Makefile.am (INCLUDES): Add `$(EXTRA_GNOME_CFLAGS)' diff --git a/mail/mail-mt.c b/mail/mail-mt.c index 9c04ca38ef..a4c924cab6 100644 --- a/mail/mail-mt.c +++ b/mail/mail-mt.c @@ -186,9 +186,10 @@ void mail_msg_check_error(void *msg) if (m->ops->describe_msg) what = m->ops->describe_msg(m, FALSE); - if (what) + if (what) { text = g_strdup_printf(_("Error while '%s':\n%s"), what, camel_exception_get_description(&m->ex)); - else + g_free (what); + } else text = g_strdup_printf(_("Error while performing operation:\n%s"), camel_exception_get_description(&m->ex)); gd = (GnomeDialog *)gnome_error_dialog(text); -- cgit v1.2.3