From 583f8ba770418d53c134fe4004d1f89e3880f466 Mon Sep 17 00:00:00 2001 From: Ettore Perazzoli Date: Thu, 11 Jul 2002 21:28:24 +0000 Subject: Allow a NULL icon [remove the precondition]. * e-shell-folder-title-bar.c (e_shell_folder_title_bar_set_icon): Allow a NULL icon [remove the precondition]. * e-shell-view.c (update_folder_title_bar): Only unref the folder_icon if not NULL. svn path=/trunk/; revision=17426 --- shell/ChangeLog | 8 ++++++++ shell/e-shell-folder-title-bar.c | 2 -- shell/e-shell-view.c | 8 +++++--- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/shell/ChangeLog b/shell/ChangeLog index cb1478b7c2..817efda21a 100644 --- a/shell/ChangeLog +++ b/shell/ChangeLog @@ -1,3 +1,11 @@ +2002-07-11 Ettore Perazzoli + + * e-shell-folder-title-bar.c (e_shell_folder_title_bar_set_icon): + Allow a NULL icon [remove the precondition]. + + * e-shell-view.c (update_folder_title_bar): Only unref the + folder_icon if not NULL. + 2002-07-11 Ettore Perazzoli * evolution-storage-set-view.c diff --git a/shell/e-shell-folder-title-bar.c b/shell/e-shell-folder-title-bar.c index f1fef8c68b..c3750f8cdc 100644 --- a/shell/e-shell-folder-title-bar.c +++ b/shell/e-shell-folder-title-bar.c @@ -689,8 +689,6 @@ e_shell_folder_title_bar_set_icon (EShellFolderTitleBar *folder_title_bar, GdkPixmap *pixmap; GdkBitmap *mask; - g_return_if_fail (icon != NULL); - g_return_if_fail (folder_title_bar != NULL); g_return_if_fail (E_IS_SHELL_FOLDER_TITLE_BAR (folder_title_bar)); diff --git a/shell/e-shell-view.c b/shell/e-shell-view.c index 8a717bcaf9..a06e8eeabd 100644 --- a/shell/e-shell-view.c +++ b/shell/e-shell-view.c @@ -1785,7 +1785,11 @@ update_folder_title_bar (EShellView *shell_view, } } - e_shell_folder_title_bar_set_icon (E_SHELL_FOLDER_TITLE_BAR (priv->folder_title_bar), folder_icon); + e_shell_folder_title_bar_set_icon (E_SHELL_FOLDER_TITLE_BAR (priv->folder_title_bar), + folder_icon); + + if (folder_icon != NULL) + gdk_pixbuf_unref (folder_icon); if (title != NULL) { char *s; @@ -1794,8 +1798,6 @@ update_folder_title_bar (EShellView *shell_view, e_shell_folder_title_bar_set_title (E_SHELL_FOLDER_TITLE_BAR (priv->folder_title_bar), s); g_free (s); } - - gdk_pixbuf_unref (folder_icon); } static void -- cgit v1.2.3