aboutsummaryrefslogtreecommitdiffstats
path: root/mail
Commit message (Collapse)AuthorAgeFilesLines
* Consolidate MailFolderCache signal handlers.Matthew Barnes2011-09-142-162/+177
| | | | | | | Merging the "folder-deleted" and "folder-renamed" signal handlers in mail-config.c into the ones in e-mail-backend.c makes the account-mgmt branch a little easier, since e-mail-backend.c has resources I can't easily get to from mail-config.c.
* Miscellaneous cleanups.Matthew Barnes2011-09-1418-322/+369
| | | | | | | Reducing diff noise with the account-mgmt branch. Trying to erode our dependency on EAccount as much as possible, or at least isolate its usage, to make things easier for me on the branch.
* Fix enum generation problems in glib-gen.mak.Matthew Barnes2011-09-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | Don't use pattern rules like %-enumtypes.h anymore because it matches installed header files like camel-enumtypes.h, so you get very strange things happening during the build like: .../camel/camel-enumtypes.h: e-util-enums.h glib-mkenums ... $^ > $@ when e-util-enums.h has a newer timestamp than camel-enumtypes.h. Instead, we'll use another variable name -- glib_enum_output -- to replace the %-enumtypes pattern rules like so: $(glib_enum_output).h: $(glib_enum_headers) glib-mkenums ... $^ > $@ $(glib_enum_output).c: $(glib_enum_headers) glib-mkenums ... $^ > $@ Also use $(AM_V_GEN) to get cleaner looking output while building.
* Stick Account Editor widgets at the top, like it used to before gtk3Milan Crha2011-09-141-41/+72
|
* Bug #657310 - Crash when editing transport-only accountsMilan Crha2011-09-142-5/+13
|
* Bug #362366 - Dragging selected folder to message pane duplicates messagesMilan Crha2011-09-141-0/+13
|
* Bug #655629 - "Path:" label for spool file should be "File:" labelMilan Crha2011-09-142-0/+5
|
* Bug #652914 - IMAP: moving mail puts a copy into real Trash tooMilan Crha2011-09-141-12/+85
|
* Very slow filling of EMSubscriptionEditor tree viewMilan Crha2011-09-141-7/+21
|
* Cannot add folder to previously saved Search folderMilan Crha2011-09-141-13/+23
|
* Bug #656733 - GUI no longer allows for non-default ports for emailMilan Crha2011-09-141-10/+0
|
* Update EMailBrowser actions when MessageList reloads.Matthew Barnes2011-09-142-1/+13
| | | | | There was never a bug filed for this, but some mailing list discussion: http://mail.gnome.org/archives/evolution-list/2011-August/msg00084.html
* Bug 656720 - Exclude NNTP stores from Create Folder dialogMatthew Barnes2011-09-143-18/+42
|
* e_mail_store_foreach(): Take an EMailSession parameter.Matthew Barnes2011-09-143-18/+24
| | | | | | Use camel_session_list_services() instead of the internal store table. The store table serves little purpose nowadays and could probably be removed. I'll look into that later.
* Use new CamelService:display-name property.Matthew Barnes2011-09-1412-94/+63
| | | | Simplify, simplify...
* Bug 656718 - Runtime warning in folder_tree_get_folder_info_cb()Matthew Barnes2011-09-141-13/+16
| | | | | | If we've just set up an NNTP account and haven't subscribed to any folders yet, the folder_info tree may legitimately be NULL. Don't treat it as an error.
* Bug #656723 - Forgets 'Use secure connection' setting during account ↵Milan Crha2011-09-141-8/+7
| | | | configuration
* Bug #656622 - 'Check for supported types' fails againMilan Crha2011-09-141-3/+8
|
* Simplify em_config_target_new_account_update_settings().Matthew Barnes2011-09-141-16/+4
| | | | | | Just connect to the "notify" signal, without the detail. That will trigger the callback when any property changes, which seems to be the intent there.
* Bug #656620 - Account editor doesn't update on settings changeMilan Crha2011-09-143-5/+43
|
* Using of uninitialized memory in em-folder-tree-model.c:store_info_freeMilan Crha2011-09-141-1/+1
|
* Adapt to new CamelSubscribable interface.Matthew Barnes2011-09-149-44/+68
|
* Notify about all newly received messages since the last checkMilan Crha2011-09-141-3/+5
|
* Bug #655254 - Cropped Junk settings textMilan Crha2011-09-141-2/+1
|
* EMAccountEditor: Utilize CamelSettings.Matthew Barnes2011-09-143-635/+488
| | | | | | | Simplifies the code overall, since now we can bind widget properties to settings properties and omit a bunch of callback functions. Plus now we can initialize the settings widgets with proper defaults according to the property specifications of CamelSettings classes.
* EMConfigTargetAccount: Add CamelSettings member.Matthew Barnes2011-09-142-2/+12
| | | | | | Allows plugins to manipulate a CamelSettings instance directly. The settings are written back to the URL string (for now) when the user clicks Apply in the mail account editor.
* EMailLocal: Change how we set "need-summary-check".Matthew Barnes2011-09-141-1/+4
| | | | | Set the CamelLocalStore:need-summary-check property directly instead of through camel_url_set_param(). This value is not stored permanently.
* EMailSession: Configure settings when adding services.Matthew Barnes2011-09-141-0/+29
| | | | | | | | | Override CamelSession.add_service(). First chain up, then, if initialization was successful, call camel_settings_load_from_url() on the CamelSettings object in the new CamelService instance. Note that eventually we'll load CamelSettings values from a key file instead of from URL parameters. This is just a temporary measure.
* Add migration routine for CamelURL param renames.Matthew Barnes2011-09-141-0/+241
|
* Bug #655942 - Shows 'Storing folder...' when deleting a local folderMilan Crha2011-09-141-1/+19
|
* Coding style and whitespace cleanup.Matthew Barnes2011-09-1413-145/+250
|
* Bug #656267 - Checking for auth types doesn't work properlyMilan Crha2011-09-142-14/+33
|
* EConfig: Broadcast abort/commit events by way of signals.Matthew Barnes2011-09-142-6/+11
| | | | | Remove the clumsy abortfunc and commitfunc callback arguments from e_config_add_items().
* EMFolderTreeModel: Avoid a potential refcount crash.Matthew Barnes2011-09-141-1/+7
|
* Bug #655944 - Import dialog is not showing operation progressMilan Crha2011-09-141-5/+5
|
* EMAccountEditor: Simplify real junk/trash folder selection.Matthew Barnes2011-09-141-19/+21
| | | | | Limit the folder choices to the current account so we don't have to check after the fact if the chosen folder is from the current account.
* EMFolderSelectionButton: Add an "account" property.Matthew Barnes2011-09-142-34/+118
| | | | | | The "account" property, if set, limits the displayed folder tree to the corresponding CamelStore only. Useful in contexts where the choice of folders should be limited to one particular store.
* EMFolderSelector: Add a "model" construct-only property.Matthew Barnes2011-09-147-22/+107
|
* Add em_folder_tree_new_with_model().Matthew Barnes2011-09-142-1/+18
| | | | | This is so an EMFolderTree can be created with a custom model, such as perhaps only a subset of available stores added.
* EMFolderTree: Clean up initialization logic.Matthew Barnes2011-09-142-317/+355
| | | | | | Some things are getting initialized too early. Not causing any bugs at present, but it's bad form. Defer non-trivial initialization steps to the constructed() method.
* EMailSidebar: Miscellaneous cleanups.Matthew Barnes2011-09-141-33/+13
|
* EMFolderTree: Miscellaneous cleanups.Matthew Barnes2011-09-141-51/+27
|
* EMFolderSelectionButton: Add a "folder-uri" property.Matthew Barnes2011-09-145-35/+62
| | | | And rename a couple get/set functions to match the property name.
* Bug #655669 - Can't save inline pictures embedded in HTML MailsMilan Crha2011-09-143-0/+177
|
* Cannot reply to message without preview panel enabledMilan Crha2011-09-141-0/+74
|
* EMAccountEditor: Readability improvements.Matthew Barnes2011-09-141-81/+169
|
* Avoid crashes when moving between messages quicklyMilan Crha2011-09-142-1/+13
| | | | | | | | The itip-formatter part is clean, but the one for attachment_button can still introduce runtime warnings, which requires more changes and rethinking of this all, which I prefer to postpone, the best after WebKit work will land, because it also may change most of the mail formatting code (I guess). It doesn't crash, at least.
* Use the same term 'Secure connection' everywhere instead of SSLAndre Klapper2011-09-141-2/+2
|
* Bug #635211 - Select-all processed on timeout when not neededMilan Crha2011-09-141-3/+3
|
* Bug #655441 - Fix typoAndre Klapper2011-09-141-1/+1
|
* Bug #655430 - Forgotten EMailJunkOptions type init for mail-config.uiMilan Crha2011-09-141-0/+2
|
* Bug #655353 - Add translator commentAndre Klapper2011-09-141-1/+1
|
* Forward button in Evolution Mail Configuration Assistant is actually called ↵Andre Klapper2011-09-141-1/+1
| | | | Continue
* EMailBackend: Explicitly remove CamelServices during dispose.Matthew Barnes2011-09-141-0/+2
| | | | | | Calling camel_session_remove_services() while disposing of our CamelSession instance can help break reference cycles and ensures the CamelServices get finalized properly.
* Convert junk filtering EPlugins to EExtensions.Matthew Barnes2011-09-1411-3483/+4544
| | | | | | | | | | | | | | | | | We now have a proper junk mail filtering API. All junk filtering extensions must subclass EMailJunkFilter for user preferences and availability testing, and implement the CamelJunkFilter interface for the actual junk filtering and learning operations. The bogofilter module should be feature-equivalent to its former EPlugin. The spamassassin module is far more complex. It's nearly feature-equivalent to its former EPlugin, but I ditched the spamd respawning code since it seemed unnecessary for a mail client to have to deal with. If there's a huge outcry from users about it I'll reluctantly put it back, but I don't expect one. This gets us a step closer to killing off EConfig, and eventually the EPlugin framework itself.
* Avoid camel_stream_printf().Matthew Barnes2011-09-143-154/+379
| | | | | | | | camel_stream_printf() is next on the chopping block. Use g_strdup_printf() or a GString to construct a formatted string in memory, pass it to camel_stream_write() in one go, and then check for errors (unless it's a memory stream).
* Prefer g_seekable_seek() over camel_stream_reset().Matthew Barnes2011-09-142-10/+13
| | | | | | | | | When a stream is obviously a file or memory stream (both of which implement the GSeekable interface), use g_seekable_seek() instead of camel_stream_reset(). This is helping me discover if it's safe to remove camel_stream_reset(). We want to eventually move to GIO streams, which have no reset method.
* Adapt to CamelSession and e-passwords changes.Matthew Barnes2011-09-142-16/+5
|
* Bug #650671 - Service connect/disconnect not cancelled properlyMilan Crha2011-09-148-16/+72
|
* Bug #499739 - "Flag for follow-up" should be easier to setMilan Crha2011-09-141-1/+27
|
* Bug 652958 - Evolution Account Assistant jumps stepsMatthew Barnes2011-09-142-28/+122
| | | | | | | The GTK+ patch in bug 653705 is also required for the Account Assistant to work properly under the new GtkAssistant design in GTK+ 3.1. This commit only deals with sidebar ordering issues.
* Bug 653247 - Don't show TIFF documents inlineMatthew Barnes2011-09-141-1/+10
| | | | | | | | | | image/tiff is omitted because it's a multi-page image format, but gdk-pixbuf unconditionally renders the first page only, and doesn't even indicate through meta-data whether multiple pages are present (see bug 335959). Therefore, make no attempt to render TIFF images inline and defer to an application that can handle multi-page TIFF files properly like Evince or Gimp. Once the referenced bug is fixed we can reevaluate this policy.
* Bug #653618 - Sending email doesn't disconnect from a serverMilan Crha2011-06-301-5/+13
|
* Limit the size of tab labels to a reasonable sizeGustavo Noronha Silva2011-06-301-0/+41
| | | | | | | | | | We use half the size allocated to the whole view as a reference, and force the label to be at most that size, taking advantage of ellipsis otherwise. Notice that we also force the natural size as the requested size if it is not too big as well, because labels ellipsisized using the minimum size usually, which is undesired. This is a fix for https://bugs.meego.com/show_bug.cgi?id=18313
* Bug #653466 - Crash in efh_format_headersMilan Crha2011-06-301-3/+3
|
* Check for cancelled GIO operation error code tooMilan Crha2011-06-301-4/+7
|
* Bug #650278 - Tab doesn't exit port fieldMilan Crha2011-06-301-2/+0
|
* Bug #648468 - Disconnect service after mail fetching is doneMilan Crha2011-06-301-1/+8
|
* Could not select real Junk/Trash folderMilan Crha2011-06-301-5/+16
|
* Bug #638307 - Error when sending mail after converting to maildirMilan Crha2011-06-301-0/+76
|
* Fix few memory leaksMilan Crha2011-06-303-3/+17
|
* Bug #530335 - Allow Reply to selected address onlyRathin2011-06-306-4/+90
|
* Remove unused variables reported by gccMilan Crha2011-06-301-8/+1
|
* Do not use deprecated EBook/ECal APIMilan Crha2011-06-302-86/+101
|
* Fix some uninitialized variable usage.Matthew Barnes2011-06-301-2/+2
|
* Coding style and whitespace cleanups.Matthew Barnes2011-06-3018-114/+269
|
* Miscellaneous mail cleanups.Matthew Barnes2011-06-303-25/+48
|
* Fixes a crash while creating VeeFolders at the root level.Chenthill Palanisamy2011-06-301-1/+7
|
* Bug #651976 - Reply/Forward setting isn't respected in message windowMilan Crha2011-06-301-1/+5
|
* Bug #651316 - Crash with Outgoing mail filtersMilan Crha2011-06-301-1/+1
|
* Bug #651761 - Message window doesn't mark message seenMilan Crha2011-06-301-0/+1
|
* Bug #651684 - Creates a copy of message in Outbox instead of replacingMilan Crha2011-06-301-0/+38
|
* Do not add 'Local delivery' accounts into folder treeMilan Crha2011-06-302-1/+8
| | | | | And make folder_tree_get_folder_info_cb() always finish properly, because evolution doesn't want to quit otherwise.
* Bug #649757 - 'Local delivery' accounts stopped workingMilan Crha2011-06-301-5/+31
|
* vfolder_adduri(): Take an EMailBackend instead of EMailSession.Matthew Barnes2011-06-301-14/+17
| | | | Needed for the account-mgmt branch.
* EMVFolderRule: Track folder URIs in a GQueue instead of GList.Matthew Barnes2011-06-303-95/+97
| | | | Makes the logic a little cleaner. Do this also in mail-vfolder.c.
* Bug #578245 - View settings for threads getting lostMilan Crha2011-06-302-29/+26
|
* e-mail-folder-utils.c cleanups.Matthew Barnes2011-06-301-4/+0
|
* Fix build breaks.Matthew Barnes2011-06-302-28/+29
|
* mail_vfolder_add_folder(): Change parameters.Matthew Barnes2011-06-301-8/+11
| | | | Take an EMailBackend instead of an EMailSession.
* Replace deprecated g_atomic_int_exchange_and_add()Milan Crha2011-06-302-2/+2
|
* EMFilterFolderElement cleanups.Matthew Barnes2011-06-301-128/+127
|
* EMFolderSourceElement: Store UIDs instead of URIs.Matthew Barnes2011-06-301-92/+94
| | | | | For backward-compatibility we can still decode <uri> elements, but new source rules will store the account UID, which is easier to deal with.
* EMFilterSourceElement: Add an EMailBackend constructor property.Matthew Barnes2011-06-303-10/+106
|
* EMFilterSourceElement cleanups.Matthew Barnes2011-06-302-179/+185
|
* Fix more places where old-style folder URIs are used.Matthew Barnes2011-06-303-50/+20
|
* Bug #649939 - Cann't create new folderMilan Crha2011-06-303-6/+62
|
* Bug #651062 - Emit operation progress on the correct cancellableMilan Crha2011-06-301-3/+3
|
* e_mail_store_add_by_account(): Fix a potential use-before-set.Matthew Barnes2011-06-301-1/+1
|
* Remove em_utils_folder_name_from_uri().Matthew Barnes2011-06-302-28/+0
|
* Change EMEventTargetFolder contents.Matthew Barnes2011-06-303-27/+22
| | | | | | Give it a CamelStore and folder name instead of an EAccount and folder URI. Both the EAccount and folder URI can be easily retrieved from the CamelStore and folder name.
* EMSubscriptionEditor: Manage stores, not accounts.Matthew Barnes2011-06-302-76/+107
| | | | | We'll query the accounts to get display names for the combo box, but that's it. Use CamelStores instead.
* Add em_folder_tree_model_list_stores().Matthew Barnes2011-06-302-0/+10
| | | | | | Lists all the CamelStores added to EMFolderTreeModel. Note that CamelStores with a corresponding EAccount are only added if the EAccount is enabled, so it's safe to assume all returned CamelStores are enabled.
* EMFolderTreeModel: Miscellaneous cleanups.Matthew Barnes2011-06-301-43/+13
|
* Including <glib-object.h> directly is rarely needed.Matthew Barnes2011-06-304-5/+0
|
* Including <glib.h> directly is rarely needed.Matthew Barnes2011-06-3021-24/+0
|
* Remove account from EMFolderTreeModelStoreInfo.Matthew Barnes2011-06-302-7/+10
| | | | | The struct already has a CamelStore, and the CamelStore UID is the same as the EAccount UID, so it's easy to lookup the corresponding EAccount.
* EMFolderTreeModel: Remove internal account_index.Matthew Barnes2011-06-301-26/+15
| | | | The store_index is sufficient.
* Remove display_name from EMFolderTreeModelStoreInfo.Matthew Barnes2011-06-303-16/+3
| | | | | It was only being used to look up an EAccount UID, but we already had the CamelStore, and the CamelStore UID is the same as the EAccount UID.
* Bug #646109 - Fix use of include <config.h> to make sure translations workMilan Crha2011-06-3037-12/+116
|
* Bug 651062 - refresh_folders_exec() reports progress incorrectly.Matthew Barnes2011-06-301-3/+6
|
* Bug 651001 - Cannot send message from accounts not having a providerLucian Langa2011-06-301-2/+8
|
* Check for vfolder stores by UID, not URI.Matthew Barnes2011-06-302-76/+80
|
* Fix em_folder_selector_get_selected_uri().Matthew Barnes2011-06-301-35/+9
| | | | | Another case of custom logic to build old-style folder URIs. The new format simplifies things considerably.
* EMFolderSelector: Fix some silly typos.Matthew Barnes2011-06-301-2/+2
|
* Use em_folder_tree_get_selected() in places to simplify code.Matthew Barnes2011-06-304-58/+42
| | | | | | There were a few places where we were accessing the folder tree model directly to get the selected store + folder name, or were asking for the selected URI only to parse back into its store + folder name components.
* Remove em_folder_tree_get_selected_path().Matthew Barnes2011-06-302-24/+0
| | | | em_folder_tree_get_selected() supercedes it.
* Add em_folder_tree_get_selected().Matthew Barnes2011-06-302-0/+39
| | | | Returns the CamelStore and folder name of the selected row.
* EMFolderTree: Rewrite async folder info loading.Matthew Barnes2011-06-301-125/+157
| | | | | | When a folder is expanded and child folder info needs to be retrieved, submit an EActivity and call camel_store_get_folder_info() instead of using the legacy MailMsg API.
* Add em_folder_tree_new_activity().Matthew Barnes2011-06-302-0/+26
| | | | | | Similar to e_mail_reader_new_activity(). Creates, configures and submits a new EActivity instance, so asynchronous operations can easily be dispatched without a lot of boilerplate code.
* EMFolderTree: Add an EAlertSink property.Matthew Barnes2011-06-305-10/+77
| | | | | Now EMFolderTree has access to both an EShellBackend and an EAlertSink; everything it needs to build and submit EActivity instances.
* Let EMFolderSelector create its own EMFolderTree.Matthew Barnes2011-06-307-252/+285
| | | | | Also, minimize the EMFolderSelector API by removing frivolous wrapper functions and unused functions.
* EMFolderTree: Whitespace cleanups.Matthew Barnes2011-06-301-6/+9
|
* EMFolderTree: Store an EMailBackend instead of an EMailSession.Matthew Barnes2011-06-3030-345/+364
| | | | | | | | All this so EMFolderTree can submit EActivity instances for async ops. You can obtain an EMailSession from an EMailBackend, but not vice versa. Creates lots of pretty ripples in the mail code, but ultimately reduces complexity. So it's a code cleanup of sorts.
* Remove emfu_create_folder_real().Matthew Barnes2011-06-303-187/+231
| | | | Use e_mail_store_create_folder() instead.
* Fix crash when opening message window.Matthew Barnes2011-06-301-2/+2
| | | | Would help if I actually did what the comment said...
* Coding style and whitespace cleanup.Matthew Barnes2011-06-3018-135/+335
|
* EMailReader: Remove the forward/reply style hack.Matthew Barnes2011-06-301-24/+23
| | | | | Now that we're configuring EMailReader instances from an idle callback, we can safely store the forward and reply styles in the private struct.
* Bug 650587 - Hide Search Folder actions when Search Folders are disabledMatthew Barnes2011-06-305-53/+86
| | | | | | | | | | | | | | | | Add an action group for Search Folders to EMailReader. The action group's visibility is bound to the "mail-enable-search-folders" setting, so that menu items related to Search Folders are hidden when Search Folders are disabled in GConf. Affected menu items are: Edit -> Search Folders Message -> Create Rule -> Search Folder from Subject... Message -> Create Rule -> Search Folder from Sender... Message -> Create Rule -> Search Folder from Recipients... Message -> Create Rule -> Search Folder from Mailing List... Search -> Create Search Folder From Search...
* EMailReader: Support multiple action groups.Matthew Barnes2011-06-307-38/+67
| | | | | | Use an enum type to request different action groups. For now we just have E_MAIL_READER_ACTION_GROUP_STANDARD. EMailReader implementations should map the enum value to an appropriate GtkActionGroup.
* mail-autofilter.c: Add argument guards in public functions.Matthew Barnes2011-06-301-1/+13
| | | | | | | | | This is related to bug #650587, but is not a proper fix. The proper fix is in the next couple commits about EMailReader action groups. This commit just trades a crash for a runtime warning, but can be backported to the stable branch, whereas the changes required for the proper fix are too extensive to backport.
* Remove mail_remove_folder().Matthew Barnes2011-06-3011-279/+352
| | | | Use e_mail_folder_remove() instead.
* Always initialized all structure membersMilan Crha2011-06-301-1/+1
|
* Bug 650522 - em-format-html: Fix uninitialized variableColin Walters2011-06-301-1/+1
|
* Remove mail_get_folderinfo().Matthew Barnes2011-06-303-131/+55
| | | | Use camel_store_get_folder_info() instead.
* Remove mail_save_messages().Matthew Barnes2011-06-308-238/+378
| | | | Use e_mail_folder_save_messages() instead.
* Remove mail_store_prepare_offline().Matthew Barnes2011-06-305-85/+89
| | | | Use e_mail_store_prepare_for_offline() instead.
* Remove mail_check_service().Matthew Barnes2011-06-303-146/+73
| | | | Use camel_service_query_auth_types() instead.
* Remove mail_remove_attachments().Matthew Barnes2011-06-307-149/+309
| | | | Use e_mail_folder_remove_attachments() instead.
* Bug #601541 - Add 'Copy Image' Option On Inline Email ImagesMilan Crha2011-06-301-0/+6
|
* Remove mail_get_folder_quota().Matthew Barnes2011-06-302-83/+0
| | | | Use camel_folder_get_quota_info() instead.
* EMFolderProperties: Fetch quota information asynchronously.Matthew Barnes2011-06-301-11/+52
|
* Remove mail_get_message().Matthew Barnes2011-06-302-85/+0
| | | | Use camel_folder_get_message() instead.
* Reimplement the "mail-reply-sender" action.Matthew Barnes2011-06-301-47/+79
| | | | Now uses camel_folder_get_message().
* Reimplement the "mail-reply-all" action.Matthew Barnes2011-06-301-33/+59
| | | | Now uses camel_folder_get_message().
* Bug #646033 - Update progress in Send/Receive dialogMilan Crha2011-06-301-0/+16
|
* Keep forgetting to add prefixes to EAlert tags.Matthew Barnes2011-06-303-5/+5
|
* Miscellaneous cleanups.Matthew Barnes2011-06-304-72/+81
|
* em_format_html_print_message(): Require a CamelMimeMessage.Matthew Barnes2011-06-304-49/+91
| | | | | | Let EMailReader fetch the CamelMimeMessage itself, handle errors, and then pass it off to EMFormatHTMLPrint. This also eliminates the need for em_format_html_print_raw_message().
* em_utils_reply_to_message(): Require a CamelMimeMessage.Matthew Barnes2011-06-304-76/+15
| | | | | No more fetching a message itself. Oh, and stop unreffing the message. Those kinds of insane semantics are what lead to crashes.
* Remove em_utils_redirect_message_by_uid().Matthew Barnes2011-06-302-42/+0
| | | | Use em_utils_redirect_message() instead.
* Reimplement the "mail-redirect" action.Matthew Barnes2011-06-301-8/+59
| | | | | Now fetches the message itself using camel_folder_get_message(), then calls em_utils_redirect_message().
* Add e_mail_reader_new_activity().Matthew Barnes2011-06-304-76/+54
| | | | | | | | | | | | | | | | Configuring and submitting an EActivity for every mail operation is getting tedious. This function helps reduce boilerplate code by: * Creating a new EActivity instance. * Installing an EAlertSink using e_mail_reader_get_alert_sink(). * Installing a GCancellable (which is really a CamelOperation). * Submitting the activity via e_shell_backend_add_activity(). I'm considering adding a similar function (or class method) for EShellView. Not sure yet...
* Reimplement e_mail_reader_create_vfolder_from_selected().Matthew Barnes2011-06-301-5/+0
| | | | Now uses camel_folder_get_message().
* Reimplement e_mail_reader_create_vfolder_from_selected().Matthew Barnes2011-06-301-24/+75
| | | | Now uses camel_folder_get_message().
* Reimplement e_mail_reader_create_filter_from_selected().Matthew Barnes2011-06-301-33/+72
| | | | Now uses camel_folder_get_message().
* EMConfigTargetFolder: Remove URI member.Matthew Barnes2011-06-303-11/+3
| | | | | Use e_mail_folder_uri_from_folder() if you really need a folder URI for the target's CamelFolder.
* Bug #645476 - Avoid scroll to cursor on folder change in message listMilan Crha2011-06-301-12/+15
|
* Cannot send message with just enabled accountMilan Crha2011-06-303-56/+46
| | | | | | | | | | | | | Everything in UI seemed as working fine, but the message is just lost, even there was printed a runtime warning on the console. This is fixing couple things along this issue: - differentiate between NULL and invalid pointers/objects in new e_mail_folder_uri_...() functions - report error to UI if mail_session_send_to_thread() fails to find corresponding transport service - call e_mail_store_add_by_account() in mail_store_load_accounts() (a side-effect of this change is no code duplication and unified processing of the same action)
* e_mail_session_uri_to_folder_sync(): Remove redundant status message.Matthew Barnes2011-06-301-5/+0
| | | | camel_store_get_folder() pushes an "Opening folder" message itself.
* Remove mail_get_folder().Matthew Barnes2011-06-302-87/+0
| | | | Use camel_store_get_folder() instead.
* Reimplement em_folder_properties_show().Matthew Barnes2011-06-302-100/+196
| | | | | Now uses camel_store_get_folder() and camel_folder_get_quota_info(), although I need to rewrite the quota function to be asynchronous.
* Get vfolder_edit_rule() working again.Matthew Barnes2011-06-302-65/+62
| | | | | | It was handling folder URIs the old way. Also, use gtk_dialog_run() to simplify the logic.
* Fix some GPtrArray leaks.Matthew Barnes2011-06-302-23/+50
|
* Add e_activity_handle_cancellation().Matthew Barnes2011-06-304-35/+15
| | | | | | | | Convenience function for use in GAsyncReadyCallback functions. This acknowledges the cancellation, so that the activity's description changes from "(cancelling)" to "(cancelled)" and the description appears crossed out in the UI for a moment before disappearing.
* Remove mail_get_messages().Matthew Barnes2011-06-302-99/+0
| | | | Use e_mail_folder_get_multiple_messages() instead.
* Remove mail_build_attachment().Matthew Barnes2011-06-302-67/+0
| | | | Use e_mail_folder_build_attachment() instead.
* Reimplement em_utils_edit_messages().Matthew Barnes2011-06-305-68/+86
| | | | Now uses e_mail_folder_get_multiple_messages().
* Add a 'message_uid' param to em_utils_edit_message().Matthew Barnes2011-06-302-53/+48
| | | | | So we can remove the internal edit_message() function and do the work directly in em_utils_edit_message().
* Reimplement em_utils_forward_messages().Matthew Barnes2011-06-304-118/+189
| | | | | Now uses e_mail_folder_build_attachment() and e_mail_folder_get_multiple_messages().
* Add e_mail_folder_build_attachment().Matthew Barnes2011-06-302-0/+186
| | | | Replaces mail_build_attachment() from mail-ops.c.
* EMailReader: Reimplement "mail-remove-duplicates" action.Matthew Barnes2011-06-304-151/+166
| | | | Now uses e_mail_folder_find_duplicate_messages().
* Add e_mail_folder_find_duplicate_messages().Matthew Barnes2011-06-302-0/+218
| | | | Moves the non-interactive logic out of EMailReader.
* Add e_mail_folder_get_multiple_messages().Matthew Barnes2011-06-302-0/+154
| | | | Replaces mail_get_messages() from mail-ops.c.
* Bug #649939 - Cann't create new folder (second shot)Milan Crha2011-06-302-3/+12
| | | | | The previous patch worked for local account only, for anything which has '@' in account's UID it still failed.
* Bug #649952 - Do not unref result of camel_session_get_service()Milan Crha2011-06-302-1/+2
|
* Bug #649939 - Cann't create new folderMilan Crha2011-06-301-41/+14
|
* "email://" URIs have encoded paths too.Matthew Barnes2011-06-301-1/+1
|
* Encode the path part of folder URIs.Matthew Barnes2011-06-301-8/+16
| | | | | | | | | | | | Wasn't sure if this was necessary, but it -is- in order to handle the local Junk and Trash vfolder names correctly: .#evolution/Junk .#evolution/Trash If we don't escape the path and we feed camel_url_new() something like "folder://local/.#evolution/Trash", it's gonna think the path is '.' and the rest of it's a fragment.
* Coding style cleanups.Matthew Barnes2011-06-3035-470/+470
|
* Whitespace and coding style cleanups.Matthew Barnes2011-06-3018-75/+168
|
* Adapt to CamelFolder:name -> display-name.Matthew Barnes2011-06-305-6/+8
|
* Adapt to CamelFolderInfo.name -> display_name.Matthew Barnes2011-06-303-15/+18
|
* mail-send-recv.c:get_folders(): Adapt to CamelVeeStore change.Matthew Barnes2011-06-301-8/+7
| | | | See E-D-S commit 26c74be4066dff41dd1e9c9adc1c2c116142ba60.
* MailFolderCache: Drop folder URI in "folder-changed" signal.Matthew Barnes2011-06-302-33/+24
| | | | | We already include a CamelStore and folder name string in the signal arguments, so it's trivial to reconstruct the URI if it's needed.
* Remove em_folder_tree_get_selected_folder_info().Matthew Barnes2011-06-302-45/+0
| | | | Function is no longer used, or wanted.
* em_folder_utils_create_folder(): Change function parameters.Matthew Barnes2011-06-303-9/+15
| | | | | Take a folder URI string instead of a CamelFolderInfo, and swap places with the GtkWindow parameter.
* em_folder_utils_copy_folder(): Change function parameter.Matthew Barnes2011-06-302-31/+48
| | | | Take a folder URI string instead of a CamelFolderInfo.
* Adapt to X-Evolution-Source headers storing UIDs.Matthew Barnes2011-06-302-33/+13
|
* Remove uid_cachename_hack().Matthew Barnes2011-06-301-24/+7
| | | | | | It was building the old CamelStore path based on the URI. Gone before 0.11 my ass.
* fetch_mail_exec(): Remove hack for local Inbox.Matthew Barnes2011-06-301-92/+66
| | | | | | Don't call camel_filter_driver_filter_mbox() on the local Inbox since the local Inbox is no longer an mbox. Just treat it like any other folder.
* Remove em_uri_from_camel() and em_uri_to_camel().Matthew Barnes2011-06-302-146/+0
| | | | Functions are no longer used, or wanted.
* mail-config.c: Don't try to rename obsolete config files.Matthew Barnes2011-06-301-10/+3
|
* MailFolderCache: Emit folder names instead of URIs in signals.Matthew Barnes2011-06-306-230/+202
|
* mail-config.c: Code cleanups.Matthew Barnes2011-06-301-105/+108
|
* mail-vfolder.c: Coding style cleanups.Matthew Barnes2011-06-301-20/+16
|
* Simplify vfolder_adduri_desc().Matthew Barnes2011-06-301-37/+30
|
* Simplify em_vfolder_rule_from_address().Matthew Barnes2011-06-301-4/+2
|
* Simplify em_vfolder_rule_from_message().Matthew Barnes2011-06-301-4/+2
|
* Simplify e_mail_session_unsubscribe_folder_sync().Matthew Barnes2011-06-301-31/+18
|
* e_mail_local_init(): Use the new folder URI format.Matthew Barnes2011-06-301-5/+5
|
* EMVFolderRule: Use the new folder URI format.Matthew Barnes2011-06-301-16/+17
|
* EMFilterFolderElement: Use the new folder URI format.Matthew Barnes2011-06-303-45/+8
| | | | No longer need to distinguish between Camel URIs and Evolution URIs.
* EMFolderTreeModel: Use the new folder URI format.Matthew Barnes2011-06-301-5/+9
| | | | Disregard CamelFolderInfo.uri strings.
* Introduce a new, simpler folder URI format.Matthew Barnes2011-06-302-8/+65
| | | | | | | | | | | | | | | | Folder URIs shall henceforth be exclusive to Evolution. The new format is: 'folder://' CAMEL_STORE_UID '/' CAMEL_FOLDER_PATH Add e_mail_folder_uri_build() to construct such a URI from a CamelStore and folder path string, change e_mail_folder_uri_from_folder() to build the new URI, and teach e_mail_folder_uri_parse() to parse it. e_mail_folder_uri_parse() will continue to know how to parse the older URI formats still present in config files and GConf keys. This captures the legacy knowledge neatly into one function.
* EMAccountEditor: Fix a runtime warning.Matthew Barnes2011-06-301-2/+5
| | | | | | Before selecting a URI in the EMFolderSelectionButton for Drafts and Sent folders, install an EMailSession in each button which is needed for parsing URIs.
* Random little coding style cleanups.Matthew Barnes2011-06-304-32/+35
|
* EMailDisplay: Coding style cleanup.Matthew Barnes2011-06-301-1/+2
|
* EMFolderTreeModel: Avoid e_get_account_by_source_url().Matthew Barnes2011-06-301-1/+3
| | | | Use e_get_account_by_uid() instead.
* EMFolderTreeModel: Always populate the CamelStore column.Matthew Barnes2011-06-301-4/+3
| | | | | Even in 'Loading...' rows. This way we know the CamelStore is present in all rows, and don't have to test for NULL.
* Simplify em_folder_tree_model_set_folder_info().Matthew Barnes2011-06-301-6/+4
| | | | | e_mail_folder_uri_equal() uses e_mail_folder_uri_parse() to parse both URIs, so we can just hand it an 'email://' URI directly.
* Simplify em_utils_folder_is_sent().Matthew Barnes2011-06-301-9/+4
| | | | | e_mail_folder_uri_equal() uses e_mail_folder_uri_parse() to parse both URIs, so we can just hand it an 'email://' URI directly.
* Simplify em_utils_folder_is_drafts().Matthew Barnes2011-06-301-8/+3
| | | | | e_mail_folder_uri_equal() uses e_mail_folder_uri_parse() to parse both URIs, so we can just hand it an 'email://' URI directly.
* Simplify em_utils_folder_is_templates().Matthew Barnes2011-06-301-8/+3
| | | | | e_mail_folder_uri_equal() uses e_mail_folder_uri_parse() to parse both URIs, so we can just hand it an 'email://' URI directly.
* Simplify emae_account_folder().Matthew Barnes2011-06-301-7/+2
| | | | | EMFolderSelectionButton uses e_mail_folder_uri_parse(), so we can just hand it an 'email://' URI directly.
* Simplify e_mail_session_uri_to_folder_sync().Matthew Barnes2011-06-301-67/+13
| | | | | | This relies on e_mail_folder_uri_parse() to handle 'email://' URIs. See the previous commit.
* Teach e_mail_folder_uri_parse() to parse 'email://' URIs.Matthew Barnes2011-06-301-9/+60
|
* Simplify em_folder_tree_set_selected_list().Matthew Barnes2011-06-301-59/+38
|
* Bug #627952 - 'Local delivery' mbox's aren't read properlyMilan Crha2011-06-302-7/+15
|
* Use e_mail_folder_uri_from_folder() instead of camel_folder_get_uri().Matthew Barnes2011-06-306-46/+48
|
* Remove EMFolderTreeModel::folder-added signal.Matthew Barnes2011-06-302-18/+0
| | | | No one was listening.
* EMFolderSelectionButton: Avoid e_get_account_by_source_url().Matthew Barnes2011-06-301-10/+19
| | | | Use e_get_account_by_uid() instead.
* MessageList: Simplify the "Location" column.Matthew Barnes2011-06-301-25/+18
|
* Drop 'folder_uri' member from MessageList.Matthew Barnes2011-06-305-40/+31
|
* Remove e_mail_reader_get_folder_uri().Matthew Barnes2011-06-304-43/+35
| | | | | Instead call e_mail_reader_get_folder() and, if you really need to, generate the folder URI with e_mail_folder_uri_from_folder().
* Build vfolder rules with CamelFolders instead of folder URIs.Matthew Barnes2011-06-306-28/+35
|
* Remove 'from_uri' params from e-msg-composer-utils.c.Matthew Barnes2011-06-304-67/+65
| | | | | Pass CamelFolder objects instead, which are already available at almost every call site.
* Change em_folder_tree_model_user_marked_unread() params.Matthew Barnes2011-06-304-7/+11
| | | | Take a CamelFolder instead of a folder URI string.
* Fix a runtime warning in e_mail_reader_check_state().Matthew Barnes2011-06-301-6/+6
| | | | | Don't call em_utils_folder_is_drafts() or em_utils_folder_is_outbox() if the CamelFolder is NULL.
* Fix compiler warnings.Matthew Barnes2011-06-305-21/+1
| | | | Mostly dead assignments.
* Drop 'folder_uri' param from em_utils_folder_is_outbox().Matthew Barnes2011-06-309-34/+21
|
* Drop 'folder_uri' param from em_utils_folder_is_sent().Matthew Barnes2011-06-306-14/+15
|
* Drop 'folder_uri' param from em_utils_folder_is_templates().Matthew Barnes2011-06-305-12/+14
|
* Drop 'folder_uri' param from em_utils_folder_is_drafts().Matthew Barnes2011-06-309-26/+24
|
* em-utils.c: Simplify guess_account_from_folder().Matthew Barnes2011-06-301-13/+5
|
* em-utils.c: More coding style cleanups.Matthew Barnes2011-06-301-8/+17
|
* Replace camel_store_folder_uri_equal() with e_mail_folder_uri_equal().Matthew Barnes2011-06-303-67/+87
|
* em-utils.c: Coding style cleanups.Matthew Barnes2011-06-301-66/+71
|
* Add some handy folder URI utility functions.Matthew Barnes2011-06-302-0/+165
| | | | | | | | | | | | | | | | | e_mail_folder_uri_parse() Parses a folder URI and returns a corresponding CamelStore instance and folder name string, or else sets a GError. e_mail_folder_uri_equal() Compares two folder URIs for equality. Replaces camel_store_folder_uri_equal(). e_mail_folder_uri_from_folder() This will eventually replace camel_folder_get_uri(), but for now it just calls camel_folder_get_uri() and duplicates the URI string.
* Drop 'folder_uri' param from message_list_set_folder().Matthew Barnes2011-06-303-8/+14
|
* MessageList coding style cleanups.Matthew Barnes2011-06-301-12/+12
|
* Remove e_mail_reader_set_folder_uri().Matthew Barnes2011-06-302-32/+0
| | | | Function is no longer used, or wanted.
* EMailShellView: Open the selected folder ourselves.Matthew Barnes2011-06-309-56/+74
| | | | | | | | | | | | | | | | | This one's a little involved: - EMailShellView now obtains a CamelFolder itself in response to EMFolderTree::folder-selected signals. Uses EActivity to do so. - Revise EMFolderTree::folder-selected signal arguments to be more useful: emit a CamelStore object instead of a folder URI. - Also revise EMFolderTree::folder-activiated signal arguments the same way while we're at it. - Remove the "folder_uri" argument from e_mail_reader_set_folder(). If you have a CamelFolder object you can obtain the URI string by calling camel_folder_get_uri().
* Add em_folder_tree_get_selected_account().Matthew Barnes2011-06-302-0/+28
| | | | Comes in handy for a few EMailShellView actions.
* EMFolderTree: Coding style cleanups.Matthew Barnes2011-06-301-6/+10
|
* EMailSession: Fix popb4smtp authentication.Matthew Barnes2011-06-301-6/+1
| | | | | Forgot I had already made CamelSaslPOPB4SMTP expect a CamelSource UID from camel_session_get_password().
* Simplify mail_session_get_password().Matthew Barnes2011-06-301-16/+13
| | | | | Utilizes the new capability in e_get_account_by_uid() to handle both CamelStore and CamelTransport UIDs.
* EMConfigTargetAccount: Add original_account member.Matthew Barnes2011-06-303-15/+35
| | | | | | | Rename the existing 'account' member to 'modified_account' and add an 'original_account' member so plugins have direct access to both. Mostly of benefit to the imap-features plugin.
* EMConfig coding style cleanups.Matthew Barnes2011-06-302-86/+92
|
* EMEventTargetFolder: Add an EAccount member.Matthew Barnes2011-06-303-1/+15
| | | | | The mail-notification plugin can use the EAccount member directly instead of searching for it by URI.