| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
the backspace is pressed in the beginning of it
|
|
|
|
| |
Plus a little code cleanup for easier grepping.
|
|
|
|
|
|
|
| |
Temporarily remove the HTML input event listener from the body element to avoid
unwanted modification of the clipboard content. In callback we are
selecting all the content in composer (badically Ctrl + A) that's
modifying the clipboard content.
|
| |
|
|
|
|
|
| |
We have to ask for the previous sibling of element that marks the selection
start instead of the end.
|
|
|
|
| |
the whole body element is selected
|
|
|
|
| |
generating the plain text version of the message
|
|
|
|
| |
HTML version of the message
|
| |
|
|
|
|
|
|
| |
We have to treat the pasting into the normal and the quoted
content separately. We have to also correctly process the new lines on
the beginning/end of the pasted content to avoid their lose.
|
|
|
|
|
| |
Namely don't lose the new line on the beginning or on the end of
processed content and also on the lines with zero width space character.
|
|
|
|
|
|
|
|
| |
event on body
There are some cases that we want to avoid the call of the callback
(performance reasons and the avoidance of the unwanted modifications of
the composer content).
|
|
|
|
| |
the spell check
|
|
|
|
| |
Also fixes the leakage of EHTMLEditorView is some code paths.
|
|
|
|
|
| |
The text color was used reverted, focused color for unfocused widget
and vice versa, producing incorrect drawing and a text hard to read.
|
|
|
|
|
| |
This also makes gnome-desktop an optional dependency, which can
be avoided with --disable-gnome-desktop configure option.
|
| |
|
|
|
|
|
| |
Check if the buffer already contains some data before doing some work
on it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes evolution depend on theme-defined named colors, namely:
theme_bg_color
theme_base_color
theme_fg_color
theme_text_color
theme_selected_bg_color
theme_selected_fg_color
theme_unfocused_selected_bg_color
theme_unfocused_selected_fg_color
If it's not defined, then a fallback color is used, in the worse case
one of the fallbacks defined in evolution itself.
|
|
|
|
|
|
| |
After commit 8a004f3e we are finally sure that the text that is passed
into e_html_editor_view_set_text_html function has always the HTML
content, so don't try to treat it as plain text.
|
|
|
|
|
| |
Don't use WebKit indent/unindent commands. Make our indentation/undentation
code (that was used when there was no selection) selection aware.
|
|
|
|
|
|
|
|
|
| |
a HTML content
Code paths for HTML content and plain text content are different. When
we will try to load plain text content as a HTML content we will lose
the new line characters. In the opposite case when HTML content is load
as a plain text at least the whole structure is lost.
|
|
|
|
| |
caret there
|
|
|
|
| |
to save it
|
|
|
|
|
| |
Remove bogus new line character insertion and don't quote the anchor
element if it has caret/selection inside.
|
|
|
|
|
|
| |
anchor elements
And add www to patterns.
|
|
|
|
|
| |
Don't replace them with 8 spaces, but count the right amount of spaces
to relace the tab character with.
|
|
|
|
|
| |
When there is a whitespace after the link leave it after the link and don't
try to wrap before it.
|
|
|
|
|
|
| |
When wrapping lines with really long words (more that is defined in Composer
settings) the maximal length for wrap could be less than zero. For
proper functionality we have to set it to the right value.
|
|
|
|
| |
changing the block's format
|
|
|
|
| |
content remove all of them
|
|
|
|
| |
quoted content
|
|
|
|
|
| |
Let's use our own spinner-like widget, which doesn't need as that
much of CPU as GtkSpinner.
|
|
|
|
|
|
|
|
|
|
| |
text-highlight module encloses the generated text into <pre/> tags,
thus the preview panel shows white-spaces correctly, but once
a reply is done to a selected text the returned HTML portion had
missing <pre/> tags, which led to lose of the white-spaces in
the generated content (in UI), while the white-spaces were there
in the raw HTML code. Enclosing selected HTML portion into <pre/>
tags in case the original text is also enclosed it them fixes it.
|
|
|
|
|
| |
When pasting the text from clipboard into the quoted content in the composer
paste it into it and not into the body.
|
|
|
|
| |
them insensitible
|
| |
|
|
|
|
|
| |
We have to check if the caret is inside the viewport when we are trying to
scroll to it. If it is in the viewport we won't scroll.
|
|
|
|
|
|
|
| |
Together with previous commit that removes the usage of deprecated
gtk-stock items and unregistering the Ctrl+v shorcut this solves the
issue. When the action is triggered and WebView doesn't have focus we have
to focus it to insert the clipboard content there.
|
| |
|
| |
|
|
|
|
|
| |
Also insert the BR elements instead of the non-breaking space as a content to
empty paragraphs to avoid unwanted character there.
|
|
|
|
| |
text after the last BR element
|
|
|
|
|
|
|
| |
There still left some references to GtkHTML in the "active code",
which should be dropped. There still can be found couple "GtkHTML"
strings in the code, but mostly in disabled code or comments only.
These are to be fixed separately.
|
| |
|
|
|
|
|
|
|
| |
previous sibling
This fixes the situation when the paragraphs with just i.e. anchor were
not properly quoted.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
anchors for links when processing data from convertor
When converting text we want to preserve spaces from original text. For this we
have to use the non-breaking spaces for it as two and more normal spaces is WebKit
replacing with just one. But we want the text from convertor to be wrapped
(non-breaking space is preventing from it) so we will replace 2+ spaces
with non-breaking spaces and leave the space of length one as it is.
Also when we are going through the text from the convertor we will
surround the links with anchor element to make them clickable.
|
|
|
|
| |
paragraph has no children
|
| |
|
|
|
|
|
|
|
|
| |
After this change when we start writing into quoted content it will
automatically rewrap the paragraph and reinserts the quote marks if the
block format is set to Normal. Also when the caret is in the beginning
of the quoted line and BackSpace is pressed the quoted content is
tooked out from the quote and inserted into body.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
email
Rework how the emoticons are inserted into composer. There were certain
situations where the previous version failed from various reasons like
wrongly saved caret position. Together with previous commits
(preventing the selection markers to be saved into body) this change
fixes the insertion of emoticons.
|
|
|
|
| |
Use them whenever it's possible and remove their duplicates from EHTMLEditorView.
|
| |
|
|
|
|
|
|
| |
This caused unpredictable behavior in functions, which relies on the
position of caret/selection. We won't save the selection markers and
handle the situation (no selection markers) in those functions.
|
|
|
|
| |
as changed
|
|
|
|
|
| |
When we will leave the CSS "display: inline-block" on inline images they will
break the caret move with Home/End keys.
|
|
|
|
| |
data instead of uri
|
|
|
|
| |
Change image's source value immediately after creating the Camel part for it.
|
|
|
|
|
|
| |
Actually, g_simple_async_result_take_error() means take, not copy,
thus the later g_clear_error() was incorrect, possibly freeing
already freed memory.
|
| |
|
|
|
|
| |
And use them in EHTMLEditorView if possible.
|
| |
|
| |
|
|
|
|
|
|
| |
composer's content
Apply width limits to paragraphs, remove images and replace smileys with its text version.
|
|
|
|
|
|
| |
Replace whitespace with non breaking space ( ) to avoid its lost.
Also when generating the plain text version of final message replace
non breaking space with normal space.
|
|
|
|
| |
Some links doesn't have the framegment so check for it before accessing it.
|
|
|
|
| |
ordered list
|
|
|
|
| |
Related to bug 731585
|
|
|
|
|
| |
Just two more places, which are new after a merge of the webkit-composer
branch changes.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Fix the wrong position of caret when in/undenting empty block and don't
lose spell checked words when in/undenting. Also don't insert unnecessary empty
lines into plain text version of message when processing indented block.
|
|
|
|
| |
Do that to avoid unnecessary empty paragraph element.
|
| |
|
|
|
|
|
| |
Don't try to wrap words that are longer than defined word wrap length,
otherwise we will end in busy loop.
|
|
|
|
| |
Merge wip/webkit-composer branch into master.
|
| |
|
|
|
|
|
|
|
| |
Similar to GObject::notify, the GSettings::changed can be emitted
even if a key didn't change. It's up to the user (aka evolution)
to test for real changes, thus let's do it. It may have certain
performance positive impact too.
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up for the previous commit, where e_signal_connect_notify*()
functions had been added. Due to a different callback and user data being
attached to the 'notify' signal, the g_signal_handlers_*() functions do not
work properly, thus these e_signal_connect_notify*() functions need
a different way for a signal handler disconnect.
A side-change was done in e-settings-web-view-gtkhtml.c, checking for a real
key change from GSettings.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is related to bug 698275, which did not cover all cases.
The problem here is that the dconf can in certain situation claim
that everything changed (path "/" changed), which GSettingsBinding
propagates to a GObject property unconditionally and GObject's
property setter (g_object_set_property()) also notifies about
the property change unconditionally, despite the real descendant
property setter properly checks for the value change. After all
these false notifications a callback on "notify" signal is called
and possibly an expensive operation is run.
Checking whether the value really changed helps in performance, for
which were added new e-util functions:
e_signal_connect_notify()
e_signal_connect_notify_after()
e_signal_connect_notify_swapped()
e_signal_connect_notify_object()
which have the same prototype as their GLib counterparts, but they allow
only "notify::..." signals and they test whether the value really changed
before they call the registered callback.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Also when hovering over the link with fragment that points to message
don't show the whole URI in status bar, but just the fragment.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
This change does a bit more, actually:
- learn the code of "tel" URI, being handler similar to "sip", "callto", "h323"
- generate tel: URIs for phone numbers, but only if the leading character of the
phone number is a plus ("+") sign
- always remove spaces in href part in the e_text_to_html() when
E_TEXT_TO_HTML_URL_IS_WHOLE_TEXT flag is set
|
|
|
|
|
| |
Rework replace_local_image_links to use CSS selectors to avoid iterating
through the DOM tree.
|
| |
|
|
|
|
|
| |
The commit fixed few memory leaks, but also caused several crashes
due to those changes, thus this fixes the introduces issues.
|
| |
|
|
|
|
|
|
|
| |
Since GLib begun to claim about incorrect ids being passed to
g_source_remove(), a problem with EActivityBar had been discovered,
it doesn't unset its priv->timeout_id when the timeout is reached,
which leads to the new runtime warnings from GLib.
|
|
|
|
|
|
|
| |
It used to copy the link into both buffers, same as the 'Copy Email Address"
does, but it seems, after a move to WebKit based message preview, this
changed and the link had been copied only to the selection clipboard.
Make the function consistent and copy the link into to both clipboards.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ports the following two function calls throughout Evolution:
• e_categories_get_list() to e_categories_dup_list()
• e_categories_get_icon_file_for() to e_categories_dup_icon_file_for()
It necessarily changes some internal e-util API:
• e_util_get_searchable_categories() to
e_util_dup_searchable_categories()
This bumps the EDS requirement to 3.13.1.
https://bugzilla.gnome.org/show_bug.cgi?id=727221
|
| |
|
|
|
|
|
|
|
| |
a) ETableColumnSpecification: the 'title' property is always overwritten
during the spec file loading, thus no need to allocate it here
b) the 'uids' are leaked on message move, because the GPtrArray is
supposed to be always unreffed
|
| |
|
|
|
|
|
| |
When enabled, this will compile all libraries/binaries with the necessary
gcc and ld flags to enable code coverage support using gcov.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The custom styles, those which are added on-the-fly directly to DOM, were
added only after whole document was completely loaded, which included also
sub-frames content, thus when these were slow to download for any reason,
the main frame content, like the top header bar, was shown with a default
style, which is white background and black text color. The WebKitWebView's
document-load-finished signal is emitted whenever the actual HTML content
is loaded, and the DOM is available as well, for each frame, including
the main frame of the WebView, thus updating/setting custom CSS styles
in this signal handler makes the loaded frames look as expected, without
waiting for other frames in the document to finish their load.
|
|
|
|
|
| |
As of gtk+ 3.2, AtkObjectFactories are no longer used to generate
accessibles for gtk widgets, so our custom atk classes need refactoring.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
It doesn't make much sense to zoom below 0.1, same as zoom 5.0 is
quite large, thus no need to zoom indefinitely in both directions.
|
|
|
|
|
|
| |
Win32 headers have a #define for 'interface', which breaks the build
when this word is used in the code, thus replace it to 'iface',
the same way as GLib or GTK+ code use to have it. (See bug #722068.)
|
|
|
|
|
|
|
|
|
| |
This extends behaviour of left-clicking column header which is not
used for sorting yet in an ETree/ETable in a way:
a) alone left-click behaves like before, all current sorting is dropped
and the ETree/ETable is sorted only by that column
b) left-click with pressed Ctrl key adds the column as the first to sort by
c) left-click with pressed Ctrl+Shift adds the column as the last to sort by
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The "dialog-apply" icon is not from a set of standard icons, thus
it cannot be used, which I overlooked yesterday. With its drop are
also dropped other button icons in itip-formatter.
The missing icon made EStockRequest "panic" which effectively broke
page rendering for WebKit - the rendering was never finished.
|
| |
|
|
|
|
|
| |
Calling g_source_remove() on a saved source ID but not resetting the
source ID to zero.
|
|
|
|
|
|
| |
Both 'groupings' and 'sortings' arrays unref the 'column_spec' on removal,
but the 'duplicate' function didn't ref them, which caused use-after-free
at the end of the application.
|
| |
|
| |
|
| |
|
|
|
|
| |
address book"
|
| |
|
|
|
|
|
|
|
| |
A simple performance improvement to ignore ESourceRegistry notifications
on source changes for sources which do not belong to the ESourceSelector.
Such notifications could cause whole model rebuild, which has other side
effects, like a bug #722399.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Easier to copy&paste than write the generate UID letter by letter.
|
| |
|
|
|
|
|
|
|
|
| |
Some locales do not provide equivalents for am/pm (the "%p" of strftime),
thus when the user has set 12 hour format in Preferences, then the am
and pm times are the same, which confuses the widget, especially
in the appointment editor, making it hard (like impossible) to enter
pm times by selection in the time combo. An example locale is de_DE.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This is based on the work of Jan-Michael Brummer from bug #705338,
just a little extended to be reusable across whole evolution.
|
|
|
|
|
|
|
|
|
|
|
| |
Added features:
- show all four selectors (for Calendars/Memos/Tasks/Books)
- be able to open/close selected source
Especially the later can be used for testing the factories easily,
without running evolution or other client. There can be added more
actions on an opened EClient descendant in the future, if it'll be
found useful.
|
|
|
|
|
| |
glib has removed g_memmove, since it was a macro there is no ABI break but sources have to be adapted to switch to memmove
See glib commit 6e4a7fca431f53fdfd89afbe956212229cf52200 for further reference.
|
|
|
|
| |
SoupRequester functionality is built directly into SoupSession now.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.
|
|
|
|
| |
Missed this one in commit 9058c6f85dc49f9500e7e67819acfd8c0d2d369c.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_dom_element_get_id() was introduced for WebKitGTK+ 2.2 and
deprecates webkit_dom_html_element_get_id(). But Evolution only
requires WebKitGTK+ 2.0.1.
Ordinarily this would sit on a shelf until we require WebKitGTK+ 2.2,
however WebKitGTK+ has now started issuing deprecation warnings about
webkit_dom_html_element_get_id() at *runtime*, which is pointless and
only fills up users' .xsession-errors file.
To put a stop to this, we'll call the new function subject to a pre-
processor WebKit version check, with a fallback to the old function.
The build requirement remains at WebKitGTK+ 2.0.1.
|
| |
|
| |
|
| |
|
|
|
|
| |
Just a nice touch, I think.
|
| |
|
|
|
|
|
|
|
| |
Shown for the "Defer to Desktop Settings" choice if gnome-control-center
is available. The button opens gnome-control-center's "Network" panel,
but unfortunately the "Network proxy" item cannot be selected from the
command line.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
EProxyComboBox is a combo box of available proxy profiles, as described
by ESource instances with an ESourceProxy extension.
|
|
|
|
| |
Sets a flag that's no longer used internally by ESourceSelector.
|
|
|
|
| |
We were leaking the ESource reference.
|
|
|
|
|
|
|
|
| |
ESourceSelector can now optionally display an icon next to each ESource
matching the selector's "extension-name". Intended for non-homogeneous
use cases where a variety of account types are shown in the selector.
The icon set is hard-coded, but we could change that if the need arises.
|
| |
|
|
|
|
|
|
|
| |
When (re)building the tree model, ESourceSelector may fall back to
e_source_registry_ref_default_for_extension_name() to help initialize
the primary selection. Depending on the selector's "extension-name"
property, that function may return NULL. Handle it gracefully.
|
| |
|
| |
|
|
|
|
|
|
| |
The change also allows setting accounts for certain recipients (based
on a part of the recipient address). The option can be found in Folder
Properties and in Edit->Preferences->Composer Preferences->Send Account.
|
|
|
|
| |
This reverts part of commit 452638466217dbfef0c0954c90aa7cb03cf91452
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Have GNetworkMonitor make an initial guess at the online state of
backends by evaluating the reachability of their host name. This
will show an initial status icon for all displayed ESources without
actually opening a connection, since some backends are expensive to
start unnecssarily.
|
|
|
|
|
|
|
| |
Avoid redrawing (thus loosing the selection and scroll position) of
preview window on style change by defining the colors through CSS styles.
On style change we just update the CSS color definitions and preview will
update itself without redraw.
|
|
|
|
|
| |
Let the open for a user, when respective source in the selector
is selected.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Closes the active EAlert and returns TRUE, or else returns FALSE if
there is no active EAlert.
|
| |
|
| |
|
| |
|
|
|
|
| |
Configures the EActivity to submit alerts to the EPreviewPane.
|
| |
|
|
|
|
|
|
| |
There's now enough hooks in EWebView that it can take over image saving
from EMailDisplay / EMailReader, with the added perk that a "Save Image"
pop-up menu item now appears for images in ALL preview panes.
|
|
|
|
|
| |
Prompts the user to choose a destination file and then asynchronously
saves the image under the cursor to the destination file.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Asynchronously copies the image under the cursor to the clipboard.
This replaces the "cursor-image" property, which attempts to match the
image URI to a subresource from WebKitWebDataSource. The problem with
that approach is EMailDisplay redirects several URI schemes to its own
custom request handlers which further mutate the URI. So for example,
a text/html message may use a "cid:" URI to refer to an embedded image,
which EMailDisplay transforms to a "mail:" URI and finally to a "data:"
URI. The final image URI might not be derivable from the original URI
without retracing the SoupRequest.
The "image-copy" action now calls e_web_view_cursor_image_copy().
This also adds an explicit requirement on gdk-pixbuf-2.0 >= 2.24 for
gdk_pixbuf_new_from_stream_async() / finish().
New functions:
e_web_view_cursor_image_copy()
Removed functions:
e_web_view_get_cursor_image()
e_web_view_set_cursor_image()
|
|
|
|
|
|
|
|
|
| |
Returns a new EActivity for an EWebView-related asynchronous operation,
and emits a "new-activity" signal. By default the EActivity comes loaded
with a GCancellable and sets the EWebView itself as the alert sink (which
means alerts are displayed directly in the content area). The signal
emission allows the EActivity to be further customized and/or tracked by
the application.
|
|
|
|
|
|
|
|
|
|
|
| |
Asynchronously requests data at a URI by way of a SoupRequest to WebKit's
default SoupSession, incorporating both e_web_view_redirect_uri() and the
custom request handlers installed via e_web_view_install_request_handler().
New functions:
e_web_view_request()
e_web_view_request_finish()
|
|
|
|
|
|
|
|
|
|
|
| |
Attempts to derive a suggested filename from the given URI for use in a
"Save As" dialog.
By default the suggested filename is the last path segment of the given
URI (the unless the given URI looks like a query), but subclasses can use
other mechanisms for custom URI schemes. For example, "cid:" URIs in an
email message may refer to a MIME part with a suggested filename in its
Content-Disposition header.
|
|
|
|
|
|
|
|
|
|
| |
Replaces the given URI with a redirected URI as necessary, primarily for
use with custom SoupRequest handlers. Typically this function would be
called just prior to handing a request off to a SoupSession, such as
from a WebKitWebView "resource-request-starting" signal handler.
Case in point: EMailDisplay now implements the redirect_uri() method,
and calls it from its own "resource-request-starting" signal handler.
|
|
|
|
|
|
|
| |
Trivial wrapper for webkit_web_view_get_uri().
Probably made sense while we were transitioning from GtkHTML to WebKit,
but we don't need it anymore.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't expose public API for this.
Even though it's still possible through the WebKitWebView API, we don't
want to encourage setting an arbitrary WebKitWebSettings on an EWebView.
Removed functions:
e_web_view_set_settings()
e_web_view_get_default_settings()
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Connect to the GtkComboBox::changed signal after all candidates are
added, to avoid calling e_source_config_check_complete() before the
candidate has been told to insert widgets. This can cause run-time
warnings such as:
(evolution:7106): evolution-cal-config-webcal-CRITICAL **:
cal_config_webcal_check_complete: assertion `context != NULL' failed
|
| |
|
| |
|
|
|
|
| |
Same issue as in bug 703991, just in a different place.
|
|
|
|
|
|
| |
I've got UI freeze in a call of e_book_client_view_stop() on contact
store dispose, caused by synchronous D-Bus call. Doing the call
in a dedicated thread makes no UI freeze here.
|
|
|
|
| |
No longer used.
|
|
|
|
|
|
| |
Unfinished undo framework from ages past.
Nice idea I guess, but not worth the complexity.
|
|
|
|
|
|
|
|
| |
nautilus-sendto has been stripped of its usefulness in GNOME 3.8.
It no longer has a UI of its own, it just immediately spawns a mail
client with a set of files as attachment arguments for a new message.
There's no reason for Evolution to be invoking it anymore.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Evolution is still occasionally getting stuck on shutdown, and although
the evolution-shell log domain shows debug messages for activities that
are preventing shutdown, they frequently look like this:
(evolution:13534): evolution-shell-DEBUG: 5 active 'mail' activities:
(evolution:13534): evolution-shell-DEBUG: * (no description)
(evolution:13534): evolution-shell-DEBUG: * (no description)
(evolution:13534): evolution-shell-DEBUG: * (no description)
(evolution:13534): evolution-shell-DEBUG: * (no description)
(evolution:13534): evolution-shell-DEBUG: * (no description)
I think the lack of descriptions is from CamelOperations popping all
their pushed messages, which is correct behavior but doesn't help us
debug the problem.
e_activity_get_last_known_text() returns the most recent _non-empty_
text value set on the EActivity. So our debug message can fall back
to that if the EActivity has no description at shutdown:
(evolution:13534): evolution-shell-DEBUG: * (was "blah, blah, blah")
|
|
|
|
| |
No longer used.
|
|
|
|
| |
No longer used.
|
|
|
|
|
|
|
|
|
|
|
| |
gal_view_collection_new() now takes system and user directory arguments
and loads GalViews during instance initialization.
Removed functions:
gal_view_collection_set_storage_directories()
gal_view_collection_load()
gal_view_collection_loaded()
|
|
|
|
|
|
| |
No longer needed. Instead, use g_type_ensure() to ensure the necessary
GalView subclasses are registered in the GType system before loading a
GalViewCollection. Best place to ensure types is from GClassInitFunc.
|
|
|
|
|
|
|
|
|
| |
Given a type code string from an XML file, find the appropriate GType by
traversing the GType hierarchy from GAL_TYPE_VIEW and checking the class
structures for a matching type code string.
This completely eliminates the need for what's left of GalViewFactory.
Now it's just a matter of cleaning up the remains.
|
| |
|
| |
|
|
|
|
|
|
| |
GalViewInstance and EMailPanedView need access. Currently they're just
using the public GalViewCollection members directly, but those are about
to be sealed up.
|
|
|
|
|
|
|
|
|
|
| |
Just readable for now, but I plan to make it also construct-only.
(Despite the precendence, I prefer "user" over "local" for the name.)
New functions:
gal_view_collection_get_user_directory()
|
|
|
|
|
|
|
|
| |
Just readable for now, but I plan to make it also construct-only.
New functions:
gal_view_collection_get_system_directory()
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
It's set by EShellView but not actually used for anything.
Removed functions:
gal_view_collection_set_title()
|
|
|
|
|
|
| |
Removed functions:
gal_view_collection_display_view()
|
|
|
|
|
| |
GalViewFactory can now use its "gal_view_type" class member to
instantiate an appropriate GalView without help from subclasses.
|
|
|
|
|
| |
GalViewFactory can now use its "gal_view_type" class member to peek at
the appropriate GalViewClass and return its static "type_code" string.
|
|
|
|
|
|
|
| |
This is the GType of the GalView instances the factory creates.
Having this information will allow GalViewFactoryClass to do more itself
and be less reliant on subclasses.
|
|
|
|
|
|
| |
All GalView subclasses return a static string in their get_type_code()
methods, so replace the method with a static string pointer directly in
the class structure, and remove the "type-code" GalView property.
|
|
|
|
|
|
|
|
| |
No longer needed.
Removed functions:
gal_view_factory_etable_get_specification()
|
|
|
|
| |
Obtain the ETableState from the attached ETable or ETree as needed.
|
|
|
|
| |
No longer used.
|
|
|
|
|
|
|
| |
Instead, lazily load the state file once an ETable or ETree is attached,
since we need its ETableSpecification to create an ETableState instance.
This means GalViewFactoryEtable can lose its ETableSpecification too.
|
| |
|
|
|
|
|
| |
This replaces the get_title() and set_title() class methods, since
it's silly to defer to subclasses to track a simple string property.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
No longer used.
Removed functions:
gal_view_factory_get_title()
|
|
|
|
|
|
|
|
| |
No longer used.
Removed functions:
gal_view_edit()
|
|
|
|
| |
No longer user.
|
|
|
|
| |
No longer used.
|
|
|
|
| |
No longer used.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e_table_specification_new() now takes a table specification filename and
a GError and parses the file as part of instance creation. If a file or
parse error occurs, e_table_specification_new() returns NULL.
This replaces e_table_specification_load_from_file().
New functions:
e_table_specification_get_filename()
Removed functions:
e_table_specification_load_from_file()
|
|
|
|
| |
No longer used.
|
|
|
|
| |
No longer used.
|
|
|
|
| |
No longer used.
|
|
|
|
| |
No longer used.
|
|
|
|
|
|
| |
Use e_table_state_duplicate() and e_table_set_state_object().
Similarly for e_tree_set_state().
|
|
|
|
|
|
|
| |
No longer used outside of e-table-specification.c.
Its logic is merged into e_table_specification_load_from_file(), but
that too will be removed momentarily.
|
|
|
|
|
|
| |
Also remove e_tree_construct_from_spec_file().
Use e_tree_new() or e_tree_construct() instead.
|