| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
This change also includes preparation for
bug 319195 - Contact dialog appallingly overcrowded
|
| |
|
|
|
|
| |
Also build dependencies at the same directory as evolution files
and build 'master' configuration by default (it used to build 'stable'
configuration instead).
|
| |
|
|
|
|
|
|
| |
* use e_util_win32_initialize() in main() to avoid code duplication
* e-spinner - correct image path build under win32
* export WIN32_SERVICELIBEXECDIR when building eds, which relies on it now
* update D-Bus patch and session-local.conf creation, thus D-Bus
can actually autostart services
|
| |
|
|
|
|
|
|
|
|
| |
The EContactEditor added a signal handler to "editor_closed" to
close also a full name editor, but it did not remove the signal
handler on full name editor's destroy, thus the callback was called
on an already freed widget, which could cause a crash.
This had been reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1128745
|
| |
|
|
|
| |
Free some of the DOM variables when they are not needed, before they are
automatically freed when the frame is destroyed
|
| |
|
|
| |
Plus a little code cleanup for easier grepping.
|
| |
|
|
|
| |
Set the maximal width and height of the contact image to 96 px. Also do
the same in the contact preview in addressbook.
|
| |
|
|
|
| |
We have to unescape the image uri when running with webkitgtk3 2.4.x
and not just in versions prior to 2.2.x
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes evolution depend on theme-defined named colors, namely:
theme_bg_color
theme_base_color
theme_fg_color
theme_text_color
theme_selected_bg_color
theme_selected_fg_color
theme_unfocused_selected_bg_color
theme_unfocused_selected_fg_color
If it's not defined, then a fallback color is used, in the worse case
one of the fallbacks defined in evolution itself.
|
| | |
|
| |
|
|
|
| |
Let's use our own spinner-like widget, which doesn't need as that
much of CPU as GtkSpinner.
|
| | |
|
| |
|
|
| |
Merge wip/webkit-composer branch into master.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is related to bug 698275, which did not cover all cases.
The problem here is that the dconf can in certain situation claim
that everything changed (path "/" changed), which GSettingsBinding
propagates to a GObject property unconditionally and GObject's
property setter (g_object_set_property()) also notifies about
the property change unconditionally, despite the real descendant
property setter properly checks for the value change. After all
these false notifications a callback on "notify" signal is called
and possibly an expensive operation is run.
Checking whether the value really changed helps in performance, for
which were added new e-util functions:
e_signal_connect_notify()
e_signal_connect_notify_after()
e_signal_connect_notify_swapped()
e_signal_connect_notify_object()
which have the same prototype as their GLib counterparts, but they allow
only "notify::..." signals and they test whether the value really changed
before they call the registered callback.
|
| |
|
|
| |
select GivenName, FN
|
| | |
|
| |
|
|
| |
Make sure evolution's widget types are available before loading the .ui file.
|
| |
|
|
|
|
|
| |
Recent changes in commit c2de4087369147e introduced a regression
in preselected widget after editor open, it was 'e-mail', instead
of 'fullname' after that commit. The focus changes when the dyntable
was updating maximum allowed entries in itself.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
This change does a bit more, actually:
- learn the code of "tel" URI, being handler similar to "sip", "callto", "h323"
- generate tel: URIs for phone numbers, but only if the leading character of the
phone number is a plus ("+") sign
- always remove spaces in href part in the e_text_to_html() when
E_TEXT_TO_HTML_URL_IS_WHOLE_TEXT flag is set
|
| |
|
|
|
|
|
| |
Due to made widget changes in fill_in_all() the focus can change
from the full name entry elsewhere. Remembering focused widget and
restoring it at the end of the function makes the editor being
opened with full name entry instead, as expected.
|
| |
|
|
|
| |
The IM service names are correctly marked for translation, but
they are not localized (passed to gettext) at the place of its usage.
|
| | |
|
| |
|
|
|
| |
The commit fixed few memory leaks, but also caused several crashes
due to those changes, thus this fixes the introduces issues.
|
| | |
|
| | |
|
| |
|
|
|
| |
When enabled, this will compile all libraries/binaries with the necessary
gcc and ld flags to enable code coverage support using gcov.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Locally stored photos were shown as a "missing image" instead of the actual
photo for cases when the URL contained special characters which required to be
encoded in the URL. This effectively updates commit 255e0529040baae67e3d70f1030ce248fd61856d,
to check WebKit version for the unescape, because WebKit 2.2.5 (which I currently use)
doesn't re-escape the URIs. Maybe earlier versions of the WebKit do the same.
|
| | |
|
| |
|
|
|
|
| |
Win32 headers have a #define for 'interface', which breaks the build
when this word is used in the code, thus replace it to 'iface',
the same way as GLib or GTK+ code use to have it. (See bug #722068.)
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This is based on the work of Jan-Michael Brummer from bug #705338,
just a little extended to be reusable across whole evolution.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_dom_element_get_id() was introduced for WebKitGTK+ 2.2 and
deprecates webkit_dom_html_element_get_id(). But Evolution only
requires WebKitGTK+ 2.0.1.
Ordinarily this would sit on a shelf until we require WebKitGTK+ 2.2,
however WebKitGTK+ has now started issuing deprecation warnings about
webkit_dom_html_element_get_id() at *runtime*, which is pointless and
only fills up users' .xsession-errors file.
To put a stop to this, we'll call the new function subject to a pre-
processor WebKit version check, with a fallback to the old function.
The build requirement remains at WebKitGTK+ 2.0.1.
|
| |
|
|
|
|
| |
ChamplainLabel does everything we need now. Need to stash a contact UID
for opening the Contact Editor on double-click, but not worth a subclass
for just that.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
g_type_init() is deprecated in GLib 2.36.
|
| |
|
|
|
| |
These two cross-referenced each other, which could cause runtime issues,
thus rather merge them into one.
|
| |
|
|
|
|
|
| |
Avoid redrawing (thus loosing the selection and scroll position) of
preview window on style change by defining the colors through CSS styles.
On style change we just update the CSS color definitions and preview will
update itself without redraw.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
An address book editor error was shown about active EShell's window,
which means switching to other application and back made the editor
in the background, but, more importantly, the editor could be
selected and the error was in the background, thus it seemed like
being stuck, it didn't respond to any button click, until the error
was dismissed.
|
| | |
|
| | |
|
| |
|
|
|
| |
The list of minicards in reflow is populated on demand, and this was
a place where the demand was not satisfied, if it was missing.
|
| | |
|
| |
|
|
| |
No longer used.
|
| |
|
|
|
| |
GalViewFactory can now use its "gal_view_type" class member to
instantiate an appropriate GalView without help from subclasses.
|
| |
|
|
|
| |
GalViewFactory can now use its "gal_view_type" class member to peek at
the appropriate GalViewClass and return its static "type_code" string.
|
| |
|
|
|
|
|
| |
This is the GType of the GalView instances the factory creates.
Having this information will allow GalViewFactoryClass to do more itself
and be less reliant on subclasses.
|
| |
|
|
|
|
| |
All GalView subclasses return a static string in their get_type_code()
methods, so replace the method with a static string pointer directly in
the class structure, and remove the "type-code" GalView property.
|
| |
|
|
|
| |
This replaces the get_title() and set_title() class methods, since
it's silly to defer to subclasses to track a simple string property.
|
| | |
|
| |
|
|
|
|
|
|
| |
No longer used.
Removed functions:
gal_view_factory_get_title()
|
| |
|
|
|
|
|
|
| |
No longer used.
Removed functions:
gal_view_edit()
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
EShellView now holds a reference to the active GalViewInstance. Where
applicable, the EShellView subclass is responsible for keeping this up
to date when the sidebar selection changes.
Holding a reference allows EShellView to implement common actions like
"Save Current View" directly instead pushing it on to subclasses.
New functions:
e_shell_view_get_view_instance
e_shell_view_set_view_instance
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e_table_specification_new() now takes a table specification filename and
a GError and parses the file as part of instance creation. If a file or
parse error occurs, e_table_specification_new() returns NULL.
This replaces e_table_specification_load_from_file().
New functions:
e_table_specification_get_filename()
Removed functions:
e_table_specification_load_from_file()
|
| |
|
|
|
|
| |
Also remove e_table_construct_from_spec_file().
Use e_table_new() or e_table_construct() instead.
|
| | |
|
| |
|
|
|
|
|
|
| |
Replace the big, bulky "open URL" button with a clickable icon directly
in the text entry field. This saves precious vertical space, especially
in the contact editor.
Also remove e_url_entry_get_entry() since EUrlEntry now IS a GtkEntry.
|
| | |
|
| |
|
|
| |
Similar to what was recently done to ETreeModel.
|
| | |
|
| |
|
|
|
|
| |
To make Evolution's shared libraries more consistent.
Also rename the documentation module to evolution-shell.
|
| |
|
|
|
|
| |
To make Evolution's shared libraries more consistent.
Also rename the documentation module to evolution-util.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify the EABContactFormatter API as follows:
* Drop all constructor arguments from eab_contact_formatter_new()
since get/set functions exist for all of them.
* Remove eab_contact_formatter_format_contact_async() since
EABContactFormatter does not block.
* Replace eab_contact_formatter_format_contact_sync() with
eab_contact_formatter_format_contact() which drops the CamelStream
and GCancellable arguments and takes a GString as an output buffer.
* Remove the "state" and "style" properties, and always use a white
background when rendering the full contact.
This is particularly important since render_normal() dereferenced
the GtkStyle without checking for NULL, which would crash on mails
with a vCard MIME part when "Show Full vCard" was clicked, because
the "vcard-inline" module never set a GtkStyle.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Not needed anymore since it finally dawned on me to use weak references
in main loop event closures. The EBookClient now dies when it should.
|
| |
|
|
| |
Basically any place where we use both EClient and ESourceComboBox.
|
| |
|
|
|
|
| |
Flush any undispated event sources from the default main loop context.
Since this program does not use a main loop, these event sources would
otherwise leak.
|
| |
|
|
| |
The previous return value was not being checked anyway.
|
| | |
|
| |
|
|
| |
Defining this as a union makes the code needlessly verbose.
|
| |
|
|
| |
Pointless option, does the same as "evolution-addressbook-export &".
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Change notifications for EClient's "readonly" property can come on any
thread. Our "notify::readonly" signal handler immediately updates the
model's editable status, which triggers GTK+ calls, which can crash the
application if we're not in the correct thread.
Connect instead to EClientCache's "client-notify" signal, which is
always emitted from EClientCache's dedicated main loop context, and
happens to be the same main loop context that GTK+ uses. It's also
less bookkeeping when the model's EBookClient gets replaced.
|
| |
|
|
|
|
|
|
|
| |
Registry can still be accessed through e_client_cache_ref_registry(),
but we'll want to utilize the client cache as well.
e_addressbook_model_new() now takes an EClientCache instead of an
ESourceRegistry, and e_addressbook_model_get_registry() is replaced
by e_addressbook_model_get_client_cache().
|
| | |
|
| | |
|
| |
|
|
|
|
| |
"Mailing Address" tab of contact editor
https://bugzilla.gnome.org/show_bug.cgi?id=692020
|
| |
|
|
| |
Use e_client_selector_get_client() to obtain an EClient.
|
| | |
|
| |
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=692720
|
| | |
|
| |
|
|
| |
Instead of e_client_utils_open_new() and e_book_client_new().
|
| | |
|
| |
|
|
|
| |
Clean up resulting deprecation warnings, which were all related to
GtkOrientable consolidation (e.g. gtk_hbox_new() -> gtk_box_new()).
|
| |
|
|
| |
I forgot to include this in 3.7.4, but no matter.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
e_config_add_skip_check()
e_config_class_remove_factory()
e_config_create_window()
e_config_page_get()
e_config_page_next()
e_config_page_prev()
e_config_set_page_is_finish()
Also remove E_CONFIG_ASSISTANT and all the assistant support therein.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Move the supporting widgets for the contact maps feature alongside
EABContactDisplay. Removing them from libeutil helps isolate our usage
of libchamplain so it's not imposed on the entire application, and even
3rd party software. That libchamplain is an optional dependency only
further complicates the matter.
Ideally I'd like to somehow isolate this feature in an extension module,
but we currently lack sufficient hooks for such an extension. So this
arrangement will have to suffice for now.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Evolution consists of entirely too many small utility libraries, which
increases linking and loading time, places a burden on higher layers of
the application (e.g. modules) which has to remember to link to all the
small in-tree utility libraries, and makes it difficult to generate API
documentation for these utility libraries in one Gtk-Doc module.
Merge the following utility libraries under the umbrella of libeutil,
and enforce a single-include policy on libeutil so we can reorganize
the files as desired without disrupting its pseudo-public API.
libemail-utils/libemail-utils.la
libevolution-utils/libevolution-utils.la
filter/libfilter.la
widgets/e-timezone-dialog/libetimezonedialog.la
widgets/menus/libmenus.la
widgets/misc/libemiscwidgets.la
widgets/table/libetable.la
widgets/text/libetext.la
This also merges libedataserverui from the Evolution-Data-Server module,
since Evolution is its only consumer nowadays, and I'd like to make some
improvements to those APIs without concern for backward-compatibility.
And finally, start a Gtk-Doc module for libeutil. It's going to be a
project just getting all the symbols _listed_ much less _documented_.
But the skeletal structure is in place and I'm off to a good start.
|
| | |
|
| |
|
|
|
| |
GnomeCanvas will stash the GdkDevice and reuse it in the subsequent
gnome_canvas_item_ungrab() call.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Prefer dealing with GdkEvent pointers and using accessor functions like
gdk_event_get_button().
This is complicated by the fact that some GtkWidget method declarations
still use GdkEventButton pointers, and synthesizing button events pretty
much requires direct GdkEventButton access. But GDK seems to be nudging
itself toward sealing the GdkEvent union. Likely to happen in GDK4.
Mainly clean up signal handlers and leave method overrides alone for now.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The "modal" attribute is ignored nowadays anyway, but these should have
never been modal to begin with.
|
| | |
|
| |
|
|
|
| |
Don't need an "OK" button because EAlert already adds an [X] button to
dismiss the alert. So we wind up seeing [ OK ] [X], which looks silly.
|
| |
|
|
|
|
|
|
| |
Some contacts have photos stored locally as files. Until now
EContactEditor displayed thumbnail of contact photo in EImageChooser
only if the photo was embedded in the vCard as data. This patch
adds support for dispalying thumbnails of photos stored in local files
to indicate that the contact has a picture set.
|
| | |
|
| |
|
|
|
|
| |
EContactPhoto URIs are already escaped, but WebKit escapes it again, so images
are not displayed sometimes. Unescaping the URI before writing it to the HTML
fixes to problem.
|
| | |
|
| |
|
|
| |
G_DEFINE_TYPE macros define a static "parent_class" variable.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
EBookSourceConfig drags in no additional dependencies, and allows us to
delay publishing a libevolution-addressbook.so since 3rd party packages
will need to subclass EBookSourceConfig.
The address book source code will need to be flattened into a single
library before we could publish a libevolution-addressbook.so anyway.
That would be a good thing to do regardless -- Evolution has way too
many internal libraries -- but it's out of scope at the moment.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Base class for building address book and calendar configuration dialogs.
|
| |
|
|
| |
One last time.
|
| |
|
|
| |
As it turns out, it's not actually required.
|
| | |
|
| | |
|
| |
|
|
| |
Always call it immediately after g_simple_async_result_new().
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This splits the giant EMailRequest to individual EFileRequest, EStockRequest, EHTTPRequest and EMailRequest,
making the first two available globally from e-utils, the othe two are loaded only with mailer,
since no other component uses them.
|
| | |
|
| | |
|
| |
|
|
|
| |
Replace 8-space indentation with tab characters, and various other
automated cleanups.
|
| |
|
|
| |
with GtkHtml
|
| | |
|
| | |
|
| |
|
|
| |
libevolution-utils.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
References evolution-addressbook-import, which was removed in 2007.
Clearly no point in keeping this script around.
|
| |
|
|
|
| |
gtk_dialog_new_with_buttons() requires some buttons, otherwise use
gtk_dialog_new() and set title/transient-for/etc properties manually.
|
| |
|
|
| |
Requires commit 768ca76 in evolution-data-server
|
| |
|
|
| |
Check for birthdays which can't be set to future dates.
|
| | |
|
| | |
|
| | |
|
| |\ |
|
| | |
| |
| |
| | |
Committing Milan Crha's patch here at his request (bug 652178).
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Evo trets first line of a multi-line address field as a street name
and the rest as "extended address", regardless of its content.
The address-formatting code was ignoring the extended address, thus
when the first line was for example a company name, the actual street
was ignored.
|
| | | |
|
| | | |
|
| | | |
|
| |\| |
|
| | | |
|
| |\| |
|
| | |
| |
| |
| |
| | |
Make behavior introduced in bug #636809 optional by adding checkbox
to Preferences->Contacts.
|
| | |
| |
| |
| |
| |
| | |
GtkFileChooser in GTK+ 3.2 now keeps track of the last-used-folder
itself, even across applications, so get out of its way and let it
handle it.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I pushed a few EShell features up to GtkApplication for GTK+ 3.2,
so we can now trim off the redundancies in EShell.
1) GtkApplication has a new "window-added" signal which replaces
EShell's own "window-created" signal.
2) GtkApplication has a new "window-removed" signal which replaces
EShell's own "window-destroyed" signal.
3) gtk_application_get_windows() now returns a list of windows sorted
by most recently focused, replacing e_shell_get_watched_windows().
4) GtkApplication now provides enough hooks to subclasses that we can
remove e_shell_watch_window() and call gtk_application_add_window()
directly.
|
| | | |
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
We have a confusing array of nearly-identical CFLAGS/LIBS definitions in
configure.ac. Time to simplify. Instead let's just have one definition
that includes all the libraries provided by Evolution-Data-Server (incl.
Camel). That, in combination with GNOME_PLATFORM, gives us most of what
we need for compliation and linking, and we can sprinkle definitions for
additional library dependencies in Makefile.am's as needed.
|
| | |
| |
| |
| | |
G_OPTION_FLAG_FILENAME is only for G_OPTION_ARG_CALLBACK options.
|
| | |
| |
| |
| |
| | |
Only setlocale(2) LC_ADDRESS is this macro actually exist.
https://bugzilla.gnome.org/show_bug.cgi?id=660624
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
From ccc980da1fd84ebfca25cf8caf9a5d62333099fc Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Wed, 28 Sep 2011 10:18:18 +0200
Subject: [PATCH] Remove Ctrl + l ( ) character from source files
The following commits
git show aac3f2c8
git show 1510304c
git show 13cabd9e
git show 350a7a33
git show 9b7cc54d
git show e6972011
git show 1d3a7938
git show 934524b9
git show b2954936
git show a7f677b5
git show 4369c400
git show d509f47a
git show a6d5818f
git show c3876df7
git show 4583098b
git show 2831ada5
git show 4e1bce59
git show 1609f699
git show 4e4c1676
git show d6fade43
among others(?) introduced several occurrences of Ctrl + l ( ). Probably this was caused by the used editor.
These control characters can be searched for using the following command [1].
$ git grep ^L
[1] http://unstableme.blogspot.com/2009/10/grep-and-print-control-characters-in.html
|
| | | |
|
| | |
| |
| |
| |
| | |
Reducing diff noise so I can see important changes easier when comparing
branches. A few API changes, but nothing that affects functionality.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
due to forgotten call to load books to ENameSelector
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
- fixed order of buttons in duplicate adding confirmation dialog
- in the editor, don't display email addresses in sublist nodes
- automatically remove sublists with no children
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Also fixes few memory leaks around ENameSelector and cancels
loading of its address books when not needed any more.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
GLib is finally dropping this hack.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Address labels should be formated according to country specific standards.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
As of GLib 2.28 all GObject virtual methods, including constructed(),
are safe to chain up to unconditionally. Remove unnecessary checks.
|
| | |
| |
| |
| | |
GCC learned how to find dead assignments.
|
| | | |
|
