aboutsummaryrefslogtreecommitdiffstats
path: root/addressbook
Commit message (Collapse)AuthorAgeFilesLines
* only handle the ESB_ADVANCED case here now. the actual query work is doneChris Toshok2002-02-252-2/+29
| | | | | | | | | | | | | | 2002-02-24 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c (addressbook_query_changed): only handle the ESB_ADVANCED case here now. the actual query work is done in addressbook_search_activated. (addressbook_search_activated): split out all the searching functionality here. (addressbook_factory_new_control): hook up "search_activated" to addressbook_search_activated. svn path=/trunk/; revision=15828
* make the right auth page start up open.Chris Toshok2002-02-253-1/+15
| | | | | | | | | | | | | | 2002-02-24 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.c (addressbook_source_dialog_set_source): make the right auth page start up open. * gui/component/addressbook-storage.c (addressbook_source_free): free the binddn. (addressbook_source_copy): copy the binddn; svn path=/trunk/; revision=15819
* [ Fixes bugs 20740, 16680, and god knows what else :) ] double theChris Toshok2002-02-234-49/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-02-22 Chris Toshok <toshok@ximian.com> [ Fixes bugs 20740, 16680, and god knows what else :) ] * gui/widgets/e-addressbook-model.c (create_card): double the allocated size every time we need more space instead of using a fixed size increment. this helps huge queries. Also, remove the gtk_object_get of "file_as", as it was dead code. (book_view_loaded): handle errors here (by popping up a dialog). * backend/pas/pas-backend-ldap.c (view_destroy): search_idle -> search_timeout. (build_card_from_entry): comment out some spew, and unref ecard when we're done to plug a memory leak. (send_pending_adds): send along to the client all the cards we've been saving up. (poll_ldap): use a timeout for ldap_result to keep the backend from blocking (and it turns out keep the frontend from hanging waiting on a ref to complete) on large db's with few matches. Also, add some fairly smart, self-tuning aggregating of cards. Keep track of the number of cards we've sent the last time through as well as this time, and estimate the number we want to aggregate the next time based on them (we average them at the moment), subject to maximum/minimum number of cards. also, we have a maximum aggregation time, after which we force a flush if there are pending cards and recalculate our target pending number. there's a minimum wait time to possibly keep outselves from spamming the ui, although it's 0 at the moment. Lastly, make sure to only notify the GUI of status messages when we need to. this results in a *huge* savings. (ldap_search_handler): initialize all the pending card stuff, and use a timeout instead of an idle function for poll_ldap. * backend/ebook/e-book-view-listener.c (e_book_view_listener_queue_response): performance optimization for large adds. If we're a CardAddedEvent and there's an existing CardAddedEvent at the end of the queue, just concat the lists of cards together. This is to keep the gui from falling further and further behind the ldap backend, which is merrily spewing updates at the gui. svn path=/trunk/; revision=15807
* Define $(iconsdir).Ettore Perazzoli2002-02-223-7/+48
| | | | | | | | | | | * gui/component/Makefile.am: Define $(iconsdir). * gui/component/addressbook-component.c (add_creatable_item): New helper function. (create_component): Add the icons for the user creatable items as well. svn path=/trunk/; revision=15789
* track change to signature, and (for now) just change all the returnChris Toshok2002-02-218-17/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-02-20 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_load_uri): track change to signature, and (for now) just change all the return FALSE's to _RepositoryOffline (what FALSE used to map to in pas_book_factory_process_request), and change TRUE to _Success. * backend/pas/pas-backend-ldap.c (pas_backend_ldap_load_uri): track change to signature, and differentiate between pas_backend_ldap_connect failing (RepositoryOffline), and ldap_url_parse failing (OtherError). * backend/pas/pas-book-factory.c (pas_book_factory_process_request): since pas_backend_load_uri returns status now, use it to nodify the BookListener if there's a failure. * backend/pas/pas-backend.c (pas_backend_load_uri): track change to signature. * backend/pas/pas-backend.h: change return type of pas_backend_load_uri to GNOME_Evolution_Addressbook_BookListener_CallStatus to allow differentiation between failure types. * backend/ebook/e-book-listener.c (e_book_listener_convert_status): handle _AUTHENTICATION_FAILED. * backend/ebook/e-book-types.h (EBookStatus): add _AUTHENTICATION_FAILED. svn path=/trunk/; revision=15779
* if the load_uri fails, notify the listener that the repository is offline.Chris Toshok2002-02-192-1/+24
| | | | | | | | | | | 2002-02-18 Chris Toshok <toshok@ximian.com> * backend/pas/pas-book-factory.c (pas_book_factory_process_request): if the load_uri fails, notify the listener that the repository is offline. (partial fix for bug 20347) svn path=/trunk/; revision=15758
* escape commas in the dn, since they're used by ldap to specify the node'sChris Toshok2002-02-192-7/+29
| | | | | | | | | | | 2002-02-18 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (create_dn_from_ecard): escape commas in the dn, since they're used by ldap to specify the node's placement in the tree. (fixes bug 20089) (rfc2254_escape): just use sprintf and %02X instead. svn path=/trunk/; revision=15756
* Keep a ref of the model in this case as well.Christopher James Lahey2002-02-142-0/+7
| | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (set_book): Keep a ref of the model in this case as well. svn path=/trunk/; revision=15716
* Make sure to only set the query once when creating a new book and not atChristopher James Lahey2002-02-143-24/+65
| | | | | | | | | | | | | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (set_book): Make sure to only set the query once when creating a new book and not at all on addressbook model creation. This prevents an accidental pair of changes from making the addressbook model load a remote addressbook. * gui/widgets/e-addressbook-model.c (get_view): If this is the first_get_view and the addressbook is remote, empty the view instead of leaving it in the state it used to be in. This only occurs if you set the book after the model has existed for a while. (e_addressbook_model_set_arg): When setting the book, set first_get_view to TRUE. svn path=/trunk/; revision=15715
* Attach to the emvw instead of the emv here.Christopher James Lahey2002-02-146-39/+92
| | | | | | | | | | | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (display_view): Attach to the emvw instead of the emv here. * gui/widgets/e-minicard-view-widget.c, e-minicard-view-widget.h: Made this object have a "column_width" argument and a "column_width_changed" signal which are a simple layer down to the EMinicardView contained within. * gui/widgets/gal-view-minicard.c, gui/widgets/gal-view-minicard.h (gal_view_minicard_attach): Made this attach to an EMinicardViewWidget instead of a EMinicardView. svn path=/trunk/; revision=15714
* Finishing commit that failed in the middle:Christopher James Lahey2002-02-1410-87/+357
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book-util.c, backend/ebook/e-book-util.h (e_book_expand_uri, e_book_load_address_book_by_uri, e_book_use_address_book_by_uri): New functions that take a file:// url ending in the directory name and automatically append the addressbook.db and do the appropriate thing. * backend/pas/pas-backend-card-sexp.c, backend/pas/pas-backend-card-sexp.h: Added copyright notice here. * gui/component/addressbook-component.c (destination_folder_handle_drop), gui/component/addressbook.c (set_prop): Use e_book_expand_uri instead of addressbook_expand_uri. * gui/component/addressbook-storage.c: Fixed the fcntl include here. * gui/component/addressbook.c (ContactsCopyToFolder, ContactsMoveToFolder): Added handlers for these two verbs. * gui/component/addressbook.h: Removed addressbook_expand_uri in favor of e_book_expand_uri. * gui/widgets/e-addressbook-reflow-adapter.c (transfer_cards): Added code to handle Move to and Copy to right click menu items. * gui/widgets/e-addressbook-util.c, gui/widgets/e-addressbook-util.h (e_addressbook_transfer_cards): New function to pop up a dialog and transfer a set of cards to the given folder. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (display_view): Don't attach to the view if it doesn't exist yet. We have to make this then attach later. (e_addressbook_view_copy_to_folder, e_addressbook_view_move_to_folder): New functions utilizing e_addressbook_transfer_cards. (table_right_click): Add copy_to_folder and move_to_folder to the right click menu for tables here. (e_addressbook_view_discard_menus): Handle menu unmerging here. * gui/widgets/e-minicard-view-widget.h (struct _EMinicardViewWidget): Removed unused field. svn path=/trunk/; revision=15711
* New functions that take a file:// url ending in the directory name andChristopher James Lahey2002-02-145-38/+211
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book-util.c, backend/ebook/e-book-util.h (e_book_expand_uri, e_book_load_address_book_by_uri, e_book_use_address_book_by_uri): New functions that take a file:// url ending in the directory name and automatically append the addressbook.db and do the appropriate thing. * backend/pas/pas-backend-card-sexp.c, backend/pas/pas-backend-card-sexp.h: Added copyright notice here. * gui/component/addressbook-component.c (destination_folder_handle_drop), gui/component/addressbook.c (set_prop): Use e_book_expand_uri instead of addressbook_expand_uri. * gui/component/addressbook-storage.c: Fixed the fcntl include here. * gui/component/addressbook.c (ContactsCopyToFolder, ContactsMoveToFolder): Added handlers for these two verbs. * gui/component/addressbook.h: Removed addressbook_expand_uri in favor of e_book_expand_uri. * gui/widgets/e-addressbook-reflow-adapter.c (transfer_cards): Added code to handle Move to and Copy to right click menu items. * gui/widgets/e-addressbook-util.c, gui/widgets/e-addressbook-util.h (e_addressbook_transfer_cards): New function to pop up a dialog and transfer a set of cards to the given folder. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (display_view): Don't attach to the view if it doesn't exist yet. We have to make this then attach later. (e_addressbook_view_copy_to_folder, e_addressbook_view_move_to_folder): New functions utilizing e_addressbook_transfer_cards. (table_right_click): Add copy_to_folder and move_to_folder to the right click menu for tables here. (e_addressbook_view_discard_menus): Handle menu unmerging here. * gui/widgets/e-minicard-view-widget.h (struct _EMinicardViewWidget): Removed unused field. svn path=/trunk/; revision=15710
* Attach the GalViewMinicard to the EMinicardView here.Christopher James Lahey2002-02-134-15/+103
| | | | | | | | | | | | | | | | 2002-02-13 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (display_view): Attach the GalViewMinicard to the EMinicardView here. * gui/widgets/gal-view-minicard.c, gui/widgets/gal-view-minicard.h (gal_view_minicard_load, gal_view_minicard_save): Made these save the column width of the view. (gal_view_minicard_attach, gal_view_minicard_detach): Added these functions to allow the GalViewMinicard to set the column width of a EMinicardView and to monitor its changes. svn path=/trunk/; revision=15707
* Added an argument to get the model.Christopher James Lahey2002-02-135-27/+105
| | | | | | | | | | | | | | | | 2002-02-12 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (addressbook_get_arg): Added an argument to get the model. * gui/widgets/e-addressbook-view.c (writable_status): Don't bother connecting to the writable_status callback on the book, simply rely on the writable_status callback on the addressbook model. * gui/widgets/e-minicard-view.c, gui/widgets/e-minicard-view.h (set_empty_message): Handle the case of a read only view here. svn path=/trunk/; revision=15698
* remove "New" from user creatable menu itemsJP Rosevear2002-02-082-2/+7
| | | | | | | | | 2002-02-07 JP Rosevear <jpr@ximian.com> * gui/component/addressbook-component.c (create_component): remove "New" from user creatable menu items svn path=/trunk/; revision=15596
* Missed one.Chris Lahey2002-02-072-4/+7
| | | | svn path=/trunk/; revision=15593
* Bumped the required version of gal.Christopher James Lahey2002-02-072-155/+281
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-02-07 Christopher James Lahey <clahey@ximian.com> * configure.in: Bumped the required version of gal. From addressbook/ChangeLog: 2002-02-07 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (e_addressbook_view_setup_menus): Changed this function to use the new GalViewMenus which takes a GalViewInstance, instead of a GalViewCollection. From calendar/ChangeLog: 2002-02-07 Christopher James Lahey <clahey@ximian.com> * gui/e-tasks.c (e_tasks_setup_view_menus), gui/gnome-cal.c (gnome_calendar_setup_view_menus): Made these use the new GalViewMenus stuff. From mail/ChangeLog: 2002-02-07 Christopher James Lahey <clahey@ximian.com> * folder-browser.c, folder-browser.h, folder-browser-ui.c, folder-browser-ui.h (folder_browser_ui_setup_view_menus, folder_browser_ui_discard_view_menus): Changed this to use the new GalViewMenus stuff. Made these exported functions. * mail-callbacks.c, message-browser.c: Changed these to not pass the now removed row parameter to message_list_select. * mail-config.c, mail-config.h (mail_config_folder_to_safe_url): Refactored this out of mail_config_folder_to_cachename. * message-list.c, message-list.h (message_list_select): Removed the row argument. Changed this to use the new function in ETree for finding the next cursor row that matches a test. (message_list_construct): Handle a failed construction of the ETree here. (message_list_setup_etree, save_tree_state): Don't load or save the header state. folder-browser-ui.c deals with this now. From views/ChangeLog: 2002-02-07 Christopher James Lahey <clahey@ximian.com> * addressbook/galview.xml, calendar/galview.xml, mail/galview.xml, tasks/galview.xml: Added default-view parameters. * mail/As_Sent_Folder.galview: New galview. * mail/Makefile.am, mail/galview.xml: Added As_Sent_Folder galview. From widgets/ChangeLog: 2002-02-07 Christopher James Lahey <clahey@ximian.com> * menus/gal-view-menus.c, menus/gal-view-menus.h (gal_view_menus_new): Made this take a GalViewInstance instead of a GalViewCollection. Reworked most of this to utilize the interfaces provided by GalViewInstance. svn path=/trunk/; revision=15592
* tidyJP Rosevear2002-02-053-21/+178
| | | | | | | | | | | | | | | | | | | | | | | | 2002-02-04 JP Rosevear <jpr@ximian.com> * gui/contact-editor/e-contact-editor.c (find_address_mailing): tidy * conduit/address-conduit.c (addrconduit_load_configuration): load default address setting (addrconduit_save_configuration): save default address setting (e_addr_gui_new): new gui routine for conduit settings (e_addr_gui_fill_widgets): ditto (e_addr_gui_fill_config): ditto (e_addr_gui_destroy): ditto (e_addr_context_destroy): destroy the gui and new_cfg (local_record_from_ecard): reinstate commented out bits, determine which address to sync to pilot (ecard_from_remote_record): determine which address to sync from pilot (fill_widgets): put the gui widgets in (create_settings_window): create gui (save_settings): fill gui svn path=/trunk/; revision=15568
* if the shown address in the mailing address or there is no mailingJP Rosevear2002-02-044-6/+134
| | | | | | | | | | | | | | | | | | | | | | 2002-02-04 JP Rosevear <jpr@ximian.com> * gui/contact-editor/e-contact-editor.c (address_text_changed): if the shown address in the mailing address or there is no mailing address, set the default flag and make sure the button is checked (address_mailing_changed): set the flags properly when the mailing address changes (e_contact_editor_init): listen for the check button being toggled (find_address_mailing): find the address (if any) with the default flag (set_address_field): set the mailing address button appropriately (fill_in_info): find the mailing address * gui/contact-editor/e-contact-editor.h: add new class data member * gui/contact-editor/contact-editor.glade: show mailing address check button svn path=/trunk/; revision=15561
* New function to find out if a destination was one which was auto-maticallyJeffrey Stedfast2002-02-023-273/+319
| | | | | | | | | | | | | | | | | | | 2002-02-01 Jeffrey Stedfast <fejj@ximian.com> * backend/ebook/e-destination.c (e_destination_is_auto_recipient): New function to find out if a destination was one which was auto-matically set by Evolution. (e_destination_set_auto_recipient): Set whether or not the dest is an auto-recipient. (e_destination_touch): Don't touch the address if it is an auto_recipient. (e_destination_list_to_vector_sized): New function to avoid having to calculate the length of the list ourselves. Allows for a bit of optimization if our caller knows the length of the list. (e_destination_xml_encode): Encode the auto_recipient bit. (e_destination_xml_decode): Decode the auto_recipient bit. svn path=/trunk/; revision=15550
* Made this preserve addressbook flags other than the first three.Christopher James Lahey2002-02-025-1638/+100
| | | | | | | | | | | | | | | | | 2002-02-01 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_sync_card): Made this preserve addressbook flags other than the first three. * backend/ebook/e-card-types.h: Added E_CARD_ADDR_MASK and E_CARD_ADDR_DEFAULT. * backend/ebook/e-card.c (get_address_flags): Added "PREF" to E_CARD_ADDR_DEFAULT mapping. * backend/ebook/test-client.c: Added #include "e-book-util.h". svn path=/trunk/; revision=15546
* compute the change db filename based on our contact db filename.Chris Toshok2002-01-312-6/+25
| | | | | | | | | | | | | 2002-01-30 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes): compute the change db filename based on our contact db filename. (pas_backend_file_load_uri): store the filename in bf->priv->filename. (pas_backend_file_destroy): free the filename, and (!) free bf->priv too. svn path=/trunk/; revision=15529
* Revert my previous change as trow says this will break auto-completionJeffrey Stedfast2002-01-292-1/+7
| | | | | | | | | | 2002-01-28 Jeffrey Stedfast <fejj@ximian.com> * backend/ebook/e-destination.c (e_destination_is_valid): Revert my previous change as trow says this will break auto-completion stuff. svn path=/trunk/; revision=15496
* Final cleanup for the CFLAGS and LIBS in the Makefiles.Ettore Perazzoli2002-01-286-34/+16
| | | | svn path=/trunk/; revision=15486
* Don't check for an @ in the email address. This is to fix bug #10960.Jeffrey Stedfast2002-01-262-1/+11
| | | | | | | | | 2002-01-25 Jeffrey Stedfast <fejj@ximian.com> * backend/ebook/e-destination.c (e_destination_is_valid): Don't check for an @ in the email address. This is to fix bug #10960. svn path=/trunk/; revision=15477
* [ fixes bug 16097 ] gui love for the new auth stuff.Chris Toshok2002-01-262-10/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-01-24 Chris Toshok <toshok@ximian.com> [ fixes bug 16097 ] * gui/component/addressbook-config.glade: gui love for the new auth stuff. * gui/component/addressbook.c (load_uri_cb): track change to auth, and offer up different prompt strings depending on which method (binddn or email) we're using. * gui/component/addressbook-storage.c (ldap_unparse_auth): use the new auth types for ldap. (ldap_parse_auth): same. (addressbook_storage_auth_type_to_string): new function. (load_source_data): get the binddn too. (ldap_source_foreach): store out binddn or emailaddr, depending on the auth type chosen. * gui/component/addressbook-storage.h: add the more detailed auth types, add "binddn" to the source structure, and add a prototype for addressbook_storage_auth_type_to_string. * gui/component/addressbook-config.c (auth_checkbutton_changed): set the auth stuff (in)sensitive. (auth_optionmenu_activated): new function. (addressbook_source_dialog_set_source): track UI change. (addressbook_source_dialog_get_source): same. (add_scope_activate_cb): rename add_activate_cb to this to distinguish it from the auth stuff. (add_auth_activate_cb): new function. (addressbook_source_dialog): track change to auth UI stuff. (addressbook_storage_auth_type_to_string): new function. * backend/ebook/e-book.h: add auth_method arg to e_book_authenticate_user. * backend/ebook/e-book.c (e_book_authenticate_user): track change to prototype - add auth_method arg, and pass it along to the CORBA call. * backend/ebook/test-client.c (book_open_cb): track api change - keep this building. * backend/pas/pas-book.h: add auth_method slot in PASRequest. * backend/pas/pas-book.c (pas_book_queue_authenticate_user): add auth_method arg and add it to the PASRequest. (impl_GNOME_Evolution_Addressbook_Book_authenticateUser): track idl change, add auth_method and pass it along to pas_book_queue_authenticate_user. * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_authenticate_user): support both "ldap/simple-email" and "ldap/simple-binddn" auth methods. * backend/idl/addressbook.idl: add "in string authMethod" to authenticateUser. svn path=/trunk/; revision=15475
* [ fixes bug 16097 ] gui love for the new auth stuff.Chris Toshok2002-01-2511-117/+445
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-01-24 Chris Toshok <toshok@ximian.com> [ fixes bug 16097 ] * gui/component/addressbook-config.glade: gui love for the new auth stuff. * gui/component/addressbook.c (load_uri_cb): track change to auth, and offer up different prompt strings depending on which method (binddn or email) we're using. * gui/component/addressbook-storage.c (ldap_unparse_auth): use the new auth types for ldap. (ldap_parse_auth): same. (addressbook_storage_auth_type_to_string): new function. (load_source_data): get the binddn too. (ldap_source_foreach): store out binddn or emailaddr, depending on the auth type chosen. * gui/component/addressbook-storage.h: add the more detailed auth types, add "binddn" to the source structure, and add a prototype for addressbook_storage_auth_type_to_string. * gui/component/addressbook-config.c (auth_checkbutton_changed): set the auth stuff (in)sensitive. (auth_optionmenu_activated): new function. (addressbook_source_dialog_set_source): track UI change. (addressbook_source_dialog_get_source): same. (add_scope_activate_cb): rename add_activate_cb to this to distinguish it from the auth stuff. (add_auth_activate_cb): new function. (addressbook_source_dialog): track change to auth UI stuff. (addressbook_storage_auth_type_to_string): new function. * backend/ebook/e-book.h: add auth_method arg to e_book_authenticate_user. * backend/ebook/e-book.c (e_book_authenticate_user): track change to prototype - add auth_method arg, and pass it along to the CORBA call. * backend/ebook/test-client.c (book_open_cb): track api change - keep this building. * backend/pas/pas-book.h: add auth_method slot in PASRequest. * backend/pas/pas-book.c (pas_book_queue_authenticate_user): add auth_method arg and add it to the PASRequest. (impl_GNOME_Evolution_Addressbook_Book_authenticateUser): track idl change, add auth_method and pass it along to pas_book_queue_authenticate_user. * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_authenticate_user): support both "ldap/simple-email" and "ldap/simple-binddn" auth methods. * backend/idl/addressbook.idl: add "in string authMethod" to authenticateUser. svn path=/trunk/; revision=15467
* Clean up some of the Makefiles so we dont' link every library multipleEttore Perazzoli2002-01-257-129/+95
| | | | | | times, causing big libtool 1.4 pain. svn path=/trunk/; revision=15461
* Pass a NULL @icon toEttore Perazzoli2002-01-242-2/+12
| | | | | | | | * gui/component/addressbook-component.c (create_component): Pass a NULL @icon to `evolution_shell_component_add_user_creatable_item()'. svn path=/trunk/; revision=15439
* #include <locale.h>.Ettore Perazzoli2002-01-242-0/+6
| | | | | | | * gui/contact-editor/e-contact-editor-address.c: #include <locale.h>. svn path=/trunk/; revision=15431
* [ fixes bug # 16864 ] create and return a GString here, instead of writingChris Toshok2002-01-232-24/+32
| | | | | | | | | | | 2002-01-22 Chris Toshok <toshok@ximian.com> [ fixes bug # 16864 ] * backend/ebook/evolution-ldif-importer.c (getValue): create and return a GString here, instead of writing to a fixed size buffer. (parseLine): use a GString here instead of a fixed size buffer. svn path=/trunk/; revision=15427
* Set the number of cards to return to the value specified in the ldap uri,Christopher James Lahey2002-01-216-10/+190
| | | | | | | | | | | | | | | | | | | 2002-01-21 Christopher James Lahey <clahey@ximian.com> * backend/pas/pas-backend-ldap.c (ldap_search_handler): Set the number of cards to return to the value specified in the ldap uri, leaving the default at 100. Fixes Ximian bug #13953. * gui/component/addressbook-config.c (addressbook_source_dialog), gui/component/addressbook-config.glade: Added a limit entry here to edit the limit field of the source. * gui/component/addressbook-storage.c, gui/component/addressbook-storage.h (addressbook_storage_init_source_uri): Added a limit field to this class and pass that value through in the uri that's generated. svn path=/trunk/; revision=15415
* Made username match with no domain match be vague instead of partial.Christopher James Lahey2002-01-182-1/+7
| | | | | | | | | | 2002-01-18 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-compare.c: Made username match with no domain match be vague instead of partial. Fixes Ximian bug #13612. svn path=/trunk/; revision=15356
* From addressbook/ChangeLog:Christopher James Lahey2002-01-187-35/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2002-01-18 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (view_contact_cb): New verb to open a bunch of cards. * gui/widgets/e-addressbook-reflow-adapter.c (open_card): Call e_addressbook_show_multiple_cards instead of doing this ourselves. * gui/widgets/e-addressbook-util.c, gui/widgets/e-addressbook-util.h (e_addressbook_show_multiple_cards): Added this function to show a bunch of cards, including a dialog if lots of windows are going to appear. * gui/widgets/e-addressbook-view.c (e_addressbook_view_view, e_addressbook_view_can_view): e_addressbook_view_view calls e_addressbook_show_multiple_cards on the appropriate list of cards. From ui/ChangeLog: 2002-01-18 Christopher James Lahey <clahey@ximian.com> * evolution-addressbook.xml: Added File->Open which calls the ContactsView command. svn path=/trunk/; revision=15355
* Sort country list. Country list moves from fulladdr.glade toChristopher James Lahey2002-01-183-236/+293
| | | | | | | | | | | | 2002-01-18 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-editor-address.c (fill_in_countries), gui/contact-editor/fulladdr.glade: Sort country list. Country list moves from fulladdr.glade to e-contact-editor-address.c, but only a few country names have actually changed. Fixes Ximian bug #16545. svn path=/trunk/; revision=15354
* Fixes #17725Zbigniew Chyla2002-01-182-4/+16
| | | | | | | | | | | | 2001-12-20 Zbigniew Chyla <cyba@gnome.pl> Fixes #17725 * evolution/addressbook/printing/e-contact-print.c (complete_sequence): Do not assume that the first byte of file_as is the first letter, use utf8 functions instead. svn path=/trunk/; revision=15351
* move all functions here, get rid of header files, use e-pilot-settings toJP Rosevear2002-01-176-280/+256
| | | | | | | | | 2002-01-16 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c: move all functions here, get rid of header files, use e-pilot-settings to display gui svn path=/trunk/; revision=15342
* remove misleading title and fix spacingJP Rosevear2002-01-162-43/+5
| | | | | | | | | 2002-01-15 JP Rosevear <jpr@ximian.com> * gui/component/select-names/select-names.glade: remove misleading title and fix spacing svn path=/trunk/; revision=15330
* Handle setting the search bar to "Advanced..." when the alphabet buttonsChristopher James Lahey2002-01-114-20/+80
| | | | | | | | | | | | | | | | | | | | | 2002-01-11 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (alphabet_state_changed): Handle setting the search bar to "Advanced..." when the alphabet buttons are pushed and back when they're cleared. Fixes Ximian bug #12904. (addressbook_menu_activated): When the user calls Search->clear, set the search to ESB_ANY and "", don't just set the text. This is especially useful when it's set to ESB_ADVANCED. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (alphabet_state_change): Added this signal which gets emitted when the alphabet buttons are pushed. (command_state_change): Removed the ref pair here. It's not necessary. gtk_signal_emit refs the object itself. svn path=/trunk/; revision=15295
* Commit the ChangeLog for the fixes I just accidently committed:Christopher James Lahey2002-01-111-0/+9
| | | | | | | | | | | | | 2002-01-11 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-compare.c (name_synonyms): Added a couple of names here. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_get_nth_obj): Removed an unused variable. svn path=/trunk/; revision=15294
* ChangeLog change.Chris Lahey2002-01-113-2/+4
| | | | svn path=/trunk/; revision=15293
* Use toggle buttons here.Christopher James Lahey2002-01-113-8/+54
| | | | | | | | | | 2002-01-11 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (create_alphabet): Use toggle buttons here. svn path=/trunk/; revision=15292
* Choose the first filled in address field here. Fixes Ximian bug #2222.Christopher James Lahey2002-01-102-3/+30
| | | | | | | | | 2002-01-09 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-editor.c (set_fields): Choose the first filled in address field here. Fixes Ximian bug #2222. svn path=/trunk/; revision=15280
* Add a test for getting arbitrary fields.Joe Shaw2002-01-104-2/+57
| | | | | | | | | | | | | | | | | 2002-01-03 Joe Shaw <joe@ximian.com> * backend/ebook/test-card.c: Add a test for getting arbitrary fields. * backend/pas/pas-backend-card-sexp.c (compare_arbitrary): Added. (prop_info_table): Add a LIST_PROP for arbitrary fields. 2002-01-03 Nat Friedman <nat@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): Free the query if the oaf response is of zero length. svn path=/trunk/; revision=15275
* When we clean, don't clean the model's last element. This helps keepJon Trowbridge2001-12-2811-203/+291
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-12-27 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (real_add_address_cb): When we clean, don't clean the model's last element. This helps keep things working properly when we have signal-character separators. (section_right_click_cb): Changed to work properly with our EText-emitted popup signal. (e_select_names_add_section): Use ETexts for the recipient sections, rather than tables. This lets us make them directly editable. (Bug #1721) * gui/component/select-names/e-select-names-popup.c (popup_info_new): Pass in a ESelectNamesTextModel, not a ESelectNamesModel. (e_select_names_popup): Adjust for the new signature for e_select_names_model_text_pos. * gui/component/select-names/e-select-names-manager.c (focus_out_cb): Schedule a cleaning when we focus out. (focus_in_cb): Cancel pending cleaning when we get focus. This helps us avoid bad things happening during the fast focus out/ins that happen when the completion dropdown appears. (completion_handler): Adjust for new signatures of e_select_names_model_text_pos and e_select_names_model_name_pos. (e_select_names_manager_entry_new): Pass in our ESelectNamesTextModel when constructing the ESelectNamesCompletion. (e_select_names_manager_entry_free): Cancel any pending clean-ups. * gui/component/select-names/e-select-names-bonobo.c (entry_get_property_fn): Get the text off of the text model. Which is the only way that really makes sense when you think about it. * gui/component/select-names/e-select-names-completion.c: Added a copy of the associated ESelectNamesTextModel to ESelectNamesCompletionPrivate. This replaces the ESelectNamesModel. (e_select_names_completion_destroy): Unref ->text_model. (e_select_names_completion_handle_request): Pass in our text model's separator info when calling e_select_names_model_text_pos. (e_select_names_completion_new): Pass in the text model as an arg instead of the model, and ref it as needed. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_init): Set separator as either ", " or ",", depending on the value of the EVOLUTION_DISABLE_MAGIC_COMMA environment variable. (e_select_names_text_model_destroy): Free the separator. (changed_cb): Flush our cached text on changed. (e_select_names_text_model_set_source): Use our own changed_cb callback on changed, rather than just connecting up e_text_model_changed. (e_select_names_text_model_set_separator): Added. Lets the separator between recipients be specified. (e_select_names_text_model_get_text): Cache the text we get from calling e_select_names_model_get_textification. (e_select_names_text_model_insert_length): A bunch of small changes to properly support generic separators, rather than (implicit and explicitly) assuming ", ". (e_select_names_text_model_delete): More small tweaks to handle generic separators. (e_select_names_text_model_get_nth_obj): Use new signature when calling e_select_names_model_name_pos, and use our cached text. * gui/component/select-names/e-select-names-model.c (e_select_names_model_destroy): We don't cache the text or addr_text anymore, so no need to free them here. (e_select_names_model_changed): ...and no need to reset our text and addr_text caches here. (e_select_names_model_get_textification): Take a separator as an arg, rather than just using ", ". Also, no caching. (e_select_names_model_get_address_text): Take a separator as an arg, rather than just using ", ". And no caching here either. (e_select_names_model_clean): Add arg that give us control over whether or not the last entry should get cleaned. We need this when using a one-character separator, so that new destinations that get tacked onto the end don't get immediately cleaned away for being empty. (e_select_names_model_name_pos): Take the separator length as an argument, remove implicit assumption of length 2. (e_select_names_model_text_pos): Take the separator length as an argument, remove implicit assumption of length 2.CVS: ---------------------------------------------------------------------- svn path=/trunk/; revision=15221
* When we clean, don't clean the model's last element. This helps keepJon Trowbridge2001-12-281-0/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-12-27 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (real_add_address_cb): When we clean, don't clean the model's last element. This helps keep things working properly when we have signal-character separators. (section_right_click_cb): Changed to work properly with our EText-emitted popup signal. (e_select_names_add_section): Use ETexts for the recipient sections, rather than tables. This lets us make them directly editable. (Bug #1721) * gui/component/select-names/e-select-names-popup.c (popup_info_new): Pass in a ESelectNamesTextModel, not a ESelectNamesModel. (e_select_names_popup): Adjust for the new signature for e_select_names_model_text_pos. * gui/component/select-names/e-select-names-manager.c (focus_out_cb): Schedule a cleaning when we focus out. (focus_in_cb): Cancel pending cleaning when we get focus. This helps us avoid bad things happening during the fast focus out/ins that happen when the completion dropdown appears. (completion_handler): Adjust for new signatures of e_select_names_model_text_pos and e_select_names_model_name_pos. (e_select_names_manager_entry_new): Pass in our ESelectNamesTextModel when constructing the ESelectNamesCompletion. (e_select_names_manager_entry_free): Cancel any pending clean-ups. * gui/component/select-names/e-select-names-bonobo.c (entry_get_property_fn): Get the text off of the text model. Which is the only way that really makes sense when you think about it. * gui/component/select-names/e-select-names-completion.c: Added a copy of the associated ESelectNamesTextModel to ESelectNamesCompletionPrivate. This replaces the ESelectNamesModel. (e_select_names_completion_destroy): Unref ->text_model. (e_select_names_completion_handle_request): Pass in our text model's separator info when calling e_select_names_model_text_pos. (e_select_names_completion_new): Pass in the text model as an arg instead of the model, and ref it as needed. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_init): Set separator as either ", " or ",", depending on the value of the EVOLUTION_DISABLE_MAGIC_COMMA environment variable. (e_select_names_text_model_destroy): Free the separator. (changed_cb): Flush our cached text on changed. (e_select_names_text_model_set_source): Use our own changed_cb callback on changed, rather than just connecting up e_text_model_changed. (e_select_names_text_model_set_separator): Added. Lets the separator between recipients be specified. (e_select_names_text_model_get_text): Cache the text we get from calling e_select_names_model_get_textification. (e_select_names_text_model_insert_length): A bunch of small changes to properly support generic separators, rather than (implicit and explicitly) assuming ", ". (e_select_names_text_model_delete): More small tweaks to handle generic separators. (e_select_names_text_model_get_nth_obj): Use new signature when calling e_select_names_model_name_pos, and use our cached text. * gui/component/select-names/e-select-names-model.c (e_select_names_model_destroy): We don't cache the text or addr_text anymore, so no need to free them here. (e_select_names_model_changed): ...and no need to reset our text and addr_text caches here. (e_select_names_model_get_textification): Take a separator as an arg, rather than just using ", ". Also, no caching. (e_select_names_model_get_address_text): Take a separator as an arg, rather than just using ", ". And no caching here either. (e_select_names_model_clean): Add arg that give us control over whether or not the last entry should get cleaned. We need this when using a one-character separator, so that new destinations that get tacked onto the end don't get immediately cleaned away for being empty. (e_select_names_model_name_pos): Take the separator length as an argument, remove implicit assumption of length 2. (e_select_names_model_text_pos): Take the separator length as an argument, remove implicit assumption of length 2. svn path=/trunk/; revision=15220
* -- Merge fix for #17377 from the evolution-1-0-branch.Ettore Perazzoli2001-12-202-0/+10
| | | | | | | * gui/component/addressbook-factory.c (main): Push GdkRGB visual and colormap. svn path=/trunk/; revision=15196
* Add cut/copy/paste to right-click menu.Jon Trowbridge2001-12-203-2/+85
| | | | | | | | | | | | | | | 2001-12-19 Jon Trowbridge <trow@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (e_addressbook_reflow_adapter_right_click): Add cut/copy/paste to right-click menu. * gui/widgets/e-addressbook-view.c (table_right_click): Add cut/copy/paste to right-click menu. (Fixes bug #14528.) Also, disable some right-click options if our addressbook isn't editable. svn path=/trunk/; revision=15190
* go slow and clear the map if the last uri and the current uri do not matchJP Rosevear2001-12-196-15/+151
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-12-18 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (check_for_slow_setting): go slow and clear the map if the last uri and the current uri do not match (post_sync): save the last uri * conduits/address-conduit-config.h: handle a last uri config option 2001-12-18 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c (addressbook_default_book_open): change this to match its e-book counterpart, and only failover to the local addressbook if the protocol wasn't supported. that way errors like "failure to connect" are still reported to the user. * backend/ebook/e-book-util.h: add prototypes for e_book_load_default_book and e_book_get_config_database. * backend/ebook/e-book-util.c (e_book_default_book_open): new function, basically cut and paste addressbook_default_book_open from addressbook.c here. (e_book_load_default_book): cut and past addressbook_load_default_book here, pretty much, except leave off the auth stuff. (e_book_get_config_database): new function, returns the Bonobo_ConfigDatabase for e_book_load_default_book to use. * conduit/address-conduit.c (start_addressbook_server): use e_book_load_default_book here. svn path=/trunk/; revision=15178
* [ fixes bug 17355 ] if we're dealing with an LDAP folder, prepend [LDAP]Chris Toshok2001-12-182-1/+75
| | | | | | | | | | | | | | | | | 2001-12-17 Chris Toshok <toshok@ximian.com> [ fixes bug 17355 ] * gui/component/select-names/e-select-names.c (new_folder): if we're dealing with an LDAP folder, prepend [LDAP] to it. Now that we have 3 different places where folders are coming from, it helps to be able to differentiate "Contacts" in ~/evolution and a "Contacts" ldap server and a "Contacts" exchange folder. (add_additional_select_names_uris): loop through the bonobo conf settings for additional folders, adding them to the option menu. (e_select_names_hookup_shell_listeners): call add_additional_select_names_uris. svn path=/trunk/; revision=15143
* Merging changes:Christopher James Lahey2001-12-182-19/+11
| | | | | | | | | | 2001-11-28 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard-view-widget.c (e_minicard_view_widget_realize): Use an #ECanvasBackground here instead of a #GnomeCanvasRect. svn path=/trunk/; revision=15130
* Added 'cache_complete' flag to ESelectNamesCompletionPrivate.Jon Trowbridge2001-12-172-1/+20
| | | | | | | | | | | | | | | 2001-12-16 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c: Added 'cache_complete' flag to ESelectNamesCompletionPrivate. (e_select_names_completion_seq_complete_cb): Set cache_complete to TRUE if our query wasn't interrupted. (e_select_names_completion_start_query): Set cache_complete to FALSE at the beginning of a potentially-cached query. (e_select_names_completion_do_query): Only reuse cached cards if cache_complete is TRUE. (Fixes bug #10241) svn path=/trunk/; revision=15096
* don't free the hash table keys, we didn't allocate them and free theJP Rosevear2001-12-162-13/+23
| | | | | | | | | | | | | 2001-12-15 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (e_addr_context_destroy): don't free the hash table keys, we didn't allocate them and free the change objects and unref the associated cards (local_record_from_uid): unref the temp card we create (replace_record): ref the new card associated with the card change and unref the old one svn path=/trunk/; revision=15091
* Make sure to copy the custom fields so they are not overwrittenJP Rosevear2001-12-142-0/+10
| | | | | | | | | 2001-12-13 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): Make sure to copy the custom fields so they are not overwritten svn path=/trunk/; revision=15034
* Used g_strdup_printf to dup a string. Doh! Changed to g_strdup. (BugJon Trowbridge2001-12-142-1/+7
| | | | | | | | | | 2001-12-13 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-util.c (simple_query_new): Used g_strdup_printf to dup a string. Doh! Changed to g_strdup. (Bug #17126) svn path=/trunk/; revision=15031
* Remove a reference to code I don't want to commit yet. :-)Jon Trowbridge2001-12-082-2/+4
| | | | | | | | | | 2001-12-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_entry_new): Remove a reference to code I don't want to commit yet. :-) svn path=/trunk/; revision=14935
* Extensively refactored -- this code had gotten _really_ ugly. UntangleJon Trowbridge2001-12-085-421/+433
| | | | | | | | | | | | | | | 2001-12-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c: Extensively refactored -- this code had gotten _really_ ugly. Untangle things to the point where our reference counting problems are fixable. * gui/component/select-names/e-select-names-bonobo.c (impl_destroy): Remove all of the ugly hacks to work around our memory management problems, and just unref the manager. (Fixes #14412) svn path=/trunk/; revision=14934
* move search_for_dn's contents here, and add an "existing_objectclasses"Chris Toshok2001-12-072-40/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-12-05 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (search_for_dn_with_objectclasses): move search_for_dn's contents here, and add an "existing_objectclasses" parameter that we pass on to build_card_from_entry. (search_for_dn): call search_for_dn_with_objectclasses with NULL for existing_objectclasses. (build_card_from_entry): if existing_objectclasses is non-NULL, fill it in with the list of existing objectclass values for this entry. (add_objectclass_mod): if existing_objectclasses is non-NULL, meaning we're modifying an entry, search in the existing objectclasses for the ones we want to be there, and only add what's missing. If none are missing, don't add objectclass_mod to the list of mods. (create_card_handler): track change to add_objectclass_mod (pass NULL). (modify_card_handler): use search_for_dn_with_objectclasses instead of search_for_dn, and pass the existing objectclasses to add_objectclass_mod. also, free the list when we're done. (poll_ldap): track change to build_card_from_entry (pass NULL). svn path=/trunk/; revision=14909
* we need to be able to disable non-labels here as well. since we're usingChris Toshok2001-12-075-7/+42
| | | | | | | | | | | | | | | | | | | | | | 2001-12-05 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c (enable_writable_fields): we need to be able to disable non-labels here as well. since we're using enable_widget and not gtk_widget_set_sensitive, it's okay to handle entries/text's, etc, here. (widget_field_mappings): add label-caluri and label-fburl here. * gui/contact-editor/contact-editor.glade: change the label names for the freebusy/calendar urls to have more descriptive names, since we use them in e-contact-editor.c now. * backend/pas/pas-backend-ldap.c: add support for caluri/calendarURI, fburl/freeBusyURI. * backend/pas/evolutionperson.schema: add calendarURI and freeBusyURI. svn path=/trunk/; revision=14908
* Merging changes:Christopher James Lahey2001-12-064-28/+42
| | | | | | | | | | | | | | | | | 2001-12-04 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/contact-editor.glade: Fixed up the accelerators and such here. * gui/contact-editor/e-contact-editor.c (file_save_as_cb): Translate this string. (pixmaps): Added a pixmap for the ContactEditorSaveClose command. (setup_tab_order): Fixed up the tab order here. * gui/contact-editor/fulladdr.glade: Made the country combo focusable here. svn path=/trunk/; revision=14895
* Make address comparisons case-insensitive. (Fixes 11776)Jon Trowbridge2001-12-043-6/+14
| | | | | | | | | | | | 2001-12-03 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_equal): Make address comparisons case-insensitive. (Fixes 11776) * backend/ebook/e-card.c (e_card_email_match_single_string): Make address host comparisons case-insensitive. (Fixes 11776) svn path=/trunk/; revision=14856
* Clean ESelectNamesModel on focus-out. (Half of a fix for 15656)Jon Trowbridge2001-12-043-3/+15
| | | | | | | | | | | | 2001-12-03 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (focus_out_cb): Clean ESelectNamesModel on focus-out. (Half of a fix for 15656) * backend/ebook/e-destination.c (nonempty): Fix this function and make it utf8-safe. (The other half of the fix for 15656) svn path=/trunk/; revision=14855
* Merging changes:Christopher James Lahey2001-12-012-3/+51
| | | | | | | | | | | 2001-11-28 Christopher James Lahey <clahey@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c: Consistency fixes with standard contact editor. Added Save As, Send As, and Send To. Replaced Save toolbar with Save and Close and added Save and Close menu item. Added a trash icon. svn path=/trunk/; revision=14844
* Merged changes:Christopher James Lahey2001-12-012-0/+34
| | | | | | | | | 2001-11-28 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-editor-address.c (setup_tab_order): Setup the tab order here. Fixes Ximian bug #13751. svn path=/trunk/; revision=14840
* Merging fixes:Christopher James Lahey2001-12-012-37/+79
| | | | | | | | | | 2001-11-28 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (connect_master_list_changed, make_suboptions): Changed how this list of categories gets computed. Fixes Ximian bugs #7707 and #7708. svn path=/trunk/; revision=14838
* s/gnome_font_get_width_string/gnome_font_get_width_utf8/Chyla Zbigniew2001-11-173-24/+34
| | | | | | | | | | | | * printing/e-contact-print-envelope.c (ecpe_linelist_dimensions), printing/e-contact-print.c (e_contact_divide_text, e_contact_output, e_contact_rectangle, e_contact_print_letter_tab, e_contact_print_letter_heading, e_contact_get_card_size, e_contact_print_card, e_contact_print_phone_list): s/gnome_font_get_width_string/gnome_font_get_width_utf8/ s/gnome_font_get_width_string_n/gnome_font_get_width_utf8_sized/ svn path=/trunk/; revision=14739
* check against LDAP_SUCCESS as the return value, not -1.Chris Toshok2001-11-152-7/+16
| | | | | | | | | | | 2001-11-14 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (search_for_dn): check against LDAP_SUCCESS as the return value, not -1. (pas_backend_ldap_build_all_cards_list): same. (pas_backend_ldap_process_authenticate_user): same. svn path=/trunk/; revision=14724
* [ Fixes Ximian bug #14843 ] don't crash if a subexpression wasn't filledChris Toshok2001-11-132-8/+19
| | | | | | | | | | | | 2001-11-12 Chris Toshok <toshok@ximian.com> [ Fixes Ximian bug #14843 ] * backend/pas/pas-backend-ldap.c (func_and): don't crash if a subexpression wasn't filled in. * backend/pas/pas-backend-ldap.c (func_or): same. svn path=/trunk/; revision=14678
* Release callback's reference to EContactListEditor. (list_modified_cb):Jon Trowbridge2001-11-132-9/+33
| | | | | | | | | | | | | | | | 2001-11-12 Jon Trowbridge <trow@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c (list_added_cb): Release callback's reference to EContactListEditor. (list_modified_cb): Release callback's reference to EContactListEditor. (save_card): Ref the EContactListEditor on behalf of the e_book_foo callback. (Fixes bug #14743) (save_card): Set changed to false once we've saved. (list_deleted_cb): Release callback's reference. (delete_cb): Hold reference for the callback. svn path=/trunk/; revision=14673
* If our call to e_categories_new returns NULL, put up an error dialog andJon Trowbridge2001-11-132-0/+14
| | | | | | | | | | 2001-11-12 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-editor.c (categories_clicked): If our call to e_categories_new returns NULL, put up an error dialog and return. (Fixed #14780) svn path=/trunk/; revision=14672
* [ Fixes Ximian bug #14687 ] backend/pas/pas-backend-file.cChris Toshok2001-11-104-16/+25
| | | | | | | | | | | | | | | | | | | | | | | | | 2001-11-09 Chris Toshok <toshok@ximian.com> [ Fixes Ximian bug #14687 ] * backend/pas/pas-backend-file.c * backend/pas/pas-book-factory.c (pas_book_factory_process_request): do load_uri before add_client, so we know if the load actually worked (add_client uses this information to respond to the new client.) before this change, the client would still think the book was in a useful state even if the load_uri failed. * backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client): if the we're not connected, say so. * backend/pas/pas-backend-file.c (pas_backend_file_add_client): same. (pas_backend_file_load_uri): don't report_writable here, add_client does it. was only needed before because of the improper ordering in pas-book-factory.c above. svn path=/trunk/; revision=14655
* [ Fixes Ximian bug #14646 ] new function. if the default_book failed toChris Toshok2001-11-103-1/+44
| | | | | | | | | | | | | | | | | 2001-11-09 Chris Toshok <toshok@ximian.com> [ Fixes Ximian bug #14646 ] * gui/component/addressbook.c (addressbook_default_book_open): new function. if the default_book failed to load, load the local addressbook in its place. addressbook_load_default_book): if we're loading the default_book uri, use addressbook_default_book_open as the open_response. * backend/ebook/e-book.c (e_book_load_uri_step): reset the load_state to NotLoaded so we can attempt another load_uri on the book if it fails. svn path=/trunk/; revision=14654
* Explicitly destroy entries. Part of the fix for the lingering completionJon Trowbridge2001-11-092-0/+22
| | | | | | | | | | 2001-11-08 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-bonobo.c (impl_destroy): Explicitly destroy entries. Part of the fix for the lingering completion window bug. svn path=/trunk/; revision=14628
* Use ordering of the pilot's phone label list to find fields we sync inJP Rosevear2001-11-052-61/+64
| | | | | | | | | | | 2001-11-04 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c: Use ordering of the pilot's phone label list to find fields we sync in order to avoid strcmp'ing the pilot's labels rendering phone syncing usable only for english language pilots svn path=/trunk/; revision=14583
* [ Fixes Ximian bug #14410 ] init in_async_call to FALSE. (card_added_cb):Chris Toshok2001-11-045-2/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-11-03 Chris Toshok <toshok@ximian.com> [ Fixes Ximian bug #14410 ] * gui/contact-editor/e-contact-editor.c (e_contact_editor_init): init in_async_call to FALSE. (card_added_cb): turn the UI back on and set in_async_call to FALSE. (card_modified_cb): same. (card_deleted_cb): same. (save_card): turn off the UI by setting the dialog insensitive, and set in_async_call to TRUE. (delete_cb): same. (app_delete_event_cb): if we're in an async call don't let the window get deleted. * gui/contact-editor/e-contact-editor.h (struct _EContactEditor): add in_async_call flag for when we make a wombat call and need to disable the UI. * gui/contact-list-editor/e-contact-list-editor.c (e_contact_list_editor_init): init in_async_call to FALSE. (list_added_cb): turn the UI back on and set in_async_call to FALSE. (list_modified_cb): same. (list_deleted_cb): same. (save_card): turn off the UI by setting the dialog insensitive, and set in_async_call to TRUE. (delete_cb): same. (app_delete_event_cb): if we're in an async call don't let the window get deleted. * gui/contact-list-editor/e-contact-list-editor.h (struct _EContactListEditor): add in_async_call flag for when we make a wombat call and need to disable the UI. svn path=/trunk/; revision=14582
* Check for NULL dates before converting them to strings. Fixes Ximian bugChristopher James Lahey2001-11-032-10/+20
| | | | | | | | | | 2001-11-02 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_get): Check for NULL dates before converting them to strings. Fixes Ximian bug #14394. svn path=/trunk/; revision=14579
* Leak select-names related data structures until the memory managementJon Trowbridge2001-11-032-1/+13
| | | | | | | | | | 2001-11-02 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-bonobo.c (impl_destroy): Leak select-names related data structures until the memory management issues get sorted out. Fixed bug #14086. svn path=/trunk/; revision=14578
* Make the pre_changes and changes match here.Christopher James Lahey2001-10-314-0/+14
| | | | | | | | | | | 2001-10-31 Christopher James Lahey <clahey@ximian.com> * gui/component/e-cardlist-model.c, gui/component/select-names/e-select-names-table-model.c, gui/widgets/e-addressbook-table-adapter.c: Make the pre_changes and changes match here. svn path=/trunk/; revision=14526
* Check that local_listener and other_contacts_listener are non-NULL beforeJon Trowbridge2001-10-314-14/+31
| | | | | | | | | | | | | | | | | | | | | 2001-10-31 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_destroy): Check that local_listener and other_contacts_listener are non-NULL before disconnecting/unrefing. * gui/component/select-names/e-select-names-manager.c (entry_destroyed): The entry shouldn't unref the manager. (e_select_names_manager_create_entry): The entry shouldn't hold a ref to the manager. It becomes circular. (e_select_names_manager_create_entry): On the other hand, we should hold a ref to the entry we create. * gui/component/select-names/e-select-names-bonobo.c (impl_destroy): Remove the explicit dialog destroy hack. svn path=/trunk/; revision=14519
* Force the select names dialog to be destroyed. This is a hack to fix bugJon Trowbridge2001-10-312-0/+14
| | | | | | | | | | | 2001-10-30 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-bonobo.c (impl_destroy): Force the select names dialog to be destroyed. This is a hack to fix bug #14002 -- I'll clean up the refcounting issues post-freeze. At least now it won't crash. svn path=/trunk/; revision=14495
* Oops.JP Rosevear2001-10-311-1/+2
| | | | svn path=/trunk/; revision=14464
* make sure to translate the character sets of the namesJP Rosevear2001-10-312-4/+6
| | | | | | | | | 2001-10-30 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): make sure to translate the character sets of the names svn path=/trunk/; revision=14463
* send a null bonobo arg to prevent explosionJP Rosevear2001-10-302-1/+11
| | | | | | | | | 001-10-30 JP Rosevear <jpr@ximian.com> * gui/component/select-names/e-select-names-bonobo.c (manager_ok_cb): send a null bonobo arg to prevent explosion svn path=/trunk/; revision=14437
* correct include typoJP Rosevear2001-10-302-1/+5
| | | | | | | | 2001-10-30 JP Rosevear <jpr@ximian.com> * gui/widgets/e-addressbook-view.c: correct include typo svn path=/trunk/; revision=14436
* Require gal 0.15.99.8Joe Shaw2001-10-303-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-29 Joe Shaw <joe@ximian.com> * configure.in: Require gal 0.15.99.8 * addressbook/backend/ebook/e-card-simple.c, addressbook/gui/component/addressbook-storage.c, addressbook/gui/widgets/e-addressbook-view.c, calendar/gui/e-calendar-table.c, calendar/gui/e-itip-control.c, calendar/gui/e-meeting-model.c, calendar/gui/itip-utils.c, calendar/gui/print.c, calendar/gui/alarm-notify/alarm-notify-dialog.c, filter/rule-editor.c, mail/mail-config.c, mail/mail-folder-cache.c, mail/mail-format.c, mail/mail-local.c, mail/mail-ops.c, mail/mail-vfolder.c, shell/e-local-storage.c, shell/e-summary-storage.c: Change includes of e-util/e-unicode-i18n.h to gal/util/e-unicode-i18n.h svn path=/trunk/; revision=14427
* 2001-10-29 Jon Trowbridge <trow@ximian.com.Jon Trowbridge2001-10-303-2/+22
| | | | | | | | | | * gui/widgets/e-minicard.c (add_field): Five characters, not four! * gui/widgets/e-addressbook-table-adapter.c (addressbook_value_at): Convert xml-ified destinations into proper addresses. svn path=/trunk/; revision=14426
* Removed conflict spew.Jon Trowbridge2001-10-301-1/+0
| | | | svn path=/trunk/; revision=14416
* Connect to manager's "ok" signal. (manager_ok_cb): Emit "ok"Jon Trowbridge2001-10-304-21/+61
| | | | | | | | | | | | | | 2001-10-29 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-bonobo.c (init): Connect to manager's "ok" signal. (manager_ok_cb): Emit "ok" bonobo-signal. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_class_init): Added "ok" signal. (e_select_names_clicked): Emit 'ok' signal. svn path=/trunk/; revision=14415
* new function, a "Do you want to save changes?" dialog.Chris Toshok2001-10-305-0/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-29 Chris Toshok <toshok@ximian.com> * gui/widgets/e-addressbook-util.c (e_addressbook_prompt_save_dialog): new function, a "Do you want to save changes?" dialog. * gui/widgets/e-addressbook-util.h: add prototype for e_addressbook_prompt_save_dialog. * gui/contact-editor/e-contact-editor.c (prompt_to_save_changes): call e_addressbook_prompt_save_dialog and save the card if they select save. return TRUE if the dialog should be closed, FALSE otherwise. (file_close_cb): check prompt_to_save_changes before closing the dialog. (app_delete_event_cb): same. * gui/contact-list-editor/e-contact-list-editor.c (prompt_to_save_changes): call e_addressbook_prompt_save_dialog and save the card if they select save. return TRUE if the dialog should be closed, FALSE otherwise. (file_close_cb): check prompt_to_save_changes before closing the dialog. (app_delete_event_cb): same. svn path=/trunk/; revision=14414
* overload this function for modifying objectclasses too, so we can makeChris Toshok2001-10-302-5/+29
| | | | | | | | | | | | | | | | | 2001-10-29 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (add_objectclass_mod): overload this function for modifying objectclasses too, so we can make sure evolutionPerson shows up in the objectclasses of an entry if it shows up in the schema for the server. (create_card_handler): add @replace = FALSE in the call to add_objectclass_mod. (modify_card_handler): call add_objectclass_mod with @replace = TRUE. (anniversary_compare): fix typo - return "equal", not "TRUE". (birthday_compare): same. svn path=/trunk/; revision=14402
* Comment out spew.Jon Trowbridge2001-10-307-8/+22
| | | | | | | | | | | | | | | | | | 2001-10-29 Jon Trowbridge <trow@ximian.com> * conduit/address-conduit.c (pre_sync): Comment out spew. * gui/contact-list-editor/e-contact-list-editor.c (fill_in_info): Comment out spew. * gui/component/addressbook-component.c (destination_folder_handle_drop): Comment out spew. (get_dnd_selection): Comment out spew. * gui/widgets/e-addressbook-table-adapter.c (addressbook_set_value_at): Comment out spew. svn path=/trunk/; revision=14401
* Check that our BonoboUIComponent has a container so we don't get a lot ofJon Trowbridge2001-10-307-72/+93
| | | | | | | | | | | | | | | | | | | | | | 2001-10-29 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (update_command_state): Check that our BonoboUIComponent has a container so we don't get a lot of annoying debug spew. * printing/smallbook.ecps: Fixed fonts. * printing/phonelist.ecps: Fixed fonts. * printing/medbook.ecps: Fixed fonts. * printing/e-contact-print.c (e_contact_get_card_size): Commented out spew. * gui/widgets/e-minicard.c (remodel): Check that e_minicard->card != NULL. svn path=/trunk/; revision=14391
* We were using book_data->book_view immediately after unrefing it.Jon Trowbridge2001-10-302-3/+15
| | | | | | | | | | | 2001-10-29 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_destroy): We were using book_data->book_view immediately after unrefing it. Reordered the code a bit to avoid this. svn path=/trunk/; revision=14382
* add prototype for pas_book_factory_dump_active_backends.Chris Toshok2001-10-303-1/+35
| | | | | | | | | | | | | 2001-10-29 Chris Toshok <toshok@ximian.com> * backend/pas/pas-book-factory.h: add prototype for pas_book_factory_dump_active_backends. * backend/pas/pas-book-factory.c (pas_book_factory_dump_active_backends): new function. (dump_active_server_map_entry): new function. svn path=/trunk/; revision=14371
* Drop a match if either of the text fields is NULL. This could happen ifJon Trowbridge2001-10-302-0/+14
| | | | | | | | | | | 2001-10-29 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (make_match): Drop a match if either of the text fields is NULL. This could happen if any of the utf-8 involved is invalid, for example. (Bug #13757) svn path=/trunk/; revision=14365
* fix bug that allowed for phone's not to be in priority order and the itemJP Rosevear2001-10-303-53/+43
| | | | | | | | | | | | | 2001-10-29 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (is_syncable): fix bug that allowed for phone's not to be in priority order and the item to still be syncable * conduit/address-conduit-config.h (addrconduit_load_configuration): get management by id svn path=/trunk/; revision=14350
* a card also needs to have its phone nums in priority order to beJP Rosevear2001-10-302-1/+30
| | | | | | | | | 2001-10-29 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (is_syncable): a card also needs to have its phone nums in priority order to be "syncable" svn path=/trunk/; revision=14344
* move the syncable checking code to a different functionJP Rosevear2001-10-292-86/+116
| | | | | | | | | | | 2001-10-29 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (is_syncable): move the syncable checking code to a different function (ecard_from_remote_record): set the name parts individually (local_record_from_ecard): use is_syncable svn path=/trunk/; revision=14343
* Use the actual ECardName in the ECard instead of parsing the full_nameChristopher James Lahey2001-10-292-14/+13
| | | | | | | | | | 2001-10-29 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (file_as_get_style, file_as_set_style): Use the actual ECardName in the ECard instead of parsing the full_name here. svn path=/trunk/; revision=14338
* New function to set the ECardName on this card and fix the file_as ifChristopher James Lahey2001-10-293-0/+19
| | | | | | | | | | 2001-10-29 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h (e_card_simple_set_name): New function to set the ECardName on this card and fix the file_as if necessary. svn path=/trunk/; revision=14337
* Handle returning dates here. (e_card_simple_get_allow_newlines): NewChristopher James Lahey2001-10-298-6/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-29 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h (e_card_simple_get): Handle returning dates here. (e_card_simple_get_allow_newlines): New function. Returns whether it makes much sense to have newlines in this string. * gui/component/addressbook-config.c, gui/component/addressbook-config.h (addressbook_create_new_source): The first argument here should be const. * gui/component/addressbook-storage.c: Added #include "addressbook-config.h". * gui/widgets/e-minicard-label.c (e_minicard_label_event): On an escape here, cancel editing and remove the focus from the text. * gui/widgets/e-minicard.c (add_field): Set allow_newlines here. (field_activated): Stop editing on the activate signal and remove the focus from the text. Fixes Ximian bug #12286. svn path=/trunk/; revision=14335
* tidyJP Rosevear2001-10-294-2/+12
| | | | | | | | | | | | 2001-10-28 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.h: tidy * conduit/address-conduit-config.h: ditto * conduit/address-conduit.c (add_record): unref ecard when done svn path=/trunk/; revision=14317
* Expose this function. (e_card_date_to_string): ...and this one. FixesJon Trowbridge2001-10-283-4/+14
| | | | | | | | | | | 2001-10-28 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_date_from_string): Expose this function. (e_card_date_to_string): ...and this one. Fixes build problem in pas-backend-ldap.c. svn path=/trunk/; revision=14284
* Change "this should never happen" dialog to not give my name/e-mail. SorryJon Trowbridge2001-10-283-1/+18
| | | | | | | | | | | | | | 2001-10-28 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listeners): Change "this should never happen" dialog to not give my name/e-mail. Sorry translators. But this really should never happen, thanks to my fix below. * gui/component/addressbook-component.c: Initialize global_shell_client to NULL. (Bug #6625) svn path=/trunk/; revision=14282
* [ bug #12979 ] new function. (anniversary_ber): new function.Chris Toshok2001-10-282-19/+172
| | | | | | | | | | | | | | | 2001-10-27 Chris Toshok <toshok@ximian.com> [ bug #12979 ] * backend/pas/pas-backend-ldap.c (anniversary_populate): new function. (anniversary_ber): new function. (anniversary_compare): new function. (birthday_populate): new function. (birthday_ber): new function. (birthday_compare): new function. svn path=/trunk/; revision=14277
* free up all the book_data list stuff.Chris Toshok2001-10-284-90/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-27 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_destroy): free up all the book_data list stuff. (e_select_names_completion_got_book_view_cb): deal with book_data being passed as the closure, and increment the pending_completion_seq counter. (e_select_names_completion_card_added_cb): deal with book_data being passwd as the closure. (e_select_names_completion_seq_complete_cb): same, and decrement the pending_completion_seq if we haven't gotten one for this book view before. (e_select_names_completion_stop_query): cancel all the book_data's. (e_select_names_completion_start_query): use the books_not_ready counter instead of book_ready. also, do e_book_get_book_view on each of the book's in our list. (e_select_names_completion_do_query): change to deal with our list. (e_select_names_completion_book_ready): decrement the book_not_ready counter. (e_select_names_completion_new): add the book we're created with to our list. (e_select_names_completion_add_book): implement. * gui/component/select-names/e-select-names-completion.h: add prototype for e_select_names_completion_add_book. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): use addressbook_config_data, and don't unref the db. (e_select_names_manager_create_entry): always add NULL for a book (which corresponds to the local book), and if the completion_book is present, add it to the list of books to complete again. svn path=/trunk/; revision=14270
* change to EBookCallback signature, and unref the book.Chris Toshok2001-10-282-5/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-27 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-quick-add.c (merge_cb): change to EBookCallback signature, and unref the book. (quick_add_merge_card): use addressbook_load_default_book. (ce_have_book): change to EBookCallback signature, and unref the book. (edit_card): use addressbook_load_default_book. * gui/component/e-address-popup.c (email_table_save_card_cb): change to EBookCallback signature, and unref the book. (add_card_idle_cb): use addressbook_load_default_book, and call the cb if it fails. (e_address_popup_cleanup): fix type -- should be "pop->card = NULL", not "pop = NULL". (contact_editor_cb): change to EBookCallback signature. (edit_contact_info_cb): use addressbook_load_default_book. (start_query): change to EBookCallback signature. (e_address_popup_query): use addressbook_load_default_book. * gui/widgets/e-minicard-control.c (book_open_cb): change to EBookCallback signature, and unref the book. (save_in_addressbook): use addressbook_load_default_book instead of e_book_use_local_address_book. * gui/widgets/Makefile.am (INCLUDES): change includes since we're including addressbook.h which has it's own set of funky include path requirements. svn path=/trunk/; revision=14269
* change to EBookCallback signature, and unref the book. (add_card_idle_cb):Chris Toshok2001-10-284-10/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-27 Chris Toshok <toshok@ximian.com> * gui/component/e-address-popup.c (email_table_save_card_cb): change to EBookCallback signature, and unref the book. (add_card_idle_cb): use addressbook_load_default_book, and call the cb if it fails. (e_address_popup_cleanup): fix type -- should be "pop->card = NULL", not "pop = NULL". (contact_editor_cb): change to EBookCallback signature. (edit_contact_info_cb): use addressbook_load_default_book. (start_query): change to EBookCallback signature. (e_address_popup_query): use addressbook_load_default_book. * gui/widgets/e-minicard-control.c (book_open_cb): change to EBookCallback signature, and unref the book. (save_in_addressbook): use addressbook_load_default_book instead of e_book_use_local_address_book. * gui/widgets/Makefile.am (INCLUDES): change includes since we're including addressbook.h which has it's own set of funky include path requirements. svn path=/trunk/; revision=14268
* Don't leak stuff. (Bug #13709)Jon Trowbridge2001-10-282-10/+20
| | | | | | | | | 2001-10-27 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): Don't leak stuff. (Bug #13709) svn path=/trunk/; revision=14267
* Fix the address of the FSF in the licensing comments.Ettore Perazzoli2001-10-281-3/+4
| | | | svn path=/trunk/; revision=14243
* Set book_uri when cardification occurs.Christopher James Lahey2001-10-282-13/+32
| | | | | | | | | 2001-10-27 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-destination.c (name_and_email_simple_query_cb, nickname_simple_query_cb): Set book_uri when cardification occurs. svn path=/trunk/; revision=14230
* Bumped required version of gal to 0.15.99.6.Christopher James Lahey2001-10-282-2/+8
| | | | | | | | | | | | | | | | 2001-10-27 Christopher James Lahey <clahey@ximian.com> * configure.in: Bumped required version of gal to 0.15.99.6. From addressbook/ChangeLog: 2001-10-27 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_add_section): Turned off use_ellipsis (it breaks emulate_label_resize) and on emulate_label_resize. svn path=/trunk/; revision=14228
* Doh! We should be sorting our contacts so that the most frequently usedJon Trowbridge2001-10-282-2/+10
| | | | | | | | | | | 2001-10-27 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (make_match): Doh! We should be sorting our contacts so that the most frequently used ones are at the top of the list, not the bottom. svn path=/trunk/; revision=14223
* oops, left a collision marker inJon Trowbridge2001-10-281-1/+0
| | | | svn path=/trunk/; revision=14219
* That should be a bonobo_object_unref, not a gtk_object_unref.Jon Trowbridge2001-10-282-2/+24
| | | | | | | | | | | | | | | 2001-10-27 Jon Trowbridge <trow@gnu.org> * backend/pas/pas-book.c (pas_book_check_queue): That should be a bonobo_object_unref, not a gtk_object_unref. (pas_book_queue_request): Likewise, we need to bonobo_object_ref here. (pas_book_destroy): If our pas_book_check_queue timeout is still active, disable it. This should never happen, but it never hurts to be careful. (pas_book_destroy): Set book->priv to NULL after we free it. svn path=/trunk/; revision=14218
* Fixing the license text.Ettore Perazzoli2001-10-289-49/+62
| | | | svn path=/trunk/; revision=14214
* copy phone labels and show phone as well, clear correct entry text andJP Rosevear2001-10-282-20/+16
| | | | | | | | | | 2001-10-27 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): copy phone labels and show phone as well, clear correct entry text and correctly detect unsyncable cases svn path=/trunk/; revision=14213
* Fixing the license text.Ettore Perazzoli2001-10-2863-63/+0
| | | | svn path=/trunk/; revision=14211
* touch the record on lookup (check_for_slow_setting): write touched only ifJP Rosevear2001-10-272-5/+16
| | | | | | | | | | | | | 2001-10-27 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): touch the record on lookup (check_for_slow_setting): write touched only if we are doing a slow sync (card_removed): don't touch on lookup (match): touch on lookup svn path=/trunk/; revision=14209
* Added paranoid reentrancy guards. (pas_book_queue_request): Changed ourJon Trowbridge2001-10-272-5/+25
| | | | | | | | | | | | 2001-10-27 Jon Trowbridge <trow@ximian.com> * backend/pas/pas-book.c (pas_book_check_queue): Added paranoid reentrancy guards. (pas_book_queue_request): Changed our idle handler into a timeout, so as to work w/ reentrancy guards. (pas_book_init): Explicit initialization. svn path=/trunk/; revision=14202
* add prototypes for addressbook_config_database, andChris Toshok2001-10-273-0/+60
| | | | | | | | | | | | | | | 2001-10-26 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.h: add prototypes for addressbook_config_database, and addressbook_load_default_book. * gui/component/addressbook.c (addressbook_config_database): new function, so we aren't activating the db everywhere we need to use it. (addressbook_load_default_book): load the default book, after getting the uri from bonobo-config. svn path=/trunk/; revision=14200
* Return on cancellation. (simple_query_sequence_complete_cb): Act if notJon Trowbridge2001-10-273-16/+70
| | | | | | | | | | | | | | | | | | | | | | 2001-10-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-util.c (simple_query_card_added_cb): Return on cancellation. (simple_query_sequence_complete_cb): Act if not cancelled. (simple_query_book_view_cb): Free & return on cancellation. (e_book_simple_query_cancel): Set cancellation flag. * gui/component/e-address-popup.c (e_address_popup_query): Hold a reference to ourselves for the duration of our addressbook fetch. (start_query): Release when we've fetched our addressbook. (e_address_popup_cleanup): Break out most of what we do in _destroy into a separate function. (e_address_popup_destroy): Class cleanup. (contact_editor_cb): Paranoid clean-up. (add_contacts_cb): Paranoid clean-up. (e_address_popup_ambiguous_email_add): Paranoid clean-up. svn path=/trunk/; revision=14199
* remove the merges as valid sync typesJP Rosevear2001-10-274-6/+28
| | | | | | | | | | | | | | | 2001-10-26 JP Rosevear <jpr@ximian.com> * conduit/e-address.conduit.in: remove the merges as valid sync types * conduit/address-conduit.c (pre_sync): write out only the touched records if we are doing copies * conduit/address-conduit-config.h (addrconduit_load_configuration): get the sync type svn path=/trunk/; revision=14197
* Oops... forgot to commit before.Jon Trowbridge2001-10-271-0/+2
| | | | svn path=/trunk/; revision=14195
* Cancel any pending queries.Jon Trowbridge2001-10-272-0/+15
| | | | | | | | | 2001-10-26 Jon Trowbridge <trow@ximian.com> * gui/component/e-address-popup.c (e_address_popup_destroy): Cancel any pending queries. svn path=/trunk/; revision=14194
* Update the licensing information to require version 2 of the GPLEttore Perazzoli2001-10-2763-126/+126
| | | | | | explicitly. svn path=/trunk/; revision=14188
* Don't assert, but check if ce->app != NULL, since this function canJon Trowbridge2001-10-272-6/+9
| | | | | | | | | | 2001-10-26 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-editor.c (close_dialog): Don't assert, but check if ce->app != NULL, since this function can (apparently) get called multiple times. svn path=/trunk/; revision=14162
* Remove bad dialog ref-counting crap.Jon Trowbridge2001-10-273-7/+21
| | | | | | | | | | | | | | | | | 2001-10-26 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-save-as.c (file_exists): Remove bad dialog ref-counting crap. * gui/contact-editor/e-contact-editor.c (save_card): Ref our EContactEditor, since we are holding a pointer to it in EditorCloseStruct. (card_modified_cb): Unref our EContactEditor when we free our EditorCloseStruct. (card_added_cb): Unref our EContactEditor when we free our EditorCloseStruct. svn path=/trunk/; revision=14157
* make debug info more accurateJP Rosevear2001-10-272-10/+13
| | | | | | | | | 2001-10-26 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (check_for_slow_setting): make debug info more accurate svn path=/trunk/; revision=14153
* prevent double unref (cursor_cb): correct typo (card_removed): remove theJP Rosevear2001-10-272-11/+22
| | | | | | | | | | | | 001-10-26 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (e_addr_context_destroy): prevent double unref (cursor_cb): correct typo (card_removed): remove the card from the map if was archived and is now deleted svn path=/trunk/; revision=14150
* new memberJP Rosevear2001-10-263-31/+132
| | | | | | | | | | | | | | | | | | | | | | | 2001-10-26 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.h: new member * conduit/address-conduit.c (print_remote): free the struct after using it (e_addr_context_new): make consistent with other conduits (e_addr_context_destroy): properly destroy the context (cursor_cb): no need to ref the card, its done for us (clear_entry_text): util function to free a field (free_local): free a local record (local_record_to_pilot_record): use a static buffer so we don't have to free it later (local_record_from_ecard): only fill in the fields we might not sync, clear a field before replacing the contents (for_each): track locals (for_each_modified): ditto (free_match): use free_local svn path=/trunk/; revision=14138
* Added has_cursor argument. Setting the argument to TRUE if the minicardChristopher James Lahey2001-10-263-16/+51
| | | | | | | | | | | 2001-10-26 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard.c, gui/widgets/e-minicard.h (set_has_cursor): Added has_cursor argument. Setting the argument to TRUE if the minicard doesn't have focus will grab the focus. Fixes Ximian bug #3024. svn path=/trunk/; revision=14137
* Initialize gnome-vfs.Jon Trowbridge2001-10-254-12/+134
| | | | | | | | | | | | | 2001-10-24 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook-factory.c (main): Initialize gnome-vfs. * gui/component/addressbook-component.c (xfer_file): Added. (Copied from the calendar.) (xfer_folder): Fixed to allow renaming of contact folders. svn path=/trunk/; revision=14080
* Removed key_press handler here since delete and backspace are now handledChristopher James Lahey2001-10-242-27/+6
| | | | | | | | | | 2001-10-24 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (e_addressbook_view_class_init): Removed key_press handler here since delete and backspace are now handled by keybindings. svn path=/trunk/; revision=13981
* Fix command paths when we specify our pixmaps, so we don't get a lot ofJon Trowbridge2001-10-243-5/+16
| | | | | | | | | | | | | 2001-10-23 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c: Fix command paths when we specify our pixmaps, so we don't get a lot of totally useless & very ugly bonobo-ui spew. * backend/ebook/e-book-util.c (e_book_nickname_query): The empty string as an arg shouldn't generate a warning. svn path=/trunk/; revision=13973
* Removed our cancelled flag and e_select_names_completion_cancel function,Jon Trowbridge2001-10-242-39/+75
| | | | | | | | | | | | | | | | | | | | | 2001-10-23 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c: Removed our cancelled flag and e_select_names_completion_cancel function, since we were just duplicating stuff that had ended up in ECompletion. (match_name): Form our menu_text properly on an additional-name match. (e_select_names_completion_got_book_view_cb): Store handles for our signals, disconnect them properly when we switch book views. (e_select_names_completion_stop_query): Disconnect signals when we stop our query. (check_capabilities): Spew if we are using LDAP for completion. (e_select_names_completion_destroy): Disconnect our signals when we destroy. This all should fix bug #10241. svn path=/trunk/; revision=13961
* Bumped required GAL to 0.15.99.3 so EEntry's "draw_button" argument can beChristopher James Lahey2001-10-232-0/+7
| | | | | | | | | | | | | | | | | | 2001-10-23 Christopher James Lahey <clahey@ximian.com> * configure.in: Bumped required GAL to 0.15.99.3 so EEntry's "draw_button" argument can be used in addressbook/gui/component/select-names/e-select-names.c. From addressbook/ChangeLog: 2001-10-23 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_add_section): Set "draw_button" argument to TRUE on this EEntry. svn path=/trunk/; revision=13935
* Put up an error dialog if there's an error while saving. If the personChristopher James Lahey2001-10-222-1/+26
| | | | | | | | | | | 2001-10-22 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-save-as.c (save_it): Put up an error dialog if there's an error while saving. If the person hits cancel on the "file exists" dialog, don't close the file selection dialog. Fixes Ximian bug #7055. svn path=/trunk/; revision=13865
* right_click_up here when we let go of the popup.Christopher James Lahey2001-10-213-0/+9
| | | | | | | | | | | | | 2001-10-21 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (model_and_selection_free): right_click_up here when we let go of the popup. * gui/widgets/e-minicard-view.c (e_minicard_view_selection_event): right_click_up here. svn path=/trunk/; revision=13843
* Use an EEntry here instead of a GtkLabel. Fixes Ximian bug #7067.Christopher James Lahey2001-10-212-33/+29
| | | | | | | | | | 2001-10-21 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_add_section, e_select_names_set_default): Use an EEntry here instead of a GtkLabel. Fixes Ximian bug #7067. svn path=/trunk/; revision=13841
* Call e_addressbook_model_force_folder_bar_message when we activate theJon Trowbridge2001-10-214-2/+24
| | | | | | | | | | | | | | 2001-10-21 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (control_activate_cb): Call e_addressbook_model_force_folder_bar_message when we activate the component. (Fixes bug #11749) * gui/widgets/e-addressbook-model.c (e_addressbook_model_force_folder_bar_message): Added. Forces emission of a folder_bar_message. svn path=/trunk/; revision=13840
* (e_select_names_set_default): don't forget to unref the oldstyle.Larry Ewing2001-10-212-1/+2
| | | | | | | | 2001-10-20 Larry Ewing <lewing@ximian.com> (e_select_names_set_default): don't forget to unref the oldstyle. svn path=/trunk/; revision=13839
* stick with the style font if the efont bold font does not exist.Larry Ewing2001-10-212-8/+24
| | | | | | | | | | 2001-10-20 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_set_default): stick with the style font if the efont bold font does not exist. svn path=/trunk/; revision=13838
* Fix memory leak.Jon Trowbridge2001-10-215-1/+21
| | | | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (name_style_query): Fix memory leak. * gui/widgets/e-addressbook-view.c (jump_to_letter): Free our string vector letter_v when we are done with it. * gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our QuickAdd structure. * gui/component/e-address-popup.c (e_address_popup_construct): Unref our style after we are done with it. svn path=/trunk/; revision=13835
* We shouldn't leak the info returned by oaf_query.Jon Trowbridge2001-10-214-2/+17
| | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): We shouldn't leak the info returned by oaf_query. * gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove superfluous call to quick_add_unref. (editor_closed_cb): Remove superfluous call to quick_add_unref. * gui/component/select-names/e-select-names.c (esn_get_key_fn): We need to unref the card returned by e_addressbook_model_get_card. svn path=/trunk/; revision=13834
* Make LDAP servers non-user-creatable.Ettore Perazzoli2001-10-212-1/+6
| | | | | | | * gui/component/addressbook-component.c: Make LDAP servers non-user-creatable. svn path=/trunk/; revision=13833
* Check that the string we are checking for xml-ness is non-NULL.Jon Trowbridge2001-10-212-1/+4
| | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * printing/e-contact-print.c (e_contact_print_card): Check that the string we are checking for xml-ness is non-NULL. svn path=/trunk/; revision=13830
* Filter out empty destinations. (also Bug #13036)Jon Trowbridge2001-10-214-12/+58
| | | | | | | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_importv): Filter out empty destinations. (also Bug #13036) * printing/e-contact-print.c (e_contact_build_style): Use gnome_font_new_closest; if gnome_font_new fails and returns NULL, our spacing gets all messed up. (Bug #10785) * gui/widgets/e-addressbook-view.c (e_addressbook_view_can_print): Allow printing if there are any cards in our view. The selection has nothing to do with it. * backend/ebook/e-destination.c (e_destination_is_empty): Check for strings that contain non-whitespace, rather than just looking for a non-zero first character. (Bug #13036) svn path=/trunk/; revision=13826
* Handle focus_change in event by selecting that contact. Fixes Ximian bugChristopher James Lahey2001-10-212-0/+17
| | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard-view.c (e_minicard_view_selection_event): Handle focus_change in event by selecting that contact. Fixes Ximian bug #3024. svn path=/trunk/; revision=13825
* Repeatedly call gtk_main_quit here as long as there is a main loop around.Christopher James Lahey2001-10-202-2/+16
| | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c (owner_unset_cb): Repeatedly call gtk_main_quit here as long as there is a main loop around. This is an ugly hack around Ximian bug #11760. svn path=/trunk/; revision=13821
* Added #include <gal/widgets/e-unicode.h>.Christopher James Lahey2001-10-203-62/+101
| | | | | | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c: Added #include <gal/widgets/e-unicode.h>. * gui/widgets/e-minicard-control.c: Made this display the number of extra cards in the attachment as well as made it save them all to the local addressbook if the person selects the button. Fixes Ximian bug #9507. svn path=/trunk/; revision=13820
* Changed this to not grab on a right click. Fixes Ximian bug #12660.Christopher James Lahey2001-10-202-1/+10
| | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): Changed this to not grab on a right click. Fixes Ximian bug #12660. svn path=/trunk/; revision=13818
* Pass the @folder_type to ::handleDrop.Ettore Perazzoli2001-10-202-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * e-storage-set-view.c (tree_drag_data_received): Pass the @folder_type to ::handleDrop. * evolution-shell-component-dnd.c (impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleMotion): New arg @folder_type. (impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleDrop): Likewise. * evolution-shell-component-dnd.h: Add @folder_type to `DndDestinationFolderHandleDropFn' and `DndDestinationFolderHandleMotionFn'. * e-storage-set-view.c (tree_drag_motion): Pass the folder type to `::handleMotion'. * Evolution-ShellComponentDnd.idl: Pass @folder_type in ::handleDrop and ::handleMotion. * component-factory.c (destination_folder_handle_motion): Get @folder_type here too [to match the changes in the EvolutionShellComponentDnd interface]. Also, remove a debugging message. (destination_folder_handle_drop): Likewise. * gui/component/addressbook-component.c (destination_folder_handle_motion): Get @folder_type here too [to match the changes in the EvolutionShellComponentDnd interface]. Also, remove a debugging message. (destination_folder_handle_drop): Likewise. svn path=/trunk/; revision=13807
* Translate labels in select-names option menu. (Bug #9604)Jon Trowbridge2001-10-203-2/+15
| | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (add_menu_item): Translate labels in select-names option menu. (Bug #9604) * gui/search/e-addressbook-search-dialog.c (e_addressbook_search_dialog_init): Made the default window size slightly wider. (Bug #7516) svn path=/trunk/; revision=13795
* Made this take a const GList.Christopher James Lahey2001-10-193-4/+9
| | | | | | | | | 2001-10-18 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c, backend/ebook/e-card.h (e_card_list_get_vcard): Made this take a const GList. svn path=/trunk/; revision=13773
* Added. Check if our book is local or networked.Jon Trowbridge2001-10-192-0/+25
| | | | | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (check_capabilities): Added. Check if our book is local or networked. (e_select_names_completion_book_ready): Call check_capabilities. (e_select_names_completion_new): Call check_capabilities. (e_select_names_completion_do_query): If we have a networked book, keep trying if we haven't been able to cache any cards --- our earlier attempts could have failed due to too many matches. (Bug #12932) svn path=/trunk/; revision=13762
* Lag our cardification on focus-out. This seems to help with the unintendedJon Trowbridge2001-10-193-5/+11
| | | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (focus_out_cb): Lag our cardification on focus-out. This seems to help with the unintended cardifications that can result from the weird focus-out/focus-in events that get generated when the popup disappears. * backend/ebook/e-card-compare.c: Removed some debug spew. svn path=/trunk/; revision=13757
* grab focus in the Account entry when preparing the dialog, fixes #10406.Chris Toshok2001-10-182-0/+10
| | | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.c (addressbook_source_dialog): grab focus in the Account entry when preparing the dialog, fixes #10406. svn path=/trunk/; revision=13734
* make sure to also add "ldap-contacts" folders to the option menu.Chris Toshok2001-10-182-1/+7
| | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names.c (new_folder): make sure to also add "ldap-contacts" folders to the option menu. svn path=/trunk/; revision=13733
* sync all the fields we can, with out overwritingJP Rosevear2001-10-182-110/+369
| | | | | | | | | | | | 2001-10-17 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): sync all the fields we can, with out overwriting (local_record_from_ecard): write the fields to the pilot in priority order unless there are fields on the pilot we can't store, then fill in the fields as they are on the pilot svn path=/trunk/; revision=13728
* Did a bit of clean up here. Might fix some crashes, specifically XimianChristopher James Lahey2001-10-173-47/+57
| | | | | | | | | | | | 2001-10-17 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c (e_card_get_vobject): Did a bit of clean up here. Might fix some crashes, specifically Ximian bug #10164. * gui/widgets/e-addressbook-view.c (SPEC): Updated the model column numbers here. Fixes Ximian bug #12308. svn path=/trunk/; revision=13721
* add upgrade from 0.1 to 0.2, where we make sure id dbt's match vcard id's,Chris Toshok2001-10-172-29/+104
| | | | | | | | | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_upgrade_db): add upgrade from 0.1 to 0.2, where we make sure id dbt's match vcard id's, fixes longstanding bug (#7406) where cards were not modifiable or removable after having been created during a 1-2 week long window in early betas. (PAS_BACKEND_FILE_VERSION): change to 0.2 (PAS_ID_PREFIX): #define this here. (pas_backend_file_create_unique_id): use PAS_ID_PREFIX instead of the string. svn path=/trunk/; revision=13720
* Check for no extensionIain Holmes2001-10-172-0/+9
| | | | svn path=/trunk/; revision=13710
* If card->id is NULL, return an empty string. (e_card_set_id): Don't allowJon Trowbridge2001-10-172-3/+12
| | | | | | | | | | | | | 2001-10-16 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_get_id): If card->id is NULL, return an empty string. (e_card_set_id): Don't allow the card id to be set to NULL; use the empty string instead. (e_card_get_vobject): When building our vcard, pass in the empty string as the id if card->id is NULL. (Bug #10164) svn path=/trunk/; revision=13705
* don't set the phone info if it is blank (ecard_from_remote_record): saveJP Rosevear2001-10-172-10/+29
| | | | | | | | | | 2001-10-16 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): don't set the phone info if it is blank (ecard_from_remote_record): save up to 3 fax numbers svn path=/trunk/; revision=13694
* unref the book after we pass it off to evolution-addressbook.Chris Toshok2001-10-162-0/+23
| | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client): unref the book after we pass it off to evolution-addressbook. svn path=/trunk/; revision=13691
* unref op->view. (pas_backend_ldap_process_create_card): ref op->view.Chris Toshok2001-10-162-3/+39
| | | | | | | | | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (create_card_dtor): unref op->view. (pas_backend_ldap_process_create_card): ref op->view. (remove_card_dtor): unref op->view. (pas_backend_ldap_process_remove_card): ref op->view. (modify_card_dtor): unref op->view. (pas_backend_ldap_process_modify_card): ref op->view. (ldap_search_dtor): unref op->view. (pas_backend_ldap_search): ref op->view. svn path=/trunk/; revision=13690
* make sure to unref the book_view here so we don't leak them.Chris Toshok2001-10-162-1/+15
| | | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_get_book_view): make sure to unref the book_view here so we don't leak them. svn path=/trunk/; revision=13680
* Properly decide whether a property needs to be marked as QP by searchingChristopher James Lahey2001-10-152-9/+106
| | | | | | | | | | 2001-10-15 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c (addPropValueQP, addPropValueSets, e_card_get_vobject): Properly decide whether a property needs to be marked as QP by searching for '\n'. Fixes Ximian bug #3021. svn path=/trunk/; revision=13675
* Set the default file name here. Fixes Ximian bug #7053.Christopher James Lahey2001-10-152-4/+61
| | | | | | | | | | 2001-10-15 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-save-as.c (e_contact_save_as, e_contact_list_save_as): Set the default file name here. Fixes Ximian bug #7053. svn path=/trunk/; revision=13674
* Added linebreaks to our "this shouldn't happen" dialog message. (BugJon Trowbridge2001-10-152-5/+12
| | | | | | | | | | 2001-10-14 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listeners): Added linebreaks to our "this shouldn't happen" dialog message. (Bug #12498)CVS: ---------------------------------------------------------------------- svn path=/trunk/; revision=13668
* Add a component name to the e_passwords_init() call.Jon Trowbridge2001-10-132-1/+6
| | | | | | | | | 2001-10-12 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook-factory.c (main): Add a component name to the e_passwords_init() call. svn path=/trunk/; revision=13644
* commit the importer originally from Michael M. Morrison, with fixups byChris Toshok2001-10-137-4/+699
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-12 Chris Toshok <toshok@ximian.com> * backend/ebook/evolution-ldif-importer.c: commit the importer originally from Michael M. Morrison, with fixups by toshok. * backend/ebook/Makefile.am (bin_PROGRAMS): add evolution-ldif-importer. (oaf_in_files): add GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in. * backend/ebook/e-card-simple.h: add WANTS_HTML and IS_LIST. * backend/ebook/e-card-simple.c (field_data): add WANTS_HTML and IS_LIST. (e_card_simple_set): fix typo. * backend/ebook/.cvsignore: ignore GNOME_Evolution_Addressbook_LDIF_Importer.oaf and evolution-ldif-importer. * backend/ebook/GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in: ldif importer oafinfo. svn path=/trunk/; revision=13627
* Added a boolean type here.Christopher James Lahey2001-10-133-0/+35
| | | | | | | | | 2001-10-12 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h: Added a boolean type here. svn path=/trunk/; revision=13624
* Check to see if the uri we are setting is the same as the current uri. IfJon Trowbridge2001-10-122-0/+16
| | | | | | | | | | | 2001-10-12 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (addressbook_model_set_uri): Check to see if the uri we are setting is the same as the current uri. If so, do nothing. (Bug #11324) svn path=/trunk/; revision=13620
* On second thought, that should be a less-than-or-equal... :)Jon Trowbridge2001-10-121-1/+1
| | | | svn path=/trunk/; revision=13612
* Added. Heuristic for whether or not we want to revert to an earlierJon Trowbridge2001-10-122-6/+46
| | | | | | | | | | | | 2001-10-11 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_reverting_is_a_good_idea): Added. Heuristic for whether or not we want to revert to an earlier cardified state. (e_destination_cardify): Don't be quite as aggressive about reverting to previous cardified states. (Bug #11890) svn path=/trunk/; revision=13610
* Changed these to use the new ref and unref functions for ECard auxillaryChristopher James Lahey2001-10-1214-164/+258
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-11 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_destroy, fill_in_info, e_card_simple_sync_card, e_card_simple_set_phone, e_card_simple_set_address, e_card_simple_set_delivery_address, file_as_get_style, file_as_set_style, e_card_simple_set, e_card_simple_set_arbitrary), gui/contact-editor/e-contact-editor-address.c (e_contact_editor_address_destroy, e_contact_editor_address_set_arg, e_contact_editor_address_get_arg), gui/contact-editor/e-contact-editor-fullname.c (e_contact_editor_fullname_destroy, e_contact_editor_fullname_set_arg, e_contact_editor_fullname_get_arg), gui/contact-editor/e-contact-editor.c (phone_entry_changed, address_text_changed, name_entry_changed, full_name_clicked, full_addr_clicked, fill_in_info): Changed these to use the new ref and unref functions for ECard auxillary types. * backend/ebook/e-card-simple.h: Added a comment. * backend/ebook/e-card-types.h: Added ref_count field to all the types. * backend/ebook/e-card.c, backend/ebook/e-card.h: Added ref and unref functions here for all the ECard auxillary types. Removed the corresponding free functions. Switched to using these functions where appropriate. * gui/component/addressbook-factory.c: #include <e-util/e-passwords.h> * gui/component/addressbook.c (load_uri_cb): const correctify. * gui/component/select-names/e-select-names-manager.c, gui/component/select-names/e-select-names.c: #include <addressbook/gui/component/addressbook.h> * gui/widgets/e-addressbook-model.c (modify_card): Removed an unnecessary ref here. svn path=/trunk/; revision=13604
* Don't need this any more.Dan Winship2001-10-122-16/+5
| | | | | | | * gui/component/select-names/e-select-names.c (update_folder): Don't need this any more. svn path=/trunk/; revision=13590
* Check that view->view != NULL. (save_contact_cb): Check that view->view !=Jon Trowbridge2001-10-116-55/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-11 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (new_contact_cb): Check that view->view != NULL. (save_contact_cb): Check that view->view != NULL. (search_cb): Check that view->view != NULL. (delete_contact_cb): Check that view->view != NULL. (print_cb): Check that view->view != NULL. (print_preview_cb): Check that view->view != NULL. (stop_loading_cb): Check that view->view != NULL. (cut_contacts_cb): Check that view->view != NULL. (copy_contacts_cb): Check that view->view != NULL. (paste_contacts_cb): Check that view->view != NULL. (select_all_contacts_cb): Check that view->view != NULL. (send_contact_cb): Check that view->view != NULL. (send_contact_to_cb): Check that view->view != NULL. (update_command_state): Check that view->view != NULL. Hold a reference to the AddressbookView for the duration of the function, in case we exit during bonobo-reentrancy. (addressbook_view_ref): Added. (addressbook_view_unref): Added. Simple ref counting for AddressbookView objects. (addressbook_view_clear): Zero out an AddressbookView. This is now separated from the deallocation of the AddressbookView object, so that we don't leave a dangling pointer if we exit during bonobo-reentrancy in update_command_state. (Which often seems to happen if we exit while addressbook operations are going on.) (destroy_callback): Replace previous call to addressbook_view_free with addressbook_view_clear/addressbook_view_unref calls. (addressbook_factory_new_control): Initialize the reference count in the AddressbookView object. * gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy): Carefully zero out our destroyed object. (command_state_change): Hold a reference to ourselves during the signal emission. (get_selected_cards): Ref cards as we add them to the list. (e_addressbook_view_stop): Check for view != NULL. (e_addressbook_view_can_create): Check for view != NULL. (e_addressbook_view_can_print): Check for view != NULL. (e_addressbook_view_can_save_as): Check for view != NULL. (e_addressbook_view_can_send): Check for view != NULL. (e_addressbook_view_can_send_to): Check for view != NULL. (e_addressbook_view_can_delete): Check for view != NULL. (e_addressbook_view_can_cut): Check for view != NULL. (e_addressbook_view_can_copy): Check for view != NULL. (e_addressbook_view_can_paste): Check for view != NULL. (e_addressbook_view_can_select_all): Check for view != NULL. (e_addressbook_view_can_stop): Check for view != NULL. * gui/widgets/e-addressbook-model.c (addressbook_destroy): Be careful about zeroing out our destroyed object. * backend/ebook/e-book-view.c (e_book_view_stop): Added. Stops event processing in the underlying listener. svn path=/trunk/; revision=13578
* If our select names dialog is still around, destroy it. Otherwise, theJon Trowbridge2001-10-112-2/+7
| | | | | | | | | | | 2001-10-10 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_destroy): If our select names dialog is still around, destroy it. Otherwise, the dialog will hang around after our composer goes away. svn path=/trunk/; revision=13565
* Added "Palestinian territory" to the country listYuri Syrota2001-10-091-0/+1
| | | | svn path=/trunk/; revision=13514
* add an Email Address field/label/help text.Chris Toshok2001-10-073-27/+110
| | | | | | | | | | | | | | | | | | | | | | 2001-10-06 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.glade: add an Email Address field/label/help text. * gui/component/addressbook-config.c (addressbook_source_dialog_set_source): fill in the email entry from the source. also, set the initial state of the email label/entry. (auth_checkbutton_changed): set the email label/entry sensitive/editable if auth is turned on, and insensitive/uneditable if it's off. (addressbook_source_dialog_get_source): get the email address from the email entry. (addressbook_source_dialog): hook up the email entry to the changed signal foo, as well as the focus handler for displaying help text. svn path=/trunk/; revision=13486
* db isn't a BonoboObject, so don't bonobo_object_unref it!Jon Trowbridge2001-10-062-1/+16
| | | | | | | | | | 2001-10-06 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): db isn't a BonoboObject, so don't bonobo_object_unref it! svn path=/trunk/; revision=13477
* e_book_load_uri -> addressbook_load_uri.Chris Toshok2001-10-067-121/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-05 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names.c (addressbook_model_set_uri): e_book_load_uri -> addressbook_load_uri. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): e_book_load_uri -> addressbook_load_uri. * gui/component/addressbook.c (forget_passwords_cb): new function, call e_passwords_forget_passwords. (verbs): Add ContactsForgetPasswords. (load_uri_auth_cb): new function, call the callback and free up our closure stuff. (load_uri_cb): once the uri is loaded, check if we're configured to authenticate for it, and do so, using the e_passwords stuff. (addressbook_load_uri): wrapper around e_book_load_uri. save off the parameters and start the load-with-auth machinery. (book_open_cb): remove all the auth stuff from here, as it's handled elsewhere now. * gui/component/addressbook-factory.c (main): call e_passwords_init. * gui/component/addressbook-component.c (user_create_new_item_cb): e_book_load_uri -> addressbook_load_uri. (destination_folder_handle_drop): same. * gui/component/addressbook.h: add prototype for addressbook_load_uri (a wrapper around e_book_load_uri that also handles authentication if the user selects it.) svn path=/trunk/; revision=13475
* Check to make sure our call to e_addressbook_model_get_card doesn't returnJon Trowbridge2001-10-065-15/+44
| | | | | | | | | | | | | | | | | | | | | | | | 2001-10-05 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (real_add_address_cb): Check to make sure our call to e_addressbook_model_get_card doesn't return NULL. * gui/widgets/e-addressbook-model.c (e_addressbook_model_get_card): Chek that we aren't requesting a negative row. * gui/contact-list-editor/e-contact-list-editor.c (add_email_cb): Move to the bottom of the scrolled window, so we can see the address we just added. (table_drag_data_received_cb): Move to the bottom of the scrolled window, so we can see the contact we just dropped. * gui/component/addressbook.c (addressbook_factory_new_control): We don't own the string returned by e_categories_master_list_nth, so terrible things will happen if we free it. (Bug 10916) svn path=/trunk/; revision=13469
* don't set the editable field on the model - let the book do that.Chris Toshok2001-10-062-1/+9
| | | | | | | | | | | | 2001-10-05 Chris Toshok <toshok@ximian.com> * gui/widgets/e-addressbook-view.c (e_addressbook_view_set_arg): don't set the editable field on the model - let the book do that. (book_writable_cb): call writable_status to propagate a ui-change event up (and sensitize the write-only toolbar buttons after you authenticate with ldap.) svn path=/trunk/; revision=13454
* for some reason, matching on protocol is causing problems for me.Chris Toshok2001-10-052-2/+11
| | | | | | | | | | 2001-10-04 Chris Toshok <toshok@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): for some reason, matching on protocol is causing problems for me. disabling it for now. svn path=/trunk/; revision=13415
* use ldap.png for ldap contacts.Chris Toshok2001-10-052-1/+6
| | | | | | | | | 2001-10-04 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-component.c: use ldap.png for ldap contacts. svn path=/trunk/; revision=13411
* Fixed warningIain Holmes2001-10-041-3/+12
| | | | svn path=/trunk/; revision=13390
* ifdef out the LDAP only bits. Cleans some warnings on startupIain Holmes2001-10-042-0/+10
| | | | svn path=/trunk/; revision=13389
* Fixed these to determine the fields to use properly.Christopher James Lahey2001-10-043-5/+8
| | | | | | | | | | 2001-10-03 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (addressbook_height), gui/widgets/e-minicard.c (remodel): Fixed these to determine the fields to use properly. svn path=/trunk/; revision=13386
* Strip out commas before forming our query. (match_name): UseJon Trowbridge2001-10-045-140/+187
| | | | | | | | | | | | | | | | | | | | | | 2001-10-02 Jon Trowbridge <trow@gnu.org> * gui/component/select-names/e-select-names-completion.c (name_style_query): Strip out commas before forming our query. (match_name): Use e_card_compare_name_to_string_full, rather than our crufty old matching code. Not only is this cleaner, but that crufty old code was very broken when it came to handling strings with whitespace. (Bug 8988) (match_nickname): utf8 and bug fixes. * backend/ebook/e-card-compare.c (e_card_compare_name_to_string_full): Added. This is basically e_card_compare_name_to_string with a bunch of extra options, so that it can more readily be reused in other contexts. (e_card_compare_name_to_string): This is now just a call to e_card_compare_name_to_string_full with the extra args filled in to defaults that simulate the old behavior. svn path=/trunk/; revision=13384
* remove most of the oaf stuff from here. we do it in load_uri, where we'llChris Toshok2001-10-032-35/+179
| | | | | | | | | | | | | | | | | | | | | 2001-10-02 Chris Toshok <toshok@ximian.com> * backend/ebook/e-book.c (e_book_construct): remove most of the oaf stuff from here. we do it in load_uri, where we'll have more information (namely, the protocol we're using.) (activate_factories_for_uri): do an oaf query to get a list of all objects implementing our BookFactory interface and also supporting the protocol used in the uri. (e_book_load_uri): try activating book factories to handle this uri, and start the iteration over the list. (e_book_load_uri_from_factory): try and load the uri. (e_book_load_uri_open_cb): callback function for the BookFactory_openBook call - if it succeeds, call the user's callback. otherwise step to the next factory. (e_book_load_uri_step): go to the next factory in our list, and error out if there are no more. svn path=/trunk/; revision=13358
* Made the max length of the textification be 2047 characters. Fixes XimianChristopher James Lahey2001-10-022-0/+13
| | | | | | | | | | 2001-10-02 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names-model.c (e_select_names_model_get_textification): Made the max length of the textification be 2047 characters. Fixes Ximian bug #3021. svn path=/trunk/; revision=13299
* if there was no first name or last name, file as the company.JP Rosevear2001-10-022-0/+7
| | | | | | | | | 2001-10-01 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): if there was no first name or last name, file as the company. svn path=/trunk/; revision=13293
* if there is a db error, assume deletion (pas_backend_file_changes): writeJP Rosevear2001-10-022-7/+9
| | | | | | | | | | | 001-10-01 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes_foreach_key): if there is a db error, assume deletion (pas_backend_file_changes): write after all is done for efficiency svn path=/trunk/; revision=13267
* g_strdup (pas_backend_file_changes): ditto, make sure to free all data andJP Rosevear2001-09-293-32/+73
| | | | | | | | | | | | | | | | 2001-09-28 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes_foreach_key): g_strdup (pas_backend_file_changes): ditto, make sure to free all data and do a hash write after each add/remove * conduit/address-conduit.c (local_record_to_pilot_record): use the local record category (local_record_from_ecard): ndle the fields and category we don't sync by making sure we don't overwrite them svn path=/trunk/; revision=13232
* Update the paths, /menu/ComponentToolsPlaceholder/Tools/ ->Ettore Perazzoli2001-09-282-2/+8
| | | | | | | | * gui/component/addressbook.c: Update the paths, /menu/ComponentToolsPlaceholder/Tools/ -> /menu/Tools/ComponentPlaceholder/. svn path=/trunk/; revision=13203
* use the old record (if there was one) so as not to overwrite fields weJP Rosevear2001-09-273-5/+24
| | | | | | | | | | | | 2001-09-27 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): use the old record (if there was one) so as not to overwrite fields we don't sync (pre_sync): store the dbi in the context and don't make it object data svn path=/trunk/; revision=13187
* use priv->iid instead of the hardcoded string here.Chris Toshok2001-09-273-9/+33
| | | | | | | | | | | | | | 2001-09-26 Chris Toshok <toshok@ximian.com> * backend/pas/pas-book-factory.c (pas_book_factory_destroy): use priv->iid instead of the hardcoded string here. (pas_book_factory_activate): parameterize the factory's iid, as in the calendar server, and provide a default if iid == NULL. * backend/pas/pas-book-factory.h: add iid parameter for pas_book_factory_activate. svn path=/trunk/; revision=13180
* Use camel_address_format, not camel_address_encode.Jon Trowbridge2001-09-272-1/+6
| | | | | | | | | 2001-09-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_get_textrep): Use camel_address_format, not camel_address_encode. svn path=/trunk/; revision=13173
* Added help text (thanks to Aaron) and re-worded the labels, and fixed theAnna Marie Dirks2001-09-272-119/+181
| | | | | | | | | | 2001-09-26 Anna Marie Dirks <anna@ximian.com> * gui/contact-editor/contact-editor.glade: Added help text (thanks to Aaron) and re-worded the labels, and fixed the shortcuts on the brand-spanking-new Collaboration tab. svn path=/trunk/; revision=13170
* add completion_book.Chris Toshok2001-09-273-3/+59
| | | | | | | | | | | | | | | | | | 2001-09-26 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names-manager.h: add completion_book. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): get /Addressbook/Completion/uri, and if it's present, use the corresponding EBook for completing addresses. (focus_out_cb): use manager->completion_book here instead of NULL, which corresponds to the local addressbook. (completion_popup_cb): same. (e_select_names_manager_create_entry): same. svn path=/trunk/; revision=13161
* Properly handle names when the individual elements (given, addition,Jon Trowbridge2001-09-274-42/+108
| | | | | | | | | | | | | | | | | | | | | | 2001-09-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card-compare.c (e_card_compare_name_to_string): Properly handle names when the individual elements (given, addition, family) contain whitespace. (Bug #10502) * backend/ebook/e-destination.c (e_destination_set_name): Reset textrep when we change the name. (e_destination_set_email): Reset textrep when we change the email. (e_destination_get_textrep): Make sure that the textrep version of the address is properly quoted if it contains unsafe characters. (All related to bug #10796) * gui/component/select-names/e-select-names-completion.c (match_nickname): Fix nickname matching. (bug #9698) (make_match): Use e_completion_match_new when building our match, rather than ad hoc manipulation of the struct. svn path=/trunk/; revision=13158
* set the last_use and use_score fields of the card to known values so theJP Rosevear2001-09-273-10/+65
| | | | | | | | | | | | | | | | 2001-09-26 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes): set the last_use and use_score fields of the card to known values so the card doesn't register as changed when only they have changed 2001-09-26 Peter Williams <peterw@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): Fix this function to set email addresses properly, and handle multiple occurrences of email addresses, home phone numbers, and business phone numbers. svn path=/trunk/; revision=13153
* Handle creating the new contact in the current folder if it's a contactsChristopher James Lahey2001-09-252-5/+36
| | | | | | | | | | 2001-09-25 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c (user_create_new_item_cb): Handle creating the new contact in the current folder if it's a contacts folder. Fixes Ximian bug #7814. svn path=/trunk/; revision=13109
* add evolutionperson.schema (EXTRA_DIST): add LDAP_SCHEMA to the dist (butChris Toshok2001-09-252-1/+15
| | | | | | | | | | 2001-09-24 Chris Toshok <toshok@ximian.com> * backend/pas/Makefile.am (LDAP_SCHEMA): add evolutionperson.schema (EXTRA_DIST): add LDAP_SCHEMA to the dist (but don't install it). svn path=/trunk/; revision=13107
* sync the note the to pilot and make sure to blank fields when appropriateJP Rosevear2001-09-242-25/+31
| | | | | | | | | | 2001-09-23 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): sync the note the to pilot and make sure to blank fields when appropriate (local_record_from_ecard): sync the note to the desktop svn path=/trunk/; revision=13091
* when creating the cards, don't display any of the subname fields (surname,Chris Toshok2001-09-232-1/+7
| | | | | | | | | | 2001-09-22 Chris Toshok <toshok@ximian.com> * gui/widgets/e-minicard.c (remodel): when creating the cards, don't display any of the subname fields (surname, given, middle, suffix, etc.) svn path=/trunk/; revision=13083
* add getters for the additional name fields. (field_data): move FAMILY_NAMEChris Toshok2001-09-233-2/+41
| | | | | | | | | | | | | 2001-09-22 Chris Toshok <toshok@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_get): add getters for the additional name fields. (field_data): move FAMILY_NAME to the end of the list, and add GIVEN_NAME, ADDITIONAL_NAME (middle name), and NAME_SUFFIX. * backend/ebook/e-card-simple.h: same. svn path=/trunk/; revision=13082
* Hooked up print preview button.Christopher James Lahey2001-09-226-4/+121
| | | | | | | | | | | | | | | | 2001-09-21 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (print_preview_cb): Hooked up print preview button. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (e_addressbook_view_print_preview): Added this function. * printing/e-contact-print.c, printing/e-contact-print.h (e_contact_print_preview): Added this function. svn path=/trunk/; revision=13071
* I'm slowly losing my mind.Jon Trowbridge2001-09-201-1/+0
| | | | | | OK, maybe it isn't such a slow process after all. svn path=/trunk/; revision=13006
* Yikes... fixing accidental breakage.Jon Trowbridge2001-09-201-1/+1
| | | | svn path=/trunk/; revision=13005
* Use the default e-mail address if we have nothing else to go on.Jon Trowbridge2001-09-207-167/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (name_and_email_simple_query_cb): Use the default e-mail address if we have nothing else to go on. Previously we just failed, which basically meant that name-only searches would never work properly. (nickname_simple_query_cb): The logic was a bit tangled here; if our query status isn't SUCCESS, always give up but don't leak the destination. And if our nickname query fails and we try the name-and-email query, use the textrep for a name-only search. The only reason we are doing a nickname query in the first place is if we have an obviously invalid e-mail. (launch_cardify_query): Use e_destination_is_valid to determine if we should try a nickname query first. These changes basically fix bug 7728, and generally make the auto-cardification of addresses a lot more clever and robust. * backend/ebook/e-book-util.c (name_and_email_cb): Use e_card_compare_name_to_string instead of e_card_name_match_string. (e_book_name_and_email_query): The arguments to g_strsplit were in the wrong order. Doh! * backend/ebook/e-card-compare.c (e_card_compare_name_to_string): Added. Replaces e_card_name_match_string, and actually works. * backend/ebook/e-card.c: Removed e_card_name_match_string function, which didn't work particularly well. svn path=/trunk/; revision=13003
* don't add to the complete list of cards if the card is a listJP Rosevear2001-09-202-5/+33
| | | | | | | | | | | | | 2001-09-19 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (cursor_cb): don't add to the complete list of cards if the card is a list (card_added): don't add to the list of changes if the card is a list (card_changed): ditto (card_removed): ditto svn path=/trunk/; revision=13002
* Change the "this should never happen" message into a request for people toJon Trowbridge2001-09-202-1/+10
| | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listeners): Change the "this should never happen" message into a request for people to e-mail me directly with info if they encounter that error. svn path=/trunk/; revision=13000
* Freeing name[i] instead of namev[i] is a bad idea. (bug #10270)Jon Trowbridge2001-09-202-1/+4
| | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-util.c (e_book_name_and_email_query): Freeing name[i] instead of namev[i] is a bad idea. (bug #10270) svn path=/trunk/; revision=12980
* Properly handle our GnomeUIInfo labels so that they won't be leaked ifJon Trowbridge2001-09-192-151/+137
| | | | | | | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_card): Properly handle our GnomeUIInfo labels so that they won't be leaked if they are dynamic strings, so that they will be i18n-correct, and so that underscores won't be interpreted as key accelerators. What a PITA. Also, don't leak our iterators. (Bug #10200.) (popup_menu_list): The same GnomeUIInfo tweaking as in popup_menu_card. (popup_menu_nocard): Ditto. svn path=/trunk/; revision=12975
* add caluri field dataJP Rosevear2001-09-197-13/+232
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-18 JP Rosevear <jpr@ximian.com> * backend/ebook/e-card-simple.c (field_data): add caluri field data * backend/ebook/e-card.c (e_card_get_vobject): add the caluri property when appropriate (parse_caluri): handle read caluri (e_card_class_init): add caluri arg (e_card_destroy): free the caluri (e_card_get_arg): return caluri arg (e_card_set_arg): set caluri from arg (e_card_init): init caluri to null * backend/ebook/e-card-simple.h: new simple field * backend/ebook/e-card.h: new member * gui/contact-editor/e-contact-editor.c (field_changed): util callback to change the command state (set_entry_changed_signal_field): hook up a change signal to above (set_entry_changed_signals): use above function * gui/contact-editor/e-contact-editor.glade: Add collaboration page and fields svn path=/trunk/; revision=12945
* create a sexp and check if the cards match before adding them to the listJP Rosevear2001-09-192-7/+28
| | | | | | | | | | | 2001-09-18 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_build_cards_list): create a sexp and check if the cards match before adding them to the list (pas_backend_file_process_get_cursor): send extra param svn path=/trunk/; revision=12940
* remove conflict droppingsLarry Ewing2001-09-181-1/+0
| | | | | | --Larry svn path=/trunk/; revision=12938
* unref the destination regardless of whether we get an email addresss.Larry Ewing2001-09-182-2/+8
| | | | | | | | | | 2001-09-18 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (book_query_process_card_list): unref the destination regardless of whether we get an email addresss. svn path=/trunk/; revision=12937
* use g_strfreev. (match_name): s/g_free/g_strfreev. (match_file_as):Larry Ewing2001-09-184-12/+22
| | | | | | | | | | | | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (name_style_query): use g_strfreev. (match_name): s/g_free/g_strfreev. (match_file_as): s/g_free/g_strfreev. * backend/ebook/e-book-util.c (e_book_name_and_email_query): fix the memory handling here. All there members of the vector need to be freed all the time. * backend/ebook/load-pine-addressbook.c (parse_line): free the string outside of the test that makes sure there are three entries. svn path=/trunk/; revision=12936
* don't malloc a match we will never use.Larry Ewing2001-09-182-1/+4
| | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_nickname): don't malloc a match we will never use. svn path=/trunk/; revision=12935
* free the dup'd capabilities.Larry Ewing2001-09-182-0/+7
| | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/widgets/e-addressbook-model.c (get_view): free the dup'd capabilities. svn path=/trunk/; revision=12933
* We want to assume that a destination that comes from a card isJon Trowbridge2001-09-182-1/+7
| | | | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_is_valid): We want to assume that a destination that comes from a card is automatically valid, but the right way to check that is by calling e_destination_from_card, not by checking if dest->priv->card != NULL. (Fixed bug #10017) svn path=/trunk/; revision=12930
* Fixed a stupid bug was causing completion to fail for contacts who haveJon Trowbridge2001-09-182-9/+14
| | | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_name): Fixed a stupid bug was causing completion to fail for contacts who have only one name. (The classic example we all know and love is 'George <jirka@5z.com>') (bug #8353) svn path=/trunk/; revision=12928
* Do the right thing if the card we are trying to send to has no validJon Trowbridge2001-09-182-53/+60
| | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_list_send): Do the right thing if the card we are trying to send to has no valid e-mail addresses. (bug #10137) svn path=/trunk/; revision=12927
* Code implicitly assumed that event->button.button is 1, 2, or 3, causingJon Trowbridge2001-09-182-17/+26
| | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): Code implicitly assumed that event->button.button is 1, 2, or 3, causing disaster when using a wheel-mouse. Fixed. (bug #9400) svn path=/trunk/; revision=12926
* use enable_widget instead of gtk_widget_set_sensitive.Chris Toshok2001-09-174-53/+109
| | | | | | | | | | | | | | | | | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c (_phone_arrow_pressed): use enable_widget instead of gtk_widget_set_sensitive. (_email_arrow_pressed): same. (_address_arrow_pressed): same. (disable_widget_foreach): same. (enable_writable_fields): same. (set_editable): same. (enable_widget): new function, using both gtk_widget_set_sensitive and *_set_editable to allow the user to select text in GtkEntry's and GtkText's. * gui/contact-editor/e-contact-editor-fullname.c (e_contact_editor_fullname_set_arg): use set_editable as well as set_sensitive, to allow the user to select text in GtkEntry's. * gui/contact-editor/e-contact-editor-address.c (e_contact_editor_address_set_arg): same. svn path=/trunk/; revision=12868
* fix syntax errors (which are broken, imo...)Chris Toshok2001-09-172-2/+7
| | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * backend/pas/evolutionperson.schema: fix syntax errors (which are broken, imo...) svn path=/trunk/; revision=12866
* reorder the LDAP scopes so that they match the order of the option menusChris Toshok2001-09-173-4/+82
| | | | | | | | | | | | | | | | | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.h: reorder the LDAP scopes so that they match the order of the option menus in the glade file. * gui/component/addressbook-config.c (auth_checkbutton_changed): new function, mostly there to house some #ifdef'ed out code. (option_menuitem_activated): new function, to keep track of changes to the ldap scope optionmenu. (addressbook_source_dialog_set_source): set the menu history as well as the dialog's copy of the scope. (addressbook_source_dialog_get_source): fill in the source's scope from the dialog's copy, and add more #if the_ui_gods_smile_on_me code. (add_activate_cb): new function, add an activate callback for the optionmenu's items. (addressbook_source_dialog): more #if the_ui_gods_smile_on_me code, always start the dialog on page 0, and hook up the scope optionmenu's items. svn path=/trunk/; revision=12865
* No loose name matches on family names. (#8802)Jon Trowbridge2001-09-153-1/+10
| | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card-compare.c (e_card_compare_name): No loose name matches on family names. (#8802) svn path=/trunk/; revision=12857
* We can't use NULL as the first arg for e_addressbook_show_contact_editorJon Trowbridge2001-09-152-2/+7
| | | | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_activate_obj): We can't use NULL as the first arg for e_addressbook_show_contact_editor anymore. Damn. (#8535) svn path=/trunk/; revision=12853
* Make "stop" do nothing but set the stopped flag, as inJon Trowbridge2001-09-1510-209/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-listener.c (e_book_listener_stop): Make "stop" do nothing but set the stopped flag, as in e-book-view-listener.c. (e_book_listener_destroy): Clean up our queue here, rather than in e_book_listener_stop. (response_free): Added. Move the rather lengthy bit of code needed to free a EBookListenerResponse into one place. (e_book_listener_check_queue): Properly deal with the stopped flag. (e_book_listener_queue_response): If the stopped flag is set, just drop the incoming response. * backend/ebook/e-book-view-listener.c (e_book_view_listener_stop): Make "stop" do nothing but set the stopped flag. (e_book_view_listener_destroy): Move all of the clean-up that used to be in e_book_view_listener_stop here. This considerably simplifies the logic required to avoid various race conditions. (e_book_view_listener_check_queue): Properly deal with the stopped flag. (e_book_view_listener_queue_response): Drop all incoming responses if we are stopped. 2001-09-14 Jon Trowbridge <trow@ximian.com> * backend/pas/pas-book.c (pas_book_queue_request): Hold a reference to the book on behalf of our idle function. (pas_book_check_queue): When we are finished, drop the reference we've been holding on behalf of the idle function. * backend/pas/pas-backend-file.c (pas_backend_file_process_create_card): Hold a reference to the book_view while sending our notifications. (pas_backend_file_process_remove_card): Hold a reference to the book_view while sending our notifications. * gui/contact-editor/e-contact-quick-add.c (quick_add_unref): Remove debugging spew. * backend/ebook/e-book-util.c: Remove a lot of unused code that worked around bugs that have long since been fixed. (simple_query_disconnect): Added. Breaks out the part of simple_query_free that disconnect signals. (simple_query_free): Replace code w/ a call to simple_query_disconnect. (simple_query_sequence_complete_cb): Call simple_query_disconnect before executing the callback, so that our callbacks don't get triggered by any book changes that might occur during that callback. * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): Changed to be consistent with e_book_listener_check_queue. (e_book_view_listener_queue_response): Also changed to use a high-frequency timeout. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): OK, I've agonized over this stupid little function, and it should now be race-free. (e_book_listener_queue_response): We process our response queue in a high-frequency timeout rather than an idle. Using an idle function leads to some tricky race conditions and bad interactions with bonobo's semi-broken attempts to take over event processing. (e_book_view_listener_stop): Manually disable our timeout and clean up. svn path=/trunk/; revision=12851
* Set CLEANFILES directly instead of using `+='.Ettore Perazzoli2001-09-152-1/+4
| | | | | | | | | | | | | * gui/component/select-names/Makefile.am: Set CLEANFILES directly instead of using `+='. * backend/pas/Makefile.am: Rename `LDAP_BACKEND_SOURCES' to `LDAP_BACKEND_FILES'. * backend/ebook/Makefile.am: Set CLEANFILES directly instead of using `+='. svn path=/trunk/; revision=12840
* [Automake 1.5 fixes pointed out by Richard BoultonEttore Perazzoli2001-09-153-5/+16
| | | | | | | | | | | | <richard@tartarus.org>, as per #9258.] * backend/pas/Makefile.am: Rename `LDAP_BACKEND_SOURCES' to `LDAP_BACKEND_FILES'. * backend/ebook/Makefile.am: Set CLEANFILES directly instead of using `+='. svn path=/trunk/; revision=12839
* use ldap_init. ldap_open is deprecated in openldap 2.x.Chris Toshok2001-09-142-1/+6
| | | | | | | | | 2001-09-13 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_connect): use ldap_init. ldap_open is deprecated in openldap 2.x. svn path=/trunk/; revision=12820
* Fix vcard importingIain Holmes2001-09-132-1/+8
| | | | svn path=/trunk/; revision=12784
* free the values that are being leaked here.Larry Ewing2001-09-132-4/+20
| | | | | | | | | 2001-09-12 Larry Ewing <lewing@ximian.com> * backend/ebook/e-destination.c: free the values that are being leaked here. svn path=/trunk/; revision=12783
* printf arguments were reversed by mistake. Fixed bug #9693.Jon Trowbridge2001-09-132-1/+6
| | | | | | | | | 2001-09-12 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_email): printf arguments were reversed by mistake. Fixed bug #9693. svn path=/trunk/; revision=12779
* Added. Treat right-clicks on a contact list as a special case.Jon Trowbridge2001-09-102-4/+111
| | | | | | | | | | | | 2001-09-09 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_list): Added. Treat right-clicks on a contact list as a special case. (e_select_names_popup): Check if we are dealing with a contact list. (Bug #9322) svn path=/trunk/; revision=12716
* (Apologies if you are seeing this multiple times. CVS is being annoying.)Jon Trowbridge2001-09-098-81/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12710
* See e_book_listener_check_queue below.Jon Trowbridge2001-09-095-92/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12709
* See e_book_listener_check_queue below.Jon Trowbridge2001-09-091-0/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12708
* (make_contact_editor_cb): show the right contact editor (the list editorChris Toshok2001-09-092-3/+15
| | | | | | | | | 2001-09-08 Chris Toshok <toshok@ximian.com> (make_contact_editor_cb): show the right contact editor (the list editor for list cards). svn path=/trunk/; revision=12707
* do the EDestination xml magic on email addresses we put in the popup.Chris Toshok2001-09-092-1/+18
| | | | | | | | | | 2001-09-08 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_card): do the EDestination xml magic on email addresses we put in the popup. svn path=/trunk/; revision=12706
* For every category: - set .translate to FALSEChyla Zbigniew2001-09-082-2/+14
| | | | | | | | | | * gui/component/addressbook.c (addressbook_factory_new_control): For every category: - set .translate to FALSE (e_categories_master_list_nth returns translated category name) - convert category name in UTF-8 to locale's encoding svn path=/trunk/; revision=12696
* Fixed two bugs: - missing coversion of contact name to GTK+ locale, -Chyla Zbigniew2001-09-082-15/+49
| | | | | | | | | | | | * gui/component/select-names/e-select-names-popup.c (popup_menu_card): Fixed two bugs: - missing coversion of contact name to GTK+ locale, - passing dynamically created string (contact name) inside uiinfo struct to gnome-app-helper functions. Remember: these functions may change strings, trying to translate them! (popup_menu_nocard): Ditto svn path=/trunk/; revision=12694