aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--addressbook/ChangeLog7
-rw-r--r--addressbook/gui/contact-list-editor/e-contact-list-editor.c4
2 files changed, 9 insertions, 2 deletions
diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog
index a68d11b86c..a24ffe2f7a 100644
--- a/addressbook/ChangeLog
+++ b/addressbook/ChangeLog
@@ -1,3 +1,10 @@
+2003-12-09 JP Rosevear <jpr@ximian.com>
+
+ * gui/contact-list-editor/e-contact-list-editor.c (extract_info):
+ free the list, not unref it, and free the elements
+
+ Fixes #51976
+
2003-12-06 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names-manager.c
diff --git a/addressbook/gui/contact-list-editor/e-contact-list-editor.c b/addressbook/gui/contact-list-editor/e-contact-list-editor.c
index a475d15cd6..de95077ced 100644
--- a/addressbook/gui/contact-list-editor/e-contact-list-editor.c
+++ b/addressbook/gui/contact-list-editor/e-contact-list-editor.c
@@ -1208,7 +1208,8 @@ extract_info(EContactListEditor *editor)
e_contact_set (contact, E_CONTACT_EMAIL, email_list);
- /* XXX free email_list? */
+ g_list_foreach (email_list, (GFunc) g_free, NULL);
+ g_list_free (email_list);
if (editor->image_buf) {
EContactPhoto photo;
@@ -1218,7 +1219,6 @@ extract_info(EContactListEditor *editor)
e_contact_set (contact, E_CONTACT_LOGO, &photo);
}
- g_object_unref (email_list);
}
}