aboutsummaryrefslogtreecommitdiffstats
path: root/widgets/misc
diff options
context:
space:
mode:
authorMatthew Barnes <mbarnes@redhat.com>2009-05-14 22:50:38 +0800
committerMatthew Barnes <mbarnes@redhat.com>2009-05-21 09:58:47 +0800
commit63b66d68529f434d16a12da81a5c611e0df1e7ee (patch)
treec7a2bf0d55236e43bfb10e0663c9790adcd8b7a9 /widgets/misc
parent1df3152d0a2001d0a85cdc960a38e2cbcb395bb9 (diff)
downloadgsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar.gz
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar.bz2
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar.lz
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar.xz
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.tar.zst
gsoc2013-evolution-63b66d68529f434d16a12da81a5c611e0df1e7ee.zip
Bug 582585 – Crash when deleting multiple attachments from composed mail
Diffstat (limited to 'widgets/misc')
-rw-r--r--widgets/misc/e-attachment-view.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/widgets/misc/e-attachment-view.c b/widgets/misc/e-attachment-view.c
index 27ef5d84a8..48292cfbc3 100644
--- a/widgets/misc/e-attachment-view.c
+++ b/widgets/misc/e-attachment-view.c
@@ -1038,6 +1038,12 @@ e_attachment_view_remove_selected (EAttachmentView *view,
store = e_attachment_view_get_store (view);
model = GTK_TREE_MODEL (store);
+ /* Remove attachments in reverse order to avoid invalidating
+ * tree paths as we iterate over the list. Note, the list is
+ * probably already sorted but we sort again just to be safe. */
+ selected = g_list_reverse (g_list_sort (
+ selected, (GCompareFunc) gtk_tree_path_compare));
+
for (item = selected; item != NULL; item = item->next) {
EAttachment *attachment;
GtkTreePath *path = item->data;