aboutsummaryrefslogtreecommitdiffstats
path: root/modules
diff options
context:
space:
mode:
authorMatthew Barnes <mbarnes@redhat.com>2010-01-16 11:19:49 +0800
committerMatthew Barnes <mbarnes@redhat.com>2010-01-16 11:19:49 +0800
commit73716c500bc2f9dd2c0057b3d57ccc340d5e1017 (patch)
tree7afaaba758a67d380260e8aa999ecc1f251f3815 /modules
parent9cb166341e0231ba1e547f90838c512867f51141 (diff)
downloadgsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar.gz
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar.bz2
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar.lz
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar.xz
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.tar.zst
gsoc2013-evolution-73716c500bc2f9dd2c0057b3d57ccc340d5e1017.zip
Fix some potential null pointer dereferences.
Caught by the Clang Static Analyzer.
Diffstat (limited to 'modules')
-rw-r--r--modules/calendar/e-cal-shell-backend.c6
-rw-r--r--modules/calendar/e-memo-shell-backend.c6
-rw-r--r--modules/calendar/e-task-shell-backend.c6
3 files changed, 12 insertions, 6 deletions
diff --git a/modules/calendar/e-cal-shell-backend.c b/modules/calendar/e-cal-shell-backend.c
index bf6f2e1189..232e8461c3 100644
--- a/modules/calendar/e-cal-shell-backend.c
+++ b/modules/calendar/e-cal-shell-backend.c
@@ -600,9 +600,11 @@ cal_shell_backend_handle_uri_cb (EShellBackend *shell_backend,
client = auth_new_cal_from_source (source, source_type);
if (client == NULL || !e_cal_open (client, TRUE, &error)) {
- g_printerr ("%s\n", error->message);
+ if (error != NULL) {
+ g_printerr ("%s\n", error->message);
+ g_error_free (error);
+ }
g_object_unref (source_list);
- g_error_free (error);
goto exit;
}
diff --git a/modules/calendar/e-memo-shell-backend.c b/modules/calendar/e-memo-shell-backend.c
index 067613e0c5..10a1ea99e7 100644
--- a/modules/calendar/e-memo-shell-backend.c
+++ b/modules/calendar/e-memo-shell-backend.c
@@ -426,9 +426,11 @@ memo_shell_backend_handle_uri_cb (EShellBackend *shell_backend,
client = auth_new_cal_from_source (source, source_type);
if (client == NULL || !e_cal_open (client, TRUE, &error)) {
- g_printerr ("%s\n", error->message);
+ if (error != NULL) {
+ g_printerr ("%s\n", error->message);
+ g_error_free (error);
+ }
g_object_unref (source_list);
- g_error_free (error);
goto exit;
}
diff --git a/modules/calendar/e-task-shell-backend.c b/modules/calendar/e-task-shell-backend.c
index d20a359e7d..1a8bee5a03 100644
--- a/modules/calendar/e-task-shell-backend.c
+++ b/modules/calendar/e-task-shell-backend.c
@@ -431,9 +431,11 @@ task_shell_backend_handle_uri_cb (EShellBackend *shell_backend,
client = auth_new_cal_from_source (source, source_type);
if (client == NULL || !e_cal_open (client, TRUE, &error)) {
- g_printerr ("%s\n", error->message);
+ if (error != NULL) {
+ g_printerr ("%s\n", error->message);
+ g_error_free (error);
+ }
g_object_unref (source_list);
- g_error_free (error);
goto exit;
}