diff options
author | Milan Crha <mcrha@redhat.com> | 2013-07-22 18:03:55 +0800 |
---|---|---|
committer | Milan Crha <mcrha@redhat.com> | 2013-07-22 18:09:14 +0800 |
commit | 7ef82cc0df5281a03c87c828245fc34c3af2a3b0 (patch) | |
tree | 279cfaeccbe168c17b284562bd642dadb2759a85 /mail | |
parent | c7c6c55ee472daa126873f557e8cdd70299c8411 (diff) | |
download | gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar.gz gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar.bz2 gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar.lz gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar.xz gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.tar.zst gsoc2013-evolution-7ef82cc0df5281a03c87c828245fc34c3af2a3b0.zip |
Do not mask CAMEL_ERROR_GENERIC in composer_send_completed()
Any provider can return a generic error code, which makes the check
useless, only hiding important error information from a user. Since
the camel_getaddrinfo() returns CAMEL_SERVICE_ERROR_URL_INVALID,
the check could be adapted and be more useful.
Diffstat (limited to 'mail')
-rw-r--r-- | mail/em-composer-utils.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/mail/em-composer-utils.c b/mail/em-composer-utils.c index 92776bc393..5de7dfd99f 100644 --- a/mail/em-composer-utils.c +++ b/mail/em-composer-utils.c @@ -517,9 +517,10 @@ composer_send_completed (GObject *source_object, g_error_matches ( local_error, CAMEL_SERVICE_ERROR, CAMEL_SERVICE_ERROR_UNAVAILABLE) || - /* XXX camel_getaddrinfo() sets this, unfortunately. */ + /* a name resolution failed */ g_error_matches ( - local_error, CAMEL_ERROR, CAMEL_ERROR_GENERIC); + local_error, CAMEL_SERVICE_ERROR, + CAMEL_SERVICE_ERROR_URL_INVALID); if (service_unavailable) { /* Inform the user. */ e_alert_run_dialog_for_args ( |