Fix/mute issues found by Coverity scan

This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.

1 files changed, 7 insertions, 2 deletions

diff --git a/mail/e-mail-migrate.c b/mail/e-mail-migrate.c
index e982b402ed..6a97b7342f 100644
--- a/mail/e-mail-migrate.c
+++ b/mail/e-mail-migrate.c
@@ -149,7 +149,9 @@ cp (const gchar *src,
 	ut.actime = st.st_atime;
 	ut.modtime = st.st_mtime;
 	utime (dest, &ut);
-	chmod (dest, st.st_mode);
+	if (chmod (dest, st.st_mode) == -1) {
+		g_warning ("%s: Failed to chmod '%s': %s", G_STRFUNC, dest, g_strerror (errno));
+	}
 
 	return TRUE;
 
@@ -264,7 +266,10 @@ em_rename_view_in_folder (gpointer data,
 		oldname = g_build_filename (views_dir, filename, NULL);
 		newname = g_build_filename (views_dir, newfile, NULL);
 
-		g_rename (oldname, newname);
+		if (g_rename (oldname, newname) == -1) {
+			g_warning ("%s: Failed to rename '%s' to '%s': %s", G_STRFUNC,
+				   oldname, newname, g_strerror (errno));
+		}
 
 		g_checksum_free (checksum);
 		g_free (oldname);