Make EAttachment a little more thread-safe.

EAttachment is now used from worker threads by EMailFormatterAttachment,
so add some thread-safe accessor functions to eliminate potential races.

Added thread-safe functions:

    e_attachment_dup_disposition()
    e_attachment_ref_file()
    e_attachment_ref_file_info()
    e_attachment_ref_icon()
    e_attachment_ref_mime_part()
    e_attachment_dup_description()
    e_attachment_dup_thumbnail_path()

Renamed functions:

    e_attachment_get_mime_type() -> e_attachment_dup_mime_type()

Removed non-thread-safe functions:

    e_attachment_get_file()
    e_attachment_get_file_info()
    e_attachment_get_icon()
    e_attachment_get_mime_part()
    e_attachment_get_description()
    e_attachment_get_thumbnail_path()

1 files changed, 1 insertions, 3 deletions

diff --git a/em-format/e-mail-parser.c b/em-format/e-mail-parser.c
index f31e0ca199..57c362e286 100644
--- a/em-format/e-mail-parser.c
+++ b/em-format/e-mail-parser.c
@@ -734,14 +734,12 @@ e_mail_parser_wrap_as_attachment (EMailParser *parser,
 	if (size != 0) {
 		GFileInfo *file_info;
 
-		file_info = e_attachment_get_file_info (attachment);
+		file_info = e_attachment_ref_file_info (attachment);
 
 		if (file_info == NULL) {
 			file_info = g_file_info_new ();
 			g_file_info_set_content_type (
 				file_info, empa->snoop_mime_type);
-		} else {
-			g_object_ref (file_info);
 		}
 
 		g_file_info_set_size (file_info, size);