Make EMailPartList thread-safe.

Exposing data members in the public struct is unwise, especially when
EMailPartList is used from multiple threads.  Instead keep the members
private and provide a set of thread-safe functions to manipulate them.

1 files changed, 8 insertions, 8 deletions

diff --git a/em-format/e-mail-formatter-quote-attachment.c b/em-format/e-mail-formatter-quote-attachment.c
index 5f88d97bff..822c93fc2b 100644
--- a/em-format/e-mail-formatter-quote-attachment.c
+++ b/em-format/e-mail-formatter-quote-attachment.c
@@ -71,21 +71,18 @@ emfqe_attachment_format (EMailFormatterExtension *extension,
 	gchar *text, *html;
 	guint32 text_format_flags;
 	EMailPartAttachment *empa;
-	EMailPart *att_part;
-	GSList *iter;
+	EMailPart *attachment_view_part;
 
 	empa = E_MAIL_PART_ATTACHMENT (part);
 
 	if (!empa->attachment_view_part_id)
 		return FALSE;
 
-	iter = e_mail_part_list_get_iter (
-		context->part_list->list, empa->attachment_view_part_id);
-	if (!iter || !iter->data)
+	attachment_view_part = e_mail_part_list_ref_part (
+		context->part_list, empa->attachment_view_part_id);
+	if (attachment_view_part == NULL)
 		return FALSE;
 
-	att_part = iter->data;
-
 	camel_stream_write_string (stream, "<br><br>", cancellable, NULL);
 
 	text_format_flags =
@@ -110,7 +107,8 @@ emfqe_attachment_format (EMailFormatterExtension *extension,
 		"<blockquote type=cite>\n", cancellable, NULL);
 
 	e_mail_formatter_format_as (
-		formatter, context, att_part, stream, NULL, cancellable);
+		formatter, context, attachment_view_part,
+		stream, NULL, cancellable);
 
 	camel_stream_write_string (
 		stream,
@@ -118,6 +116,8 @@ emfqe_attachment_format (EMailFormatterExtension *extension,
 		"<DATA class=\"ClueFlow\" clear=\"orig\">-->",
 		cancellable, NULL);
 
+	e_mail_part_unref (attachment_view_part);
+
 	return TRUE;
 }