Fix/mute issues found by Coverity scan

This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.

1 files changed, 2 insertions, 0 deletions

diff --git a/e-util/e-send-options.c b/e-util/e-send-options.c
index f586f36f66..c105571f1c 100644
--- a/e-util/e-send-options.c
+++ b/e-util/e-send-options.c
@@ -573,6 +573,7 @@ setup_widgets (ESendOptionsDialog *sod,
 			priv->help_section = g_strdup ("groupwise-placeholder");
 			gtk_widget_hide (priv->completed_label);
 			gtk_widget_hide (priv->when_completed);
+			break;
 		case E_ITEM_TASK:
 			priv->help_section = g_strdup ("groupwise-placeholder");
 			gtk_widget_hide (priv->security_label);
@@ -636,6 +637,7 @@ e_send_options_cb (GtkDialog *dialog,
 	switch (state) {
 		case GTK_RESPONSE_OK:
 			e_send_options_get_widgets_data (sod);
+			/* coverity[fallthrough] */
 		case GTK_RESPONSE_CANCEL:
 			gtk_widget_hide (priv->main);
 			gtk_widget_destroy (priv->main);