General cleanup (camel_mbox_summary_sync): Fixed a memory leak and added

2000-06-28  Jeffrey Stedfast  <fejj@helixcode.com>

	* providers/mbox/camel-mbox-summary.c: General cleanup
	(camel_mbox_summary_sync): Fixed a memory leak and added
	CamelException handling.

	* providers/mbox/camel-mbox-store.c (delete_folder): Fixed a
	memory leak

	* providers/mbox/camel-mbox-folder.c (mbox_append_message):
	Default 'off_t seek' to -1 so as to make sure it's initialized
	before it's used in the case of a bad stat() call.
	(mbox_sync): Updated
	(mbox_expunge): Updated

svn path=/trunk/; revision=3774

1 files changed, 276 insertions, 223 deletions

diff --git a/camel/providers/mbox/camel-mbox-summary.c b/camel/providers/mbox/camel-mbox-summary.c
index 12c1c38274..90f13a7ff2 100644
--- a/camel/providers/mbox/camel-mbox-summary.c
+++ b/camel/providers/mbox/camel-mbox-summary.c
@@ -40,14 +40,14 @@ struct _CamelMboxSummaryPrivate {
 
 #define _PRIVATE(o) (((CamelMboxSummary *)(o))->priv)
 
-static int summary_header_load(CamelFolderSummary *, FILE *);
-static int summary_header_save(CamelFolderSummary *, FILE *);
+static int summary_header_load (CamelFolderSummary *, FILE *);
+static int summary_header_save (CamelFolderSummary *, FILE *);
 
-static CamelMessageInfo * message_info_new(CamelFolderSummary *, struct _header_raw *);
-static CamelMessageInfo * message_info_new_from_parser(CamelFolderSummary *, CamelMimeParser *);
-static CamelMessageInfo * message_info_load(CamelFolderSummary *, FILE *);
-static int		  message_info_save(CamelFolderSummary *, FILE *, CamelMessageInfo *);
-/*static void		  message_info_free(CamelFolderSummary *, CamelMessageInfo *);*/
+static CamelMessageInfo * message_info_new (CamelFolderSummary *, struct _header_raw *);
+static CamelMessageInfo * message_info_new_from_parser (CamelFolderSummary *, CamelMimeParser *);
+static CamelMessageInfo * message_info_load (CamelFolderSummary *, FILE *);
+static int		  message_info_save (CamelFolderSummary *, FILE *, CamelMessageInfo *);
+/*static void		  message_info_free (CamelFolderSummary *, CamelMessageInfo *);*/
 
 static void camel_mbox_summary_class_init (CamelMboxSummaryClass *klass);
 static void camel_mbox_summary_init       (CamelMboxSummary *obj);
@@ -124,11 +124,11 @@ camel_mbox_summary_init (CamelMboxSummary *obj)
 static void
 camel_mbox_summary_finalise (GtkObject *obj)
 {
-	CamelMboxSummary *mbs = (CamelMboxSummary *)obj;
+	CamelMboxSummary *mbs = CAMEL_MBOX_SUMMARY (obj);
 
-	g_free(mbs->folder_path);
+	g_free (mbs->folder_path);
 
-	((GtkObjectClass *)(camel_mbox_summary_parent))->finalize((GtkObject *)obj);
+	((GtkObjectClass *)(camel_mbox_summary_parent))->finalize(GTK_OBJECT (obj));
 }
 
 /**
@@ -141,185 +141,200 @@ camel_mbox_summary_finalise (GtkObject *obj)
 CamelMboxSummary *
 camel_mbox_summary_new (const char *filename, const char *mbox_name, ibex *index)
 {
-	CamelMboxSummary *new = CAMEL_MBOX_SUMMARY ( gtk_type_new (camel_mbox_summary_get_type ()));
+	CamelMboxSummary *new = CAMEL_MBOX_SUMMARY (gtk_type_new (camel_mbox_summary_get_type ()));
+	
 	if (new) {
 		/* ?? */
-		camel_folder_summary_set_build_content((CamelFolderSummary *)new, TRUE);
-		camel_folder_summary_set_filename((CamelFolderSummary *)new, filename);
-		new->folder_path = g_strdup(mbox_name);
+		camel_folder_summary_set_build_content (CAMEL_FOLDER_SUMMARY (new), TRUE);
+		camel_folder_summary_set_filename (CAMEL_FOLDER_SUMMARY (new), filename);
+		new->folder_path = g_strdup (mbox_name);
 		new->index = index;
 	}
 	return new;
 }
 
-
-static int summary_header_load(CamelFolderSummary *s, FILE *in)
+static int
+summary_header_load (CamelFolderSummary *s, FILE *in)
 {
-	CamelMboxSummary *mbs = (CamelMboxSummary *)s;
+	CamelMboxSummary *mbs = CAMEL_MBOX_SUMMARY (s);
 
-	if (((CamelFolderSummaryClass *)camel_mbox_summary_parent)->summary_header_load(s, in) == -1)
+	if (((CamelFolderSummaryClass *)camel_mbox_summary_parent)->summary_header_load (s, in) == -1)
 		return -1;
 
-	return camel_folder_summary_decode_uint32(in, &mbs->folder_size);
+	return camel_folder_summary_decode_uint32 (in, &mbs->folder_size);
 }
 
-static int summary_header_save(CamelFolderSummary *s, FILE *out)
+static int
+summary_header_save (CamelFolderSummary *s, FILE *out)
 {
-	CamelMboxSummary *mbs = (CamelMboxSummary *)s;
+	CamelMboxSummary *mbs = CAMEL_MBOX_SUMMARY (s);
 
-	if (((CamelFolderSummaryClass *)camel_mbox_summary_parent)->summary_header_save(s, out) == -1)
+	if (((CamelFolderSummaryClass *)camel_mbox_summary_parent)->summary_header_save (s, out) == -1)
 		return -1;
 
-	return camel_folder_summary_encode_uint32(out, mbs->folder_size);
+	return camel_folder_summary_encode_uint32 (out, mbs->folder_size);
 }
 
 static int
-header_evolution_decode(const char *in, guint32 *uid, guint32 *flags)
+header_evolution_decode (const char *in, guint32 *uid, guint32 *flags)
 {
         char *header;
-        if (in
-            && (header = header_token_decode(in))) {
-                if (strlen(header) == strlen("00000000-0000")
-                    && sscanf(header, "%08x-%04x", uid, flags) == 2) {
-                        g_free(header);
+	
+        if (in && (header = header_token_decode(in))) {
+                if (strlen (header) == strlen ("00000000-0000")
+                    && sscanf (header, "%08x-%04x", uid, flags) == 2) {
+                        g_free (header);
                         return *uid;
                 }
-                g_free(header);
+                g_free (header);
         }
 
         return -1;
 }
 
 static char *
-header_evolution_encode(guint32 uid, guint32 flags)
+header_evolution_encode (guint32 uid, guint32 flags)
 {
-	return g_strdup_printf("%08x-%04x", uid, flags & 0xffff);
+	return g_strdup_printf ("%08x-%04x", uid, flags & 0xffff);
 }
 
-static CamelMessageInfo * message_info_new(CamelFolderSummary *s, struct _header_raw *h)
+static CamelMessageInfo *
+message_info_new (CamelFolderSummary *s, struct _header_raw *h)
 {
 	CamelMessageInfo *mi;
 
-	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_new(s, h);
+	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_new (s, h);
 	if (mi) {
 		const char *xev;
 		guint32 uid, flags;
 		CamelMboxMessageInfo *mbi = (CamelMboxMessageInfo *)mi;
 
-		xev = header_raw_find(&h, "X-Evolution", NULL);
-		if (xev
-		    && header_evolution_decode(xev, &uid, &flags) != -1) {
-			g_free(mi->uid);
-			mi->uid = g_strdup_printf("%u", uid);
+		xev = header_raw_find (&h, "X-Evolution", NULL);
+		if (xev && header_evolution_decode(xev, &uid, &flags) != -1) {
+			g_free (mi->uid);
+			mi->uid = g_strdup_printf ("%u", uid);
 			mi->flags = flags;
 		} else {
 			/* to indicate it has no xev header? */
-			mi->flags |= CAMEL_MESSAGE_FOLDER_FLAGGED|CAMEL_MESSAGE_FOLDER_NOXEV;
-			mi->uid = g_strdup_printf("%u", camel_folder_summary_next_uid(s));
+			mi->flags |= CAMEL_MESSAGE_FOLDER_FLAGGED | CAMEL_MESSAGE_FOLDER_NOXEV;
+			mi->uid = g_strdup_printf ("%u", camel_folder_summary_next_uid (s));
 		}
 		mbi->frompos = -1;
 	}
+	
 	return mi;
 }
 
-static CamelMessageInfo * message_info_new_from_parser(CamelFolderSummary *s, CamelMimeParser *mp)
+static CamelMessageInfo *
+message_info_new_from_parser (CamelFolderSummary *s, CamelMimeParser *mp)
 {
 	CamelMessageInfo *mi;
-	CamelMboxSummary *mbs = (CamelMboxSummary *)s;
+	CamelMboxSummary *mbs = CAMEL_MBOX_SUMMARY (s);
 
-	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_new_from_parser(s, mp);
+	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_new_from_parser (s, mp);
 	if (mi) {
 		CamelMboxMessageInfo *mbi = (CamelMboxMessageInfo *)mi;
 
-		mbi->frompos = camel_mime_parser_tell_start_from(mp);
+		mbi->frompos = camel_mime_parser_tell_start_from (mp);
 
 		/* do we want to index this message as we add it, as well? */
 		if (mbs->index_force
 		    || (mi->flags & CAMEL_MESSAGE_FOLDER_FLAGGED) != 0
 		    || !ibex_contains_name(mbs->index, mi->uid)) {
-			camel_folder_summary_set_index(s, mbs->index);
+			
+			camel_folder_summary_set_index (s, mbs->index);
 		} else {
-			camel_folder_summary_set_index(s, NULL);
+			camel_folder_summary_set_index (s, NULL);
 		}
 	}
+	
 	return mi;
 }
 
-static CamelMessageInfo * message_info_load(CamelFolderSummary *s, FILE *in)
+static CamelMessageInfo *
+message_info_load (CamelFolderSummary *s, FILE *in)
 {
 	CamelMessageInfo *mi;
 
-	io(printf("loading mbox message info\n"));
+	io (printf ("loading mbox message info\n"));
 
-	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_load(s, in);
+	mi = ((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_load (s, in);
 	if (mi) {
 		CamelMboxMessageInfo *mbi = (CamelMboxMessageInfo *)mi;
 
-		camel_folder_summary_decode_uint32(in, &mbi->frompos);
+		camel_folder_summary_decode_uint32 (in, &mbi->frompos);
 	}
+	
 	return mi;
 }
 
-static int		  message_info_save(CamelFolderSummary *s, FILE *out, CamelMessageInfo *mi)
+static int
+message_info_save (CamelFolderSummary *s, FILE *out, CamelMessageInfo *mi)
 {
 	CamelMboxMessageInfo *mbi = (CamelMboxMessageInfo *)mi;
 
-	io(printf("saving mbox message info\n"));
+	io (printf ("saving mbox message info\n"));
 
-	((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_save(s, out, mi);
+	((CamelFolderSummaryClass *)camel_mbox_summary_parent)->message_info_save (s, out, mi);
 
-	return camel_folder_summary_encode_uint32(out, mbi->frompos);
+	return camel_folder_summary_encode_uint32 (out, mbi->frompos);
 }
 
 static int
-summary_rebuild(CamelMboxSummary *mbs, off_t offset)
+summary_rebuild (CamelMboxSummary *mbs, off_t offset)
 {
-	CamelFolderSummary *s = (CamelFolderSummary *)mbs;
+	CamelFolderSummary *s = CAMEL_FOLDER_SUMMARY (mbs);
 	CamelMimeParser *mp;
 	int fd;
 	int ok = 0;
 
-	printf("(re)Building summary from %d (%s)\n", (int)offset, mbs->folder_path);
+	printf ("(re)Building summary from %d (%s)\n", (int)offset, mbs->folder_path);
 
-	fd = open(mbs->folder_path, O_RDONLY);
-	mp = camel_mime_parser_new();
-	camel_mime_parser_init_with_fd(mp, fd);
-	camel_mime_parser_scan_from(mp, TRUE);
-	camel_mime_parser_seek(mp, offset, SEEK_SET);
+	fd = open (mbs->folder_path, O_RDONLY);
+	if (fd == -1) {
+		printf ("%s failed to open: %s", mbs->folder_path, strerror (errno));
+		return -1;
+	}
+	
+	mp = camel_mime_parser_new ();
+	camel_mime_parser_init_with_fd (mp, fd);
+	camel_mime_parser_scan_from (mp, TRUE);
+	camel_mime_parser_seek (mp, offset, SEEK_SET);
 
 	if (offset > 0) {
-		if (camel_mime_parser_step(mp, NULL, NULL) == HSCAN_FROM) {
-			if (camel_mime_parser_tell_start_from(mp) != offset) {
-				g_warning("The next message didn't start where I expected\nbuilding summary from start");
-				camel_mime_parser_drop_step(mp);
+		if (camel_mime_parser_step (mp, NULL, NULL) == HSCAN_FROM) {
+			if (camel_mime_parser_tell_start_from (mp) != offset) {
+				g_warning ("The next message didn't start where I expected\nbuilding summary from start");
+				camel_mime_parser_drop_step (mp);
 				offset = 0;
-				camel_mime_parser_seek(mp, offset, SEEK_SET);
-				camel_folder_summary_clear((CamelFolderSummary *)mbs);
+				camel_mime_parser_seek (mp, offset, SEEK_SET);
+				camel_folder_summary_clear (CAMEL_FOLDER_SUMMARY (mbs));
 			} else {
-				camel_mime_parser_unstep(mp);
+				camel_mime_parser_unstep (mp);
 			}
 		} else {
-			gtk_object_unref((GtkObject *)mp);
+			gtk_object_unref (GTK_OBJECT (mp));
 			/* end of file - no content? */
-			printf("We radn out of file?\n");
+			printf("We ran out of file?\n");
 			return -1;
 		}
 	}
 
-	while (camel_mime_parser_step(mp, NULL, NULL) == HSCAN_FROM) {
+	while (camel_mime_parser_step (mp, NULL, NULL) == HSCAN_FROM) {
 		CamelMessageInfo *info;
 
-		info = camel_folder_summary_add_from_parser((CamelFolderSummary *)mbs, mp);
+		info = camel_folder_summary_add_from_parser (CAMEL_FOLDER_SUMMARY (mbs), mp);
 		if (info == NULL) {
-			printf("Could not build info from file?\n");
+			printf ("Could not build info from file?\n");
 			ok = -1;
 			break;
 		}
 
-		g_assert(camel_mime_parser_step(mp, NULL, NULL) == HSCAN_FROM_END);
+		g_assert (camel_mime_parser_step (mp, NULL, NULL) == HSCAN_FROM_END);
 	}
 
-	gtk_object_unref((GtkObject *)mp);
+	gtk_object_unref (GTK_OBJECT (mp));
+	
 	/* update the file size/mtime in the summary */
 	if (ok != -1) {
 		struct stat st;
@@ -334,12 +349,12 @@ summary_rebuild(CamelMboxSummary *mbs, off_t offset)
 }
 
 int
-camel_mbox_summary_update(CamelMboxSummary *mbs, off_t offset)
+camel_mbox_summary_update (CamelMboxSummary *mbs, off_t offset)
 {
 	int ret;
 
 	mbs->index_force = FALSE;
-	ret = summary_rebuild(mbs, offset);
+	ret = summary_rebuild (mbs, offset);
 
 #if 0
 #warning "Saving full summary and index after every summarisation is slow ..."
@@ -356,9 +371,9 @@ camel_mbox_summary_update(CamelMboxSummary *mbs, off_t offset)
 }
 
 int
-camel_mbox_summary_load(CamelMboxSummary *mbs, int forceindex)
+camel_mbox_summary_load (CamelMboxSummary *mbs, int forceindex)
 {
-	CamelFolderSummary *s = (CamelFolderSummary *)mbs;
+	CamelFolderSummary *s = CAMEL_FOLDER_SUMMARY (mbs);
 	struct stat st;
 	int ret = 0;
 	off_t minstart;
@@ -366,17 +381,17 @@ camel_mbox_summary_load(CamelMboxSummary *mbs, int forceindex)
 	mbs->index_force = forceindex;
 
 	/* is the summary out of date? */
-	if (stat(mbs->folder_path, &st) == -1) {
-		camel_folder_summary_clear(s);
-		printf("Cannot summarise folder: '%s': %s\n", mbs->folder_path, strerror(errno));
+	if (stat (mbs->folder_path, &st) == -1) {
+		camel_folder_summary_clear (s);
+		printf ("Cannot summarise folder: '%s': %s\n", mbs->folder_path, strerror(errno));
 		return -1;
 	}
 
-	if (forceindex || camel_folder_summary_load(s) == -1) {
+	if (forceindex || camel_folder_summary_load (s) == -1) {
 		printf ("REBUILDING SUMMARY: %s\n",
 			forceindex ? "Summary non-existent." : "Summary load failed.");
-		camel_folder_summary_clear(s);
-		ret = summary_rebuild(mbs, 0);
+		camel_folder_summary_clear (s);
+		ret = summary_rebuild (mbs, 0);
 	} else {
 		minstart = st.st_size;
 #if 0
@@ -395,30 +410,30 @@ camel_mbox_summary_load(CamelMboxSummary *mbs, int forceindex)
 #endif
 		/* is the summary uptodate? */
 		if (st.st_size == mbs->folder_size && st.st_mtime == s->time) {
-			printf("Summary time and date match mbox\n");
+			printf ("Summary time and date match mbox\n");
 			if (minstart < st.st_size) {
 				/* FIXME: Only clear the messages and reindex from this point forward */
 				printf ("REBUILDING SUMMARY: Index file is incomplete.\n");
-				camel_folder_summary_clear(s);
-				ret = summary_rebuild(mbs, 0);
+				camel_folder_summary_clear (s);
+				ret = summary_rebuild (mbs, 0);
 			}
 		} else {
 			if (mbs->folder_size < st.st_size) {
-				printf("REBUILDING SUMMARY: Summary is for a smaller mbox\n");
+				printf ("REBUILDING SUMMARY: Summary is for a smaller mbox\n");
 				if (minstart < mbs->folder_size) {
 					/* FIXME: only make it rebuild as necessary */
-					camel_folder_summary_clear(s);
-					ret = summary_rebuild(mbs, 0);
+					camel_folder_summary_clear (s);
+					ret = summary_rebuild (mbs, 0);
 				} else {
-					ret = summary_rebuild(mbs, mbs->folder_size);
+					ret = summary_rebuild (mbs, mbs->folder_size);
 				}
 			} else {
 				if (mbs->folder_size > st.st_size)
-					printf("REBUILDING_SUMMARY: Summary is for a bigger mbox\n");
+					printf ("REBUILDING_SUMMARY: Summary is for a bigger mbox\n");
 				else
-					printf("REBUILDING SUMMARY: Summary is for an older mbox\n");
-				camel_folder_summary_clear(s);
-				ret = summary_rebuild(mbs, 0);
+					printf ("REBUILDING SUMMARY: Summary is for an older mbox\n");
+				camel_folder_summary_clear (s);
+				ret = summary_rebuild (mbs, 0);
 			}
 		}
 	}
@@ -426,20 +441,20 @@ camel_mbox_summary_load(CamelMboxSummary *mbs, int forceindex)
 	if (ret != -1) {
 		mbs->folder_size = st.st_size;
 		s->time = st.st_mtime;
-		printf("saving summary\n");
-		if (camel_folder_summary_save(s) == -1)
-			g_warning("Could not save summary: %s", strerror(errno));
-		printf("summary saved\n");
+		printf ("saving summary\n");
+		if (camel_folder_summary_save (s) == -1)
+			g_warning("Could not save summary: %s", strerror (errno));
+		printf ("summary saved\n");
 		if (mbs->index)
-			ibex_save(mbs->index);
-		printf("ibex saved\n");
+			ibex_save (mbs->index);
+		printf ("ibex saved\n");
 	}
 
 	return ret;
 }
 
 static int
-header_write(int fd, struct _header_raw *header, char *xevline)
+header_write (int fd, struct _header_raw *header, char *xevline)
 {
         struct iovec iv[4];
         int outlen = 0, len;
@@ -450,7 +465,7 @@ header_write(int fd, struct _header_raw *header, char *xevline)
         iv[3].iov_len = 1;
 
         while (header) {
-		if (strcasecmp(header->name, "X-Evolution")) {
+		if (strcasecmp (header->name, "X-Evolution")) {
 			iv[0].iov_base = header->name;
 			iv[0].iov_len = strlen(header->name);
 			iv[2].iov_base = header->value;
@@ -468,14 +483,14 @@ header_write(int fd, struct _header_raw *header, char *xevline)
         }
 
         iv[0].iov_base = "X-Evolution: ";
-        iv[0].iov_len = strlen(iv[0].iov_base);
+        iv[0].iov_len = strlen (iv[0].iov_base);
         iv[1].iov_base = xevline;
-        iv[1].iov_len = strlen(xevline);
+        iv[1].iov_len = strlen (xevline);
         iv[2].iov_base = "\n\n";
         iv[2].iov_len = 2;
 
 	do {
-		len = writev(fd, iv, 3);
+		len = writev (fd, iv, 3);
 	} while (len == -1 && errno == EINTR);
 
 	if (len == -1)
@@ -483,7 +498,7 @@ header_write(int fd, struct _header_raw *header, char *xevline)
 
 	outlen += 1;
 
-	d(printf("Wrote %d bytes of headers\n", outlen));
+	d(printf ("Wrote %d bytes of headers\n", outlen));
 
         return outlen;
 }
@@ -494,21 +509,21 @@ copy_block(int fromfd, int tofd, off_t start, size_t bytes)
         char buffer[4096];
         int written = 0;
 
-	d(printf("writing %d bytes ... ", bytes));
+	d(printf ("writing %d bytes ... ", bytes));
 
 	if (lseek(fromfd, start, SEEK_SET) != start)
 		return -1;
 
-        while (bytes>0) {
+        while (bytes > 0) {
                 int toread, towrite;
 
                 toread = bytes;
-                if (bytes>4096)
+                if (bytes > 4096)
                         toread = 4096;
                 else
                         toread = bytes;
 		do {
-			towrite = read(fromfd, buffer, toread);
+			towrite = read (fromfd, buffer, toread);
 		} while (towrite == -1 && errno == EINTR);
 
 		if (towrite == -1)
@@ -516,12 +531,12 @@ copy_block(int fromfd, int tofd, off_t start, size_t bytes)
 
                 /* check for 'end of file' */
                 if (towrite == 0) {
-			d(printf("end of file?\n"));
+			d(printf ("end of file?\n"));
                         break;
 		}
 
 		do {
-			toread = write(tofd, buffer, towrite);
+			toread = write (tofd, buffer, towrite);
 		} while (toread == -1 && errno == EINTR);
 
 		if (toread == -1)
@@ -531,22 +546,21 @@ copy_block(int fromfd, int tofd, off_t start, size_t bytes)
                 bytes -= toread;
         }
 
-        d(printf("written %d bytes\n", written));
+        d(printf ("written %d bytes\n", written));
 
         return written;
 }
 
 int
-camel_mbox_summary_sync(CamelMboxSummary *mbs, gboolean expunge)
+camel_mbox_summary_sync (CamelMboxSummary *mbs, gboolean expunge, CamelException *ex)
 {
-	CamelMimeParser *mp=NULL;
+	CamelMimeParser *mp = NULL;
 	int i, count;
 	CamelMboxMessageInfo *info;
-	CamelFolderSummary *s = (CamelFolderSummary *)mbs;
-
-	int fd=-1, fdout=-1;
+	CamelFolderSummary *s = CAMEL_FOLDER_SUMMARY (mbs);
+	int fd = -1, fdout = -1;
 	off_t offset = 0;
-	char *tmpname=0;
+	char *tmpname = NULL;
 	char *buffer, *xevnew = NULL;
 	const char *xev;
 	int len;
@@ -555,18 +569,18 @@ camel_mbox_summary_sync(CamelMboxSummary *mbs, gboolean expunge)
 	struct stat st;
 
 	/* make sure we're in sync */
-	count = camel_folder_summary_count(s);
-	if (count>0) {
-		CamelMessageInfo *mi = camel_folder_summary_index(s, count-1);
-		camel_mbox_summary_update(mbs, mi->content->endpos);
+	count = camel_folder_summary_count (s);
+	if (count > 0) {
+		CamelMessageInfo *mi = camel_folder_summary_index (s, count - 1);
+		camel_mbox_summary_update (mbs, mi->content->endpos);
 	} else {
-		camel_mbox_summary_update(mbs, 0);
+		camel_mbox_summary_update (mbs, 0);
 	}
 
 	/* check if we have any work to do */
-	d(printf("Performing sync, %d messages in inbox\n", count));
-	for (i=0;quick && i<count;i++) {
-		info = (CamelMboxMessageInfo *)camel_folder_summary_index(s, i);
+	d(printf ("Performing sync, %d messages in inbox\n", count));
+	for (i = 0; quick && i < count; i++) {
+		info = (CamelMboxMessageInfo *)camel_folder_summary_index (s, i);
 		if ((expunge && (info->info.flags & CAMEL_MESSAGE_DELETED)) ||
 		    (info->info.flags & CAMEL_MESSAGE_FOLDER_NOXEV))
 			quick = FALSE;
@@ -574,36 +588,43 @@ camel_mbox_summary_sync(CamelMboxSummary *mbs, gboolean expunge)
 			work |= (info->info.flags & CAMEL_MESSAGE_FOLDER_FLAGGED) != 0;
 	}
 
-	d(printf("Options: %s %s %s\n", expunge?"expunge":"", quick?"quick":"", work?"Work":""));
+	d(printf ("Options: %s %s %s\n", expunge ? "expunge" : "", quick ? "quick" : "", work ? "Work" : ""));
 
 	if (quick && !work)
 		return 0;
 
-	fd = open(mbs->folder_path, O_RDWR);
-	if (fd == -1)
+	fd = open (mbs->folder_path, O_RDWR);
+	if (fd == -1) {
+		camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+				      "Could not open summary %s", mbs->folder_path);
 		return -1;
+	}
 
-	mp = camel_mime_parser_new();
-	camel_mime_parser_scan_from(mp, TRUE);
-	camel_mime_parser_init_with_fd(mp, fd);
+	mp = camel_mime_parser_new ();
+	camel_mime_parser_scan_from (mp, TRUE);
+	camel_mime_parser_init_with_fd (mp, fd);
 
 	if (!quick) {
-		tmpname = alloca(strlen(mbs->folder_path)+5);
-		sprintf(tmpname, "%s.tmp", mbs->folder_path);
-		d(printf("Writing tmp file to %s\n", tmpname));
+		tmpname = alloca (strlen (mbs->folder_path) + 5);
+		sprintf (tmpname, "%s.tmp", mbs->folder_path);
+		d(printf ("Writing tmp file to %s\n", tmpname));
 	retry_out:
-		fdout = open(tmpname, O_WRONLY|O_CREAT|O_EXCL, 0600);
+		fdout = open (tmpname, O_WRONLY | O_CREAT | O_EXCL, 0600);
 		if (fdout == -1) {
 			if (errno == EEXIST)
 				if (unlink(tmpname) != -1)
 					goto retry_out;
-			tmpname = 0;
-			g_warning("Something failed (yo!)");
+			
+			free (tmpname);
+			tmpname = NULL;
+			g_warning ("Something failed (yo!)");
+			camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+					      "Cannot open temporary mailbox: %s", strerror (errno));
 			goto error;
 		}
 	}
 
-	for (i=0;i<count;i++) {
+	for (i = 0; i < count; i++) {
 		off_t frompos, bodypos, lastpos;
 		/* This has to be an int, not an off_t, because that's
 		 * what camel_mime_parser_header returns... FIXME.
@@ -612,169 +633,201 @@ camel_mbox_summary_sync(CamelMboxSummary *mbs, gboolean expunge)
 
 		info = (CamelMboxMessageInfo *)camel_folder_summary_index(s, i);
 
-		g_assert(info);
+		g_assert (info);
 
-		d(printf("Looking at message %s\n", info->info.uid));
+		d(printf ("Looking at message %s\n", info->info.uid));
 
 		if (expunge && info->info.flags & CAMEL_MESSAGE_DELETED) {
-			d(printf("Deleting %s\n", info->info.uid));
+			d(printf ("Deleting %s\n", info->info.uid));
 
-			g_assert(!quick);
+			g_assert (!quick);
 			offset -= (info->info.content->endpos - info->frompos);
 			if (mbs->index)
-				ibex_unindex(mbs->index, info->info.uid);
-			camel_folder_summary_remove(s, (CamelMessageInfo *)info);
+				ibex_unindex (mbs->index, info->info.uid);
+			camel_folder_summary_remove (s, (CamelMessageInfo *)info);
 			count--;
 			i--;
 			info = NULL;
-		} else if (info->info.flags & (CAMEL_MESSAGE_FOLDER_NOXEV|CAMEL_MESSAGE_FOLDER_FLAGGED)) {
+		} else if (info->info.flags & (CAMEL_MESSAGE_FOLDER_NOXEV | CAMEL_MESSAGE_FOLDER_FLAGGED)) {
 			int xevok = FALSE;
 
-			d(printf("Updating header for %s flags = %08x\n", info->info.uid, info->info.flags));
+			d(printf ("Updating header for %s flags = %08x\n", info->info.uid, info->info.flags));
 
 			/* find the next message, header parts */
-			camel_mime_parser_seek(mp, info->frompos, SEEK_SET);
-			if (camel_mime_parser_step(mp, &buffer, &len) != HSCAN_FROM) {
-				g_warning("camel_mime_parser_step failed (1)");
+			camel_mime_parser_seek (mp, info->frompos, SEEK_SET);
+			if (camel_mime_parser_step (mp, &buffer, &len) != HSCAN_FROM) {
+				g_warning ("camel_mime_parser_step failed (1)");
 				goto error;
 			}
 
-			if (camel_mime_parser_tell_start_from(mp) != info->frompos) {
-				g_warning("Summary/mbox mismatch, aborting sync");
+			if (camel_mime_parser_tell_start_from (mp) != info->frompos) {
+				g_warning ("Summary/mbox mismatch, aborting sync");
+				camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+						      "Summary mismatch, aborting sync");
 				goto error;
 			}
 			
-			if (camel_mime_parser_step(mp, &buffer, &len) == HSCAN_FROM_END) {
-				g_warning("camel_mime_parser_step failed (2)");
+			if (camel_mime_parser_step (mp, &buffer, &len) == HSCAN_FROM_END) {
+				g_warning ("camel_mime_parser_step failed (2)");
 				goto error;
 			}
 
-			xev = camel_mime_parser_header(mp, "X-Evolution", &xevoffset);
-			if (xev && header_evolution_decode(xev, &uid, &flags) != -1) {
+			xev = camel_mime_parser_header (mp, "X-Evolution", &xevoffset);
+			if (xev && header_evolution_decode (xev, &uid, &flags) != -1) {
 				char name[64];
 
-				sprintf(name, "%u", uid);
-				if (strcmp(name, info->info.uid)) {
-					d(printf("Summary mismatch, aborting leaving mailbox intact\n"));
+				sprintf (name, "%u", uid);
+				if (strcmp (name, info->info.uid)) {
+					d(printf ("Summary mismatch, aborting leaving mailbox intact\n"));
+					camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+							      "Summary mismatch, aborting leaving mailbox intact");
 					goto error;
 				}
 				xevok = TRUE;
 			}
-			xevnew = header_evolution_encode(strtoul(info->info.uid, NULL, 10), info->info.flags & 0xffff);
+			xevnew = header_evolution_encode (strtoul (info->info.uid, NULL, 10), info->info.flags & 0xffff);
 			if (quick) {
 				if (!xevok) {
-					g_warning("The summary told me I had an X-Evolution header, but i dont!");
+					g_warning ("The summary told me I had an X-Evolution header, but i dont!");
+					camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+							      "Summary mismatch, X-Evolution header missing");
 					goto error;
 				}
-				buffer = g_strdup_printf("X-Evolution: %s", xevnew);
+				buffer = g_strdup_printf ("X-Evolution: %s", xevnew);
 				lastpos = lseek (fd, 0, SEEK_CUR);
 				lseek (fd, xevoffset, SEEK_SET);
 				do {
-					len = write(fd, buffer, strlen(buffer));
+					len = write (fd, buffer, strlen (buffer));
 				} while (len == -1 && errno == EINTR);
 				lseek (fd, lastpos, SEEK_SET);
-				g_free(buffer);
+				g_free (buffer);
 				if (len == -1) {
-					g_warning("Yahoo!  len == -1");
+					g_warning ("Yahoo!  len == -1");
 					goto error;
 				}
 			} else {
-				frompos = lseek(fdout, 0, SEEK_CUR);
-				write(fdout, "From -\n", strlen("From -\n"));
-				if (header_write(fdout, camel_mime_parser_headers_raw(mp), xevnew) == -1) {
-					d(printf("Error writing to tmp mailbox\n"));
+				frompos = lseek (fdout, 0, SEEK_CUR);
+				write (fdout, "From -\n", strlen("From -\n"));
+				if (header_write (fdout, camel_mime_parser_headers_raw (mp), xevnew) == -1) {
+					d(printf ("Error writing to tmp mailbox\n"));
+					camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+							      "Error writing to temp mailbox: %s",
+							      strerror (errno));
 					goto error;
 				}
-				bodypos = lseek(fdout, 0, SEEK_CUR);
-				d(printf("pos = %d, endpos = %d, bodypos = %d\n",
-					 info->info.content->pos,
-					 info->info.content->endpos,
-					 info->info.content->bodypos));
-				if (copy_block(fd, fdout, info->info.content->bodypos,
-					       info->info.content->endpos - info->info.content->bodypos) == -1) {
-					g_warning("Cannot copy data to output fd");
+				bodypos = lseek (fdout, 0, SEEK_CUR);
+				d(printf ("pos = %d, endpos = %d, bodypos = %d\n",
+					  (int) info->info.content->pos,
+					  (int) info->info.content->endpos,
+					  (int) info->info.content->bodypos));
+				if (copy_block (fd, fdout, info->info.content->bodypos,
+						info->info.content->endpos - info->info.content->bodypos) == -1) {
+					g_warning ("Cannot copy data to output fd");
+					camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+							      "Cannot copy data to output fd: %s",
+							      strerror (errno));
 					goto error;
 				}
 				info->frompos = frompos;
 				offset = bodypos - info->info.content->bodypos;
 			}
 			info->info.flags &= 0xffff;
-			g_free(xevnew); xevnew = NULL;
-			camel_mime_parser_drop_step(mp);
-			camel_mime_parser_drop_step(mp);
+			g_free (xevnew);
+			xevnew = NULL;
+			camel_mime_parser_drop_step (mp);
+			camel_mime_parser_drop_step (mp);
 		} else {
 			if (!quick) {
-				if (copy_block(fd, fdout, info->frompos,
-					       info->info.content->endpos - info->frompos) == -1) {
-					g_warning("Cannot copy data to output fd");
+				if (copy_block (fd, fdout, info->frompos,
+						info->info.content->endpos - info->frompos) == -1) {
+					g_warning ("Cannot copy data to output fd");
+					camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+							      "Cannot copy data to output fd: %s",
+							      strerror (errno));
 					goto error;
 				}
 				/* update from pos here? */
 				info->frompos += offset;
 			} else {
-				d(printf("Nothing to do for this message\n"));
+				d(printf ("Nothing to do for this message\n"));
 			}
 		}
-		if (!quick && info!=NULL && offset!=0) {
-			d(printf("offsetting content: %d\n", offset));
-			camel_folder_summary_offset_content(info->info.content, offset);
-			d(printf("pos = %d, endpos = %d, bodypos = %d\n",
-				 info->info.content->pos,
-				 info->info.content->endpos,
-				 info->info.content->bodypos));
+		if (!quick && info != NULL && offset != 0) {
+			d(printf ("offsetting content: %d\n", (int) offset));
+			camel_folder_summary_offset_content (info->info.content, offset);
+			d(printf ("pos = %d, endpos = %d, bodypos = %d\n",
+				  (int) info->info.content->pos,
+				  (int) info->info.content->endpos,
+				  (int) info->info.content->bodypos));
 		}
 	}
 
-	d(printf("Closing folders\n"));
+	d(printf ("Closing folders\n"));
 
-	if (close(fd) == -1) {
-		g_warning("Cannot close source folder: %s", strerror(errno));
+	if (close (fd) == -1) {
+		g_warning ("Cannot close source folder: %s", strerror (errno));
+		camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+				      "Could not close source folder %s: %s",
+				      mbs->folder_path, strerror (errno));
 		goto error;
 	}
 
 	if (!quick) {
-		if (close(fdout) == -1) {
-			g_warning("Cannot close tmp folder: %s", strerror(errno));
+		if (close (fdout) == -1) {
+			g_warning ("Cannot close tmp folder: %s", strerror (errno));
+			camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+					      "Could not close temp folder: %s",
+					      strerror (errno));
 			goto error;
 		}
 
-		if (rename(tmpname, mbs->folder_path) == -1) {
-			g_warning("Cannot rename folder: %s", strerror(errno));
+		if (rename (tmpname, mbs->folder_path) == -1) {
+			g_warning ("Cannot rename folder: %s", strerror (errno));
+			camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+					      "Could not rename folder: %s",
+					      strerror (errno));
 			goto error;
 		}
-		tmpname = 0;
+		tmpname = NULL;
 
 		if (mbs->index)
-			ibex_save(mbs->index);
+			ibex_save (mbs->index);
 	}
 
-	if (stat(mbs->folder_path, &st) == -1) {
-		g_warning("Hmm...  stat(mbs->folder_path, &st) == -1");
+	if (stat (mbs->folder_path, &st) == -1) {
+		g_warning ("Hmm...  stat(mbs->folder_path, &st) == -1");
+		camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
+				      "Unknown error: %s",
+				      strerror (errno));
 		goto error;
 	}
 
-	camel_folder_summary_touch(s);
+	camel_folder_summary_touch (s);
 	s->time = st.st_mtime;
 	mbs->folder_size = st.st_size;
-	camel_folder_summary_save(s);
-
-	gtk_object_unref((GtkObject *)mp);
+	camel_folder_summary_save (s);
 
+	gtk_object_unref (GTK_OBJECT (mp));
+	
 	return 0;
-error:
-	d(printf("Error occured: %s\n", strerror(errno)));
-	count = errno;
-
-	close(fd);
-	close(fdout);
-
-	g_free(xevnew);
-
+ error:
+	if (fd != -1)
+		close (fd);
+	
+	if (fdout != -1)
+		close (fdout);
+	
+	g_free (xevnew);
+	
 	if (tmpname)
-		unlink(tmpname);
+		unlink (tmpname);
 	if (mp)
-		gtk_object_unref((GtkObject *)mp);
+		gtk_object_unref (GTK_OBJECT (mp));
 
-	errno = count;
 	return -1;
 }
+
+	
+	
+	
+