fix to show a sample correct implementation.

2000-02-22  bertrand  <Bertrand.Guiheneuf@aful.org>

	* message-list.c (message_list_set_folder):
	fix to show a sample correct implementation.

	* camel-folder.c (camel_folder_get_subfolder):
	(camel_folder_create):
	(camel_folder_delete):
	(camel_folder_delete_messages):
	(camel_folder_list_subfolders):
	(camel_folder_expunge):
	(camel_folder_get_message_by_number):
	(camel_folder_get_message_count):
	(camel_folder_append_message):
	(camel_folder_copy_message_to):
	(camel_folder_get_summary):
	(camel_folder_get_message_uid):
	(camel_folder_get_message_by_uid):
	(camel_folder_get_uid_list):
	Check folder state (open/close) and raise an
	exception if it is not ok.

	* providers/mbox/camel-mbox-folder.c (_create):
	create the file and the path with two different
	names.

	* camel-folder.c (_create): handle the case
	when the folder name starts with '/'

	* camel-exception.c (camel_exception_new): use
	(void) instead of () in decl.

	* camel-exception.h: cosmetic fixes.

	* camel-exception.c (camel_exception_init): new routine.
	Fix a bug in mail/message-list.c


	* camel-folder.h: cosmetic changes.

	* camel-stream-b64.c (reset__static): added a
	reset method. Thanks message-browser to find
	so much bugs :)

	* providers/mbox/Makefile.am (libcamelmbox_la_LIBADD): readd
	Unicode libs.

Fixes and exception handling in camel-folder.
Fixes in mail/evolution-mail to make it not
segfault and to demonstrate a correct implementation.

svn path=/trunk/; revision=1902

1 files changed, 72 insertions, 46 deletions

diff --git a/camel/camel-folder.h b/camel/camel-folder.h
index ebc8e6aa20..a646ce961e 100644
--- a/camel/camel-folder.h
+++ b/camel/camel-folder.h
@@ -212,80 +212,106 @@ GtkType camel_folder_get_type (void);
 
 
 
-CamelFolder *camel_folder_get_subfolder (CamelFolder *folder, 
-				      gchar *folder_name, 
-				      CamelException *ex);
+CamelFolder *      camel_folder_get_subfolder          (CamelFolder *folder, 
+							gchar *folder_name, 
+							CamelException *ex);
 
-void camel_folder_open (CamelFolder *folder, 
-			CamelFolderOpenMode mode, 
-			CamelException *ex);
+void               camel_folder_open                   (CamelFolder *folder, 
+							CamelFolderOpenMode mode, 
+							CamelException *ex);
 
 
-void camel_folder_close (CamelFolder *folder, 
-			 gboolean expunge, 
-			 CamelException *ex);
+void               camel_folder_close                  (CamelFolder *folder, 
+							gboolean expunge, 
+							CamelException *ex);
 
-gboolean camel_folder_create (CamelFolder *folder, CamelException *ex);
-CamelFolder *camel_folder_get_parent_folder (CamelFolder *folder, CamelException *ex);
-CamelStore *camel_folder_get_parent_store (CamelFolder *folder, CamelException *ex);
-GList *camel_folder_list_subfolders (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_create                 (CamelFolder *folder, 
+							CamelException *ex);
+CamelFolder *      camel_folder_get_parent_folder      (CamelFolder *folder, 
+							CamelException *ex);
+CamelStore *       camel_folder_get_parent_store       (CamelFolder *folder, 
+							CamelException *ex);
+GList *            camel_folder_list_subfolders        (CamelFolder *folder, 
+							CamelException *ex);
 
 
 /* delete operations */
-gboolean camel_folder_delete (CamelFolder *folder, gboolean recurse, CamelException *ex);
-gboolean camel_folder_delete_messages (CamelFolder *folder, CamelException *ex);
-GList *camel_folder_expunge (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_delete                 (CamelFolder *folder, 
+							gboolean recurse, 
+							CamelException *ex);
+gboolean           camel_folder_delete_messages        (CamelFolder *folder, 
+							CamelException *ex);
+GList *            camel_folder_expunge                (CamelFolder *folder, 
+							CamelException *ex);
 
 
 /* folder name manipulation operations */
-void camel_folder_set_name (CamelFolder *folder, 
-			    const gchar *name, 
-			    CamelException *ex);
-const gchar *camel_folder_get_name (CamelFolder *folder, CamelException *ex);
-const gchar *camel_folder_get_full_name (CamelFolder *folder, CamelException *ex);
+void               camel_folder_set_name               (CamelFolder *folder, 
+							const gchar *name, 
+							CamelException *ex);
+const gchar *      camel_folder_get_name               (CamelFolder *folder, 
+							CamelException *ex);
+const gchar *      camel_folder_get_full_name          (CamelFolder *folder, 
+							CamelException *ex);
 
 
 /* various properties accessors */
-gboolean camel_folder_exists (CamelFolder *folder, CamelException *ex);
-const GList *camel_folder_list_permanent_flags (CamelFolder *folder, CamelException *ex);
-CamelFolderOpenMode camel_folder_get_mode (CamelFolder *folder, CamelException *ex);
-gboolean camel_folder_is_open (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_exists                 (CamelFolder *folder, 
+							CamelException *ex);
+const GList *      camel_folder_list_permanent_flags   (CamelFolder *folder, 
+							CamelException *ex);
+CamelFolderOpenMode camel_folder_get_mode              (CamelFolder *folder, 
+							CamelException *ex);
+gboolean           camel_folder_is_open                (CamelFolder *folder, 
+							CamelException *ex);
 
 
 
 /* message manipulation */
-void  camel_folder_append_message  (CamelFolder *folder, 
-				    CamelMimeMessage *message, CamelException *ex);
-void camel_folder_copy_message_to (CamelFolder *folder, 
-				   CamelMimeMessage *message, 
-				   CamelFolder *dest_folder, 
-				   CamelException *ex);
+void               camel_folder_append_message         (CamelFolder *folder, 
+							CamelMimeMessage *message, 
+							CamelException *ex);
+void               camel_folder_copy_message_to        (CamelFolder *folder, 
+							CamelMimeMessage *message, 
+							CamelFolder *dest_folder, 
+							CamelException *ex);
 
 
 /* summary related operations */
-gboolean camel_folder_has_summary_capability (CamelFolder *folder, CamelException *ex);
-CamelFolderSummary *camel_folder_get_summary (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_has_summary_capability (CamelFolder *folder, 
+							CamelException *ex);
+CamelFolderSummary *camel_folder_get_summary           (CamelFolder *folder, 
+							CamelException *ex);
 
 
 /* number based access operations */
-gboolean camel_folder_has_message_number_capability (CamelFolder *folder, CamelException *ex);
-CamelMimeMessage *camel_folder_get_message_by_number (CamelFolder *folder, 
-						      gint number, CamelException *ex);
-gint camel_folder_get_message_count (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_has_message_number_capability (CamelFolder *folder, 
+							       CamelException *ex);
+CamelMimeMessage * camel_folder_get_message_by_number (CamelFolder *folder, 
+						       gint number, 
+						       CamelException *ex);
+gint               camel_folder_get_message_count     (CamelFolder *folder, 
+						       CamelException *ex);
 
 
 /* uid based access operations */
-gboolean camel_folder_has_uid_capability (CamelFolder *folder, CamelException *ex);
-const gchar * camel_folder_get_message_uid (CamelFolder *folder, CamelMimeMessage *message, CamelException *ex);
-CamelMimeMessage *camel_folder_get_message_by_uid  (CamelFolder *folder, const gchar *uid, CamelException *ex);
-GList *camel_folder_get_uid_list  (CamelFolder *folder, CamelException *ex);
+gboolean           camel_folder_has_uid_capability    (CamelFolder *folder, 
+						       CamelException *ex);
+const gchar *      camel_folder_get_message_uid       (CamelFolder *folder, 
+						       CamelMimeMessage *message, 
+						       CamelException *ex);
+CamelMimeMessage * camel_folder_get_message_by_uid    (CamelFolder *folder, 
+						       const gchar *uid, 
+						       CamelException *ex);
+GList *            camel_folder_get_uid_list          (CamelFolder *folder, 
+						       CamelException *ex);
 
 /* search api */
-gboolean camel_folder_has_search_capability            (CamelFolder *folder,
-							CamelException *ex);
-GList *camel_folder_search_by_expression  (CamelFolder *folder,
-					   const char *expression,
-					   CamelException *ex);
+gboolean           camel_folder_has_search_capability (CamelFolder *folder,
+						       CamelException *ex);
+GList *            camel_folder_search_by_expression  (CamelFolder *folder,
+						       const char *expression,
+						       CamelException *ex);
 
 #ifdef __cplusplus
 }