Fixes bug #4380 as well as some leftovers from the days of struct tm and

2001-07-11  Federico Mena Quintero  <federico@ximian.com>

	Fixes bug #4380 as well as some leftovers from the days of struct
	tm and some uninitialized values.

	* gui/gnome-cal.c
	(gnome_calendar_on_date_navigator_selection_changed): Initialize
	the icaltimetype structures completely.
	(gnome_calendar_init): Do not reset priv->zone to NULL here, since
	it was set by gnome_calendar_update_config_settings() from
	setup_widgets().

	* gui/calendar-model.c (set_completed): Do not set is_daylight.

	* gui/e-day-view.c (e_day_view_convert_grid_position_to_time):
	Likewise.

	* gui/e-week-view.c (e_week_view_set_timezone): Likewise.

	* cal-util/cal-recur.c (generate_instances_for_chunk): Likewise,
	and initialize start_tt and end_tt completely.

	* cal-util/timeutil.c (time_year_begin_with_zone): Likewise.
	(time_month_begin_with_zone): Likewise.
	(time_week_begin_with_zone): Likewise.
	(time_day_begin_with_zone): Likewise.
	(time_day_end_with_zone): Likewise.
	(time_from_isodate): Likewise.

	* gui/dialogs/task-page.c (task_page_fill_component): Initialize
	icaltime before using it.

	* gui/dialogs/event-page.c (event_page_fill_component): Likewise.

	* gui/dialogs/recurrence-page.c (simple_recur_to_comp): Removed an
	unused icaltimetype.

	* gui/dialogs/task-details-page.c
	(task_details_page_fill_component): Initialize icaltime before
	using it.

svn path=/trunk/; revision=11024

1 files changed, 2 insertions, 10 deletions

diff --git a/calendar/gui/gnome-cal.c b/calendar/gui/gnome-cal.c
index 166f715fa4..cf8d12bc14 100644
--- a/calendar/gui/gnome-cal.c
+++ b/calendar/gui/gnome-cal.c
@@ -506,8 +506,6 @@ gnome_calendar_init (GnomeCalendar *gcal)
 
 	priv->view_collection = NULL;
 	priv->view_menus = NULL;
-
-	priv->zone = NULL;
 }
 
 /* Used from g_hash_table_foreach(); frees an UID string */
@@ -1816,22 +1814,16 @@ gnome_calendar_on_date_navigator_selection_changed (ECalendarItem    *calitem,
 		end_month = g_date_month (&new_end_date);
 		end_day = g_date_day (&new_end_date);
 
+		tt = icaltime_null_time ();
 		tt.year = start_year;
 		tt.month  = start_month;
 		tt.day = start_day;
-		tt.hour = 0;
-		tt.minute  = 0;
-		tt.second  = 0;
-		tt.is_daylight = -1;
 		priv->selection_start_time = icaltime_as_timet_with_zone (tt, priv->zone);
 
+		tt = icaltime_null_time ();
 		tt.year = end_year;
 		tt.month  = end_month;
 		tt.day = end_day;
-		tt.hour = 0;
-		tt.minute  = 0;
-		tt.second  = 0;
-		tt.is_daylight = -1;
 		icaltime_adjust (&tt, 1, 0, 0, 0);
 		priv->selection_end_time = icaltime_as_timet_with_zone (tt, priv->zone);