aboutsummaryrefslogtreecommitdiffstats
path: root/addressbook/backend/pas/TODO
diff options
context:
space:
mode:
authorDan Winship <danw@src.gnome.org>2000-04-02 05:58:27 +0800
committerDan Winship <danw@src.gnome.org>2000-04-02 05:58:27 +0800
commit9e7dabfa8274777916da364b50284cfa51ac9a6f (patch)
tree579b255f6178357a1c2d9e697a423636fb65d619 /addressbook/backend/pas/TODO
parent98690e9f75e909483f857f23bae0f903ee1ed84a (diff)
downloadgsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar.gz
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar.bz2
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar.lz
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar.xz
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.tar.zst
gsoc2013-evolution-9e7dabfa8274777916da364b50284cfa51ac9a6f.zip
Compare mbox_file_size and mbox_modtime to the results of stat()ing the
* providers/mbox/camel-mbox-folder.c (_check_get_or_maybe_generate_summary_file): Compare mbox_file_size and mbox_modtime to the results of stat()ing the mbox file, not the summary file. Duh. (_close): Update the summary's mbox_file_size and mbox_modtime before writing it to disk. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_save, camel_mbox_summary_load): Wow. I must have been tired when I wrote this code. First, the comparison bug above. Second, it was using ntohs and htons instead of ntohl and htonl. Third, I was reading the status flag byte in two different places and thus getting out of sync. Fourth, it was writing out field_length bytes of each header field after having converted field_length to network byte order, resulting in lots of random crap being appended, and the summary files being huge. (Fortunately, since the size/modtime comparison was biffed, the garbage summary read from disk was always immediately discarded.) * providers/mbox/camel-mbox-parser.c (camel_mbox_parse_file): fix an off-by-one error that caused the last-used UID to be reused if the summary file was regenerated. (That one wasn't my fault. :-) svn path=/trunk/; revision=2279
Diffstat (limited to 'addressbook/backend/pas/TODO')
0 files changed, 0 insertions, 0 deletions