diff options
| author | Chris Toshok <toshok@ximian.com> | 2002-08-27 07:03:48 +0800 |
|---|---|---|
| committer | Chris Toshok <toshok@src.gnome.org> | 2002-08-27 07:03:48 +0800 |
| commit | 147fe9f099ebdc8e777b3d6709cc5d409903c3b1 (patch) | |
| tree | 6b6e4f7ca3d72f260570a920a5a4c6243e522498 /addressbook/ChangeLog | |
| parent | b1971b08cd80e57bf20b1a4d7e289de22bff54de (diff) | |
| download | gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar.gz gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar.bz2 gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar.lz gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar.xz gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.tar.zst gsoc2013-evolution-147fe9f099ebdc8e777b3d6709cc5d409903c3b1.zip | |
[ Fixes (almost certainly) #24649, #25494, #27351, and other LDAP search
2002-08-26 Chris Toshok <toshok@ximian.com>
[ Fixes (almost certainly) #24649, #25494, #27351, and other LDAP search crashes ]
* backend/pas/pas-backend-ldap.c (view_destroy): use an EList
instead of a GList to store the book_view's so we don't have weird
issues with modifying the list while it's being traversed.
(find_book_view): same.
(create_card_handler): same.
(remove_card_handler): same.
(modify_card_modify_handler): same.
(poll_ldap): same, and also ref the book_view before calling
ldap_search_op_timeout (and therefore send_pending_adds).
(ldap_search_handler): same.
(ldap_op_add): warn about conflicting ldap msgid's (shouldn't ever
happen..)
(homephone_populate): make this a bit more robust (if values[0] ==
NULL, values[1] won't be valid).
(business_populate): same.
(build_card_from_entry): break out of the prop_info loop when we
get a match, and only set the simple field if the value != NULL.
(ldap_search_dtor): free all the pending adds stuff.
(pas_backend_ldap_process_get_book_view): g_list_prepend =>
e_list_append.
(pas_backend_ldap_remove_client): simplify the removing of the
book (use g_list_remove instead of searching and then using
g_list_remove_link.)
(pas_backend_ldap_destroy): unref the book_views list.
(pas_backend_ldap_init): initialize the EList for book_views.
svn path=/trunk/; revision=17870
Diffstat (limited to 'addressbook/ChangeLog')
| -rw-r--r-- | addressbook/ChangeLog | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog index bfccc93641..df209424be 100644 --- a/addressbook/ChangeLog +++ b/addressbook/ChangeLog @@ -1,3 +1,32 @@ +2002-08-26 Chris Toshok <toshok@ximian.com> + + [ Fixes (almost certainly) #24649, #25494, #27351, and other LDAP search crashes ] + * backend/pas/pas-backend-ldap.c (view_destroy): use an EList + instead of a GList to store the book_view's so we don't have weird + issues with modifying the list while it's being traversed. + (find_book_view): same. + (create_card_handler): same. + (remove_card_handler): same. + (modify_card_modify_handler): same. + (poll_ldap): same, and also ref the book_view before calling + ldap_search_op_timeout (and therefore send_pending_adds). + (ldap_search_handler): same. + (ldap_op_add): warn about conflicting ldap msgid's (shouldn't ever + happen..) + (homephone_populate): make this a bit more robust (if values[0] == + NULL, values[1] won't be valid). + (business_populate): same. + (build_card_from_entry): break out of the prop_info loop when we + get a match, and only set the simple field if the value != NULL. + (ldap_search_dtor): free all the pending adds stuff. + (pas_backend_ldap_process_get_book_view): g_list_prepend => + e_list_append. + (pas_backend_ldap_remove_client): simplify the removing of the + book (use g_list_remove instead of searching and then using + g_list_remove_link.) + (pas_backend_ldap_destroy): unref the book_views list. + (pas_backend_ldap_init): initialize the EList for book_views. + 2002-08-25 Mike Kestner <mkestner@ximian.com> * gui/widgets/e-addressbook-view.c (remove_book_view): stop the |