aboutsummaryrefslogtreecommitdiffstats
path: root/addressbook/ChangeLog
diff options
context:
space:
mode:
authorChris Toshok <toshok@ximian.com>2003-05-14 08:42:36 +0800
committerChris Toshok <toshok@src.gnome.org>2003-05-14 08:42:36 +0800
commit2579e70339ec9fe523115b654f457b6a07367de8 (patch)
tree0f095610a5d1110f06225cb9833e95ace746d92a /addressbook/ChangeLog
parent9c06fd0d7f85ad322ba9e996e64587f60ad19d9d (diff)
downloadgsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar.gz
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar.bz2
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar.lz
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar.xz
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.tar.zst
gsoc2013-evolution-2579e70339ec9fe523115b654f457b6a07367de8.zip
[ fixes several utf8/pango related problems, including bugs #41288,
2003-05-13 Chris Toshok <toshok@ximian.com> [ fixes several utf8/pango related problems, including bugs #41288, #42596, #42604 ] * configure.in (GAL_CURRENT): bump to 3, per mkestner. (GAL_REVISION): drop to 0, per mkestner. * gal/e-text/e-text.c (reset_layout_attrs): we need to convert the start/end bounds of the object to byte indices for the attribute. (reset_layout): in the layout == NULL case don't create the layout then immediately set it again with the same text. also, we need to convert selection_start to a byte index before calling pango_layout_get_cursor_pos. (e_text_draw): remove some #ifdef 0'd code, move the calculation of our initial clip_rect below the xpos/ypos assignments so we don't duplicate the expression. Fix the selection drawing in the multiline case so that it actually works, instead of assuming that all ETexts only have 1 line *boggle*. (get_position_from_xy): this needs to return a utf8 offset. (e_text_copy_clipboard): convert sel_start/sel_end to byte indices before copying. (primary_get_cb): same. (paste_received): validate the input here, and drop the length parameter from e_text_insert. (next_word): convert from an utf8 offset on entry to this function, and return a utf8 offset when we're done. also, remove the call the g_unichar_validate. we validate at all points where text is inserted. (find_offset_into_line): new function used in the backward/forward line code. find the utf8 offset into a line (the number of utf8 characters from a prior \n or beginning of the string.) (_get_position): in general there are lots of changes here because text->selection_start/text->selection_end are utf8 offsets, not byte offsets. fix E_TEP_START_OF_LINE so that hitting Ctrl-a when you're at the beginning of a line doesn't take you to the beginning of the previous line. fix E_TEP_END_OF_LINE in an analogous fashion. for E_TEP_FORWARD_CHARACTER we just increment by 1. for E_TEP_BACKWARD_CHARACTER we just decrement by 1. for E_TEP_BACKWARD_WORD we drop the g_unichar_validate call and simplify things a bit. reimplement E_TEP_FORWARD_LINE/E_TEP_BACKWARD_LINE so they find the current offset into the line, then scan forward/backward for the next/prev line, and put us at the right offset on that line. fix E_TEP_SELECT_WORD so double clicking in the space between words doesn't select both words - if you double click on the trailing edge of the space, it selects the next word. leading edge selects the previous one. for E_TEP_SELECT_ALL use g_utf8_strlen. (e_text_insert): everything that calls this passes a \0 terminated string, so we assume it's \0 terminated (the old code did as well, with calls to strlen) and drop the length parameter. also make sure this is all utf8 happy. (capitalize): use g_utf8_offset_to_pointer instead of just adding text->text and start/end, and remove the validate call. also fix the call to e_text_model_delete and use e_text_model_insert_length instead of e_text_model_insert. (e_text_command): for E_TEP_INSERT, validate the input. for E_TEP_CAPS just use MAX instead of the neat little hack. also, fix the scrolling so that it scrolls properly in both X and Y directions (there are still some hiccups but it's much much better than previously). (e_text_commit_cb): validate the input here. * gal/e-text/e-text-model.c (struct _ETextModelPrivate): just use a GString here and get rid of MAX_LENGTH. (e_text_model_dispose): free GString. (e_text_model_real_validate_position): clean this up a bit. (e_text_model_real_get_text): return the contents of the GString. (e_text_model_real_get_text_length): use g_utf8_strlen here. (e_text_model_real_set_text): convert to GString (e_text_model_real_insert): just call e_text_model_insert_length here instead of duplicating the function. (e_text_model_real_insert_length): convert to utf8/gstring. i.e. convert @position and @length to a bytes and use g_string_insert_len. (e_text_model_real_delete): same, with g_string_erase. (e_text_model_get_text_length): use g_utf8_strlen (e_text_model_strdup_nth_object): convert the length of the object to bytes before copying. (e_text_model_get_nth_object_bounds): calculate start/end properly for u svn path=/trunk/; revision=21163
Diffstat (limited to 'addressbook/ChangeLog')
0 files changed, 0 insertions, 0 deletions