aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNot Zed <NotZed@Ximian.com>2004-05-13 19:24:34 +0800
committerMichael Zucci <zucchi@src.gnome.org>2004-05-13 19:24:34 +0800
commitda7c7d850d66ba98f9e31f3f54dd02d738b7a4c1 (patch)
tree4ba999c9ea109979c67bb9bad4ad353fe8d9c695
parent5a89dabc7cfff27beb866f4e10768f21629bbba4 (diff)
downloadgsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar.gz
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar.bz2
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar.lz
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar.xz
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.tar.zst
gsoc2013-evolution-da7c7d850d66ba98f9e31f3f54dd02d738b7a4c1.zip
Fixes #57644.
2004-05-13 Not Zed <NotZed@Ximian.com> Fixes #57644. * gui/e-day-view.c (row_deleted_check_cb): strdup the uid, as below. (remove_uid_cb): and free it. * gui/e-week-view.c (row_deleted_check_cb): strdup the uid, 'cause otherwise it can go away later as we delete stuff. (remove_uid_cb): free the uid. svn path=/trunk/; revision=25897
-rw-r--r--calendar/ChangeLog10
-rw-r--r--calendar/gui/e-day-view.c5
-rw-r--r--calendar/gui/e-week-view.c7
3 files changed, 17 insertions, 5 deletions
diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index 5b47fe211d..4b950c5e4f 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,5 +1,15 @@
2004-05-13 Not Zed <NotZed@Ximian.com>
+ Fixes #57644.
+
+ * gui/e-day-view.c (row_deleted_check_cb): strdup the uid, as
+ below.
+ (remove_uid_cb): and free it.
+
+ * gui/e-week-view.c (row_deleted_check_cb): strdup the uid, 'cause
+ otherwise it can go away later as we delete stuff.
+ (remove_uid_cb): free the uid.
+
* gui/e-week-view-event-item.c (e_week_view_event_item_draw): add
some array bounds checking as an attempt to isolate the crash in
#57644.
diff --git a/calendar/gui/e-day-view.c b/calendar/gui/e-day-view.c
index df61ee088f..d2ad842313 100644
--- a/calendar/gui/e-day-view.c
+++ b/calendar/gui/e-day-view.c
@@ -668,7 +668,7 @@ row_deleted_check_cb (EDayView *day_view, gint day, gint event_num, gpointer dat
model = e_calendar_view_get_model (E_CALENDAR_VIEW (day_view));
if (!e_cal_model_get_component_for_uid (model, uid))
- g_hash_table_insert (uids, (char *)uid, GINT_TO_POINTER (1));
+ g_hash_table_insert (uids, g_strdup(uid), GINT_TO_POINTER (1));
return TRUE;
}
@@ -677,9 +677,10 @@ static void
remove_uid_cb (gpointer key, gpointer value, gpointer data)
{
EDayView *day_view = data;
- const char *uid = key;
+ char *uid = key;
e_day_view_foreach_event_with_uid (day_view, uid, e_day_view_remove_event_cb, NULL);
+ g_free(uid);
}
static void
diff --git a/calendar/gui/e-week-view.c b/calendar/gui/e-week-view.c
index 08589305b3..28d3dff4e9 100644
--- a/calendar/gui/e-week-view.c
+++ b/calendar/gui/e-week-view.c
@@ -474,7 +474,7 @@ row_deleted_check_cb (EWeekView *week_view, gint event_num, gpointer data)
model = e_calendar_view_get_model (E_CALENDAR_VIEW (week_view));
if (!e_cal_model_get_component_for_uid (model, uid))
- g_hash_table_insert (uids, (char *)uid, GINT_TO_POINTER (1));
+ g_hash_table_insert (uids, g_strdup(uid), GINT_TO_POINTER (1));
return TRUE;
}
@@ -483,9 +483,10 @@ static void
remove_uid_cb (gpointer key, gpointer value, gpointer data)
{
EWeekView *week_view = data;
- const char *uid = key;
-
+ char *uid = key;
+
e_week_view_foreach_event_with_uid (week_view, uid, e_week_view_remove_event_cb, NULL);
+ g_free(uid);
}
static void