aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Barnes <mbarnes@redhat.com>2011-06-30 23:02:42 +0800
committerRodrigo Moya <rodrigo@gnome-db.org>2011-09-14 20:08:33 +0800
commitc82fcd83e7b9490b0b6beaf6c98593cd2f1446d0 (patch)
treea1de6aee79aee65bede12405bb58acb8fe7c3a41
parent33446a4c605a0e8b8cbc462a1ed1f0af3dc15757 (diff)
downloadgsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar.gz
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar.bz2
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar.lz
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar.xz
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.tar.zst
gsoc2013-evolution-c82fcd83e7b9490b0b6beaf6c98593cd2f1446d0.zip
Bug 653247 - Don't show TIFF documents inline
image/tiff is omitted because it's a multi-page image format, but gdk-pixbuf unconditionally renders the first page only, and doesn't even indicate through meta-data whether multiple pages are present (see bug 335959). Therefore, make no attempt to render TIFF images inline and defer to an application that can handle multi-page TIFF files properly like Evince or Gimp. Once the referenced bug is fixed we can reevaluate this policy.
-rw-r--r--mail/em-format-html.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/mail/em-format-html.c b/mail/em-format-html.c
index 0e8d8d3df7..b7b6e4d784 100644
--- a/mail/em-format-html.c
+++ b/mail/em-format-html.c
@@ -2353,12 +2353,21 @@ efh_image (EMFormat *emf,
stream, "<img hspace=10 vspace=10 src=\"%s\">", puri->cid);
}
+/* Notes:
+ *
+ * image/tiff is omitted because it's a multi-page image format, but
+ * gdk-pixbuf unconditionally renders the first page only, and doesn't
+ * even indicate through meta-data whether multiple pages are present
+ * (see bug 335959). Therefore, make no attempt to render TIFF images
+ * inline and defer to an application that can handle multi-page TIFF
+ * files properly like Evince or Gimp. Once the referenced bug is
+ * fixed we can reevaluate this policy.
+ */
static EMFormatHandler type_builtin_table[] = {
{ (gchar *) "image/gif", efh_image },
{ (gchar *) "image/jpeg", efh_image },
{ (gchar *) "image/png", efh_image },
{ (gchar *) "image/x-png", efh_image },
- { (gchar *) "image/tiff", efh_image },
{ (gchar *) "image/x-bmp", efh_image },
{ (gchar *) "image/bmp", efh_image },
{ (gchar *) "image/svg", efh_image },