diff options
| author | Milan Crha <mcrha@redhat.com> | 2013-07-22 18:03:55 +0800 |
|---|---|---|
| committer | Milan Crha <mcrha@redhat.com> | 2013-07-22 18:03:55 +0800 |
| commit | 5cffe63121e4d1f21b2ed628bcd96f084fef412e (patch) | |
| tree | b779965b84988c706b921f0e1d1ef3a99dd5b07f | |
| parent | 25737061ee2b2d5c92f3c3479ea9d812aeae1c0e (diff) | |
| download | gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar.gz gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar.bz2 gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar.lz gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar.xz gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.tar.zst gsoc2013-evolution-5cffe63121e4d1f21b2ed628bcd96f084fef412e.zip | |
Do not mask CAMEL_ERROR_GENERIC in composer_send_completed()
Any provider can return a generic error code, which makes the check
useless, only hiding important error information from a user. Since
the camel_getaddrinfo() returns CAMEL_SERVICE_ERROR_URL_INVALID,
the check could be adapted and be more useful.
| -rw-r--r-- | mail/em-composer-utils.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/mail/em-composer-utils.c b/mail/em-composer-utils.c index 1980ac902c..d8d9eb7496 100644 --- a/mail/em-composer-utils.c +++ b/mail/em-composer-utils.c @@ -523,9 +523,10 @@ composer_send_completed (GObject *source_object, g_error_matches ( local_error, CAMEL_SERVICE_ERROR, CAMEL_SERVICE_ERROR_UNAVAILABLE) || - /* XXX camel_getaddrinfo() sets this, unfortunately. */ + /* a name resolution failed */ g_error_matches ( - local_error, CAMEL_ERROR, CAMEL_ERROR_GENERIC); + local_error, CAMEL_SERVICE_ERROR, + CAMEL_SERVICE_ERROR_URL_INVALID); if (service_unavailable) { /* Inform the user. */ e_alert_run_dialog_for_args ( |