aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEttore Perazzoli <ettore@src.gnome.org>2000-11-08 02:37:30 +0800
committerEttore Perazzoli <ettore@src.gnome.org>2000-11-08 02:37:30 +0800
commitbe043c8ce6817c80eb2c3909a539d7efcb28dea7 (patch)
tree96cb458d520c6eca0faad4180362940bc4b4cd26
parent3045084721851c09ffc5e18551eaa241d605e3e9 (diff)
downloadgsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar.gz
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar.bz2
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar.lz
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar.xz
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.tar.zst
gsoc2013-evolution-be043c8ce6817c80eb2c3909a539d7efcb28dea7.zip
Fix the default implementation for CamelService::get_name() so that it
returns a malloced string instead of a static one. (A static one breaks the semantics of the method.) svn path=/trunk/; revision=6483
-rw-r--r--camel/ChangeLog5
-rw-r--r--camel/camel-service.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/camel/ChangeLog b/camel/ChangeLog
index 5b12c2bcf7..f3e7b49d29 100644
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,3 +1,8 @@
+2000-11-07 Ettore Perazzoli <ettore@helixcode.com>
+
+ * camel-service.c (get_name): Strdup the "???" string you return,
+ so that the expected semantics for `::get_name()' is respected.
+
2000-11-07 Dan Winship <danw@helixcode.com>
* camel-stream-filter.c (d): Kill debugging, as it causes lots of
diff --git a/camel/camel-service.c b/camel/camel-service.c
index 15702db42f..ee2a5b5431 100644
--- a/camel/camel-service.c
+++ b/camel/camel-service.c
@@ -287,7 +287,7 @@ get_name (CamelService *service, gboolean brief)
{
g_warning ("CamelService::get_name not implemented for `%s'",
camel_type_to_name (CAMEL_OBJECT_GET_TYPE (service)));
- return "???";
+ return g_strdup ("???");
}
/**