aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Trowbridge <trow@ximian.com>2001-10-21 08:57:18 +0800
committerJon Trowbridge <trow@src.gnome.org>2001-10-21 08:57:18 +0800
commit872eec784e2ba1c65ef9e8489a9fc199c4059fc3 (patch)
tree40e30ee980f648ba00b05a9618d29f0556960716
parent17a415bd21dfa41e5ba2b9711a5170d3765d7eac (diff)
downloadgsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar.gz
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar.bz2
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar.lz
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar.xz
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.tar.zst
gsoc2013-evolution-872eec784e2ba1c65ef9e8489a9fc199c4059fc3.zip
Fix memory leak.
2001-10-20 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (name_style_query): Fix memory leak. * gui/widgets/e-addressbook-view.c (jump_to_letter): Free our string vector letter_v when we are done with it. * gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our QuickAdd structure. * gui/component/e-address-popup.c (e_address_popup_construct): Unref our style after we are done with it. svn path=/trunk/; revision=13835
-rw-r--r--addressbook/ChangeLog14
-rw-r--r--addressbook/gui/component/e-address-popup.c1
-rw-r--r--addressbook/gui/component/select-names/e-select-names-completion.c5
-rw-r--r--addressbook/gui/contact-editor/e-contact-quick-add.c1
-rw-r--r--addressbook/gui/widgets/e-addressbook-view.c1
5 files changed, 21 insertions, 1 deletions
diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog
index d3a5a1ec93..2e0c3d8e62 100644
--- a/addressbook/ChangeLog
+++ b/addressbook/ChangeLog
@@ -1,5 +1,19 @@
2001-10-20 Jon Trowbridge <trow@ximian.com>
+ * gui/component/select-names/e-select-names-completion.c
+ (name_style_query): Fix memory leak.
+
+ * gui/widgets/e-addressbook-view.c (jump_to_letter): Free our
+ string vector letter_v when we are done with it.
+
+ * gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our
+ QuickAdd structure.
+
+ * gui/component/e-address-popup.c (e_address_popup_construct):
+ Unref our style after we are done with it.
+
+2001-10-20 Jon Trowbridge <trow@ximian.com>
+
* backend/ebook/e-book.c (activate_factories_for_uri): We
shouldn't leak the info returned by oaf_query.
diff --git a/addressbook/gui/component/e-address-popup.c b/addressbook/gui/component/e-address-popup.c
index 362eee4250..f9e54c4b9e 100644
--- a/addressbook/gui/component/e-address-popup.c
+++ b/addressbook/gui/component/e-address-popup.c
@@ -849,6 +849,7 @@ e_address_popup_construct (EAddressPopup *pop)
GtkStyle *style = gtk_style_copy (gtk_widget_get_style (GTK_WIDGET (name_holder)));
style->bg[0] = color;
gtk_widget_set_style (GTK_WIDGET (name_holder), style);
+ gtk_style_unref (style);
}
pop->generic_view = gtk_frame_new (NULL);
diff --git a/addressbook/gui/component/select-names/e-select-names-completion.c b/addressbook/gui/component/select-names/e-select-names-completion.c
index 403173caa8..0da1b42a50 100644
--- a/addressbook/gui/component/select-names/e-select-names-completion.c
+++ b/addressbook/gui/component/select-names/e-select-names-completion.c
@@ -230,9 +230,12 @@ name_style_query (ESelectNamesCompletion *comp, const gchar *field)
strv = g_strsplit (cpy, " ", 0);
for (i=0; strv[i]; ++i) {
+ gchar *old;
++count;
g_strstrip (strv[i]);
- strv[i] = g_strdup_printf ("(contains \"%s\" \"%s\")", field, strv[i]);
+ old = strv[i];
+ strv[i] = g_strdup_printf ("(contains \"%s\" \"%s\")", field, old);
+ g_free (old);
}
if (count == 1) {
diff --git a/addressbook/gui/contact-editor/e-contact-quick-add.c b/addressbook/gui/contact-editor/e-contact-quick-add.c
index 7b84f50281..637c4019aa 100644
--- a/addressbook/gui/contact-editor/e-contact-quick-add.c
+++ b/addressbook/gui/contact-editor/e-contact-quick-add.c
@@ -219,6 +219,7 @@ static void
edit_card (QuickAdd *qa)
{
e_book_use_local_address_book (ce_have_book, qa);
+ quick_add_unref (qa);
}
static void
diff --git a/addressbook/gui/widgets/e-addressbook-view.c b/addressbook/gui/widgets/e-addressbook-view.c
index 5142d99f2d..76f37b5f00 100644
--- a/addressbook/gui/widgets/e-addressbook-view.c
+++ b/addressbook/gui/widgets/e-addressbook-view.c
@@ -482,6 +482,7 @@ jump_to_letter(GtkWidget *button, LetterClosure *closure)
}
g_string_append (gstr, "))");
query = gstr->str;
+ g_strfreev (letter_v);
g_string_free (gstr, FALSE);
} else {
char s1[6 + 1], s2[6 + 1];