From 7795f72123d8aced9247c512a708583cef62b95a Mon Sep 17 00:00:00 2001 From: Diego Escalante Urrelo Date: Wed, 24 Feb 2010 10:26:28 -0500 Subject: Correctly handle shit+click only in ephy-window If we handle shift+click in EphyWebView default handler then we will be preventing WebKit from getting *any* shift+click event, this breaks shift+click for extending selection. Removing that however makes shift+click browse to links just as click would do. The solution is to prevent policy_decision_required_cb to browse to the clicked link when it includes the shift modifier. Bug #610844 --- embed/ephy-web-view.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'embed') diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c index ca32314d0..129ee3bc7 100644 --- a/embed/ephy-web-view.c +++ b/embed/ephy-web-view.c @@ -526,10 +526,6 @@ ephy_web_view_button_press_event (GtkWidget *widget, GdkEventButton *event) if (event->button == 3 && event->state == GDK_CONTROL_MASK) return FALSE; - /* We use this for downloading. */ - if (event->button == 1 && event->state == GDK_SHIFT_MASK) - return FALSE; - /* Let WebKitWebView handle this. */ return GTK_WIDGET_CLASS (ephy_web_view_parent_class)->button_press_event (widget, event); } -- cgit v1.2.3