From e7fa362332fd9dae8ade423e12c24bb3ab1d3ac6 Mon Sep 17 00:00:00 2001 From: Xan Lopez Date: Sat, 3 Sep 2011 18:30:59 +0200 Subject: HACKING: remove dubious guideline, add guideline for headers --- HACKING | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'HACKING') diff --git a/HACKING b/HACKING index a768611d8..ccaf382fc 100644 --- a/HACKING +++ b/HACKING @@ -1,15 +1,17 @@ In order to keep the code nice and clean we have a few requirements you'll need to stick to in order to get your patch accepted: -- use 2-space no-tabs for indentation (mandatory on new files, old ones will +- Use 2-space no-tabs for indentation (mandatory on new files, old ones will be re-indented eventually. When modifying an existing file with 8-space - indentation keep the old style please) -- Use K&R style for the braces + indentation keep the old style please). +- Use K&R style for the braces. - No braces for one line control clauses. -- please compare with NULL or FALSE isntead of using "!" -- callback functions have a suffix _cb -- all files have to be encoded in UTF-8 +- Callback functions have a suffix _cb. +- All files have to be encoded in UTF-8. - Use char/int/double/..., not gchar/gint/gdouble/... types. +- All implementation files must include first "config.h", followed by + the primary header, followed by a blank line, followed by all the + other headers sorted alphabetically. - data/kr-gnome-indent.cfg is provided as a reference config file for the uncrustify program to get correct indentation in new files. -- cgit v1.2.3