From a2a5043584b00f1ee879c41162ec76060df74bc0 Mon Sep 17 00:00:00 2001 From: Marco Pesenti Gritti Date: Tue, 10 Jun 2003 19:05:29 +0000 Subject: Dont set sort function on idle. The sort is visible and we can crash if 2003-06-10 Marco Pesenti Gritti * src/bookmarks/ephy-topics-selector.c: (ephy_topics_build_ui): Dont set sort function on idle. The sort is visible and we can crash if the dialog is closed very fast. --- ChangeLog | 7 +++++++ src/bookmarks/ephy-topics-selector.c | 13 +++---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index b70d207d5..1fe71429c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2003-06-10 Marco Pesenti Gritti + + * src/bookmarks/ephy-topics-selector.c: (ephy_topics_build_ui): + + Dont set sort function on idle. The sort is visible and we can + crash if the dialog is closed very fast. + 2003-06-10 Marco Pesenti Gritti * lib/egg/eggtoolbar.c: diff --git a/src/bookmarks/ephy-topics-selector.c b/src/bookmarks/ephy-topics-selector.c index 994ed302e..cacf9a1b5 100644 --- a/src/bookmarks/ephy-topics-selector.c +++ b/src/bookmarks/ephy-topics-selector.c @@ -298,15 +298,6 @@ ephy_topics_selector_apply (EphyTopicsSelector *editor) while (gtk_tree_model_iter_next (model, &iter)); } -static gboolean -set_sort_column_id (GtkListStore *model) -{ - gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (model), - COL_TOPIC, - GTK_SORT_ASCENDING); - return FALSE; -} - static gboolean topic_clicked (GtkTreeView *tree_view, GdkEventButton *event, @@ -376,7 +367,9 @@ ephy_topics_build_ui (EphyTopicsSelector *editor) gtk_tree_view_set_model (GTK_TREE_VIEW (editor), GTK_TREE_MODEL (model)); gtk_tree_view_set_headers_visible (GTK_TREE_VIEW (editor), FALSE); - g_idle_add ((GSourceFunc) set_sort_column_id, model); + gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (model), + COL_TOPIC, + GTK_SORT_ASCENDING); g_object_unref (model); /* Has topic column */ -- cgit v1.2.3