From 6e95a5fe46c4be44b37889a273624f87d6fe367e Mon Sep 17 00:00:00 2001 From: Christian Persch Date: Sun, 25 Jan 2004 20:02:53 +0000 Subject: 2004-01-25 Christian Persch * lib/ephy-node-filter.c: (ephy_node_filter_finalize), (ephy_node_filter_new), (ephy_node_filter_add_expression): --- ChangeLog | 7 +++++++ lib/ephy-node-filter.c | 12 +++--------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 815a555f3..526534391 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2004-01-25 Christian Persch + + * lib/ephy-node-filter.c: (ephy_node_filter_finalize), + (ephy_node_filter_new), (ephy_node_filter_add_expression): + + Fix mem leak. + 2004-01-25 Christian Persch * embed/ephy-history.c: (ephy_history_finalize): diff --git a/lib/ephy-node-filter.c b/lib/ephy-node-filter.c index 1625c6ecb..863ddc8eb 100644 --- a/lib/ephy-node-filter.c +++ b/lib/ephy-node-filter.c @@ -139,7 +139,7 @@ ephy_node_filter_finalize (GObject *object) ephy_node_filter_empty (filter); - g_ptr_array_free (filter->priv->levels, FALSE); + g_ptr_array_free (filter->priv->levels, TRUE); G_OBJECT_CLASS (parent_class)->finalize (object); } @@ -147,14 +147,7 @@ ephy_node_filter_finalize (GObject *object) EphyNodeFilter * ephy_node_filter_new (void) { - EphyNodeFilter *filter; - - filter = EPHY_NODE_FILTER (g_object_new (EPHY_TYPE_NODE_FILTER, - NULL)); - - g_return_val_if_fail (filter->priv != NULL, NULL); - - return filter; + return EPHY_NODE_FILTER (g_object_new (EPHY_TYPE_NODE_FILTER, NULL)); } void @@ -165,6 +158,7 @@ ephy_node_filter_add_expression (EphyNodeFilter *filter, while (level >= filter->priv->levels->len) g_ptr_array_add (filter->priv->levels, NULL); + /* FIXME bogosity! This only works because g_list_append (x, data) == x */ g_ptr_array_index (filter->priv->levels, level) = g_list_append (g_ptr_array_index (filter->priv->levels, level), exp); } -- cgit v1.2.3