From 4a9440cdc83655f653029a8acf86ba805743c377 Mon Sep 17 00:00:00 2001 From: Diego Escalante Urrelo Date: Tue, 2 Mar 2010 18:28:57 -0500 Subject: Remove download only after showing its notification Otherwise we can hit a case where the DownloaderView no longer exists (and hence the notification widget) because the removed download was the last one. Bug #611635 --- embed/downloader-view.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embed/downloader-view.c b/embed/downloader-view.c index b7bfd766e..cb2b5ab9f 100644 --- a/embed/downloader-view.c +++ b/embed/downloader-view.c @@ -499,7 +499,6 @@ update_download_row (DownloaderView *dv, WebKitDownload *download) break; } - downloader_view_remove_download (dv, download); #ifdef HAVE_LIBNOTIFY downloaded = g_strdup_printf (_("The file ā€œ%sā€ has been downloaded."), name); @@ -512,6 +511,7 @@ update_download_row (DownloaderView *dv, WebKitDownload *download) g_free (downloaded); #endif + downloader_view_remove_download (dv, download); return; case WEBKIT_DOWNLOAD_STATUS_STARTED: -- cgit v1.2.3