diff options
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | embed/mozilla/EventContext.cpp | 7 |
2 files changed, 12 insertions, 1 deletions
@@ -1,5 +1,11 @@ 2003-02-15 Marco Pesenti Gritti <marco@it.gnome.org> + * embed/mozilla/EventContext.cpp: + + fix casting on big-endian, from galeon. + +2003-02-15 Marco Pesenti Gritti <marco@it.gnome.org> + * data/ui/epiphany-ui.xml.in: * src/ephy-tab.c: (ephy_tab_show_embed_popup): diff --git a/embed/mozilla/EventContext.cpp b/embed/mozilla/EventContext.cpp index 78a01e451..7e07e757b 100644 --- a/embed/mozilla/EventContext.cpp +++ b/embed/mozilla/EventContext.cpp @@ -527,7 +527,12 @@ nsresult EventContext::GetMouseEventInfo (EphyEmbedEvent *info) nsresult result; nsIDOMMouseEvent *aMouseEvent = (nsIDOMMouseEvent*)mEvent; - aMouseEvent->GetButton ((PRUint16*)&info->mouse_button); + /* casting 32-bit guint* to PRUint16* below will break on big-endian */ + PRUint16 btn; + aMouseEvent->GetButton (&btn); + info->mouse_button = (guint)btn; + + /* OTOH, casting only between (un)signedness is safe */ aMouseEvent->GetScreenX ((PRInt32*)&info->mouse_x); aMouseEvent->GetScreenY ((PRInt32*)&info->mouse_y); |