aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ChangeLog7
-rw-r--r--src/ephy-tab.c15
2 files changed, 15 insertions, 7 deletions
diff --git a/ChangeLog b/ChangeLog
index c9f6d1c20..11af7e114 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2003-04-15 Marco Pesenti Gritti <marco@it.gnome.org>
+
+ * src/ephy-tab.c: (ephy_tab_set_favicon):
+
+ Dont set icon on bookmarks when the url is NULL !
+ Fix a bad crasher.
+
2003-04-15 Xan Lopez <xan@masilla.org>
* src/bookmarks/ephy-node-view.c: (ephy_node_view_remove):
diff --git a/src/ephy-tab.c b/src/ephy-tab.c
index dea7707d5..52f668f7b 100644
--- a/src/ephy-tab.c
+++ b/src/ephy-tab.c
@@ -455,13 +455,14 @@ ephy_tab_set_favicon (EphyTab *tab,
GTK_WIDGET (tab->priv->embed),
favicon);
- if (!tab->priv->is_active) return;
-
- eb = ephy_shell_get_bookmarks (ephy_shell);
- ephy_bookmarks_set_icon (eb, tab->priv->location,
- tab->priv->favicon_url);
- ephy_window_update_control (tab->priv->window,
- FaviconControl);
+ if (tab->priv->favicon_url[0] != '\0')
+ {
+ eb = ephy_shell_get_bookmarks (ephy_shell);
+ ephy_bookmarks_set_icon (eb, tab->priv->location,
+ tab->priv->favicon_url);
+ ephy_window_update_control (tab->priv->window,
+ FaviconControl);
+ }
}
/* Private callbacks for embed signals */