diff options
| author | Carlos Garcia Campos <cgarcia@igalia.com> | 2012-09-04 20:48:26 +0800 |
|---|---|---|
| committer | Carlos Garcia Campos <carlosgc@gnome.org> | 2012-09-06 16:25:09 +0800 |
| commit | b70fe20a489b0a89e4f8779551e87698434485a5 (patch) | |
| tree | 08d63f5fce54bd741bea3279fab00ebd7ba65295 /tests | |
| parent | 8712d1d951319e69dabae819d80700023cd920b8 (diff) | |
| download | gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar.gz gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar.bz2 gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar.lz gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar.xz gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.tar.zst gsoc2013-epiphany-b70fe20a489b0a89e4f8779551e87698434485a5.zip | |
ephy-snapshot-service: Split ephy_snapshot_service_get_snapshot_async()
ephy_snapshot_service_get_snapshot_async() receives an option web view
parameter, that it's only used in case the snapshot is not the in the
thumbnails cache. We can split the method into
ephy_snapshot_service_get_snapshot_async() to get a snapshot from a web
view and ephy_snapshot_service_get_snapshot_for_url_async() to get a
snapshot from the cache. The former uses the latter to try first if the
web view URI is in the cache.
Patch includes other cleanups and fixes:
- Add missing ephy_snapshot_service_save_snapshot_finish()
- Add EphySnapshotServiceError to handle errors
- Use GSimpleAsyncResult API instead of using GIOScheduler directly
- Use different async data structs for every async operation
https://bugzilla.gnome.org/show_bug.cgi?id=683327
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/ephy-snapshot-service-test.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/tests/ephy-snapshot-service-test.c b/tests/ephy-snapshot-service-test.c index 2ece2df1e..5c352e040 100644 --- a/tests/ephy-snapshot-service-test.c +++ b/tests/ephy-snapshot-service-test.c @@ -84,7 +84,6 @@ test_snapshot (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI, mtime, NULL, (GAsyncReadyCallback)on_snapshot_ready, @@ -102,7 +101,6 @@ test_cached_snapshot (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI, mtime, NULL, (GAsyncReadyCallback)on_snapshot_ready, @@ -121,7 +119,6 @@ test_many_snapshots (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI "/some"); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/some", mtime, NULL, (GAsyncReadyCallback)on_snapshot_ready, @@ -131,7 +128,6 @@ test_many_snapshots (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI "/other"); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/other", mtime, NULL, (GAsyncReadyCallback)on_snapshot_ready, @@ -141,7 +137,6 @@ test_many_snapshots (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI "/place"); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/place", mtime, NULL, (GAsyncReadyCallback)on_snapshot_ready, @@ -160,7 +155,6 @@ test_snapshot_with_cancellable (void) webkit_web_view_load_uri (webview, TEST_SERVER_URI "/and"); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/and", mtime, cancellable, (GAsyncReadyCallback)on_snapshot_ready, @@ -180,7 +174,6 @@ test_already_cancelled_snapshot (void) g_cancellable_cancel (cancellable); ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/so", mtime, cancellable, (GAsyncReadyCallback)on_snapshot_ready, @@ -207,7 +200,6 @@ test_snapshot_and_timed_cancellation (void) ephy_snapshot_service_get_snapshot_async (service, webview, - TEST_SERVER_URI "/on", mtime, cancellable, (GAsyncReadyCallback)on_snapshot_ready, |