e-file-helpers: Add ephy_file_create_data_uri_for_filename()

It creates a data URI for the given filename. Use the new function when
building error and applications pages.

https://bugzilla.gnome.org/show_bug.cgi?id=677025

1 files changed, 7 insertions, 9 deletions

diff --git a/embed/ephy-request-about.c b/embed/ephy-request-about.c
index e239c1123..bfff22f95 100644
--- a/embed/ephy-request-about.c
+++ b/embed/ephy-request-about.c
@@ -182,19 +182,17 @@ ephy_request_about_send (SoupRequest          *request,
 
     applications = ephy_web_application_get_application_list ();
     for (p = applications; p; p = p->next) {
-      char *img_data = NULL, *img_data_base64 = NULL;
-      gsize data_length;
+      char *icon_uri;
       EphyWebApplication *app = (EphyWebApplication*)p->data;
-      
-      if (g_file_get_contents (app->icon_url, &img_data, &data_length, NULL))
-        img_data_base64 = g_base64_encode ((guchar*)img_data, data_length);
-      g_string_append_printf (data_str, "<tbody><tr><td class=\"icon\"><img width=64 height=64 src=\"data:image/png;base64,%s\">" \
+
+      icon_uri = ephy_file_create_data_uri_for_filename (app->icon_url, "image/png");
+      g_string_append_printf (data_str, "<tbody><tr><td class=\"icon\"><img width=64 height=64 src=\"%s\">" \
                               " </img></td><td class=\"data\"><div class=\"appname\">%s</div><div class=\"appurl\">%s</div></td><td class=\"input\"><input type=\"submit\" value=\"Delete\" id=\"%s\"></td><td class=\"date\">%s <br /> %s</td></tr>",
-                              img_data_base64, app->name, app->url, app->name,
+                              icon_uri ? icon_uri : "",
+                              app->name, app->url, app->name,
                               /* Note for translators: this refers to the installation date. */
                               _("Installed on:"), app->install_date);
-      g_free (img_data_base64);
-      g_free (img_data);
+      g_free (icon_uri);
     }
 
     g_string_append (data_str, "</form></table></body>");