diff options
| author | Christian Persch <chpe@cvs.gnome.org> | 2005-03-15 02:23:14 +0800 |
|---|---|---|
| committer | Christian Persch <chpe@src.gnome.org> | 2005-03-15 02:23:14 +0800 |
| commit | 0b624873bea03ff3116318471312c6321cda62af (patch) | |
| tree | 3dcefbb3bea257182731079f7eb7acdf2d04ab99 | |
| parent | 6115a6c88a16d606713c961462f3fd9a04f2af7c (diff) | |
| download | gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar.gz gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar.bz2 gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar.lz gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar.xz gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.tar.zst gsoc2013-epiphany-0b624873bea03ff3116318471312c6321cda62af.zip | |
Use connect_object, to guard against "title" signal emitted when the
2005-03-14 Christian Persch <chpe@cvs.gnome.org>
* src/ephy-tabs-menu.c: (tab_added_cb):
Use connect_object, to guard against "title" signal emitted
when the window is dying. Fixes bug #169833.
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | src/ephy-tabs-menu.c | 5 |
2 files changed, 10 insertions, 2 deletions
@@ -1,5 +1,12 @@ 2005-03-14 Christian Persch <chpe@cvs.gnome.org> + * src/ephy-tabs-menu.c: (tab_added_cb): + + Use connect_object, to guard against "title" signal emitted + when the window is dying. Fixes bug #169833. + +2005-03-14 Christian Persch <chpe@cvs.gnome.org> + * src/ephy-tabs-menu.c: (tab_removed_cb): Fix signal handler disconnection; bug #170353. diff --git a/src/ephy-tabs-menu.c b/src/ephy-tabs-menu.c index d28bb9a56..c900eab24 100644 --- a/src/ephy-tabs-menu.c +++ b/src/ephy-tabs-menu.c @@ -149,8 +149,9 @@ tab_added_cb (EphyNotebook *notebook, NULL); sync_tab_title (tab, NULL, action); - g_signal_connect (tab, "notify::title", - G_CALLBACK (sync_tab_title), action); + /* make sure the action is alive when handling the signal, see bug #169833 */ + g_signal_connect_object (tab, "notify::title", + G_CALLBACK (sync_tab_title), action, 0); gtk_action_group_add_action_with_accel (priv->action_group, action, NULL); |