diff options
| author | Xan Lopez <xan@src.gnome.org> | 2003-07-14 17:51:37 +0800 |
|---|---|---|
| committer | Xan Lopez <xan@src.gnome.org> | 2003-07-14 17:51:37 +0800 |
| commit | aaf367e6ca143eb22deeee902cbb9955de68305b (patch) | |
| tree | 27eedecccfb5ff49c968f1ae50627625aca0776d | |
| parent | 227e58bfb458aa2d2019992d30ae9fb659718660 (diff) | |
| download | gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar.gz gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar.bz2 gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar.lz gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar.xz gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.tar.zst gsoc2013-epiphany-aaf367e6ca143eb22deeee902cbb9955de68305b.zip | |
We use g_list_prepend to create selections now (in
We use g_list_prepend to create selections now (in ephy_node_view_get_selection()
and inside pdm_cmd_delete_selection), so the last element selected is the first in
the list and we need to use g_list_first instead of _last to make intelligent
selection after removal work on multiple selections.
| -rw-r--r-- | ChangeLog | 10 | ||||
| -rw-r--r-- | lib/widgets/ephy-node-view.c | 2 | ||||
| -rwxr-xr-x | src/pdm-dialog.c | 2 |
3 files changed, 12 insertions, 2 deletions
@@ -1,5 +1,15 @@ 2003-07-14 Xan Lopez <xan@masilla.org> + * lib/widgets/ephy-node-view.c: (ephy_node_view_remove): + * src/pdm-dialog.c: (pdm_cmd_delete_selection): + + We use g_list_prepend to create selections now (in ephy_node_view_get_selection() + and inside pdm_cmd_delete_selection), so the last element selected is the first in + the list and we need to use g_list_first instead of _last to make intelligent selection + after removal work on multiple selections. + +2003-07-14 Xan Lopez <xan@masilla.org> + * src/pdm-dialog.c: (pdm_cmd_delete_selection): Fix leak. diff --git a/lib/widgets/ephy-node-view.c b/lib/widgets/ephy-node-view.c index 6e000358a..c83b92e62 100644 --- a/lib/widgets/ephy-node-view.c +++ b/lib/widgets/ephy-node-view.c @@ -985,7 +985,7 @@ ephy_node_view_remove (EphyNodeView *view) list = ephy_node_view_get_selection (view); g_return_if_fail (list != NULL); - node = g_list_last (list)->data; + node = g_list_first (list)->data; ephy_tree_model_node_iter_from_node (EPHY_TREE_MODEL_NODE (view->priv->nodemodel), node, &iter); egg_tree_model_filter_convert_child_iter_to_iter (EGG_TREE_MODEL_FILTER (view->priv->filtermodel), diff --git a/src/pdm-dialog.c b/src/pdm-dialog.c index 3fc4b68ac..d5ef8cc42 100755 --- a/src/pdm-dialog.c +++ b/src/pdm-dialog.c @@ -361,7 +361,7 @@ pdm_cmd_delete_selection (PdmActionInfo *action) /* Intelligent selection logic, no actual selection yet */ path = gtk_tree_row_reference_get_path - ((GtkTreeRowReference *) g_list_last (rlist)->data); + ((GtkTreeRowReference *) g_list_first (rlist)->data); gtk_tree_model_get_iter (model, &iter, path); gtk_tree_path_free (path); |