diff options
| author | Gustavo Noronha Silva <gns@gnome.org> | 2011-04-18 01:48:28 +0800 |
|---|---|---|
| committer | Gustavo Noronha Silva <gns@gnome.org> | 2011-04-18 20:42:24 +0800 |
| commit | af770e0804aa904ff872f84d42c51aec93d7eea1 (patch) | |
| tree | 7cc68dace357f35df747ab88c5c7b1494e5a0427 | |
| parent | e802e029282a545966e6fe4951c00c4bb5425ea3 (diff) | |
| download | gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar.gz gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar.bz2 gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar.lz gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar.xz gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.tar.zst gsoc2013-epiphany-af770e0804aa904ff872f84d42c51aec93d7eea1.zip | |
Only unset the value after we are done with the string for 'Save Link As...'
We get the string from the GValue without making a copy, so we cannot
unset it before we are done using the string, otherwise we may end up
with our string pointing to garbage.
Bug #646724
| -rw-r--r-- | src/popup-commands.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/popup-commands.c b/src/popup-commands.c index 005a39de8..e7064f16d 100644 --- a/src/popup-commands.c +++ b/src/popup-commands.c @@ -222,7 +222,6 @@ save_property_url (GtkAction *action, download = ephy_download_new_for_uri (location); ephy_download_set_window (download, GTK_WIDGET (window)); - g_value_unset (&value); if (ask_dest) { @@ -250,6 +249,8 @@ save_property_url (GtkAction *action, ephy_download_set_auto_destination (download); ephy_download_start (download); } + + g_value_unset (&value); } void |