diff options
| author | Gustavo Noronha Silva <gns@gnome.org> | 2011-04-18 01:48:28 +0800 |
|---|---|---|
| committer | Xan Lopez <xlopez@igalia.com> | 2011-04-19 03:15:05 +0800 |
| commit | 5112696e8bcd857e3a9278b8fc9bbe59891bbfab (patch) | |
| tree | 6649b8740f7f03b71504ec67504de59deb92026d | |
| parent | 9d106fb898a71bca2d0aa9233b72a6423627942e (diff) | |
| download | gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar.gz gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar.bz2 gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar.lz gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar.xz gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.tar.zst gsoc2013-epiphany-5112696e8bcd857e3a9278b8fc9bbe59891bbfab.zip | |
Only unset the value after we are done with the string for 'Save Link As...'
We get the string from the GValue without making a copy, so we cannot
unset it before we are done using the string, otherwise we may end up
with our string pointing to garbage.
Bug #646724
| -rw-r--r-- | src/popup-commands.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/popup-commands.c b/src/popup-commands.c index 005a39de8..e7064f16d 100644 --- a/src/popup-commands.c +++ b/src/popup-commands.c @@ -222,7 +222,6 @@ save_property_url (GtkAction *action, download = ephy_download_new_for_uri (location); ephy_download_set_window (download, GTK_WIDGET (window)); - g_value_unset (&value); if (ask_dest) { @@ -250,6 +249,8 @@ save_property_url (GtkAction *action, ephy_download_set_auto_destination (download); ephy_download_start (download); } + + g_value_unset (&value); } void |