Windows opened from links are not always popups. Windows with menu bar

2005-05-23  Jean-François Rameau  <jframeau@cvs.gnome.org>

	* src/ephy-shell.c: (ephy_shell_new_window_cb):

	Windows opened from links are not always popups. Windows
	with menu bar toggled on are not considered as popups.
	#304992

2 files changed, 15 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index 627756642..c455069d5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2005-05-23  Jean-François Rameau  <jframeau@cvs.gnome.org>
+
+	* src/ephy-shell.c: (ephy_shell_new_window_cb):
+
+	Windows opened from links are not always popups. Windows
+	with menu bar toggled on are not considered as popups.
+	#304992	
+
 2005-05-22  Christian Persch  <chpe@cvs.gnome.org>
 
 	* configure.ac:
diff --git a/src/ephy-shell.c b/src/ephy-shell.c
index 6d3c57969..ab555f905 100644
--- a/src/ephy-shell.c
+++ b/src/ephy-shell.c
@@ -160,6 +160,7 @@ ephy_shell_new_window_cb (EphyEmbedSingle *single,
 {
 	GtkWidget *parent = NULL;
 	EphyTab *new_tab;
+	gboolean is_popup;
 	EphyNewTabFlags flags = EPHY_NEW_TAB_DONT_SHOW_WINDOW |
 				EPHY_NEW_TAB_APPEND_LAST |
 				EPHY_NEW_TAB_IN_NEW_WINDOW |
@@ -181,10 +182,15 @@ ephy_shell_new_window_cb (EphyEmbedSingle *single,
 		parent = gtk_widget_get_toplevel (GTK_WIDGET (parent_embed));
 	}
 
+	/* what's a popup ? ATM, any window opened with menubar toggled on 
+   	 * is *not* a popup 
+	 */
+	is_popup = (chromemask & EPHY_EMBED_CHROME_MENUBAR) == 0;
+
 	new_tab = ephy_shell_new_tab_full
 		(shell,
 		 EPHY_IS_WINDOW (parent) ? EPHY_WINDOW (parent) : NULL,
-		 NULL, NULL, flags, chromemask, TRUE, 0);
+		 NULL, NULL, flags, chromemask, is_popup, 0);
 
 	return ephy_tab_get_embed (new_tab);
 }