Revert the earlier patch: don't emit tabs-reordered when the tab-added

2004-11-28  Christian Persch  <chpe@cvs.gnome.org>

	* src/ephy-notebook.c: (ephy_notebook_add_tab):

	Revert the earlier patch: don't emit tabs-reordered when
	the tab-added signal handler reordered the tab, since
	ephy_notebook_move_tab does it already.

2 files changed, 10 insertions, 12 deletions

diff --git a/ChangeLog b/ChangeLog
index a29dbec9d..857b10e0d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2004-11-28  Christian Persch  <chpe@cvs.gnome.org>
+
+	* src/ephy-notebook.c: (ephy_notebook_add_tab):
+
+	Revert the earlier patch: don't emit tabs-reordered when
+	the tab-added signal handler reordered the tab, since
+	ephy_notebook_move_tab does it already.
+
 2004-11-26  Christian Persch  <chpe@cvs.gnome.org>
 
 	* src/ephy-shell.c: (ephy_shell_new_tab):
diff --git a/src/ephy-notebook.c b/src/ephy-notebook.c
index 2afb5a1c1..b4d62a3f9 100644
--- a/src/ephy-notebook.c
+++ b/src/ephy-notebook.c
@@ -906,7 +906,6 @@ ephy_notebook_add_tab (EphyNotebook *nb,
 		       gboolean jump_to)
 {
 	GtkWidget *label;
-	int new_position;
 
 	g_return_if_fail (EPHY_IS_TAB (tab));
 
@@ -938,20 +937,11 @@ ephy_notebook_add_tab (EphyNotebook *nb,
 	g_signal_emit (G_OBJECT (nb), signals[TAB_ADDED], 0, tab);
 
 	/* The signal handler may have reordered the tabs */
-	new_position = gtk_notebook_page_num (GTK_NOTEBOOK (nb), GTK_WIDGET (tab));
-
-	/* if the signal handler reordered the tabs, emit "tabs-reordered",
-	 * so that the tabs menu updates itself.
-	 */
-	if (position != new_position)
-	{
-		g_signal_emit (nb, signals[TABS_REORDERED], 0);
-	}
+	position = gtk_notebook_page_num (GTK_NOTEBOOK (nb), GTK_WIDGET (tab));
 
 	if (jump_to)
 	{
-		gtk_notebook_set_current_page (GTK_NOTEBOOK (nb),
-					       new_position);
+		gtk_notebook_set_current_page (GTK_NOTEBOOK (nb), position);
 		g_object_set_data (G_OBJECT (tab), "jump_to",
 				   GINT_TO_POINTER (jump_to));