path: root/src/bookmarks/ephy-bookmarks.c

/*
 *  Copyright (C) 2002-2004 Marco Pesenti Gritti
 *  Copyright (C) 2003, 2004 Christian Persch
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2, or (at your option)
 *  any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 *
 *  $Id$
 */

#include "config.h"

#include "ephy-bookmarks.h"
#include "ephy-bookmarks-type-builtins.h"
#include "ephy-file-helpers.h"
#include "ephy-embed-shell.h"
#include "ephy-shell.h"
#include "ephy-history.h"
#include "ephy-debug.h"
#include "ephy-tree-model-node.h"
#include "ephy-node-common.h"
#include "ephy-bookmarks-export.h"
#include "ephy-bookmarks-import.h"
#include "ephy-bookmark-properties.h"
#include "ephy-prefs.h"
#include "ephy-marshal.h"
#include "ephy-signal-accumulator.h"

#include "eel-gconf-extensions.h"

#include <string.h>
#include <glib/gi18n.h>
#include <libgnomevfs/gnome-vfs-utils.h>
#include <libgnomevfs/gnome-vfs-dns-sd.h>
#include <gtk/gtkmessagedialog.h>
#include <gtk/gtkdialog.h>

#define EPHY_BOOKMARKS_XML_ROOT    "ephy_bookmarks"
#define EPHY_BOOKMARKS_XML_VERSION "1.03"
#define BOOKMARKS_SAVE_DELAY (3 * 1000) /* ms */
#define MAX_FAVORITES_NUM 10
#define UPDATE_URI_DATA_KEY "updated-uri"
#define SD_RESOLVE_TIMEOUT (3 * 1000) /* ms */

#define EPHY_BOOKMARKS_GET_PRIVATE(object)(G_TYPE_INSTANCE_GET_PRIVATE ((object), EPHY_TYPE_BOOKMARKS, EphyBookmarksPrivate))

struct _EphyBookmarksPrivate
{
    gboolean init_defaults;
    gboolean dirty;
    guint save_timeout_id;
    char *xml_file;
    char *rdf_file;
    EphyNodeDb *db;
    EphyNode *bookmarks;
    EphyNode *keywords;
    EphyNode *favorites;
    EphyNode *notcategorized;
    EphyNode *smartbookmarks;
    EphyNode *lower_fav;
    double lower_score;
    GHashTable *props_dialogs;
    guint disable_bookmark_editing_notifier_id;

#ifdef ENABLE_ZEROCONF
    /* Local sites */
    EphyNode *local;
    GnomeVFSDNSSDBrowseHandle *browse_handle;
    GList *resolve_list;
#endif
};

typedef struct
{
    const char *title;
    const char *location;
} EphyBookmarksBookmarkInfo;

static const EphyBookmarksBookmarkInfo default_bookmarks [] =
{
    /* Translators you should change these links to respect your locale.
     * For instance in .nl these should be
     * "http://www.google.nl" and "http://www.google.nl/search?q=%s"
     */
    { N_("Search the web"), N_("http://www.google.com/search?q=%s&ie=UTF-8&oe=UTF-8") }
};
static int n_default_bookmarks = G_N_ELEMENTS (default_bookmarks);

static const char *default_topics [] =
{
    N_("Entertainment"),
    N_("News"),
    N_("Shopping"),
    N_("Sports"),
    N_("Travel"),
    N_("Work")
};
static int n_default_topics = G_N_ELEMENTS (default_topics);

/* Signals */
enum
{
    TREE_CHANGED,
    RESOLVE_ADDRESS,
    LAST_SIGNAL
};

static guint ephy_bookmarks_signals[LAST_SIGNAL] = { 0 };

static void ephy_bookmarks_class_init   (EphyBookmarksClass *klass);
static void ephy_bookmarks_init     (EphyBookmarks *tab);
static void ephy_bookmarks_finalize (GObject *object);
static char *impl_resolve_address   (EphyBookmarks*, const char*, const char*);

static GObjectClass *parent_class = NULL;

GType
ephy_bookmarks_get_type (void)
{
    static GType type = 0;

    if (G_UNLIKELY (type == 0))
    {
        static const GTypeInfo our_info =
        {
            sizeof (EphyBookmarksClass),
            NULL, /* base_init */
            NULL, /* base_finalize */
            (GClassInitFunc) ephy_bookmarks_class_init,
            NULL,
            NULL, /* class_data */
            sizeof (EphyBookmarks),
            0, /* n_preallocs */
            (GInstanceInitFunc) ephy_bookmarks_init
        };
        volatile GType flags_type; /* work around gcc's optimiser */
      
        /* make sure the flags type is known */
            flags_type = EPHY_TYPE_BOOKMARK_PROPERTY;

        type = g_type_register_static (G_TYPE_OBJECT,
                           "EphyBookmarks",
                           &our_info, 0);
    }

    return type;
}

static void
ephy_bookmarks_init_defaults (EphyBookmarks *eb)
{
    int i;

    for (i = 0; i < n_default_topics; i++)
    {
        ephy_bookmarks_add_keyword (eb, _(default_topics[i]));
    }

    for (i = 0; i < n_default_bookmarks; i++)
    {
        EphyNode *bmk;

        bmk = ephy_bookmarks_add (eb, _(default_bookmarks[i].title),
                      _(default_bookmarks[i].location));
    }
}

static void
ephy_bookmarks_class_init (EphyBookmarksClass *klass)
{
    GObjectClass *object_class = G_OBJECT_CLASS (klass);

    parent_class = g_type_class_peek_parent (klass);

    object_class->finalize = ephy_bookmarks_finalize;

    klass->resolve_address = impl_resolve_address;

    ephy_bookmarks_signals[TREE_CHANGED] =
        g_signal_new ("tree-changed",
                  G_OBJECT_CLASS_TYPE (object_class),
                  G_SIGNAL_RUN_LAST,
                  G_STRUCT_OFFSET (EphyBookmarksClass, tree_changed),
                  NULL, NULL,
                  g_cclosure_marshal_VOID__VOID,
                  G_TYPE_NONE,
                  0);

    ephy_bookmarks_signals[RESOLVE_ADDRESS] =
        g_signal_new ("resolve-address",
                  G_OBJECT_CLASS_TYPE (object_class),
                  G_SIGNAL_RUN_LAST,
                  G_STRUCT_OFFSET (EphyBookmarksClass, resolve_address),
                  ephy_signal_accumulator_string, NULL,
                  ephy_marshal_STRING__STRING_STRING,
                  G_TYPE_STRING,
                  2,
                  G_TYPE_STRING,
                  G_TYPE_STRING);

    g_type_class_add_private (object_class, sizeof(EphyBookmarksPrivate));
}

static gboolean
save_filter (EphyNode *node,
         EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;

    return node != priv->bookmarks &&
           node != priv->favorites &&
           node != priv->notcategorized &&
#ifdef ENABLE_ZEROCONF
           node != priv->local;
#else
           TRUE;
#endif
}

#ifdef ENABLE_ZEROCONF
static gboolean
save_filter_local (EphyNode *node,
           EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;

    return !ephy_node_has_child (priv->local, node);
}
#endif

static void
ephy_bookmarks_save (EphyBookmarks *eb)
{

    LOG ("Saving bookmarks");

    ephy_node_db_write_to_xml_safe
        (eb->priv->db,
         (xmlChar *) eb->priv->xml_file,
         (xmlChar *) EPHY_BOOKMARKS_XML_ROOT,
         (xmlChar *) EPHY_BOOKMARKS_XML_VERSION,
         (xmlChar *) "Do not rely on this file, it's only for internal use. Use bookmarks.rdf instead.",
         eb->priv->keywords, (EphyNodeFilterFunc) save_filter, eb,
#ifdef ENABLE_ZEROCONF
         eb->priv->bookmarks, (EphyNodeFilterFunc) save_filter_local, eb,
#else
         eb->priv->bookmarks, NULL, eb,
#endif
         NULL);

    /* Export bookmarks in rdf */
    ephy_bookmarks_export_rdf (eb, eb->priv->rdf_file);
}

static gboolean
save_bookmarks_delayed (EphyBookmarks *bookmarks)
{
    ephy_bookmarks_save (bookmarks);
    bookmarks->priv->dirty = FALSE;
    bookmarks->priv->save_timeout_id = 0;

    return FALSE;
}

static void
ephy_bookmarks_save_delayed (EphyBookmarks *bookmarks, int delay)
{
    if (!bookmarks->priv->dirty)
    {
        bookmarks->priv->dirty = TRUE;

        if (delay > 0)
        {
            bookmarks->priv->save_timeout_id =
                g_timeout_add (BOOKMARKS_SAVE_DELAY,
                           (GSourceFunc) save_bookmarks_delayed,
                           bookmarks);
        }
        else
        {
            bookmarks->priv->save_timeout_id =
                g_idle_add ((GSourceFunc) save_bookmarks_delayed,
                        bookmarks);
        }
    }
}

static double
get_history_item_score (EphyHistory *eh, const char *page)
{
    return ephy_history_get_page_visits (eh, page);
}

static EphyNode *
compute_lower_fav (EphyNode *favorites, double *score)
{
    GPtrArray *children;
    int i;
    EphyHistory *history;
    EphyNode *result = NULL;

    history = EPHY_HISTORY (ephy_embed_shell_get_global_history (embed_shell));

    *score = DBL_MAX;
    children = ephy_node_get_children (favorites);
    for (i = 0; i < children->len; i++)
    {
        const char *url;
        EphyNode *child;
        double item_score;

        child = g_ptr_array_index (children, i);
        url = ephy_node_get_property_string
            (child, EPHY_NODE_BMK_PROP_LOCATION);
        item_score = get_history_item_score (history, url);
        if (*score > item_score)
        {
            *score = item_score;
            result = child;
        }
    }

    if (result == NULL) *score = 0;

    return result;
}

static void
ephy_bookmarks_update_favorites (EphyBookmarks *eb)
{
    eb->priv->lower_fav = compute_lower_fav (eb->priv->favorites,
                         &eb->priv->lower_score);
}

static gboolean
add_to_favorites (EphyBookmarks *eb, EphyNode *node, EphyHistory *eh)
{
    const char *url;
    gboolean full_menu;
    double score;

    if (ephy_node_has_child (eb->priv->favorites, node)) return FALSE;

    url = ephy_node_get_property_string (node, EPHY_NODE_BMK_PROP_LOCATION);
    score = get_history_item_score (eh, url);
    full_menu = ephy_node_get_n_children (eb->priv->favorites)
            >= MAX_FAVORITES_NUM;
    if (full_menu && score < eb->priv->lower_score) return FALSE;

    if (eb->priv->lower_fav && full_menu)
    {
        ephy_node_remove_child (eb->priv->favorites,
                    eb->priv->lower_fav);
    }

    ephy_node_add_child (eb->priv->favorites, node);
    ephy_bookmarks_update_favorites (eb);

    return TRUE;
}

static void
history_site_visited_cb (EphyHistory *gh, const char *url, EphyBookmarks *eb)
{
    EphyNode *node;

    node = ephy_bookmarks_find_bookmark (eb, url);
    if (node == NULL) return;

    add_to_favorites (eb, node, gh);
}

static void
clear_favorites (EphyBookmarks *bookmarks)
{
    EphyNode *node;
    GPtrArray *children;
    int i;
    gboolean was_immutable;

    /* clear the favourites */

    was_immutable = ephy_node_db_is_immutable (bookmarks->priv->db);
    ephy_node_db_set_immutable (bookmarks->priv->db, FALSE);

    node = bookmarks->priv->favorites;
    children = ephy_node_get_children (node);
    for (i = (int) children->len - 1; i >= 0; i--)
    {
        EphyNode *kid;

        kid = g_ptr_array_index (children, i);

        ephy_node_remove_child (node, kid);
    }

    ephy_node_db_set_immutable (bookmarks->priv->db, was_immutable);

    ephy_bookmarks_update_favorites (bookmarks);
}

static void
history_cleared_cb (EphyHistory *history, EphyBookmarks *bookmarks)
{
    clear_favorites (bookmarks);
}

static void
update_bookmark_response_cb (GtkWidget *dialog,
                 int response,
                 EphyNode *bookmark)
{
    GValue value = { 0, };
    char *to_uri;

    if (response == GTK_RESPONSE_ACCEPT)
    {
        to_uri = (char *) g_object_steal_data (G_OBJECT (dialog),
                               UPDATE_URI_DATA_KEY);

        g_value_init (&value, G_TYPE_STRING);
        g_value_take_string (&value, to_uri);
        ephy_node_set_property (bookmark, EPHY_NODE_BMK_PROP_LOCATION,
                    &value);
        g_value_unset (&value);
    }

    gtk_widget_destroy (dialog);
}

static void
update_bookmark_destroy_cb (EphyNode *zombie,
                GtkWidget *dialog)
{
    gtk_widget_destroy (dialog);
}

static void
redirect_cb (EphyHistory *history,
          const char *from_uri,
          const char *to_uri,
          EphyBookmarks *eb)
{
    EphyNode *bookmark;
    GtkWidget *dialog;
    const char *title;

    bookmark = ephy_bookmarks_find_bookmark (eb, from_uri);

    /* FIXME check if there's another update-bookmark dialog up
     * for from_uri' -> from_uri and update it accordingly
     */
    if (bookmark == NULL) return;

    title = ephy_node_get_property_string (bookmark, EPHY_NODE_BMK_PROP_TITLE);

    dialog = gtk_message_dialog_new
            (NULL, GTK_DIALOG_DESTROY_WITH_PARENT,
                GTK_MESSAGE_QUESTION,
                GTK_BUTTONS_NONE,
                /* translators: the %s is the title of the bookmark */
                _("Update bookmark \"%s\"?"),
                title);
    gtk_message_dialog_format_secondary_text
        (GTK_MESSAGE_DIALOG (dialog),
        /* translators: the %s is a URL */
        _("The bookmarked page has moved to \"%s\"."),
        to_uri);

    gtk_dialog_add_button (GTK_DIALOG (dialog),
                _("_Don't Update"), GTK_RESPONSE_REJECT);
    gtk_dialog_add_button (GTK_DIALOG (dialog),
                _("_Update"), GTK_RESPONSE_ACCEPT);
    gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_REJECT);

    gtk_window_set_title (GTK_WINDOW (dialog), _("Update Bookmark?"));
    gtk_window_set_icon_name (GTK_WINDOW (dialog), "web-browser");

    g_object_set_data_full (G_OBJECT (dialog), UPDATE_URI_DATA_KEY,
                g_strdup (to_uri), (GDestroyNotify) g_free);
    g_signal_connect (dialog, "response",
              G_CALLBACK (update_bookmark_response_cb), bookmark);
    ephy_node_signal_connect_object (bookmark,
                     EPHY_NODE_DESTROY,
                     (EphyNodeCallback) update_bookmark_destroy_cb,
                     G_OBJECT (dialog));

    /* this dialogue is unexpected */
    gtk_window_set_focus_on_map (GTK_WINDOW (dialog), FALSE);

    gtk_window_present (GTK_WINDOW (dialog));
}

static void
ephy_setup_history_notifiers (EphyBookmarks *eb)
{
    EphyHistory *history;

    history = EPHY_HISTORY (ephy_embed_shell_get_global_history (embed_shell));

    if (ephy_history_is_enabled (history) == FALSE)
    {
        clear_favorites (eb);
    }

    g_signal_connect (history, "visited",
              G_CALLBACK (history_site_visited_cb), eb);
    g_signal_connect (history, "cleared",
              G_CALLBACK (history_cleared_cb), eb);
    g_signal_connect (history, "redirect",
              G_CALLBACK (redirect_cb), eb);
}

static void
update_bookmark_keywords (EphyBookmarks *eb, EphyNode *bookmark)
{
    GValue value = { 0, };
    GPtrArray *children;
    int i;
    GString *list;
    const char *title;
    char *normalized_keywords, *case_normalized_keywords;

    list = g_string_new (NULL);

    children = ephy_node_get_children (eb->priv->keywords);
    for (i = 0; i < children->len; i++)
    {
        EphyNode *kid;

        kid = g_ptr_array_index (children, i);

        if (kid != eb->priv->notcategorized && 
            kid != eb->priv->favorites &&
            kid != eb->priv->bookmarks &&
#ifdef ENABLE_ZEROCONF
            kid != eb->priv->local &&
#endif
            ephy_node_has_child (kid, bookmark))
        {
            const char *topic;
            topic = ephy_node_get_property_string
                (kid, EPHY_NODE_KEYWORD_PROP_NAME);
            g_string_append (list, topic);
            g_string_append (list, " ");
        }
    }

    title = ephy_node_get_property_string
        (bookmark, EPHY_NODE_BMK_PROP_TITLE);
    g_string_append (list, " ");
    g_string_append (list, title);

    normalized_keywords = g_utf8_normalize (list->str, -1, G_NORMALIZE_ALL);
    case_normalized_keywords = g_utf8_casefold (normalized_keywords, -1);

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, case_normalized_keywords);
    ephy_node_set_property (bookmark, EPHY_NODE_BMK_PROP_KEYWORDS,
                &value);
    g_value_unset (&value);

    g_string_free (list, TRUE);
    g_free (normalized_keywords);
    g_free (case_normalized_keywords);
}

static void
bookmarks_changed_cb (EphyNode *node,
              EphyNode *child,
              guint property_id,
              EphyBookmarks *eb)
{
    if (property_id == EPHY_NODE_BMK_PROP_TITLE)
    {
        update_bookmark_keywords (eb, child);
    }

    ephy_bookmarks_save_delayed (eb, BOOKMARKS_SAVE_DELAY);
}

static void
bookmarks_removed_cb (EphyNode *node,
              EphyNode *child,
              guint old_index,
              EphyBookmarks *eb)
{
    ephy_bookmarks_save_delayed (eb, BOOKMARKS_SAVE_DELAY);
}

static gboolean
bookmark_is_categorized (EphyBookmarks *eb, EphyNode *bookmark)
{
    GPtrArray *children;
    int i;

    children = ephy_node_get_children (eb->priv->keywords);
    for (i = 0; i < children->len; i++)
    {
        EphyNode *kid;

        kid = g_ptr_array_index (children, i);

        if (kid != eb->priv->notcategorized && 
            kid != eb->priv->favorites &&
            kid != eb->priv->bookmarks &&
#ifdef ENABLE_ZEROCONF
            kid != eb->priv->local &&
#endif
            ephy_node_has_child (kid, bookmark))
        {
            return TRUE;
        }
    }

    return FALSE;
}

static void
topics_removed_cb (EphyNode *node,
           EphyNode *child,
           guint old_index,
           EphyBookmarks *eb)
{
    GPtrArray *children;
    int i;

    children = ephy_node_get_children (child);
    for (i = 0; i < children->len; i++)
    {
        EphyNode *kid;

        kid = g_ptr_array_index (children, i);

        if (!bookmark_is_categorized (eb, kid) &&
            !ephy_node_has_child (eb->priv->notcategorized, kid))
        {
            ephy_node_add_child
                (eb->priv->notcategorized, kid);
        }

        update_bookmark_keywords (eb, kid);
    }
}

static void
update_bookmark_editing (EphyBookmarks *eb)
{
    g_object_set (G_OBJECT (eb->priv->db),
              "immutable", eel_gconf_get_boolean (CONF_LOCKDOWN_DISABLE_BOOKMARK_EDITING),
              NULL);
}

static void
disable_bookmark_editing_notifier (GConfClient *client,
                   guint cnxn_id,
                   GConfEntry *entry,
                   EphyBookmarks *eb)
{
    update_bookmark_editing (eb);
}

static void
backup_file (const char *original_filename, const char *extension)
{
    char *template, *backup_filename;
    int result = 0;

    if (g_file_test (original_filename, G_FILE_TEST_EXISTS) == FALSE)
    {
        return;
    }

    template = g_strconcat (original_filename, ".backup-XXXXXX", NULL);
    backup_filename = ephy_file_tmp_filename (template, extension);

    if (backup_filename != NULL)
    {
        result = rename (original_filename, backup_filename);
    }

    if (result >= 0)
    {
        g_message ("Your old bookmarks file was backed up as \"%s\".\n",
               backup_filename);
    }
    else
    {
        g_warning ("Backup failed! Your old bookmarks file was lost.\n");
    }

    g_free (template);
    g_free (backup_filename);
}

#ifdef ENABLE_ZEROCONF

static void
resolve_cb (GnomeVFSDNSSDResolveHandle *handle,
        GnomeVFSResult result,
        const GnomeVFSDNSSDService *service,
        const char *host,
        int port,
        /* const */ GHashTable *text,
        int text_raw_len,
        const char *text_raw,
        EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;
    EphyNode *node;
    GValue value = { 0, };
    const char *path = NULL;
    char *url;

    priv->resolve_list = g_list_remove (priv->resolve_list, handle);

    if (result != GNOME_VFS_OK) return;

    if (text != NULL)
    {
        path = g_hash_table_lookup (text, "path");
    }
    if (path == NULL || path[0] == '\0')
    {
        path = "/";
    }

    url = g_strdup_printf ("http://%s:%d%s", host, port, path);

    node = ephy_node_new (priv->db);
    if (node == NULL) return;

    /* don't allow dragging this node */
    ephy_node_set_is_drag_source (node, FALSE);

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, service->name);
    ephy_node_set_property (node, EPHY_NODE_BMK_PROP_TITLE, &value);
    g_value_unset (&value);

    g_value_init (&value, G_TYPE_STRING);
    g_value_take_string (&value, url);
    ephy_node_set_property (node, EPHY_NODE_BMK_PROP_LOCATION, &value);
    g_value_unset (&value);

    g_value_init (&value, G_TYPE_BOOLEAN);
    g_value_set_boolean (&value, TRUE);
    ephy_node_set_property (node, EPHY_NODE_BMK_PROP_IMMUTABLE, &value);
    g_value_unset (&value);

    ephy_node_add_child (priv->bookmarks, node);
    ephy_node_add_child (priv->local, node);
}

static void
browse_cb (GnomeVFSDNSSDBrowseHandle *handle,
       GnomeVFSDNSSDServiceStatus status,
       const GnomeVFSDNSSDService *service,
       EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;
    GnomeVFSDNSSDResolveHandle *reshandle = NULL;
    GPtrArray *children;
    EphyNode *kid;
    const char *title;
    guint i;

    if (status == GNOME_VFS_DNS_SD_SERVICE_REMOVED)
    {
        /* Find the bookmark to remove */
        children = ephy_node_get_children (priv->local);
        for (i = 0; i < children->len; i++)
        {
            kid = g_ptr_array_index (children, i);
            title = ephy_node_get_property_string (kid, EPHY_NODE_BMK_PROP_TITLE);

            if (g_str_equal (title, service->name))
            {
                ephy_node_remove_child (priv->local, kid);
                break;
            }
        }

        return;
    }

    /* status == GNOME_VFS_DNS_SD_SERVICE_ADDED */

    if (gnome_vfs_dns_sd_resolve (&reshandle,
                      service->name, service->type, service->domain,
                      SD_RESOLVE_TIMEOUT,
                      (GnomeVFSDNSSDResolveCallback) resolve_cb,
                      bookmarks,
                      NULL) == GNOME_VFS_OK)
    {
        priv->resolve_list =
            g_list_prepend (priv->resolve_list, reshandle);
    }
}

static void
ephy_local_bookmarks_init (EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;

    if (gnome_vfs_dns_sd_browse (&priv->browse_handle,
                     "local", "_http._tcp",
                     (GnomeVFSDNSSDBrowseCallback) browse_cb,
                     bookmarks,
                     NULL) != GNOME_VFS_OK)
    {
        priv->browse_handle = NULL;
        ephy_node_remove_child (priv->keywords, priv->local);
    }
}

static void
ephy_local_bookmarks_stop (EphyBookmarks *bookmarks)
{
    EphyBookmarksPrivate *priv = bookmarks->priv;

    if (priv->browse_handle != NULL)
    {
        gnome_vfs_dns_sd_stop_browse (priv->browse_handle);
        priv->browse_handle = NULL;
        ephy_node_remove_child (priv->keywords, priv->local);
    }

    g_list_foreach (priv->resolve_list,
            (GFunc) gnome_vfs_dns_sd_cancel_resolve, NULL);
    g_list_free (priv->resolve_list);
    priv->resolve_list = NULL;
}

#endif /* ENABLE_ZEROCONF */

static void
ephy_bookmarks_init (EphyBookmarks *eb)
{
    GValue value = { 0, };
    EphyNodeDb *db;

    eb->priv = EPHY_BOOKMARKS_GET_PRIVATE (eb);

    db = ephy_node_db_new (EPHY_NODE_DB_BOOKMARKS);
    eb->priv->db = db;

    eb->priv->xml_file = g_build_filename (ephy_dot_dir (),
                           "ephy-bookmarks.xml",
                           NULL);
    eb->priv->rdf_file = g_build_filename (ephy_dot_dir (),
                           "bookmarks.rdf",
                           NULL);

    eb->priv->props_dialogs = g_hash_table_new (g_direct_hash,
                            g_direct_equal);

    /* Bookmarks */
    eb->priv->bookmarks = ephy_node_new_with_id (db, BOOKMARKS_NODE_ID);
    g_value_init (&value, G_TYPE_STRING);
    /* Translators: The text before the "|" is context to help you decide on
     * the correct translation. You MUST OMIT it in the translated string. */
    /* Translators: this topic contains all bookmarks */
    g_value_set_string (&value, Q_("bookmarks|All"));
    ephy_node_set_property (eb->priv->bookmarks,
                EPHY_NODE_KEYWORD_PROP_NAME,
                &value);
    g_value_unset (&value);
    ephy_node_signal_connect_object (eb->priv->bookmarks,
                     EPHY_NODE_CHILD_REMOVED,
                     (EphyNodeCallback) bookmarks_removed_cb,
                     G_OBJECT (eb));
    ephy_node_signal_connect_object (eb->priv->bookmarks,
                     EPHY_NODE_CHILD_CHANGED,
                     (EphyNodeCallback) bookmarks_changed_cb,
                     G_OBJECT (eb));

    /* Keywords */
    eb->priv->keywords = ephy_node_new_with_id (db, KEYWORDS_NODE_ID);
    g_value_init (&value, G_TYPE_INT);
    g_value_set_int (&value, EPHY_NODE_ALL_PRIORITY);
    ephy_node_set_property (eb->priv->bookmarks,
                EPHY_NODE_KEYWORD_PROP_PRIORITY,
                &value);
    g_value_unset (&value);
    ephy_node_signal_connect_object (eb->priv->keywords,
                     EPHY_NODE_CHILD_REMOVED,
                     (EphyNodeCallback) topics_removed_cb,
                     G_OBJECT (eb));

    ephy_node_add_child (eb->priv->keywords,
                 eb->priv->bookmarks);

    /* Favorites */
    eb->priv->favorites = ephy_node_new_with_id (db, FAVORITES_NODE_ID);
    g_value_init (&value, G_TYPE_STRING);
    /* Translators: The text before the "|" is context to help you decide on
     * the correct translation. You MUST OMIT it in the translated string. */
    /* Translators: this topic contains the most used bookmarks */
    g_value_set_string (&value, Q_("bookmarks|Most Visited"));
    ephy_node_set_property (eb->priv->favorites,
                EPHY_NODE_KEYWORD_PROP_NAME,
                &value);
    g_value_unset (&value);
    g_value_init (&value, G_TYPE_INT);
    g_value_set_int (&value, EPHY_NODE_SPECIAL_PRIORITY);
    ephy_node_set_property (eb->priv->favorites,
                EPHY_NODE_KEYWORD_PROP_PRIORITY,
                &value);
    g_value_unset (&value);
    ephy_node_add_child (eb->priv->keywords, eb->priv->favorites);

    /* Not categorized */
    eb->priv->notcategorized = ephy_node_new_with_id (db, BMKS_NOTCATEGORIZED_NODE_ID);
    g_value_init (&value, G_TYPE_STRING);
    /* Translators: The text before the "|" is context to help you decide on
     * the correct translation. You MUST OMIT it in the translated string. */
    /* Translators: this topic contains the not categorized bookmarks */
    g_value_set_string (&value, Q_("bookmarks|Not Categorized"));
    ephy_node_set_property (eb->priv->notcategorized,
                EPHY_NODE_KEYWORD_PROP_NAME,
                &value);
    g_value_unset (&value);
    g_value_init (&value, G_TYPE_INT);
    g_value_set_int (&value, EPHY_NODE_SPECIAL_PRIORITY);
    ephy_node_set_property (eb->priv->notcategorized,
                EPHY_NODE_KEYWORD_PROP_PRIORITY,
                &value);
    g_value_unset (&value);
    ephy_node_add_child (eb->priv->keywords, eb->priv->notcategorized);

#ifdef ENABLE_ZEROCONF
    /* Local Websites */
    eb->priv->local = ephy_node_new_with_id (db, BMKS_LOCAL_NODE_ID);

    /* don't allow drags to this topic */
    ephy_node_set_is_drag_dest (eb->priv->local, FALSE);

    g_value_init (&value, G_TYPE_STRING);
    /* Translators: The text before the "|" is context to help you decide on
     * the correct translation. You MUST OMIT it in the translated string. */
    /* Translators: this is an automatic topic containing local websites bookmarks
     * autodiscovered with zeroconf. */
    g_value_set_string (&value, Q_("bookmarks|Local Sites"));
    ephy_node_set_property (eb->priv->local,
                    EPHY_NODE_KEYWORD_PROP_NAME,
                    &value);
    g_value_unset (&value);
    g_value_init (&value, G_TYPE_INT);
    g_value_set_int (&value, EPHY_NODE_SPECIAL_PRIORITY);
    ephy_node_set_property (eb->priv->local,
                EPHY_NODE_KEYWORD_PROP_PRIORITY,
                &value);
    g_value_unset (&value);
    ephy_node_add_child (eb->priv->keywords, eb->priv->local);
    ephy_local_bookmarks_init (eb);
#endif /* ENABLE_ZEROCONF */

    /* Smart bookmarks */
    eb->priv->smartbookmarks = ephy_node_new_with_id (db, SMARTBOOKMARKS_NODE_ID);

    if (g_file_test (eb->priv->xml_file, G_FILE_TEST_EXISTS) == FALSE
        && g_file_test (eb->priv->rdf_file, G_FILE_TEST_EXISTS) == FALSE)
    {
        eb->priv->init_defaults = TRUE;
    }
    else if (ephy_node_db_load_from_file (eb->priv->db, eb->priv->xml_file,
                          (xmlChar *) EPHY_BOOKMARKS_XML_ROOT,
                          (xmlChar *) EPHY_BOOKMARKS_XML_VERSION) == FALSE)
    {
        /* save the corrupted files so the user can late try to
         * manually recover them. See bug #128308.
         */

        g_warning ("Could not read bookmarks file \"%s\", trying to "
               "re-import bookmarks from \"%s\"\n",
               eb->priv->xml_file, eb->priv->rdf_file);

        backup_file (eb->priv->xml_file, "xml");

        if (ephy_bookmarks_import_rdf (eb, eb->priv->rdf_file) == FALSE)
        {
            backup_file (eb->priv->rdf_file, "rdf");

            eb->priv->init_defaults = TRUE;
        }
    }
    
    if (eb->priv->init_defaults)
    {
        ephy_bookmarks_init_defaults (eb);
    }

    eb->priv->disable_bookmark_editing_notifier_id = eel_gconf_notification_add
        (CONF_LOCKDOWN_DISABLE_BOOKMARK_EDITING,
         (GConfClientNotifyFunc)disable_bookmark_editing_notifier, eb);
    update_bookmark_editing (eb);

    ephy_setup_history_notifiers (eb);
    ephy_bookmarks_update_favorites (eb);
}

static void
ephy_bookmarks_finalize (GObject *object)
{
    EphyBookmarks *eb = EPHY_BOOKMARKS (object);

    eel_gconf_notification_remove (eb->priv->disable_bookmark_editing_notifier_id);

    g_hash_table_destroy (eb->priv->props_dialogs);

    if (eb->priv->save_timeout_id != 0)
    {
        g_source_remove (eb->priv->save_timeout_id);
    }

#ifdef ENABLE_ZEROCONF
    ephy_local_bookmarks_stop (eb);
#endif

    ephy_bookmarks_save (eb);

    ephy_node_unref (eb->priv->bookmarks);
    ephy_node_unref (eb->priv->keywords);
    ephy_node_unref (eb->priv->favorites);
    ephy_node_unref (eb->priv->notcategorized);

    g_object_unref (eb->priv->db);

    g_free (eb->priv->xml_file);
    g_free (eb->priv->rdf_file);

    LOG ("Bookmarks finalized");

    G_OBJECT_CLASS (parent_class)->finalize (object);
}

EphyBookmarks *
ephy_bookmarks_new (void)
{
    EphyBookmarks *eb;

    eb = EPHY_BOOKMARKS (g_object_new (EPHY_TYPE_BOOKMARKS, NULL));

    return eb;
}

static void
update_has_smart_address (EphyBookmarks *bookmarks, EphyNode *bmk, const char *address)
{
    EphyNode *smart_bmks;
    gboolean smart = FALSE, with_options = FALSE;

    smart_bmks = bookmarks->priv->smartbookmarks;

    if (address)
    {
        smart = strstr (address, "%s") != NULL;
        with_options = strstr (address, "%s%{") != NULL;
    }

    /* if we have a smart bookmark with width specification,
     * remove from smart bookmarks first to force an update
     * in the toolbar
     */
    if (smart && with_options)
    {
        ephy_node_remove_child (smart_bmks, bmk);
        ephy_node_add_child (smart_bmks, bmk);
    }
    else if (smart)
    {
        if (!ephy_node_has_child (smart_bmks, bmk))
        {
            ephy_node_add_child (smart_bmks, bmk);
        }
    }
    else
    {
        if (ephy_node_has_child (smart_bmks, bmk))
        {
            ephy_node_remove_child (smart_bmks, bmk);
        }
    }
}

EphyNode *
ephy_bookmarks_add (EphyBookmarks *eb,
            const char *title,
            const char *url)
{
    EphyNode *bm;
    GValue value = { 0, };

    bm = ephy_node_new (eb->priv->db);

    if (bm == NULL) return NULL;

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, title);
    ephy_node_set_property (bm, EPHY_NODE_BMK_PROP_TITLE,
                &value);
    g_value_unset (&value);

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, url);
    ephy_node_set_property (bm, EPHY_NODE_BMK_PROP_LOCATION,
                &value);
    g_value_unset (&value);

    update_has_smart_address (eb, bm, url);
    update_bookmark_keywords (eb, bm);

    ephy_node_add_child (eb->priv->bookmarks, bm);
    ephy_node_add_child (eb->priv->notcategorized, bm);

    ephy_bookmarks_save_delayed (eb, 0);

    return bm;
}

void
ephy_bookmarks_set_address (EphyBookmarks *eb,
                EphyNode *bookmark,
                const char *address)
{
    GValue value = { 0, };

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, address);
    ephy_node_set_property (bookmark, EPHY_NODE_BMK_PROP_LOCATION,
                &value);
    g_value_unset (&value);

    update_has_smart_address (eb, bookmark, address);
}

EphyNode *
ephy_bookmarks_find_bookmark (EphyBookmarks *eb,
                  const char *url)
{
    GPtrArray *children;
    int i;

    g_return_val_if_fail (EPHY_IS_BOOKMARKS (eb), NULL);
    g_return_val_if_fail (eb->priv->bookmarks != NULL, NULL);
    g_return_val_if_fail (url != NULL, NULL);

    children = ephy_node_get_children (eb->priv->bookmarks);
    for (i = 0; i < children->len; i++)
    {
        EphyNode *kid;
        const char *location;

        kid = g_ptr_array_index (children, i);
        location = ephy_node_get_property_string
            (kid, EPHY_NODE_BMK_PROP_LOCATION);

        if (location != NULL && strcmp (url, location) == 0)
        {
            return kid;
        }
    }

    return NULL;
}

void
ephy_bookmarks_set_icon (EphyBookmarks *eb,
             const char *url,
             const char *icon)
{
    EphyNode *node;
    GValue value = { 0, };

    g_return_if_fail (icon != NULL);

    node = ephy_bookmarks_find_bookmark (eb, url);
    if (node == NULL) return;

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, icon);
    ephy_node_set_property (node, EPHY_NODE_BMK_PROP_ICON,
                &value);
    g_value_unset (&value);
}

/* name must end with '=' */
static char *
get_option (char *start,
        const char *name,
        char **optionsend)
{
    char *end, *p;

    *optionsend = start;

    if (start == NULL || start[0] != '%' || start[1] != '{') return NULL;
    start += 2;

    end = strstr (start, "}");
    if (end == NULL) return NULL;
    *optionsend = end + 1;

    start = strstr (start, name);
    if (start == NULL || start > end) return NULL;
    start += strlen (name);

    /* Find end of option, either ',' or '}' */
    end = strstr (start, ",");
    if (end == NULL || end >= *optionsend) end = *optionsend - 1;

    /* limit option length and sanity-check it */
    if (end - start > 32) return NULL;
    for (p = start; p < end; ++p)
    {
        if (!g_ascii_isalnum (*p)) return NULL;
    }

    return g_strndup (start, end - start);
}

static char *
impl_resolve_address (EphyBookmarks *eb,
              const char *address,
              const char *content)
{
    GString *result;
    char *pos, *oldpos, *arg, *escaped_arg, *encoding, *optionsend;

    if (address == NULL) return NULL;
    if (content == NULL) content = "";

    result = g_string_new_len (NULL, strlen (content) + strlen (address));

    /* substitute %s's */
    oldpos = (char*) address;
    while ((pos = strstr (oldpos, "%s")) != NULL)
    {
        g_string_append_len (result, oldpos, pos - oldpos);
        pos += 2;

        encoding = get_option (pos, "encoding=", &optionsend);
        if (encoding != NULL)
        {
            GError *error = NULL;

            arg = g_convert (content, strlen (content), encoding,
                     "UTF-8", NULL, NULL, &error);
            if (error != NULL)
            {
                g_warning ("Error when converting arg to encoding '%s': %s\n",
                       encoding, error->message);
                g_error_free (error);
            }
            else
            {
                escaped_arg = gnome_vfs_escape_string (arg);
                g_string_append (result, escaped_arg);
                g_free (escaped_arg);
                g_free (arg);
            }

            g_free (encoding);
        }
        else
        {
            arg = gnome_vfs_escape_string (content);
            g_string_append (result, arg);
            g_free (arg);
        }

        oldpos = optionsend;
    }
    g_string_append (result, oldpos);

    return g_string_free (result, FALSE);
}

char *
ephy_bookmarks_resolve_address (EphyBookmarks *eb,
                const char *address,
                const char *parameter)
{
    char *retval = NULL;

    g_return_val_if_fail (EPHY_IS_BOOKMARKS (eb), NULL);
    g_return_val_if_fail (address != NULL, NULL);

    g_signal_emit (eb, ephy_bookmarks_signals[RESOLVE_ADDRESS], 0,
               address, parameter, &retval);

    return retval;
}

guint
ephy_bookmarks_get_smart_bookmark_width (EphyNode *bookmark)
{
    const char *url;
    char *option, *end, *number;
    guint width;

    url = ephy_node_get_property_string (bookmark, EPHY_NODE_BMK_PROP_LOCATION);
    if (url == NULL) return 0;

    /* this takes the first %s, but that's okay since we only support one text entry box */
    option = strstr (url, "%s%{");
    if (option == NULL) return 0;
    option += 2;

    number = get_option (option, "width=", &end);
    if (number == NULL) return 0;

    width = (guint) g_ascii_strtoull (number, NULL, 10);
    g_free (number);

    return CLAMP (width, 1, 64);
}

EphyNode *
ephy_bookmarks_add_keyword (EphyBookmarks *eb,
                const char *name)
{
    EphyNode *key;
    GValue value = { 0, };

    key = ephy_node_new (eb->priv->db);

    if (key == NULL) return NULL;

    g_value_init (&value, G_TYPE_STRING);
    g_value_set_string (&value, name);
    ephy_node_set_property (key, EPHY_NODE_KEYWORD_PROP_NAME,
                &value);
    g_value_unset (&value);

    g_value_init (&value, G_TYPE_INT);
    g_value_set_int (&value, EPHY_NODE_NORMAL_PRIORITY);
    ephy_node_set_property (key, EPHY_NODE_KEYWORD_PROP_PRIORITY,
                &value);
    g_value_unset (&value);

    ephy_node_add_child (eb->priv->keywords, key);

    return key;
}


static void
prop_dialog_destroy_cb (EphyBookmarkProperties *dialog,
            EphyBookmarks *bookmarks)
{
    EphyNode *bookmark;

    bookmark = ephy_bookmark_properties_get_node (dialog);

    g_hash_table_remove (bookmarks->priv->props_dialogs, bookmark);
}

static void
bookmark_destroyed_cb (EphyNode *bookmark,
               GtkWidget *dialog)
{
    gtk_widget_destroy (dialog);
}        

GtkWidget *
ephy_bookmarks_show_bookmark_properties (EphyBookmarks *bookmarks,
                     EphyNode *bookmark,
                     GtkWidget *parent)
{
    GtkWidget *dialog = NULL;

    g_return_val_if_fail (EPHY_IS_BOOKMARKS (bookmarks), NULL);
    g_return_val_if_fail (EPHY_IS_NODE (bookmark), NULL);

    dialog = g_hash_table_lookup (bookmarks->priv->props_dialogs, bookmark);

    if (dialog == NULL)
    {
        dialog = ephy_bookmark_properties_new (bookmarks, bookmark, parent);

        ephy_node_signal_connect_object (bookmark,
                         EPHY_NODE_DESTROY,
                         (EphyNodeCallback) bookmark_destroyed_cb,
                         G_OBJECT (dialog));

        g_signal_connect (dialog, "destroy",
                  G_CALLBACK (prop_dialog_destroy_cb), bookmarks);
        g_hash_table_insert (bookmarks->priv->props_dialogs,
                     bookmark, dialog);
    }

    gtk_window_present (GTK_WINDOW (dialog));

    return dialog;
}

void
ephy_bookmarks_remove_keyword (EphyBookmarks *eb,
                   EphyNode *keyword)
{
    ephy_node_remove_child (eb->priv->keywords, keyword);
}

char *
ephy_bookmarks_get_topic_uri (EphyBookmarks *eb,
                  EphyNode *node)
{
    char *uri;

    if (ephy_bookmarks_get_bookmarks (eb) == node)
    {
        uri = g_strdup ("topic://Special/All");
    }
    else if (ephy_bookmarks_get_not_categorized (eb) == node)
    {
        uri = g_strdup ("topic://Special/NotCategorized");
    }
    else if (ephy_bookmarks_get_favorites (eb) == node)
    {
        uri = g_strdup ("topic://Special/Favorites");
    }
#ifdef ENABLE_ZEROCONF
    else if (ephy_bookmarks_get_local (eb) == node)
    {
        uri = g_strdup ("topic://Special/Local");
    }
#endif
    else
    {
        const char *name;

        name = ephy_node_get_property_string
            (node, EPHY_NODE_KEYWORD_PROP_NAME);

        uri = g_strdup_printf ("topic://%s", name);
    }

    return uri;
}

EphyNode *
ephy_bookmarks_find_keyword (EphyBookmarks *eb,
                 const char *name,
                 gboolean partial_match)
{
    EphyNode *node;
    GPtrArray *children;
    int i;
    const char *topic_name;

    g_return_val_if_fail (name != NULL, NULL);

    topic_name = name;

    if (g_utf8_strlen (name, -1) == 0)
    {
        LOG ("Empty name, no keyword matches.");
        return NULL;
    }

    if (strcmp (name, "topic://Special/All") == 0)
    {
        return ephy_bookmarks_get_bookmarks (eb);
    }
    else if (strcmp (name, "topic://Special/NotCategorized") == 0)
    {
        return ephy_bookmarks_get_not_categorized (eb);
    }
    else if (strcmp (name, "topic://Special/Favorites") == 0)
    {
        return ephy_bookmarks_get_favorites (eb);
    }
#ifdef ENABLE_ZEROCONF
    else if (strcmp (name, "topic://Special/Local") == 0)
    {
        return ephy_bookmarks_get_local (eb);
    }
#endif
    else if (g_str_has_prefix (name, "topic://"))
    {
        topic_name += strlen ("topic://");
    }

    children = ephy_node_get_children (eb->priv->keywords);
    node = NULL;
    for (i = 0; i < children->len; i++)
    {
         EphyNode *kid;
         const char *key;

         kid = g_ptr_array_index (children, i);
         key = ephy_node_get_property_string (kid, EPHY_NODE_KEYWORD_PROP_NAME);

         if ((partial_match && g_str_has_prefix (key, topic_name) > 0) ||
             (!partial_match && strcmp (key, topic_name) == 0))
         {
             node = kid;
         }
    }

    return node;
}

gboolean
ephy_bookmarks_has_keyword (EphyBookmarks *eb,
                EphyNode *keyword,
                EphyNode *bookmark)
{
    return ephy_node_has_child (keyword, bookmark);
}

void
ephy_bookmarks_set_keyword (EphyBookmarks *eb,
                EphyNode *keyword,
                EphyNode *bookmark)
{
    if (ephy_node_has_child (keyword, bookmark)) return;

    ephy_node_add_child (keyword, bookmark);

    if (ephy_node_has_child (eb->priv->notcategorized, bookmark))
    {
        LOG ("Remove from categorized bookmarks");
        ephy_node_remove_child
            (eb->priv->notcategorized, bookmark);
    }

    update_bookmark_keywords (eb, bookmark);

    g_signal_emit (G_OBJECT (eb), ephy_bookmarks_signals[TREE_CHANGED], 0);
}

void
ephy_bookmarks_unset_keyword (EphyBookmarks *eb,
                  EphyNode *keyword,
                  EphyNode *bookmark)
{
    if (!ephy_node_has_child (keyword, bookmark)) return;

    ephy_node_remove_child (keyword, bookmark);

    if (!bookmark_is_categorized (eb, bookmark) &&
        !ephy_node_has_child (eb->priv->notcategorized, bookmark))
    {
        LOG ("Add to not categorized bookmarks");
        ephy_node_add_child
            (eb->priv->notcategorized, bookmark);
    }

    update_bookmark_keywords (eb, bookmark);

    g_signal_emit (G_OBJECT (eb), ephy_bookmarks_signals[TREE_CHANGED], 0);
}

EphyNode *
ephy_bookmarks_get_smart_bookmarks (EphyBookmarks *eb)
{
    return eb->priv->smartbookmarks;
}

EphyNode *
ephy_bookmarks_get_keywords (EphyBookmarks *eb)
{
    return eb->priv->keywords;
}

EphyNode *
ephy_bookmarks_get_bookmarks (EphyBookmarks *eb)
{
    return eb->priv->bookmarks;
}

EphyNode *
ephy_bookmarks_get_favorites (EphyBookmarks *eb)
{
    return eb->priv->favorites;
}

#ifdef ENABLE_ZEROCONF
EphyNode *
ephy_bookmarks_get_local (EphyBookmarks *eb)
{
    return eb->priv->local;
}
#endif

EphyNode *
ephy_bookmarks_get_not_categorized (EphyBookmarks *eb)
{
    return eb->priv->notcategorized;
}

EphyNode *
ephy_bookmarks_get_from_id (EphyBookmarks *eb, long id)
{
    return ephy_node_db_get_node_from_id (eb->priv->db, id);
}

int
ephy_bookmarks_compare_topics (gconstpointer a, gconstpointer b)
{
    EphyNode *node_a = (EphyNode *)a;
    EphyNode *node_b = (EphyNode *)b;
    const char *title1, *title2;
    int priority1, priority2;

    priority1 = ephy_node_get_property_int (node_a, EPHY_NODE_KEYWORD_PROP_PRIORITY);
    priority2 = ephy_node_get_property_int (node_b, EPHY_NODE_KEYWORD_PROP_PRIORITY);
    
    if (priority1 > priority2) return 1;
    if (priority1 < priority2) return -1;

    title1 = ephy_node_get_property_string (node_a, EPHY_NODE_KEYWORD_PROP_NAME);
    title2 = ephy_node_get_property_string (node_b, EPHY_NODE_KEYWORD_PROP_NAME);

    if (title1 == title2) return 0;
    if (title1 == NULL) return -1;
    if (title2 == NULL) return 1;
    return g_utf8_collate (title1, title2);
}

int
ephy_bookmarks_compare_topic_pointers (gconstpointer a, gconstpointer b)
{
    EphyNode *node_a = *(EphyNode **)a;
    EphyNode *node_b = *(EphyNode **)b;
    
    return ephy_bookmarks_compare_topics (node_a, node_b);
}

int
ephy_bookmarks_compare_bookmarks (gconstpointer a, gconstpointer b)
{
    EphyNode *node_a = (EphyNode *)a;
    EphyNode *node_b = (EphyNode *)b;
    const char *title1, *title2;
    
    title1 = ephy_node_get_property_string (node_a, EPHY_NODE_BMK_PROP_TITLE);
    title2 = ephy_node_get_property_string (node_b, EPHY_NODE_BMK_PROP_TITLE);

    if (title1 == title2) return 0;
    if (title1 == NULL) return -1;
    if (title2 == NULL) return 1;
    return g_utf8_collate (title1, title2);
}

int
ephy_bookmarks_compare_bookmark_pointers (gconstpointer a, gconstpointer b)
{
    EphyNode *node_a = *(EphyNode **)a;
    EphyNode *node_b = *(EphyNode **)b;
    
    return ephy_bookmarks_compare_bookmarks (node_a, node_b);
}