From 52e1e2fbdafd993933ba7866847ddbbedd7a2748 Mon Sep 17 00:00:00 2001 From: Jonny Lamb Date: Mon, 16 May 2011 15:12:59 +0100 Subject: chat-manager: expose UndoClosedChat over DBus Signed-off-by: Jonny Lamb --- src/empathy-chat-manager.c | 72 +++++++++++++++++++++++++++++++++++++++++++++- src/empathy-chat-manager.h | 2 ++ 2 files changed, 73 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/empathy-chat-manager.c b/src/empathy-chat-manager.c index a90c2d08c..36f9512c7 100644 --- a/src/empathy-chat-manager.c +++ b/src/empathy-chat-manager.c @@ -18,6 +18,7 @@ */ #include +#include #include #include @@ -30,6 +31,8 @@ #include "empathy-chat-manager.h" +#include + enum { CLOSED_CHATS_CHANGED, DISPLAYED_CHATS_CHANGED, @@ -38,7 +41,13 @@ enum { static guint signals[LAST_SIGNAL]; -G_DEFINE_TYPE(EmpathyChatManager, empathy_chat_manager, G_TYPE_OBJECT) +static void svc_iface_init (gpointer, gpointer); + +G_DEFINE_TYPE_WITH_CODE (EmpathyChatManager, empathy_chat_manager, + G_TYPE_OBJECT, + G_IMPLEMENT_INTERFACE (EMP_TYPE_SVC_CHAT_MANAGER, + svc_iface_init) + ) /* private structure */ typedef struct _EmpathyChatManagerPriv EmpathyChatManagerPriv; @@ -362,6 +371,22 @@ empathy_chat_manager_constructor (GType type, return retval; } +static void +empathy_chat_manager_constructed (GObject *obj) +{ + TpDBusDaemon *dbus_daemon; + + dbus_daemon = tp_dbus_daemon_dup (NULL); + + if (dbus_daemon != NULL) + { + tp_dbus_daemon_register_object (dbus_daemon, + "/org/gnome/Empathy/ChatManager", obj); + + g_object_unref (dbus_daemon); + } +} + static void empathy_chat_manager_class_init ( EmpathyChatManagerClass *empathy_chat_manager_class) @@ -370,6 +395,7 @@ empathy_chat_manager_class_init ( object_class->finalize = empathy_chat_manager_finalize; object_class->constructor = empathy_chat_manager_constructor; + object_class->constructed = empathy_chat_manager_constructed; signals[CLOSED_CHATS_CHANGED] = g_signal_new ("closed-chats-changed", @@ -453,3 +479,47 @@ empathy_chat_manager_get_num_closed_chats (EmpathyChatManager *self) return g_queue_get_length (priv->closed_queue); } + +static void +empathy_chat_manager_dbus_undo_closed_chat (EmpSvcChatManager *manager, + DBusGMethodInvocation *context) +{ + empathy_chat_manager_undo_closed_chat ((EmpathyChatManager *) manager); + + emp_svc_chat_manager_return_from_undo_closed_chat (context); +} + +static void +svc_iface_init (gpointer g_iface, + gpointer iface_data) +{ + EmpSvcChatManagerClass *klass = (EmpSvcChatManagerClass *) g_iface; + +#define IMPLEMENT(x) emp_svc_chat_manager_implement_##x (\ + klass, empathy_chat_manager_dbus_##x) + IMPLEMENT(undo_closed_chat); +#undef IMPLEMENT +} + +void +empathy_chat_manager_call_undo_closed_chat (void) +{ + TpDBusDaemon *dbus_daemon = tp_dbus_daemon_dup (NULL); + TpProxy *proxy; + + if (dbus_daemon == NULL) + return; + + proxy = g_object_new (TP_TYPE_PROXY, + "dbus-daemon", dbus_daemon, + "dbus-connection", tp_proxy_get_dbus_connection (TP_PROXY (dbus_daemon)), + "bus-name", "org.freedesktop.Telepathy.Client.Empathy.Chat", + "object-path", "/org/gnome/Empathy/ChatManager", + NULL); + + tp_proxy_add_interface_by_id (proxy, EMP_IFACE_QUARK_CHAT_MANAGER); + + emp_cli_chat_manager_call_undo_closed_chat (proxy, -1, NULL, NULL, NULL, NULL); + + g_object_unref (dbus_daemon); +} diff --git a/src/empathy-chat-manager.h b/src/empathy-chat-manager.h index 6d249b3e4..88632b4dd 100644 --- a/src/empathy-chat-manager.h +++ b/src/empathy-chat-manager.h @@ -65,6 +65,8 @@ void empathy_chat_manager_closed_chat (EmpathyChatManager *self, void empathy_chat_manager_undo_closed_chat (EmpathyChatManager *self); guint empathy_chat_manager_get_num_closed_chats (EmpathyChatManager *self); +void empathy_chat_manager_call_undo_closed_chat (void); + G_END_DECLS #endif /* #ifndef __EMPATHY_CHAT_MANAGER_H__*/ -- cgit v1.2.3 From 2d5e4f0a14794617d5fe385d4fcea86e4120edf5 Mon Sep 17 00:00:00 2001 From: Jonny Lamb Date: Mon, 16 May 2011 15:13:13 +0100 Subject: main-window: call the remote UndoClosedTab It will work, unlike this one. Signed-off-by: Jonny Lamb --- src/empathy-main-window.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src') diff --git a/src/empathy-main-window.c b/src/empathy-main-window.c index 0ac08c856..227160985 100644 --- a/src/empathy-main-window.c +++ b/src/empathy-main-window.c @@ -1226,14 +1226,10 @@ main_window_key_press_event_cb (GtkWidget *window, GdkEventKey *event, gpointer user_data) { - EmpathyChatManager *chat_manager; - if (event->keyval == GDK_KEY_T && event->state & GDK_SHIFT_MASK && event->state & GDK_CONTROL_MASK) { - chat_manager = empathy_chat_manager_dup_singleton (); - empathy_chat_manager_undo_closed_chat (chat_manager); - g_object_unref (chat_manager); + empathy_chat_manager_call_undo_closed_chat (); } return FALSE; } -- cgit v1.2.3 From 583dbd45639081ea4c760b81a4e2cc5c8137192e Mon Sep 17 00:00:00 2001 From: Jonny Lamb Date: Wed, 18 May 2011 14:23:24 +0100 Subject: chat-manager: don't leak proxy Signed-off-by: Jonny Lamb --- src/empathy-chat-manager.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/empathy-chat-manager.c b/src/empathy-chat-manager.c index 36f9512c7..86a285314 100644 --- a/src/empathy-chat-manager.c +++ b/src/empathy-chat-manager.c @@ -521,5 +521,6 @@ empathy_chat_manager_call_undo_closed_chat (void) emp_cli_chat_manager_call_undo_closed_chat (proxy, -1, NULL, NULL, NULL, NULL); + g_object_unref (proxy); g_object_unref (dbus_daemon); } -- cgit v1.2.3 From 510edcb3c7e288000544aa12fa4dc708085bfd2f Mon Sep 17 00:00:00 2001 From: Jonny Lamb Date: Wed, 18 May 2011 14:25:34 +0100 Subject: chat-manager: use EMPATHY_CHAT_BUS_NAME Signed-off-by: Jonny Lamb --- src/empathy-chat-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/empathy-chat-manager.c b/src/empathy-chat-manager.c index 86a285314..28f639d4c 100644 --- a/src/empathy-chat-manager.c +++ b/src/empathy-chat-manager.c @@ -513,7 +513,7 @@ empathy_chat_manager_call_undo_closed_chat (void) proxy = g_object_new (TP_TYPE_PROXY, "dbus-daemon", dbus_daemon, "dbus-connection", tp_proxy_get_dbus_connection (TP_PROXY (dbus_daemon)), - "bus-name", "org.freedesktop.Telepathy.Client.Empathy.Chat", + "bus-name", EMPATHY_CHAT_BUS_NAME, "object-path", "/org/gnome/Empathy/ChatManager", NULL); -- cgit v1.2.3