From db0b0f0ad369618f8204bbdf918aa574ccb25c8c Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 9 Dec 2009 16:15:09 +0000 Subject: tp_contact_list_remove: add FIXME about potential race --- libempathy/empathy-tp-contact-list.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libempathy') diff --git a/libempathy/empathy-tp-contact-list.c b/libempathy/empathy-tp-contact-list.c index 9ef71b4f9..9b67ec7e2 100644 --- a/libempathy/empathy-tp-contact-list.c +++ b/libempathy/empathy-tp-contact-list.c @@ -1060,6 +1060,8 @@ tp_contact_list_remove (EmpathyContactList *list, handle = empathy_contact_get_handle (contact); + /* FIXME: this is racy if tp_contact_list_remove is called before the + * 'stored' list has been retrieved. */ if (priv->stored != NULL) { tp_cli_channel_interface_group_call_remove_members (priv->stored, -1, &handles, message, NULL, NULL, NULL, NULL); -- cgit v1.2.3