From 9477559ddcd604d7d0687afa499694c4f3a2914f Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Tue, 6 Jan 2009 16:48:10 +0000 Subject: Don't leak a reference to McAccount objects and don't leak a list. svn path=/trunk/; revision=2066 --- libempathy/empathy-account-manager.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'libempathy') diff --git a/libempathy/empathy-account-manager.c b/libempathy/empathy-account-manager.c index e11289f3f..16f633015 100644 --- a/libempathy/empathy-account-manager.c +++ b/libempathy/empathy-account-manager.c @@ -334,9 +334,11 @@ empathy_account_manager_init (EmpathyAccountManager *manager) for (l = mc_accounts; l; l = l->next) { data = account_data_new_default (priv->mc, l->data); - - g_hash_table_insert (priv->accounts, g_object_ref (l->data), - data); + + /* no need to g_object_ref () the account here, as mc_accounts_list () + * already increases the refcount. + */ + g_hash_table_insert (priv->accounts, l->data, data); } g_signal_connect (priv->monitor, "account-created", @@ -353,6 +355,8 @@ empathy_account_manager_init (EmpathyAccountManager *manager) dbus_g_proxy_connect_signal (DBUS_G_PROXY (priv->mc), "AccountStatusChanged", G_CALLBACK (account_status_changed_cb), manager, NULL); + + g_list_free (mc_accounts); } static void -- cgit v1.2.3