From b5063fd8122ca1f5fcfbd93b7d495554d900f7f5 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Thu, 5 Apr 2012 14:35:27 +0200 Subject: live-search: don't forward shift keys Not doing so cancel any group renaming operation. https://bugzilla.gnome.org/show_bug.cgi?id=501065 --- libempathy-gtk/empathy-live-search.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libempathy-gtk/empathy-live-search.c b/libempathy-gtk/empathy-live-search.c index 3dc77998c..f03aa9fe4 100644 --- a/libempathy-gtk/empathy-live-search.c +++ b/libempathy-gtk/empathy-live-search.c @@ -357,6 +357,14 @@ live_search_key_press_event_cb (GtkWidget *widget, return FALSE; } + /* Don't forward shift keys events as focusing the search entry would + * cancel an in-progress editing on a cell renderer (like when renaming a + * group). There is no point focusing it anyway as we don't display the + * search entry when only a shift key is pressed. */ + if (event->keyval == GDK_KEY_Shift_L || + event->keyval == GDK_KEY_Shift_R) + return FALSE; + /* realize the widget if it is not realized yet */ gtk_widget_realize (priv->search_entry); if (!gtk_widget_has_focus (priv->search_entry)) -- cgit v1.2.3