From 273ef9afeabc1de111d4b890dccb3e9153c8c3b1 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Mon, 7 Jan 2013 14:23:14 +0100 Subject: roster-window: ellipsize infobar title This avoid to increase the width of the roster window when displaying the error. https://bugzilla.gnome.org/show_bug.cgi?id=691137 --- src/empathy-roster-window.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/empathy-roster-window.c b/src/empathy-roster-window.c index b042ba4fb..34c2c2952 100644 --- a/src/empathy-roster-window.c +++ b/src/empathy-roster-window.c @@ -559,6 +559,7 @@ roster_window_error_create_info_bar (EmpathyRosterWindow *self, label = gtk_label_new (message_markup); gtk_label_set_use_markup (GTK_LABEL (label), TRUE); gtk_label_set_line_wrap (GTK_LABEL (label), TRUE); + gtk_label_set_ellipsize (GTK_LABEL (label), PANGO_ELLIPSIZE_END); gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5); gtk_widget_show (label); -- cgit v1.2.3 From 620122e5b41b4ae529ffcdb927b6b4898d98b5f3 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Tue, 8 Jan 2013 10:39:11 +0100 Subject: account-settings: early return if SASL earlier We should update the URI schemes and service even if the account uses SASL, so it has to be done *before* the early return. I did not hit this bug before as the only CM on which we use URI schemes (rakia) was not implementing SASL channel when I implemented this feature. https://bugzilla.gnome.org/show_bug.cgi?id=691195 --- libempathy/empathy-account-settings.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libempathy/empathy-account-settings.c b/libempathy/empathy-account-settings.c index 8731479be..a0e42cc77 100644 --- a/libempathy/empathy-account-settings.c +++ b/libempathy/empathy-account-settings.c @@ -1327,6 +1327,12 @@ empathy_account_settings_account_updated (GObject *source, goto out; } + update_account_uri_schemes (settings); + update_account_service (settings); + + g_simple_async_result_set_op_res_gboolean (priv->apply_result, + g_strv_length (reconnect_required) > 0); + /* Only set the password in the keyring if the CM supports SASL. */ if (priv->supports_sasl) { @@ -1348,12 +1354,6 @@ empathy_account_settings_account_updated (GObject *source, return; } - update_account_uri_schemes (settings); - update_account_service (settings); - - g_simple_async_result_set_op_res_gboolean (priv->apply_result, - g_strv_length (reconnect_required) > 0); - out: empathy_account_settings_discard_changes (settings); -- cgit v1.2.3 From d95a09bded20a2cccf0847f4663fd075536399ca Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Tue, 8 Jan 2013 12:31:43 +0100 Subject: tp-chat: prepare CONNECTED on the TpConnection first We have to make sure that tp_connection_get_self_contact() won't return NULL. https://bugzilla.gnome.org/show_bug.cgi?id=691006 --- libempathy/empathy-tp-chat.c | 58 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 48 insertions(+), 10 deletions(-) diff --git a/libempathy/empathy-tp-chat.c b/libempathy/empathy-tp-chat.c index 4857243c1..42ab0836e 100644 --- a/libempathy/empathy-tp-chat.c +++ b/libempathy/empathy-tp-chat.c @@ -1298,20 +1298,12 @@ password_feature_prepare_cb (GObject *source, } static void -tp_chat_prepare_ready_async (TpProxy *proxy, - const TpProxyFeature *feature, - GAsyncReadyCallback callback, - gpointer user_data) +continue_preparing (EmpathyTpChat *self) { - EmpathyTpChat *self = (EmpathyTpChat *) proxy; - TpChannel *channel = (TpChannel *) proxy; + TpChannel *channel = (TpChannel *) self; TpConnection *connection; gboolean listen_for_dbus_properties_changed = FALSE; - g_assert (self->priv->ready_result == NULL); - self->priv->ready_result = g_simple_async_result_new (G_OBJECT (self), - callback, user_data, tp_chat_prepare_ready_async); - connection = tp_channel_get_connection (channel); if (tp_proxy_has_interface_by_id (self, @@ -1436,3 +1428,49 @@ tp_chat_prepare_ready_async (TpProxy *proxy, G_OBJECT (self), NULL); } } + +static void +conn_connected_cb (GObject *source, + GAsyncResult *result, + gpointer user_data) +{ + EmpathyTpChat *self = user_data; + GError *error = NULL; + + if (!tp_proxy_prepare_finish (source, result, &error)) + { + DEBUG ("Failed to prepare Connected: %s", error->message); + g_simple_async_result_take_error (self->priv->ready_result, error); + g_simple_async_result_complete (self->priv->ready_result); + tp_clear_object (&self->priv->ready_result); + return; + } + + continue_preparing (self); +} + +static void +tp_chat_prepare_ready_async (TpProxy *proxy, + const TpProxyFeature *feature, + GAsyncReadyCallback callback, + gpointer user_data) +{ + EmpathyTpChat *self = (EmpathyTpChat *) proxy; + TpChannel *channel = (TpChannel *) proxy; + TpConnection *connection; + GQuark features[] = { TP_CONNECTION_FEATURE_CONNECTED, 0 }; + + g_assert (self->priv->ready_result == NULL); + + self->priv->ready_result = g_simple_async_result_new (G_OBJECT (self), + callback, user_data, tp_chat_prepare_ready_async); + + connection = tp_channel_get_connection (channel); + + /* First we have to make sure that TP_CONNECTION_FEATURE_CONNECTED is + * prepared as we rely on TpConnection::self-contact + * in continue_preparing(). + * + * It would be nice if tp-glib could do this for us: fdo#59126 */ + tp_proxy_prepare_async (connection, features, conn_connected_cb, proxy); +} -- cgit v1.2.3