From 3e34b40f5a2ce026187c2e9c8316f1b255c193e9 Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Fri, 15 Apr 2011 19:31:28 +0100 Subject: contact_list_store_chat_state_changed_cb(): tidy This doesn't fix bgo#647891, but I think it makes the loop clearer. Reviewed-by: Guillaume Desmottes --- libempathy-gtk/empathy-contact-list-store.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libempathy-gtk/empathy-contact-list-store.c b/libempathy-gtk/empathy-contact-list-store.c index f6a7a114d..783ce77ef 100644 --- a/libempathy-gtk/empathy-contact-list-store.c +++ b/libempathy-gtk/empathy-contact-list-store.c @@ -194,17 +194,15 @@ contact_list_store_chat_state_changed_cb (TpChannel *self, contacts = empathy_contact_list_get_members (priv->list); - /* Find the contact in the list. After that l is the list elem or NULL */ for (l = contacts; l != NULL; l = l->next) { - if (empathy_contact_get_handle (EMPATHY_CONTACT (l->data)) == - contact_handle) { + EmpathyContact *contact = EMPATHY_CONTACT (l->data); + + if (empathy_contact_get_handle (contact) == contact_handle) { + contact_list_store_contact_update (store, contact); break; } } - if (l != NULL) - contact_list_store_contact_update (store, l->data); - g_list_foreach (contacts, (GFunc) g_object_unref, NULL); g_list_free (contacts); } -- cgit v1.2.3