aboutsummaryrefslogtreecommitdiffstats
path: root/libempathy-gtk
Commit message (Collapse)AuthorAgeFilesLines
* create roster-view skeletonGuillaume Desmottes2012-06-143-0/+207
|
* Add egg-list-box as a submoduleGuillaume Desmottes2012-06-142-0/+4
|
* empathy-chat: abort chat_log_filter if object was destroyedDebarshi Ray2012-06-111-9/+20
| | | | Fixes: https://bugzilla.gnome.org/677641
* empathy-chat: abort got_filtered_messages_cb if object was destroyedDebarshi Ray2012-06-111-3/+14
| | | | Fixes: https://bugzilla.gnome.org/677641
* move 'Remove' item code to individual-menuGuillaume Desmottes2012-06-083-203/+208
| | | | | | | There is no reason to not have it implemented like all the other menu items. Furtermore, having the logic in individual-menu.c will make it easier to use from the new roster view.
* remove libebook supportGuillaume Desmottes2012-06-072-73/+2
| | | | | | | It's API just changed and it's not really useful anymore as gnome-about-me has been removed. https://bugzilla.gnome.org/show_bug.cgi?id=677533
* account-settings: always use GVariant to store parametersGuillaume Desmottes2012-06-074-36/+65
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677545
* remove empathy_account_settings_set_* functionsGuillaume Desmottes2012-06-075-57/+65
| | | | | | | | They don't buy us much so let's just pass the GVariant directly. Fix some string leaks in empathy-account-widget-irc.c as well. https://bugzilla.gnome.org/show_bug.cgi?id=677545
* accounts-settings: store parameters as GVariantGuillaume Desmottes2012-06-071-3/+3
| | | | | | | This patch introduces a GValue leak. I'm going to fix it when switching the rest of this code to GVariant but I prefer to keep patches smaller. https://bugzilla.gnome.org/show_bug.cgi?id=677545
* account-widget: use TpConnectionManager accessorsGuillaume Desmottes2012-06-071-17/+22
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677545
* protocol-chooser: use TpConnectionManagerProtocol accessorsGuillaume Desmottes2012-06-071-22/+32
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677545
* protocol-chooser: use TpProtocolGuillaume Desmottes2012-06-062-11/+12
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677465
* account-settings: use TpProtocol's API to get TpConnectionManagerParamGuillaume Desmottes2012-06-061-3/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677465
* accounts_widget_generic_setup: continue iterating when treating optional ↵Guillaume Desmottes2012-06-061-1/+1
| | | | | | | | param in simple mode We may have more non-optional parameters later. https://bugzilla.gnome.org/show_bug.cgi?id=677465
* empathy_account_settings_get_tp_protocol: return a TpProtocolGuillaume Desmottes2012-06-061-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=677465
* account-widget-jabber.ui: remove n-{rows,columns} propertiesGuillaume Desmottes2012-06-061-2/+0
| | | | Not valid in a GtkGrid.
* live-search: handle the 'Menu' key as a navigation oneGuillaume Desmottes2012-06-041-2/+4
| | | | Fix opening the popup menu from the 'Menu' key in the treeview.
* Merge branch 'ui-work-672043'Danielle Madeley2012-05-3013-445/+741
|\
| * account-widget: support for account widget genericDanielle Madeley2012-05-292-9/+71
| |
| * account-widget: msn, icq, groupwiseDanielle Madeley2012-05-293-26/+65
| |
| * account-widget-aim: remove colons, dim labels, fix packingDanielle Madeley2012-05-291-8/+26
| |
| * account-widget-local-xmpp: remove colons, dim labelsDanielle Madeley2012-05-291-12/+30
| |
| * account-widget-irc: remove colonsDanielle Madeley2012-05-291-18/+43
| | | | | | | | | | | | The advanced settings for IRC look different to XMPP/SIP. They should probably be changed to be contained within a scrolled window/viewport for consistency.
| * account-widget-sip: remove colons, clean up paddingDanielle Madeley2012-05-291-16/+22
| |
| * account-widget-jabber: remove colons, clean up advanced sectionDanielle Madeley2012-05-291-184/+223
| | | | | | | | Don't dim labels in viewport, grey on white looks wrong.
| * contact-widget: remove colons and dim labels, move avatar to LHSDanielle Madeley2012-05-293-172/+261
| | | | | | | | | | | | Make widget look like mockup. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=672043
* | factor out empathy_individual_get_client_types()Guillaume Desmottes2012-05-251-44/+2
| |
* | Add empathy.css and helper code to use itGuillaume Desmottes2012-05-242-0/+35
|/ | | | https://bugzilla.gnome.org/show_bug.cgi?id=669473
* individual-store: add missing folks.h includeGuillaume Desmottes2012-05-171-0/+1
|
* Use the symbolic version of the avatar-default iconGuillaume Desmottes2012-05-171-1/+1
| | | | That's the one used by Contacts so best to stay coherent
* Authentification → AuthenticationGuillaume Desmottes2012-05-151-1/+1
| | | | | | So yeah, Authentification is actually not an English word... https://bugzilla.gnome.org/show_bug.cgi?id=676027
* remove unused tp-contact-factory includesGuillaume Desmottes2012-05-153-3/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=675597
* contact-widget: use empathy_client_factory_dup_contact_by_id_async()Guillaume Desmottes2012-05-151-11/+24
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=675597
* Use (non-)starred-symbolic for presence chooserDanielle Madeley2012-05-151-49/+4
| | | | | | This makes it look somewhat more visually up to date with Help etc. However this makes the use of STOCK_OK out of place (what to replace this with?).
* turn EmpathyContactWidget to be a proper GtkWidgetGuillaume Desmottes2012-05-152-406/+443
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=675803
* Merge branch 'gnome-3-4'Guillaume Desmottes2012-05-111-1/+1
|\
| * account-widget-irc: Quit label should be in the first columnGuillaume Desmottes2012-05-111-1/+1
| |
| * Use TP_ERROR instead of TP_ERRORSGuillaume Desmottes2012-05-092-3/+3
| | | | | | | | The latter has been deprecated in tp-glib master.
* | contact-blocking-dialog: use tp_connection_dup_contact_by_id_async()Guillaume Desmottes2012-05-111-29/+30
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675808
* | contact-chooser: use empathy_client_factory_dup_contact_by_id_async()Guillaume Desmottes2012-05-111-25/+37
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675808
* | chat: use empathy_client_factory_dup_contact_by_id_async()Guillaume Desmottes2012-05-111-62/+33
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675808
* | chat: use contact-chat-state-changed signalGuillaume Desmottes2012-05-101-4/+10
| | | | | | | | | | | | | | Now that we have a signal giving us a prepared TpContact there is no need to use the empathy variant as we can easily create the EmpathyContact directly. https://bugzilla.gnome.org/show_bug.cgi?id=675807
* | contact-search-dialog: use empathy_client_factory_dup_contact_by_id_async()Guillaume Desmottes2012-05-101-29/+50
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675597
* | remove invisible_char from ui filesGuillaume Desmottes2012-05-102-7/+0
| | | | | | | | We should use Gtk+'s default and those widgets don't use it any way.
* | Use TpTpTLSCertificateGuillaume Desmottes2012-05-102-28/+26
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=674318
* | new-account-dialog: rely on the EmpathyAccountWidget::close signalGuillaume Desmottes2012-05-091-17/+6
| | | | | | | | | | | | | | | | | | | | User of the dialog should wait for the widget to be completely done before destroying it. Change the 'success' dialog response to GTK_RESPONSE_APPLY to stay coherent with the response type received from EmpathyAccountWidget. https://bugzilla.gnome.org/show_bug.cgi?id=675667
* | account-widget: delay 'close' signal if enabling the accountGuillaume Desmottes2012-05-091-2/+11
| | | | | | | | | | | | | | The whole point of this signal is to tell to user when it can be destroyed, so we shouldn't fire it if we are still pending on an async call. https://bugzilla.gnome.org/show_bug.cgi?id=675667
* | Turn EmpathyAccountWidget to a proper GtkWidgetGuillaume Desmottes2012-05-089-117/+116
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=640417
* | Use TP_ERROR instead of TP_ERRORSGuillaume Desmottes2012-05-072-3/+3
| | | | | | | | The latter has been deprecated in tp-glib master.
* | contact-widget: stop using tp_connection_get_self_handle()Guillaume Desmottes2012-05-031-4/+7
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675229
* | individual-store-channel: stop preparing TP_CHANNEL_FEATURE_CONTACTSGuillaume Desmottes2012-05-031-26/+5
| | | | | | | | | | | | The factory does it for us now. https://bugzilla.gnome.org/show_bug.cgi?id=675229
* | Revert "Revert "Stop requesting StreamedMedia channels""Guillaume Desmottes2012-05-022-73/+5
| | | | | | | | | | | | This reverts commit 758b4250e767d9e952b8c0ea4db7d93df192a0c0. https://bugzilla.gnome.org/show_bug.cgi?id=675296
* | remove empathy-avGuillaume Desmottes2012-05-021-17/+14
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=675296
* | strip the new group nameGuillaume Desmottes2012-04-201-3/+8
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=501065
* | live-search: don't forward shift keysGuillaume Desmottes2012-04-201-0/+8
| | | | | | | | | | | | Not doing so cancel any group renaming operation. https://bugzilla.gnome.org/show_bug.cgi?id=501065
* | individual-view: add menu item to rename groupsGuillaume Desmottes2012-04-201-20/+97
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=501065
* | remove empathy_plist_parse_array()Guillaume Desmottes2012-04-101-29/+0
| | | | | | | | It's not used by the Adium code and uses a GValueArray which is deprecated.
* | remove useless empathy-contact-list.h includesGuillaume Desmottes2012-04-103-3/+0
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=673821
* | implement empathy_tp_chat_get_members as a method on TpChatGuillaume Desmottes2012-04-101-1/+1
| | | | | | | | | | | | | | That means EmpathyTpChat doesn't have to implement the EmpathyContactList interface any more. https://bugzilla.gnome.org/show_bug.cgi?id=673821
* | implement empathy_tp_chat_add as a method on TpChatGuillaume Desmottes2012-04-101-2/+1
| | | | | | | | | | | | We want to get rid of the EmpathyContactList interface. https://bugzilla.gnome.org/show_bug.cgi?id=673821
* | presence-chooser: use GNetworkMonitorGuillaume Desmottes2012-04-051-7/+8
| |
* | Remove Meego specific codeGuillaume Desmottes2012-04-051-5/+0
| | | | | | | | It's not used any more by Intel.
* | Merge branch 'gnome-3-4'Guillaume Desmottes2012-04-054-3/+11
|\|
| * add empathy_local_xmpp_assistant_widget_is_valid()Guillaume Desmottes2012-04-042-0/+10
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=673451
| * include logger single headerGuillaume Desmottes2012-04-042-3/+1
| |
* | Tooltip text marked as translatableLaurent2012-04-031-2/+3
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=673410
* | Merge branch 'gnome-3-4'Danielle Madeley2012-04-031-23/+10
|\|
| * Logger support for calls is no longer optionalDanielle Madeley2012-04-031-18/+4
| |
| * TplCallEndReason ceased to exist on March 28Danielle Madeley2012-04-031-5/+6
| |
* | Added support for local IP address and port in SIP account settings widget.Laurent2012-04-022-0/+61
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669134
* | Tooltip is more usefull when editing status. FixupLaurent2012-04-021-0/+10
|/ | | | https://bugzilla.gnome.org/show_bug.cgi?id=640846
* groups-widget: use gtk_list_store_insert_with_values()Guillaume Desmottes2012-03-291-6/+2
|
* contact-search-dialog: use gtk_list_store_insert_with_values()Guillaume Desmottes2012-03-291-4/+1
|
* account-widget-sip: use gtk_list_store_insert_with_values()Guillaume Desmottes2012-03-291-17/+16
|
* Move category name constants to #definesWill Thompson2012-03-281-0/+15
| | | | | This is kind of overkill to avoid me typoing the two names used in empathy-chat-window.c, but, hey.
* log-window: use gtk_list_store_insert_with_values()Guillaume Desmottes2012-03-271-6/+2
|
* factor out add_event_to_store()Guillaume Desmottes2012-03-271-52/+39
|
* log-window: factor out add_date_if_needed()Guillaume Desmottes2012-03-271-32/+33
| | | | Free a leak as 'text' wasn't freed in the first case.
* contact_widget_contact_update: check if widget_avatar is a chooserGuillaume Desmottes2012-03-261-2/+5
| | | | | | | information->widget_avatar can actually be a EmpathyAvatarImage when displaying a read only widget. https://bugzilla.gnome.org/show_bug.cgi?id=672828
* Update avatar chooser's account if EMPATHY_CONTACT_WIDGET_EDIT_ACCOUNT is ↵Guillaume Desmottes2012-03-261-0/+3
| | | | | | | | not set We can't rely on the account chooser to do it so we have to do it manually. https://bugzilla.gnome.org/show_bug.cgi?id=672633
* contact_widget_contact_update: change 'if else' block to a 'if' block inside ↵Guillaume Desmottes2012-03-261-8/+13
| | | | | | | | the 'else' No semantic change. https://bugzilla.gnome.org/show_bug.cgi?id=672633
* Use help:empathy to open the helpGuillaume Desmottes2012-03-221-1/+1
| | | | | | Looks like the new doc infra uses "help" rather than "ghelp". https://bugzilla.gnome.org/show_bug.cgi?id=672596
* account-widget-irc: add translators comment on up/down tooltipsGuillaume Desmottes2012-03-221-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=672608
* account-widget: set shadow_type=in for advanced scrolled windowsCosimo Cecchi2012-03-213-0/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=672508
* contact-widget: right align contact info fieldsGuillaume Desmottes2012-03-162-7/+7
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=672037
* contact-widget: don't display the account when editing our infoGuillaume Desmottes2012-03-163-6/+17
| | | | | | | All these flags are making this code pretty messy. Hopefully we'll move and clean it when implementing the new design next cycle. https://bugzilla.gnome.org/show_bug.cgi?id=672036
* Don't display parameters if Parameters_Exact is not SetGuillaume Desmottes2012-03-164-6/+15
| | | | | | | There is no point cluttering the UI with it as we don't allow user to choose which param he wants to set. https://bugzilla.gnome.org/show_bug.cgi?id=671983
* contact-widget: use EmpathyCalendarButtonGuillaume Desmottes2012-03-161-24/+17
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671981
* add EmpathyCalendarButtonGuillaume Desmottes2012-03-163-0/+343
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671981
* Set chat.facebook.com:443 as fallback serverGuillaume Desmottes2012-03-151-0/+6
| | | | | | | Some nasty firewalls block the port 5222, Facebook servers allow connection to the port 443 as a fallback in this case. https://bugzilla.gnome.org/show_bug.cgi?id=672120
* Free the GError in Geoclue callbacksGuillaume Desmottes2012-03-151-0/+4
|
* location-manager: use geoclue_master_client_create_address_async()Guillaume Desmottes2012-03-151-13/+24
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671994
* location-manager: use geoclue_master_client_create_position_async()Guillaume Desmottes2012-03-151-11/+23
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671994
* location-manager: use geoclue_master_client_set_requirements_async()Guillaume Desmottes2012-03-151-27/+44
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671994
* location-manager: use geoclue_master_create_client_async()Guillaume Desmottes2012-03-151-12/+27
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=671994
* Merge remote-tracking branch 'gulic/buttons-668464'Danielle Madeley2012-03-144-68/+92
|\
| * Toolbar and Treeview mergedJovanka Gulicoska2012-03-131-9/+13
| |
| * Remove size group from Blocked Contacts dialogJovanka Gulicoska2012-03-131-6/+0
| |
| * Server field expandedJovanka Gulicoska2012-03-131-3/+3
| |
| * IRC network dialog: use the use the right style for the buttonsGuillaume Desmottes2012-01-232-53/+77
| |
| * status preset dialog: use the right style for the remove buttonGuillaume Desmottes2012-01-231-2/+3
| |
| * contact-blocking-dialog: use the right style for the remove buttonGuillaume Desmottes2012-01-231-3/+4
| |
* | individual-menu: only use 'gnome-contacts' with individuals from FolksGuillaume Desmottes2012-03-131-1/+19
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=671884
* | Revert "remove empathy-individual-information-dialog"Guillaume Desmottes2012-03-133-0/+380
| | | | | | | | | | | | This reverts commit 8c56829f3fa97640abf47ced7d39aa618fffe07f. https://bugzilla.gnome.org/show_bug.cgi?id=671884
* | remove empathy-tp-contact-listGuillaume Desmottes2012-03-121-2/+0
| |
* | individual-store-manager: always display individual's alias in debug messagesGuillaume Desmottes2012-03-091-6/+12
| | | | | | | | It's much more useful that just the ID.
* | individual_personas_changed_cb: remove debug messageGuillaume Desmottes2012-03-091-3/+0
| | | | | | | | The individual manager already sends the exact same debugging message.
* | Don't flood logs when individials don't have avatarsGuillaume Desmottes2012-03-092-5/+11
| |
* | Remove flooding debug messagesGuillaume Desmottes2012-03-092-27/+0
| | | | | | | | Those messages flood the debug window and never helped me finding any bug.
* | empathy_gtk_init: add local copy of icons to the search path (#616159)Guillaume Desmottes2012-03-081-0/+13
| |
* | Make use of new GLib macros to check API we are usingGuillaume Desmottes2012-03-071-1/+2
| |
* | add missing config.h includesGuillaume Desmottes2012-03-072-0/+4
| |
* | Show date in local timezone instead of UTCDebarshi Ray2012-03-061-1/+1
| | | | | | | | Fixes: https://bugzilla.gnome.org/661515
* | Allow to build with empathy-avGuillaume Desmottes2012-03-021-14/+17
| |
* | Revert "Stop requesting StreamedMedia channels"Guillaume Desmottes2012-03-011-5/+69
| | | | | | | | This reverts commit b7f1fab64f9a59221b4d666cd788db4efe855b13.
* | Stop requesting StreamedMedia channelsGuillaume Desmottes2012-02-211-69/+5
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=629902
* | always build empathy-callGuillaume Desmottes2012-02-211-35/+0
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=629902
* | Use the MSN account widget with HazeGuillaume Desmottes2012-02-211-1/+1
| | | | | | | | | | | | | | The parameters supported by the UI have the same names as the Butterfly ones so no change needed. https://bugzilla.gnome.org/show_bug.cgi?id=663829
* | protocol-chooser: stop using ButterflyGuillaume Desmottes2012-02-211-0/+4
| | | | | | | | | | | | | | It doesn't implement any modern Telepathy API like ContactList for example and we now rely on it. https://bugzilla.gnome.org/show_bug.cgi?id=663829
* | tp_call_channel_add_content_async() now takes the directionGuillaume Desmottes2012-02-211-1/+2
| |
* | Merge remote-tracking branch 'origin/call1' into master+callGuillaume Desmottes2012-02-214-12/+92
|\ \ | | | | | | | | | | | | | | | Conflicts: configure.ac telepathy-yell
| * \ Merge branch 'master' into call1Danielle Madeley2012-01-177-84/+64
| |\ \
| * | | Remove tp-yell and use TpCallChannelXavier Claessens2012-01-104-12/+92
| | | |
* | | | Patch to change Yes/No to Accept/RejectBrian Curtis2012-02-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch will change the Yes and No in the subscription request dialog box to Accept and Reject respectively. https://bugzilla.gnome.org/show_bug.cgi?id=646654
* | | | local-xmpp-assistant-widget: increase row-spacingGuillaume Desmottes2012-02-171-1/+1
| | | |
* | | | use the 48x48 version of the local-xmpp iconGuillaume Desmottes2012-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | We don't have to scale up the icon any more and it looks good as it. https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | move the second part of the message at the end of the widgetGuillaume Desmottes2012-02-171-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | I rephrased it as well per Will's suggestion. https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | widget-local-xmpp: expand the entry fieldsGuillaume Desmottes2012-02-171-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | We want them to take all the space available. https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | local-xmpp-assistant-widget: inherit from a GtkGridGuillaume Desmottes2012-02-172-13/+8
| | | | | | | | | | | | | | | | | | | | | | | | It simplifies widgets packing. https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | Move should_create_salut_account to local-xmpp-assistant-widgetGuillaume Desmottes2012-02-172-0/+30
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | add empathy-local-xmpp-assistant-widgetGuillaume Desmottes2012-02-173-0/+344
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All of this is duplicated code from empathy-account-assistant and empathy-auto-salut-account-helper but those are going away so I didn't bother refactoring them. https://bugzilla.gnome.org/show_bug.cgi?id=652669
* | | | coding style fixesGuillaume Desmottes2012-02-161-2/+2
| | | |
* | | | empathy-chat: use empathy_ensure_individual_from_tp_contact()Guillaume Desmottes2012-02-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures we'll pass the right individual ID to gnome-contacts when opening a meta-contact. https://bugzilla.gnome.org/show_bug.cgi?id=669676
* | | | tls-dialog: add accessor on the 'Continue' buttonGuillaume Desmottes2012-02-131-1/+1
| | | |
* | | | Toggle telling others you are typing to themPatrick F. Allen2012-02-131-1/+15
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=668985
* | | | Don't unhighlight chat tabs when more messages are receivedWill Thompson2012-02-112-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Travis noticed that if you receive a message in which you are not mentioned after one in which you are, the highlight on the chat tab is cleared. This turned out to be because the text of the chat tab label was set in two different places in empathy-chat-window.c: one which takes should_highlight into account, and one which does not. This patch makes EmpathyChat keep track of whether it should be highlighted (reusing empathy_chat_messages_read(), which is called to acknowledge messages as having been seen by the user, to clear the flag), and then uses that from one of the label-updating code paths and deletes the other. https://bugzilla.gnome.org/show_bug.cgi?id=669823
* | | | start_gnome_contacts: make sure individual is validGuillaume Desmottes2012-02-101-0/+2
| | | |
* | | | fix individual_info_menu_item_activate_cb signatureGuillaume Desmottes2012-02-101-1/+2
| | | |
* | | | ContactInfo: always escape IRC channel names in markupWill Thompson2012-02-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some reason, I chose to escape the channel name for the contents of the href='' attribute but not in the body of the tag. Thus, channel names like "#r&d" made Pango refuse to coöperate. https://bugzilla.gnome.org/show_bug.cgi?id=669695
* | | | account-widget-jabber: doesn't allow negative priorityGuillaume Desmottes2012-02-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting a negative priority secretly mean "don't send me any message" which can be very confusing. https://bugzilla.gnome.org/show_bug.cgi?id=669712
* | | | contact-widget: use 'Personal Details' when editing our own infoGuillaume Desmottes2012-02-082-1/+10
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669655
* | | | Remove unused persona store/viewGuillaume Desmottes2012-02-085-2258/+0
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669482
* | | | remove linking UIGuillaume Desmottes2012-02-085-1201/+0
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669482
* | | | individual-menu: remove link-contacts-activated signalGuillaume Desmottes2012-02-082-34/+0
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669482
* | | | Remove 'Link Contact' menu itemGuillaume Desmottes2012-02-082-56/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to use gnome-contacts and the 'Informations' menu item already starts it. https://bugzilla.gnome.org/show_bug.cgi?id=669482
* | | | Try installing gnome-contacts using PackageKitGuillaume Desmottes2012-02-081-5/+47
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669578
* | | | factor out start_gnome_contacts()Guillaume Desmottes2012-02-081-1/+7
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669578
* | | | Factor out show_gnome_contacts_error_dialog()Guillaume Desmottes2012-02-081-14/+19
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669578
* | | | remove empathy-individual-information-dialogGuillaume Desmottes2012-02-073-380/+0
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669559
* | | | Use gnome-contacts instead of the information dialogGuillaume Desmottes2012-02-071-2/+56
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669559
* | | | individual_menu_add_personas: remove useless variableGuillaume Desmottes2012-02-061-1/+0
| | | |
* | | | account_widget_generic_format_param_name: make sure param_name is not NULLGuillaume Desmottes2012-02-061-0/+2
| | | | | | | | | | | | | | | | This should make the clang analyzer happier.
* | | | Chat: show who changed the subjectWill Thompson2012-02-021-1/+8
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=669177
* | | | individual_view_drag_end: remove the auto scrollGuillaume Desmottes2012-01-311-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures that we'll stop scrolling if the DnD operation hasn't been completed. https://bugzilla.gnome.org/show_bug.cgi?id=662916
* | | | auth-client: set keep above on dialogsGuillaume Desmottes2012-01-272-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This will avoid to accidentally 'loose' the dialog. https://bugzilla.gnome.org/show_bug.cgi?id=643699
* | | | coding style fixGuillaume Desmottes2012-01-271-1/+1
| | | |
* | | | individual-store: contacts in Favourite People are not UngroupedDanielle Madeley2012-01-271-47/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rearrange the code that puts people into groups a bit in a way I think makes more sense. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=668796
* | | | empathy-tls-dialog: add a title for screenshotsDanielle Madeley2012-01-261-0/+1
| | | | | | | | | | | | | | | | Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=668681
* | | | Merge branch 'highlight-regex'Will Thompson2012-01-268-26/+175
|\ \ \ \
| * | | | EmpathyChat: cache highlight regex.Will Thompson2012-01-251-17/+45
| | | | |
| * | | | EmpathyChat: track self contact.Will Thompson2012-01-191-8/+27
| | | | |
| * | | | Don't highlight messages in 1-1 chats.Will Thompson2012-01-191-0/+4
| | | | | | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=576912
| * | | | Don't highlight messages the user sent themselfWill Thompson2012-01-191-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | If a message is outgoing, then why on earth would we check whether it mentions our own nick and highlight it?
| * | | | Move empathy_message_should_highlight to EmpathyChatWill Thompson2012-01-191-3/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will give us a place to cache the GRegex object. (Of course, this also depends on monitoring changes to the TpChat's self contact's alias, and changes to the TpChat's self contact!)
| * | | | EmpathyChat: include should_highlight in ::new-messageWill Thompson2012-01-191-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | This allows EmpathyChatWindow to use this rather than calling empathy_message_should_highlight() itself.
| * | | | chat_view_append_message: take a should_highlight argumentWill Thompson2012-01-198-20/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than the EmpathyChatView implementations calling empathy_message_should_highlight() themselves, this patch makes EmpathyChat take responsibility for doing so. The theme preview in Preferences, whether deliberately or otherwise, highlights the line in which Juliet mentions Romeo. This behaviour is preserved.
* | | | | don't display 'No topic defined' if topic are not supportedGuillaume Desmottes2012-01-241-4/+8
| |_|_|/ |/| | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=668502
* | | | contact-widget: merge grid_contact and main_grid_contactGuillaume Desmottes2012-01-231-70/+52
| | | | | | | | | | | | | | | | | | | | | | | | No point keeping the extra widgets now. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | | | move vbox_avatar to grid_contactGuillaume Desmottes2012-01-231-12/+13
| | | | | | | | | | | | | | | | | | | | | | | | That way the avatar is no longer miss aligned with the other fields. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | | | contact-widget: move hbox_presence to grid_contactGuillaume Desmottes2012-01-231-27/+16
| | | | | | | | | | | | | | | | | | | | | | | | There is no point keeping this even more complicated that it already is. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | | | empathy-contact-widget: replace hbox_contact by a GtkGridGuillaume Desmottes2012-01-231-6/+5
| | | | | | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | | | contact-widget: stop storing hbox_contactGuillaume Desmottes2012-01-231-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | It's not used. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | | | remove empathy_contact_personal_dialog_show()Guillaume Desmottes2012-01-202-54/+0
|/ / /
* | / account-widget: allow JID such as 'test@localhost'Guillaume Desmottes2012-01-171-1/+1
| |/ |/| | | | | | | | | Thanks to marc@ttux.net for his help. https://bugzilla.gnome.org/show_bug.cgi?id=660856
* | don't free content of the list returned by ↵Guillaume Desmottes2012-01-171-2/+0
| | | | | | | | | | | | empathy_connection_aggregator_get_all_groups() https://bugzilla.gnome.org/show_bug.cgi?id=667037
* | empathy_pixbuf_avatar_from_individual_scaled_async: set an error if no avatarGuillaume Desmottes2012-01-171-11/+10
| | | | | | | | | | | | | | It's fair for the caller to expect the error the be set if the _finish() function returns NULL. https://bugzilla.gnome.org/show_bug.cgi?id=667037
* | individual-view: remove GTK+ workaroundsGuillaume Desmottes2012-01-161-68/+0
| | | | | | | | They have been properly fixed since a while.
* | individual-view: use tp_g_signal_connect_object() to connect the destroy sigGuillaume Desmottes2012-01-161-2/+4
| | | | | | | | | | | | This ensure that we won't call the callback when disposing the widget. https://bugzilla.gnome.org/show_bug.cgi?id=667676
* | filter_result_callback_data_new: add some checksGuillaume Desmottes2012-01-161-0/+4
| |
* | account-widget-irc: fix label position in the gridGuillaume Desmottes2012-01-131-0/+1
| |
* | be less restrictive regarding the Service formatGuillaume Desmottes2012-01-131-11/+17
| |
* | irc-network-chooser-dialog: be more NULL-safeGuillaume Desmottes2012-01-131-1/+4
| |
* | irc-network-chooser: set the account serviceGuillaume Desmottes2012-01-131-0/+35
|/ | | | https://bugzilla.gnome.org/show_bug.cgi?id=667791
* EmpathySoundManager: passing a GtkWidget is optionalXavier Claessens2012-01-101-10/+19
|
* contact-chooser: keep a ref on the TpContact we requestedGuillaume Desmottes2012-01-061-2/+20
| | | | | | Kinda hacky but that's the best we can do without major changes in Folks. https://bugzilla.gnome.org/show_bug.cgi?id=666531
* individual-widget: display champlain map in tooltipsGuillaume Desmottes2011-12-221-2/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661500
* individual_grid_destroy: remove the ChamplainEmbedView from its containerGuillaume Desmottes2011-12-221-0/+11
| | | | | | | The EmpathyIndividualWidget object is re-used for tooltips so we should remove the ChamplainEmbedView before trying to add a new one. https://bugzilla.gnome.org/show_bug.cgi?id=661500
* add new-account-dialogGuillaume Desmottes2011-12-223-0/+273
| | | | | This introduces some code duplication with the assistant but it's going to die soon anyway.
* account-widget: display the buttons in simple mode as wellGuillaume Desmottes2011-12-222-55/+57
| | | | | We'll need them when creating the account. Adding a simple function to manually hide them in the assistant for now.
* account-widget: modernize dipose functionGuillaume Desmottes2011-12-221-20/+2
|
* account-widget: use the self->priv patternGuillaume Desmottes2011-12-222-326/+287
| | | | I'm changing this file a lot so while I'm on it...
* properly handle accounts using an external storageGuillaume Desmottes2011-12-221-208/+20
|
* we can now use the stock close buttonGuillaume Desmottes2011-12-221-10/+1
| | | | | We should use the official accelerator for closing dialog. If widget fields are also using the 'C' accelerator then they should be fixed.
* remove old commentGuillaume Desmottes2011-12-221-1/+0
| | | | We fire the close signal a bit later in this function
* no need to control the cancel button sensitivity any moreGuillaume Desmottes2011-12-221-2/+0
| | | | | It should also be displayed now as we always want the user to be able to close the dialog.
* Don't show the presence twiceDanielle Madeley2011-12-222-1/+4
|
* Add a close signal, emitted by both cancel and applyDanielle Madeley2011-12-221-0/+14
|
* Begin combining the dialogsDanielle Madeley2011-12-221-2/+3
| | | | | | | This is not functional yet, but it does compile and kindof demonstrate what's going to happen. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=652670
* coding style fixEMPATHY_3_3_3Guillaume Desmottes2011-12-201-1/+1
|
* add empathy_move_to_window_desktopGuillaume Desmottes2011-12-192-0/+120
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=649208
* Stop passing an EmpathyContact to menu_item_new() fonctionsGuillaume Desmottes2011-12-143-152/+64
| | | | | | Best to always use an individual so we don't have 2 code paths to maintain. https://bugzilla.gnome.org/show_bug.cgi?id=666163
* individual-menu: export only the methods we needGuillaume Desmottes2011-12-142-33/+41
| | | | | | | No need to export everything. I added prototypes in the C file to not have to move everything upside down. https://bugzilla.gnome.org/show_bug.cgi?id=666163
* remove useless includes of empathy-contact-manager.hGuillaume Desmottes2011-12-143-3/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* remove EMPATHY_CONTACT_WIDGET_EDIT_FAVOURITEGuillaume Desmottes2011-12-142-72/+2
| | | | | | | It's not used any more and this code was the last one using the contact manager. https://bugzilla.gnome.org/show_bug.cgi?id=660547
* remove unused empathy_contact_edit_dialog_show()Guillaume Desmottes2011-12-142-62/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* Show a contact as blocked if *all* is personas are blockedGuillaume Desmottes2011-12-141-4/+7
| | | | | | It's clearer that way. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* individual_menu_add_personas: add the block menu item, if neededGuillaume Desmottes2011-12-141-0/+22
| | | | | | | | | | | | | This allow user to select the personas he wants to block. Note that I didn't pass an EmpathyContact as second argument to empathy_individiual_block_menu_item_new() as we currently do with most item_new() methods. Instead I just craft a new individual containing only the persona we care about. This approach is much cleaner as we don't have to deal with 2 different code paths. I filed bug #666163 to do the same with the existing functions. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* remove empathy-contact-menuGuillaume Desmottes2011-12-143-723/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* chat: use an EmpathyIndividualMenuGuillaume Desmottes2011-12-141-8/+20
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* add EMPATHY_INDIVIDUAL_FEATURE_BLOCKGuillaume Desmottes2011-12-142-0/+216
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* remove EMPATHY_INDIVIDUAL_FEATURE_ALLGuillaume Desmottes2011-12-142-2/+0
| | | | | | It's a bit fragile, user should say which features he wants. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* individual-menu: allow priv->store to be NULLGuillaume Desmottes2011-12-141-2/+3
| | | | | | | We already checks if it's a IndividualStoreChannel before using it so that's safe. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* Deal with empathy_create_individual_from_tp_contact() returning NULLGuillaume Desmottes2011-12-142-0/+4
| | | | | | Shouldn't really happen in practice but better to be safe than sorry. https://bugzilla.gnome.org/show_bug.cgi?id=665853
* log-window: update buttons if contact's caps are updatedGuillaume Desmottes2011-12-061-1/+22
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665592
* factor out do_update_buttons_sensitivity()Guillaume Desmottes2011-12-061-34/+41
| | | | | | | | This fix a bug with button_video_binding not being re-installed when a contact supporting video was selected. It was only re-installed when using the contact from the selected event. https://bugzilla.gnome.org/show_bug.cgi?id=665592
* log-window: include empathy-geometry.hGuillaume Desmottes2011-12-051-0/+1
|
* log-window: save window geometryGuillaume Desmottes2011-12-051-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=664209
* contact-blocking-dialog: stop using EmpathyContactManagerGuillaume Desmottes2011-12-021-19/+9
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* use the individual edit dialog when pressing F2Guillaume Desmottes2011-11-301-9/+2
| | | | | We already use it when using the menu so there is no reason to keep using the old one.
* ui-utils: don't expect that cancellable is not NULLGuillaume Desmottes2011-11-301-2/+3
| | | | cancellable are always optional so this code should be NULL safe.
* groups-widget: use empathy_connection_aggregator_get_all_groups()Guillaume Desmottes2011-11-291-8/+8
| | | | | | | | We have to prepare the contact groups feature and ensure that the singleton is still alive. The 'empathy' process is the only one allowing user to change contact groups so we just have to do it there. https://bugzilla.gnome.org/show_bug.cgi?id=665121
* add missing empathy-contact-list.h includeGuillaume Desmottes2011-11-281-0/+1
| | | | | | | | For some reason, gcc starts complaining about this as soon as I remove EmpathyContactListFlags from empathy-contact-list.h ?! If you have an explanation for this please let me know... https://bugzilla.gnome.org/show_bug.cgi?id=663328
* contact-menu: stop using empathy_contact_manager_get_flags_for_connection()Guillaume Desmottes2011-11-281-15/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663328
* Properly update the 'simple' themeGuillaume Desmottes2011-11-251-3/+13
| | | | | | | | We have to call the callback manually to update the theme when it's changed. Also make sure that style-set signal is only connected once and we update the theme only if the 'simple' one is used. https://bugzilla.gnome.org/show_bug.cgi?id=664795
* remove unused variablesGuillaume Desmottes2011-11-241-3/+0
|
* Remove obsolete contact-list-{store,view}Guillaume Desmottes2011-11-246-4116/+0
| | | | | | Hourrah \o/ https://bugzilla.gnome.org/show_bug.cgi?id=663387
* chat: use the individual view/store rather than the contact oneGuillaume Desmottes2011-11-241-14/+22
| | | | | | | | | The great unification ! EmpathyChat was the last user of the contact store/view, everything now use the individual ones. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add initial_loading() as a virtual methodGuillaume Desmottes2011-11-244-14/+37
| | | | | | This allows us to remove setup_idle_id as a protected variable. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add empathy_individual_store_refresh_individual() as a protected methodGuillaume Desmottes2011-11-243-11/+22
| | | | | | This allows us to remove show_active as a protected variable. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* Add individual-store-channelGuillaume Desmottes2011-11-243-0/+397
| | | | | | This will allow us to use the individual view to display muc members. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add EMPATHY_INDIVIDUAL_FEATURE_ADD_CONTACTGuillaume Desmottes2011-11-243-4/+149
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387
* factor out empathy_create_individual_from_tp_contact()Guillaume Desmottes2011-11-241-20/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387
* Abstract the individual storeGuillaume Desmottes2011-11-247-177/+400
| | | | | | | We now have EmpathyIndividualStoreManager which implements the store using EmpathyIndividualManager as its contact source. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* individual-store: expose some attributes and methods as 'protected'Guillaume Desmottes2011-11-242-30/+44
| | | | | | This will be needed when abstracting EmpathyIndividualStore. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add empathy-bad-password-dialogGuillaume Desmottes2011-11-233-0/+262
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661640
* Abstract EmpathyPasswordDialog to EmpathyBasePasswordDialogGuillaume Desmottes2011-11-235-196/+391
| | | | | | | I'm going to implement a slidely different version of this dialog so best to re-use as much code as possible. https://bugzilla.gnome.org/show_bug.cgi?id=661640
* password-dialog: use self->priv patternGuillaume Desmottes2011-11-232-68/+68
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661640
* fix GTK_BOX castsGuillaume Desmottes2011-11-211-1/+1
|
* use gtk_box_new() instead of gtk_[h,v]box_new()Guillaume Desmottes2011-11-2111-21/+23
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* use gtk_paned_new() instead of gtk_hpaned_new()Guillaume Desmottes2011-11-211-1/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* use gtk_separator_new() instead of gtk_hseparator_new()Guillaume Desmottes2011-11-211-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* Use _unref instead of _free _destroy when possible.unrefXavier Claessens2011-11-1612-17/+17
| | | | | | | | | | | Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref. I used this command to generate this patch: for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done See Danielle's blog for explanation of possible bug _free can do: http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
* individual-view: don't display menu if ↵Guillaume Desmottes2011-11-161-0/+4
| | | | | | | | | empathy_folks_individual_contains_contact() fails The individual menu already asserts that's the case. And there is no point displaying a menu anyway. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-view: add an option to disable uninteresting filteringGuillaume Desmottes2011-11-162-24/+76
| | | | | | This is needed when being used in a muc. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-widget: display channels list if availableGuillaume Desmottes2011-11-161-0/+22
| | | | | | This will be needed when using this widget in MUC. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* factor out empathy_contact_info_create_channel_list_label()Guillaume Desmottes2011-11-163-81/+106
| | | | | | | Move it to empathy-contactinfo-utils so we'll be able to re-use it in empathy-individual-widget as well. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* update_weak_contact: use a greater or equal comparaisonGuillaume Desmottes2011-11-161-1/+1
| | | | | | | That way we'll pick at least one TpContact if there is only one contact in the individual and he doesn't have any presence (IRC for example). https://bugzilla.gnome.org/show_bug.cgi?id=663763
* fix separator leakGuillaume Desmottes2011-11-141-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663873
* don't leak uri returned by g_file_get_uri()Guillaume Desmottes2011-11-141-2/+4
| | | | | | God I hate _get functions returning new memory... https://bugzilla.gnome.org/show_bug.cgi?id=663873
* fix GDate leaks when getting dates from the modelGuillaume Desmottes2011-11-141-1/+10
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663873